Re: [pve-devel] pvedaemon hanging because of qga retry

2018-05-28 Thread Alexandre DERUMIER
guest-$cmd"); I'll send a patch - Mail original - De: "aderumier" À: "Thomas Lamprecht" Cc: "pve-devel" Envoyé: Mardi 22 Mai 2018 09:59:37 Objet: Re: [pve-devel] pvedaemon hanging because of qga retry >>But, AFAICT, this isn't your real

Re: [pve-devel] pvedaemon hanging because of qga retry

2018-05-22 Thread Alexandre DERUMIER
If I understood correctly? yes ! - Mail original - De: "Thomas Lamprecht" À: "pve-devel" , "aderumier" , "dietmar" Envoyé: Mardi 22 Mai 2018 09:56:13 Objet: Re: [pve-devel] pvedaemon hanging because of qga retry On 5/21/18 3:02 PM, Alexandre DERUM

Re: [pve-devel] pvedaemon hanging because of qga retry

2018-05-22 Thread Thomas Lamprecht
o answer cannot be that high, as no IO is involved. That could be done with a relative small timeout and if that fails we know that it doesn't makes sense to make the fsfreeze call with it - reasonable - high timeout. If I understood correctly? > > > - Mail original - >

Re: [pve-devel] pvedaemon hanging because of qga retry

2018-05-22 Thread Dietmar Maurer
> On May 17, 2018 at 11:16 PM Alexandre DERUMIER wrote: > > > Hi, > I had a strange behaviour today, > > with a vm running + qga enabled, but qga service down in the vm > > after theses attempts, > > May 17 21:54:01 kvm14 pvedaemon[20088]: VM 745 qmp command failed - VM 745 qmp > command 'g

Re: [pve-devel] pvedaemon hanging because of qga retry

2018-05-21 Thread Dietmar Maurer
> On May 21, 2018 at 3:02 PM Alexandre DERUMIER wrote: > > > >>Seems this patch does not solve the 'high load' problem at all? > > I can't reproduce this high load, so I can't say. Its holiday today in Austria. But I will ask our support team tomorrow how to reproduce this ... _

Re: [pve-devel] pvedaemon hanging because of qga retry

2018-05-21 Thread Alexandre DERUMIER
a response with a longer timeout. - Mail original - De: "dietmar" À: "aderumier" Cc: "pve-devel" Envoyé: Lundi 21 Mai 2018 09:56:03 Objet: Re: [pve-devel] pvedaemon hanging because of qga retry > I have looked at libvirt/ovirt. > > It seem th

Re: [pve-devel] pvedaemon hanging because of qga retry

2018-05-21 Thread Dietmar Maurer
> I have looked at libvirt/ovirt. > > It seem that's it's possible to detect if agent is connected, through a qmp > event VSERPORT_CHANGE. > > https://git.qemu.org/?p=qemu.git;a=commit;h=e2ae6159 > https://git.qemu.org/?p=qemu.git;a=blobdiff;f=docs/qmp/qmp-events.txt;h=d759d197486a3edf3b629fb11e9

Re: [pve-devel] pvedaemon hanging because of qga retry

2018-05-21 Thread Alexandre DERUMIER
ce. We don't catch events currently, but maybe could we patch qemu to store the status somewhere instead event only, and retrieve it with a qmp command before calling qga ? - Mail original - De: "dietmar" À: "aderumier" Cc: "pve-devel" Envoyé: Dimanche

Re: [pve-devel] pvedaemon hanging because of qga retry

2018-05-20 Thread Dietmar Maurer
> if the guest is so loaded, than it can't even send reponse to guest-ping (with > a "short" timeout of some seconds, not ms!), AFAIK this is quite common ... (unfortunately). We had several support cases in the past (several seconds delay), but I do not remember how to reproduce. I will ask the s

Re: [pve-devel] pvedaemon hanging because of qga retry

2018-05-20 Thread Alexandre DERUMIER
; timeout of some seconds, not ms!), if think we shouldn't try to send after that the other command with 1 hour timeout... - Mail original - De: "dietmar" À: "aderumier" Cc: "pve-devel" Envoyé: Dimanche 20 Mai 2018 08:16:25 Objet: Re: [pve-devel] pv

Re: [pve-devel] pvedaemon hanging because of qga retry

2018-05-19 Thread Dietmar Maurer
> On May 20, 2018 at 3:22 AM Alexandre DERUMIER wrote: > > > I have notice something when agent daemon is down: > > #qm agent 124 ping > VM 124 qmp command 'guest-ping' failed - got timeout > #qm agent 124 ping > VM 124 qmp command 'guest-ping' failed - got timeout > #qm agent 124 ping > VM 1

Re: [pve-devel] pvedaemon hanging because of qga retry

2018-05-19 Thread Alexandre DERUMIER
exist) Maybe create a specific sub to do it for any qga command. what do you think about this? - Mail original ----- De: "dietmar" À: "aderumier" Cc: "pve-devel" Envoyé: Vendredi 18 Mai 2018 19:03:19 Objet: Re: [pve-devel] pvedaemon hanging because of qga retr

Re: [pve-devel] pvedaemon hanging because of qga retry

2018-05-18 Thread Dietmar Maurer
> >>If you simply skip commands like 'guest-fsfreeze-thaw' > >>your VM will get totally unusable (frozen). So I am not > >>sure what you want to suggest? > > I'm not sure, but don't we have 2 timeout here ? > > 1 for connect , and 1 for command execution ? what for? > I would like to be able

Re: [pve-devel] pvedaemon hanging because of qga retry

2018-05-17 Thread Alexandre DERUMIER
was already async. - Mail original - De: "dietmar" À: "aderumier" , "pve-devel" Envoyé: Vendredi 18 Mai 2018 07:27:54 Objet: Re: [pve-devel] pvedaemon hanging because of qga retry If you simply skip commands like 'guest-fsfreeze-thaw' your VM wi

Re: [pve-devel] pvedaemon hanging because of qga retry

2018-05-17 Thread Dietmar Maurer
l original - > De: "aderumier" > À: "pve-devel" > Envoyé: Vendredi 18 Mai 2018 00:37:30 > Objet: Re: [pve-devel] pvedaemon hanging because of qga retry > > in qmpclient : open_connection > > for (;;) { > $count++; > $fh = IO::Socket::UNIX->

Re: [pve-devel] pvedaemon hanging because of qga retry

2018-05-17 Thread Dietmar Maurer
> we use $elapsed >= $timeout. > > Isn't this timeout for command execution time and not connect time ? > > I'm seeing at the end: > $self->{mux}->set_timeout($fh, $timeout); > > seem to be the command execution time in the muxer > I guess both should be shorter than $timeout? ___

Re: [pve-devel] pvedaemon hanging because of qga retry

2018-05-17 Thread Alexandre DERUMIER
Vendredi 18 Mai 2018 00:37:30 Objet: Re: [pve-devel] pvedaemon hanging because of qga retry in qmpclient : open_connection for (;;) { $count++; $fh = IO::Socket::UNIX->new(Peer => $sname, Blocking => 0, Timeout => 1); last if $fh; if ($! != EINTR && $! != EAGAIN) { d

Re: [pve-devel] pvedaemon hanging because of qga retry

2018-05-17 Thread Alexandre DERUMIER
in qmpclient : open_connection for (;;) { $count++; $fh = IO::Socket::UNIX->new(Peer => $sname, Blocking => 0, Timeout => 1); last if $fh; if ($! != EINTR && $! != EAGAIN) { die "unable to connect to VM $vmid $sotype socket - $!\n"; }