I'll see if I can figure out something to do based on Nathan's suggestion.
Looking a little closer today, it looks like maybe there is more of a
compiler difference (or -W flag difference) that determines if you see
the warning, rather than a kernel version?
For example, on RHEL4 (x86_64) I
Maybe just put something like this in pvfs2-types.h so we have a clean
#define to use in the rest of the code?
#ifdef __KERNEL__
#ifndef BITS_PER_LONG
#error Cannot determine PVFS2_WORDSIZE
#endif
#define PVFS2_WORDSIZE BITS_PER_LONG
#else
#ifndef INTPTR_MIN
Except it needs to be like this for the kernel module:
#if defined(__WORDSIZE)
#define SIZEOF_VOIDP __WORDSIZE
#elif defined(BITS_PER_LONG)
#define SIZEOF_VOIDP BITS_PER_LONG
#elif defined(INTPTR_MIN)
#if INTPTR_MIN == INT32_MIN
#define SIZEOF_VOIDP 32
#elif INTPTR_MIN ==
Looks good to me. My only suggestions would be to rename it to
PVFS2_ALIGN_VAR and put it in pvfs2-types.h in case we want to use it
elsewhere. Maybe put PVFS2_ on the SIZEOF_VOIDP too, to make sure it
doesn't ever conflict with something that autoconf generates.
-Phil
Sam Lang wrote:
Phil somehow the server got backed up so I didn't get your first
email. Looks like you beat me to it. :-)
I've committed the suggested changes.
-sam
On Apr 5, 2006, at 1:21 PM, Phil Carns wrote:
Looks good to me. My only suggestions would be to rename it to
PVFS2_ALIGN_VAR and put it
