Re: [Pvfs2-developers] pvfs2.o kernel module

2007-04-05 Thread Dharani Sankar Vijayakumar
Sam, I am using a stock kernel. I am using the pvfs-2.6.2. (Yeah, i added the --disable-redhat24 --->since mine is not redhat & it is a stock kernel). Regards, Dharani On Thu, 5 Apr 2007, Sam Lang wrote: Hi Dharani, Are you using a stock kernel from a particular distro? Redhat 9 by c

Re: [Pvfs2-developers] pvfs2.o kernel module

2007-04-05 Thread Sam Lang
Hi Dharani, Are you using a stock kernel from a particular distro? Redhat 9 by chance? You might need to add --enable-redhat24 to your configure if so. Which version of pvfs2 are you trying to build? -sam On Apr 5, 2007, at 11:41 PM, Dharani Sankar Vijayakumar wrote: Hi, I am having

[Pvfs2-developers] pvfs2.o kernel module

2007-04-05 Thread Dharani Sankar Vijayakumar
Hi, I am having problem building a pvfs2 kernel module for linux 2.4.20-8. I got the following when i did make kmod24. Is this a problem because of linux kernel version(2.4.20) or something else? CC [M] /home/csl/vijayaku/downloads/pvfs2/src/kernel/linux-2.4/pvfs2-utils.o pvfs2-utils.c: In f

Re: [Pvfs2-developers] patches: misc small fixes

2007-04-05 Thread Sam Lang
Committed. Thanks Phil. -sam On Apr 5, 2007, at 3:55 PM, Phil Carns wrote: These are all pretty minor: mod-parm-desc.patch: The pvfs2 kernel module is missing the parameter description for the op_timeout_secs option that can be set at insmod time. server-gossip-errn

[Pvfs2-developers] patches: misc small fixes

2007-04-05 Thread Phil Carns
These are all pretty minor: mod-parm-desc.patch: The pvfs2 kernel module is missing the parameter description for the op_timeout_secs option that can be set at insmod time. server-gossip-errno.patch: -- The pvfs2-server is trying to use errno to pro

Re: [Pvfs2-developers] patch: namei bug fixes

2007-04-05 Thread Murali Vilayannur
Hi Sam, I think I am guilty of that regression during the iget<->iget456 conversion.. I think your new version captures the essence of the vfs semantics for 2.4 and 2.6. I wonder why a dcache run did not capture this behavior.. Sorry about this. thanks, Murali On 4/5/07, Sam Lang <[EMAIL PROTECTE

Re: [Pvfs2-developers] patch: error code bug fixes

2007-04-05 Thread Murali Vilayannur
Hi Sam, We could define a PVFS_OK/BMI_OK to be 0. Given that non-error cases return 0, it might be counter-intuitive to make the return type PVFS_error, and making it PVFS_error doesn't help with compile time type-checking. I'd rather just leave it as an int for now, but that's just my prefere

Re: [Pvfs2-developers] patches: permission/acl bug fixes

2007-04-05 Thread Murali Vilayannur
Hi Phil, I also remember seeing these errors. But I cannot recollect if we resolved them.. :( IIRC we don't support doing a setxattr on a symbolic link. hence the warnings. For now, I think we can safely ignore those errors/warnings. thanks, Murali It seems like Murali saw some differences in th

Re: [Pvfs2-developers] patches: permission/acl bug fixes

2007-04-05 Thread Sam Lang
On Apr 5, 2007, at 10:55 AM, Murali Vilayannur wrote: Hi Sam, Never mind my previous email. :) Did not see the thread carefully.. Patch looks great! I see that it has been checked in already.. Sorry for the late feedback :( Its cool. Any feedback is great! -sam Murali On 3/21/07, Sam Lan

Re: [Pvfs2-developers] patch: error code bug fixes

2007-04-05 Thread Sam Lang
On Apr 5, 2007, at 10:38 AM, Murali Vilayannur wrote: Hi Phil, Nice catches! Should we perhaps augment all such functions to not return a int and replace them with a PVFS_error or a BMI_error as the case maybe? Hi Murali, Given that non-error cases return 0, it might be counter-intuitive to

Re: [Pvfs2-developers] patches: permission/acl bug fixes

2007-04-05 Thread Murali Vilayannur
Hi Sam, Never mind my previous email. :) Did not see the thread carefully.. Patch looks great! I see that it has been checked in already.. Sorry for the late feedback :( Murali On 3/21/07, Sam Lang <[EMAIL PROTECTED]> wrote: On Mar 21, 2007, at 8:35 AM, Phil Carns wrote: > Sam Lang wrote: > >>

Re: [Pvfs2-developers] patches: permission/acl bug fixes

2007-04-05 Thread Murali Vilayannur
Hi Sam, It seems like it should be possible to do that format checking of the acl when the system.posix_acl_access extended attribute is set. Does it make sense to add a callouts framework to set-eattr to do format checking for specific xattrs? Hmm.. Given that acl's are encoded while setting

Re: [Pvfs2-developers] patch: error code bug fixes

2007-04-05 Thread Murali Vilayannur
Hi Phil, Nice catches! Should we perhaps augment all such functions to not return a int and replace them with a PVFS_error or a BMI_error as the case maybe? thanks, Murali On 3/26/07, Sam Lang <[EMAIL PROTECTED]> wrote: Phil, I've committed this patch. Thanks for all the fixes. It looks like

Re: [Pvfs2-developers] patches: misc. bug fixes

2007-04-05 Thread Sam Lang
Hi Murali, Thanks for commenting on this. I lost track of these patches somehow. I agree that they look good, so I went ahead and commited them. Thanks Phil! -sam On Apr 5, 2007, at 7:57 AM, Phil Carns wrote: Murali Vilayannur wrote: Hi Phil, FWIW, if these patches haven't been comm

Re: [Pvfs2-developers] patch: namei bug fixes

2007-04-05 Thread Sam Lang
On Apr 4, 2007, at 8:22 PM, Sam Lang wrote: Do you think that we should go with your patch plus a "#ifdef PVFS2_LINUX_KERNEL_2_4" wrapper to control whether it returns NULL or res on that one line? Yeah. Sounds good to me. I can commit unless there are other objections. Went ahea

Re: [Pvfs2-developers] patches: misc. bug fixes

2007-04-05 Thread Phil Carns
Murali Vilayannur wrote: Hi Phil, FWIW, if these patches haven't been committed, it looks good :) I am really backlogged with all my emails. auto-sm-tracking.patch: --- At some point, new linked lists were added to track state machines that are currently running within the s

Re: [Pvfs2-developers] patches: misc. bug fixes

2007-04-05 Thread Murali Vilayannur
Hi Phil, FWIW, if these patches haven't been committed, it looks good :) I am really backlogged with all my emails. auto-sm-tracking.patch: --- At some point, new linked lists were added to track state machines that are currently running within the server. When an SM complet