Re: [Pvfs2-developers] pvfs2_flush_inode() and directory permissions

2006-09-21 Thread Phil Carns
Murali Vilayannur wrote: Thanks, Phil! BTW: Do all the ACL stuff work for you guys now on different distros? Murali It works on all of the redhat variants that we work with, which was our main concern. The test script doesn't jive on the gentoo box that I use for development, but it looks l

Re: [Pvfs2-developers] pvfs2_flush_inode() and directory permissions

2006-09-20 Thread Murali Vilayannur
Thanks, Phil! BTW: Do all the ACL stuff work for you guys now on different distros? Murali On Wed, 20 Sep 2006, Phil Carns wrote: > Yes, this works great. Thanks for the quick fix! > > -Phil > > Murali Vilayannur wrote: > > Hi Phil, > > I just checked in a fix for this. > > Basically, the proble

Re: [Pvfs2-developers] pvfs2_flush_inode() and directory permissions

2006-09-20 Thread Phil Carns
Yes, this works great. Thanks for the quick fix! -Phil Murali Vilayannur wrote: Hi Phil, I just checked in a fix for this. Basically, the problem was that in pvfs2_init_acl(), i wanted to mark the inode as dirty if its mode changed. Instead i was unconditionally marking it as dirty..duh Could

Re: [Pvfs2-developers] pvfs2_flush_inode() and directory permissions

2006-09-19 Thread Murali Vilayannur
Hi Phil, I just checked in a fix for this. Basically, the problem was that in pvfs2_init_acl(), i wanted to mark the inode as dirty if its mode changed. Instead i was unconditionally marking it as dirty..duh Could you give it a spin and see if that fixes this issue? Thanks, Murali On Wed, 20 Sep 2

[Pvfs2-developers] pvfs2_flush_inode() and directory permissions

2006-09-19 Thread Phil Carns
We are seeing a new problem (not sure how long it has been around) with setgid permission bits on directories. This happens with 2.6 kernels: /home/pcarns> mkdir /mnt/pvfs2/dir1 /home/pcarns> chmod g+s /mnt/pvfs2/dir1 /home/pcarns> mkdir /mnt/pvfs2/dir1/dir2 /home/pcarns> ls -alh /mnt/pvfs2/dir