Re: [PyGreSQL] Insert and update should handle bytea

2015-12-10 Thread Christoph Zwerschke
Am 10.12.2015 um 07:25 schrieb D'Arcy J.M. Cain: Shouldn't it? Here is a test that I think should pass but currently does not. Since DB adapts other types on ingress of insert() and update() as well, that makes sense. Your patch missed adding the bytea check in the _quote method. The test

[PyGreSQL] PyGreSQL Commit r662 - in trunk/module: . tests

2015-12-10 Thread darcy
Author: cito Date: Thu Dec 10 06:36:49 2015 New Revision: 662 Log: insert() and update() should convert bytes to bytea As suggested by D'Arcy on the mailing list. Modified: trunk/module/pg.py trunk/module/tests/test_classic_dbwrapper.py Modified: trunk/module/pg.py

[PyGreSQL] PyGreSQL Commit r664 - in trunk/module: . tests

2015-12-10 Thread darcy
Author: cito Date: Thu Dec 10 07:59:20 2015 New Revision: 664 Log: get() should convert bytea to bytes insert() and update() should also do this with their return values. Modified: trunk/module/pg.py trunk/module/tests/test_classic_dbwrapper.py Modified: trunk/module/pg.py

Re: [PyGreSQL] Insert and update should handle bytea

2015-12-10 Thread Christoph Zwerschke
Am 10.12.2015 um 07:25 schrieb D'Arcy J.M. Cain: It should also handle the get method so that we don't need the unescape. Done in r664. The methods now encode incoming bytes to bytea to bytes and decode outcoming bytea to bytes automatically. Note that this is currently done on the DB