Re: [PyGreSQL] [PATCH] PQresultMemorySize

2020-03-25 Thread Justin Pryzby
On Wed, Mar 25, 2020 at 10:08:25AM +0100, Christoph Zwerschke wrote: > > Am 25.03.2020 um 02:20 schrieb Justin Pryzby: > > The old stuff can be removed eventually. I like this: > > > > if self.escaping_funcs and pg_version >= (9, 0): > >

Re: [PyGreSQL] [PATCH] PQresultMemorySize

2020-03-25 Thread Christoph Zwerschke
Am 25.03.2020 um 02:20 schrieb Justin Pryzby: > The old stuff can be removed eventually. I like this: > > if self.escaping_funcs and pg_version >= (9, 0): > define_macros.append(('ESCAPING_FUNCS', None)) > That allows a packager to disable a feature > if they want the

Re: [PyGreSQL] [PATCH] PQresultMemorySize

2020-03-25 Thread Christoph Zwerschke
Am 25.03.2020 um 10:34 schrieb Justin Pryzby: I think I would leave the "positive" variable names, and *add* negative forms of the commandline options. --no-foo and/or --foo=no Yes, that would be nice. Unfortunately, the options are not interpreted by us, but by distutils. The way the

Re: [PyGreSQL] [PATCH] PQresultMemorySize

2020-03-25 Thread Justin Pryzby
On Wed, Mar 25, 2020 at 12:25:12PM +0100, Christoph Zwerschke wrote: > Am 25.03.2020 um 10:34 schrieb Justin Pryzby: > > I think I would leave the "positive" variable names, and *add* negative > > forms > > of the commandline options. --no-foo and/or --foo=no > > 1) Either two options

Re: [PyGreSQL] [PATCH] PQresultMemorySize

2020-03-25 Thread Christoph Zwerschke
Am 25.03.2020 um 12:28 schrieb Justin Pryzby: I think (1) is more common, I think that's what autoconf and gnu tools use. In that case, maybe we should use enable/disable or with/without as prefixes, like autotools? But I think it's not very common as setup option. Also, by using the old