[jira] [Commented] (PYLUCENE-47) Type matching in methods with same number of arguments

2019-04-23 Thread JIRA
[ https://issues.apache.org/jira/browse/PYLUCENE-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824421#comment-16824421 ] Petrus Hyvönen commented on PYLUCENE-47: Many thanks Andi... > Type matching in methods with

[jira] [Commented] (PYLUCENE-47) Type matching in methods with same number of arguments

2019-04-22 Thread Andi Vajda (JIRA)
[ https://issues.apache.org/jira/browse/PYLUCENE-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823602#comment-16823602 ] Andi Vajda commented on PYLUCENE-47: Fixed in rev 1857978 (the attached test passes both with

Re: [jira] [Commented] (PYLUCENE-47) Type matching in methods with same number of arguments

2019-04-19 Thread Petrus Hyvönen
Hi, I uploaded a patch that now also uses the rank function for constructors as well as a testcase. I need to think a bit on the Interface stuff and how this matches the class tests. A java class implements a specific set of interfaces I think, so in the "class" hierarchy we don't need to

[jira] [Commented] (PYLUCENE-47) Type matching in methods with same number of arguments

2019-04-18 Thread Andi Vajda (JIRA)
[ https://issues.apache.org/jira/browse/PYLUCENE-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821358#comment-16821358 ] Andi Vajda commented on PYLUCENE-47: In that case, my comment makes no sense, sorry for the noise.

Re: [jira] [Commented] (PYLUCENE-47) Type matching in methods with same number of arguments

2019-04-18 Thread Andi Vajda
On Wed, 17 Apr 2019, Petrus Hyvönen (JIRA) wrote: Petrus Hyvönen commented on PYLUCENE-47: Thanks for looking at this. I am not sure I understand your comments/questions. I don't think it is possible to have method overloading based on return type, so

[jira] [Commented] (PYLUCENE-47) Type matching in methods with same number of arguments

2019-04-16 Thread Andi Vajda (JIRA)
[ https://issues.apache.org/jira/browse/PYLUCENE-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819386#comment-16819386 ] Andi Vajda commented on PYLUCENE-47: I took at your patch and it makes sense (thanks!) Would it make

[jira] [Commented] (PYLUCENE-47) Type matching in methods with same number of arguments

2019-04-14 Thread JIRA
[ https://issues.apache.org/jira/browse/PYLUCENE-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817252#comment-16817252 ] Petrus Hyvönen commented on PYLUCENE-47: Uploaded new patch and testcase where order is based on

[jira] [Commented] (PYLUCENE-47) Type matching in methods with same number of arguments

2019-04-13 Thread JIRA
[ https://issues.apache.org/jira/browse/PYLUCENE-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817012#comment-16817012 ] Petrus Hyvönen commented on PYLUCENE-47: Updated test case to include methods with more than one