Author: Alex Gaynor <alex.gay...@gmail.com> Branch: better-jit-hooks Changeset: r51125:1c83e7759323 Date: 2012-01-07 14:21 -0600 http://bitbucket.org/pypy/pypy/changeset/1c83e7759323/
Log: review notes diff --git a/REVIEW.rst b/REVIEW.rst new file mode 100644 --- /dev/null +++ b/REVIEW.rst @@ -0,0 +1,12 @@ +REVIEW NOTES +============ + +* ``namespace=locals()``, can we please not use ``locals()``, even in tests? I find it super hard to read, and it's bad for the JIT. +* Don't we already have a thing named portal (portal call maybe?) is the name confusing? +* ``interp_reso.pyp:wrap_greenkey()`` should do something useful on non-pypyjit jds. +* The ``WrappedOp`` constructor doesn't make much sense, it can only create an op with integer args? +* Let's at least expose ``name`` on ``WrappedOp``. +* DebugMergePoints don't appears to get their metadata. +* Someone else should review the annotator magic. +* Are entry_bridge's compiled seperately anymore? (``set_compile_hook`` docstring) + _______________________________________________ pypy-commit mailing list pypy-commit@python.org http://mail.python.org/mailman/listinfo/pypy-commit
