Author: Alex Gaynor <alex.gay...@gmail.com> Branch: Changeset: r60703:248f9bb5ec68 Date: 2013-01-29 20:22 -0800 http://bitbucket.org/pypy/pypy/changeset/248f9bb5ec68/
Log: some cleanups and style changes diff --git a/rpython/jit/metainterp/virtualizable.py b/rpython/jit/metainterp/virtualizable.py --- a/rpython/jit/metainterp/virtualizable.py +++ b/rpython/jit/metainterp/virtualizable.py @@ -1,14 +1,12 @@ +from rpython.jit.metainterp import history +from rpython.jit.metainterp.typesystem import deref, fieldType, arrayItem +from rpython.jit.metainterp.warmstate import wrap, unwrap +from rpython.rlib.unroll import unrolling_iterable +from rpython.rtyper import rvirtualizable2 from rpython.rtyper.lltypesystem import lltype, llmemory from rpython.rtyper.ootypesystem import ootype -from rpython.rtyper.annlowlevel import cast_base_ptr_to_instance from rpython.rtyper.rclass import IR_IMMUTABLE_ARRAY, IR_IMMUTABLE -from rpython.rtyper import rvirtualizable2 -from rpython.rlib.unroll import unrolling_iterable -from rpython.rlib.nonconst import NonConstant -from rpython.jit.metainterp.typesystem import deref, fieldType, arrayItem -from rpython.jit.metainterp import history -from rpython.jit.metainterp.warmstate import wrap, unwrap -from rpython.rlib.objectmodel import specialize + class VirtualizableInfo(object): TOKEN_NONE = 0 # must be 0 -- see also x86.call_assembler @@ -76,7 +74,7 @@ getlength = cpu.ts.getlength getarrayitem = cpu.ts.getarrayitem setarrayitem = cpu.ts.setarrayitem - # + def read_boxes(cpu, virtualizable): assert lltype.typeOf(virtualizable) == llmemory.GCREF virtualizable = cast_gcref_to_vtype(virtualizable) @@ -89,7 +87,7 @@ for i in range(getlength(lst)): boxes.append(wrap(cpu, getarrayitem(lst, i))) return boxes - # + def write_boxes(virtualizable, boxes): virtualizable = cast_gcref_to_vtype(virtualizable) i = 0 @@ -104,7 +102,7 @@ setarrayitem(lst, j, x) i = i + 1 assert len(boxes) == i + 1 - # + def write_from_resume_data_partial(virtualizable, reader, numb): virtualizable = cast_gcref_to_vtype(virtualizable) # Load values from the reader (see resume.py) described by @@ -117,7 +115,7 @@ assert i >= 0 for ARRAYITEMTYPE, fieldname in unroll_array_fields_rev: lst = getattr(virtualizable, fieldname) - for j in range(getlength(lst)-1, -1, -1): + for j in range(getlength(lst) - 1, -1, -1): i -= 1 assert i >= 0 x = reader.load_value_of_type(ARRAYITEMTYPE, numb.nums[i]) @@ -128,7 +126,7 @@ x = reader.load_value_of_type(FIELDTYPE, numb.nums[i]) setattr(virtualizable, fieldname, x) return i - # + def load_list_of_boxes(virtualizable, reader, numb): virtualizable = cast_gcref_to_vtype(virtualizable) # Uses 'virtualizable' only to know the length of the arrays; @@ -140,10 +138,10 @@ boxes = [reader.decode_box_of_type(self.VTYPEPTR, numb.nums[i])] for ARRAYITEMTYPE, fieldname in unroll_array_fields_rev: lst = getattr(virtualizable, fieldname) - for j in range(getlength(lst)-1, -1, -1): + for j in range(getlength(lst) - 1, -1, -1): i -= 1 assert i >= 0 - box = reader.decode_box_of_type(ARRAYITEMTYPE,numb.nums[i]) + box = reader.decode_box_of_type(ARRAYITEMTYPE, numb.nums[i]) boxes.append(box) for FIELDTYPE, fieldname in unroll_static_fields_rev: i -= 1 @@ -152,7 +150,7 @@ boxes.append(box) boxes.reverse() return boxes - # + def check_boxes(virtualizable, boxes): virtualizable = cast_gcref_to_vtype(virtualizable) # for debugging @@ -168,7 +166,7 @@ assert getarrayitem(lst, j) == x i = i + 1 assert len(boxes) == i + 1 - # + def get_index_in_array(virtualizable, arrayindex, index): virtualizable = cast_gcref_to_vtype(virtualizable) index += self.num_static_extra_boxes @@ -180,7 +178,7 @@ index += getlength(lst) j = j + 1 assert False, "invalid arrayindex" - # + def get_array_length(virtualizable, arrayindex): virtualizable = cast_gcref_to_vtype(virtualizable) j = 0 @@ -188,16 +186,16 @@ if arrayindex == j: lst = getattr(virtualizable, fieldname) return getlength(lst) - j = j + 1 + j += 1 assert False, "invalid arrayindex" - # + unroll_static_fields = unrolling_iterable(zip(FIELDTYPES, static_fields)) unroll_array_fields = unrolling_iterable(zip(ARRAYITEMTYPES, array_fields)) unroll_static_fields_rev = unrolling_iterable( reversed(list(unroll_static_fields))) - unroll_array_fields_rev = unrolling_iterable( + unroll_array_fields_rev = unrolling_iterable( reversed(list(unroll_array_fields))) self.read_boxes = read_boxes self.write_boxes = write_boxes @@ -291,7 +289,7 @@ def unwrap_virtualizable_box(self, virtualizable_box): return virtualizable_box.getref(llmemory.GCREF) - + def is_vtypeptr(self, TYPE): return rvirtualizable2.match_virtualizable_type(TYPE, self.VTYPEPTR) _______________________________________________ pypy-commit mailing list pypy-commit@python.org http://mail.python.org/mailman/listinfo/pypy-commit