Re: [pypy-dev] [pypy-commit] pypy default: Detect objects with h_tid==-42

2015-04-23 Thread Armin Rigo
Hi Alex, On 22 April 2015 at 19:31, Alex Stewart wrote: > Sorry, I couldn't help noticing this: > >> if sys.maxsize < 2**32: >> offset = tid & 0x # 32bit > > 0x is not 32 bit, it's 16 bit.. Should that be 0x instead? No, this "32bit" comment mean

Re: [pypy-dev] [pypy-commit] pypy default: Detect objects with h_tid==-42

2015-04-22 Thread Alex Stewart
Sorry, I couldn't help noticing this: > if sys.maxsize < 2**32: > offset = tid & 0x # 32bit 0x is not 32 bit, it's 16 bit.. Should that be 0x instead? -alex On Apr 22, 2015 9:43 AM, "Armin Rigo" wrote: > Hi Maciej, > > On 22 April 2015 at 08:59

Re: [pypy-dev] [pypy-commit] pypy default: Detect objects with h_tid==-42

2015-04-22 Thread Armin Rigo
Hi Maciej, On 22 April 2015 at 08:59, Maciej Fijalkowski wrote: > Are you sure this is unsigned? IMO I've seen '0xffd5' or something > like that. As far as I can tell, the C code contains the declaration "Signed h_tid;". So I would guess that hdr['h_tid'] returns a signed integer. The next

Re: [pypy-dev] [pypy-commit] pypy default: Detect objects with h_tid==-42

2015-04-21 Thread Maciej Fijalkowski
Are you sure this is unsigned? IMO I've seen '0xffd5' or something like that. On Tue, Apr 21, 2015 at 7:24 PM, arigo wrote: > Author: Armin Rigo > Branch: > Changeset: r76860:e30bd43e438c > Date: 2015-04-21 19:24 +0200 > http://bitbucket.org/pypy/pypy/changeset/e30bd43e438c/ > > Log:Dete