Re: [pypy-dev] ndarray cpyext api on the pypy-pyarray branch

2013-09-10 Thread Antonio Cuni
Hi, On 09/09/13 21:37, Matti Picus wrote: I reverted the changes I made to the pypy-pyarray branch that changed c-api functions like PyArray_NDIM(arr). The original code had no real answer to what happens if these are called when arr is not an ndarray. [cut] The discussion we had on IRC star

[pypy-dev] ndarray cpyext api on the pypy-pyarray branch

2013-09-09 Thread Matti Picus
I reverted the changes I made to the pypy-pyarray branch that changed c-api functions like PyArray_NDIM(arr). The original code had no real answer to what happens if these are called when arr is not an ndarray. While the reviewers of the branch suggested that these should raise an exception i

Re: [pypy-dev] ndarray cpyext api on the pypy-pyarray branch

2013-09-09 Thread Romain Guillebert
Hi Matti I think it's fine to copy numpy's behaviour. Cheers Romain On Mon, Sep 9, 2013 at 9:37 PM, Matti Picus wrote: > I reverted the changes I made to the pypy-pyarray branch that changed c-api > functions like PyArray_NDIM(arr). > > The original code had no real answer to what happens if th