On 08/12/2011 03:41 PM, David Edelsohn wrote:
On Thu, Aug 11, 2011 at 4:32 PM, Sven Hager
wrote:
I think it is okay to add an attribute to class Field which
explicitly allows overlapping bits. It is very easy to adapt
the existing code in form.py to this.
Sven,
Attached is a patch that fixe
On Thu, Aug 11, 2011 at 4:32 PM, Sven Hager
wrote:
> I think it is okay to add an attribute to class Field which
> explicitly allows overlapping bits. It is very easy to adapt
> the existing code in form.py to this.
Sven,
Attached is a patch that fixes the rldicXXX shift by adding an
"overlap"
Sven,
If we use the overlapping bits approach, let me update that part of the patch.
You can add the changes to fields, but don't add the rldicXXX changes
in ppc_assembler.py
Thanks, David
On Thu, Aug 11, 2011 at 4:32 PM, Sven Hager
wrote:
> On 08/11/2011 09:42 PM, David Edelsohn wrote:
>>
>>
On 08/11/2011 09:42 PM, David Edelsohn wrote:
Attached is a new patch that corrects the PPC fields.
The only simple way I can think of handling the 64 bit immediate shift
field is by adding a keyword argument to Field to ignore overlap.
Expressing the details of the field splitting will be compl
Attached is a new patch that corrects the PPC fields.
The only simple way I can think of handling the 64 bit immediate shift
field is by adding a keyword argument to Field to ignore overlap.
Expressing the details of the field splitting will be complicated and
doesn't seem worth it.
Is there a pr
On Wed, Aug 10, 2011 at 9:34 AM, Michael Hudson-Doyle wrote:
> -- nothing prevents a field returning a value that is split between
> multiple bit ranges. There is a bit of scaffolding that assumes
> contiguous bit ranges but nothing fundamental (and as I said, I think
> this is mostly for checki
On Aug 10, 2011 2:23 PM, "David Edelsohn" wrote:
>
> On Wed, Aug 10, 2011 at 4:26 AM, Michael Hudson-Doyle
> wrote:
>
> > There are already fields that behave in unusual ways -- see
> >
> > https://bitbucket.org/pypy/pypy/src/f8c92c646275/pypy/jit/backend/ppc/ppcgen/ppc_field.py#cl-55
> >
> > I
On Wed, Aug 10, 2011 at 4:26 AM, Michael Hudson-Doyle wrote:
> There are already fields that behave in unusual ways -- see
>
> https://bitbucket.org/pypy/pypy/src/f8c92c646275/pypy/jit/backend/ppc/ppcgen/ppc_field.py#cl-55
>
> I think you should be able to add your fields in this fashion -- in
>
(sorry, forgot reply to all on the first version of this)
I guess a useful thing to understand here is that the powerpc
assembler was mostly written by me on a whim many many years ago --
there never was a really strong design sense and if there was, I've
probably forgotten it :)
On 10 August 201
