Re: [pypy-dev] Fwd: Re: Adding init/variables to W_Root

2017-01-11 Thread Frank Wang
Hi Armin, I've taken your advice, and my W_Root has these additions (in bold): class W_Root(object): _attrs_ = ['__weakref__', *'rb_flags'*] _must_be_light_finalizer_ = True user_overridden_class = False # Riverbed flags *rb_flags = None* *def add_rbflags(self, new_flags)

Re: [pypy-dev] Fwd: Re: Adding init/variables to W_Root

2017-01-11 Thread William ML Leslie
On 12 January 2017 at 09:08, Frank Wang wrote: > def binaryoperation(operationname): > """NOT_RPYTHON""" > def opimpl(self, *ignored): > operation = getattr(self.space, operationname) > w_2 = self.popvalue() > w_1 = self.popvalue() > w_result = operation(w_1

Re: [pypy-dev] Fwd: Re: Adding init/variables to W_Root

2017-01-11 Thread Frank Wang
Hi William, Good catch! I was just trying to get something to work, but it seems like you found another bug. I am now checking if it is None: # union flags in w_1 and w_2 and propagate to result if isinstance(w_result, W_Root) and w_result is not None: rb_results = {}