Re: [pypy-dev] RPython Darwin platform description so_prefixes empty

2016-12-06 Thread John Zhang
Hi Armin, I think we can include 'lib' in so_prefix of all Posix platforms, is that right? I can’t seem to find a definitive answer for all POSIX platforms. But for all the ones that PyPy currently supports, I think the answer is true. So if you want to make the changes then I think it’s a

Re: [pypy-dev] Request to make `makedev`, `major` and `minor` macros

2016-12-06 Thread John Zhang
Thanks Armin! I will keep my eyes open for other cases and let you know. :) Cheers, John Zhang -- John Zhang Research Assistant Programming Languages, Design & Implementation Division Computer Systems Group ANU College of Engineering & Computer

Re: [pypy-dev] Request to make `makedev`, `major` and `minor` macros

2016-12-06 Thread Armin Rigo
Hi John, On 6 December 2016 at 08:20, John Zhang wrote: > I would like to request making the definitions of > `rpython.rlib.rposix.c_makedev/c_major/c_minor` include explicit macro > functions, i.e., passing `macro=_MACRO_ON_POSIX` to the `rffi.llexternal` > function.

Re: [pypy-dev] RPython Darwin platform description so_prefixes empty

2016-12-06 Thread Armin Rigo
Hi John, On 6 December 2016 at 03:06, John Zhang wrote: > So I think it’s right to make a simple fix as suggested in the patch to > include ‘lib’ in the so_prefix on Darwin platforms. I think we can include 'lib' in so_prefix of all Posix platforms, is that right? It's

Re: [pypy-dev] RPython Darwin platform description so_prefixes empty

2016-12-06 Thread John Zhang
Hi Armin, The test `rpython.rtyper.lltypesystem.test.TestPlatform.test_prefix` illustrates the problem quite well. Currently this test is skipped on non-linux platforms. When that is turned off, the test fails on macOS X. With `Darwin_x86.so_prefix == (‘’, )`, line ll2ctypes:1218 will fail,

Re: [pypy-dev] Request to make `makedev`, `major` and `minor` macros

2016-12-06 Thread John Zhang
Forgot the attachment, sorry! -- John Zhang Research Assistant Programming Languages, Design & Implementation Division Computer Systems Group ANU College of Engineering & Computer Science 108 North Rd The Australian National University Acton ACT

[pypy-dev] Request to make `makedev`, `major` and `minor` macros

2016-12-06 Thread John Zhang
Hi all (Armin?), I would like to request making the definitions of `rpython.rlib.rposix.c_makedev/c_major/c_minor` include explicit macro functions, i.e., passing `macro=_MACRO_ON_POSIX` to the `rffi.llexternal` function. These functions are macros on both Linux and macOS (the comment above the