Re: [pytest-dev] Fwd: Continuing on failures

2020-03-27 Thread Brian Okken
I'd even be more than ok with a context manager approach and even using asserts within the context manager. As long as you can have more than one assert fail within the context. -Brian On Fri, Mar 27, 2020 at 9:30 AM Brian Okken wrote: > Victor, > > This would be brilliant. There is a fairly

Re: [pytest-dev] Fwd: Continuing on failures

2020-03-27 Thread Brian Okken
Victor, This would be brilliant. There is a fairly large need for a soft assert feature. pytest-check would not be needed if it existed. I personally would not want it to be an overriding of assert, but perhaps a different function that is used almost identically to assert, including failing the

Re: [pytest-dev] Fwd: Continuing on failures

2020-03-27 Thread Maximilian Roos
Yes exactly, we're aligned. Thanks Victor. On Fri, 27 Mar 2020 at 12:19, Victor Maryama wrote: > Oh sure, I see now what you mean. > > Back then when I was thinking about this subject it seemed to me that soft > assertions could be something implemented in pytest core itself using the >

Re: [pytest-dev] Fwd: Continuing on failures

2020-03-27 Thread Victor Maryama
Oh sure, I see now what you mean. Back then when I was thinking about this subject it seemed to me that soft assertions could be something implemented in pytest core itself using the assertion rewriting module (which in turn would put the assertion calls around the context manager), along the

Re: [pytest-dev] Fwd: Continuing on failures

2020-03-27 Thread Victor Maryama
What about pytest-assume as a context manager around the assert line? That way you get the soft assertions feature and pytest still rewrites the assertions. On Fri, Mar 27, 2020, 12:47 PM Bruno Oliveira wrote: > Hi Maximilian, > > On Thu, Mar 26, 2020 at 7:29 PM Maximilian Roos > wrote: > >>

Re: [pytest-dev] Fwd: Continuing on failures

2020-03-27 Thread Bruno Oliveira
Hi Maximilian, On Thu, Mar 26, 2020 at 7:29 PM Maximilian Roos wrote: > > To prefix: as a long time user and evangelizer of pytest, a big thank you > for the superb tool. > Thanks for the kind words, we appreciate it. > As per that README, it only works on the first failure, because the test

[pytest-dev] Fwd: Continuing on failures

2020-03-26 Thread Maximilian Roos
Hi there, To prefix: as a long time user and evangelizer of pytest, a big thank you for the superb tool. I wanted to build a tool that replaces incorrect values in tests with correct values, similar to frameworks like rust's insta or ocaml's ppx_expect