Re: [Python-3000] longobject.c and Windows x64

2008-04-14 Thread Trent Nelson
08 01:30 To: Trent Nelson Cc: Python 3000 Subject: Re: [Python-3000] longobject.c and Windows x64 On Mon, Apr 14, 2008 at 8:01 PM, Trent Nelson <[EMAIL PROTECTED]> wrote: Yeah, that's the 'wrong' part I was referring to. I guess

Re: [Python-3000] longobject.c and Windows x64

2008-04-14 Thread Mark Dickinson
On Mon, Apr 14, 2008 at 8:01 PM, Trent Nelson <[EMAIL PROTECTED]> wrote: > > Yeah, that's the 'wrong' part I was referring to. I guess I wanted to > bring that issue up as well as question the actual implementation. For > example, if we fixed the if statement, we'd having something looking like:

Re: [Python-3000] longobject.c and Windows x64

2008-04-14 Thread Trent Nelson
> > On Mon, Apr 14, 2008 at 6:02 AM, Trent Nelson <[EMAIL PROTECTED]> wrote: > > > > On Windows x64, sizeof(size_t) > sizeof(long), so the existing > > PyLong_FromSsize_t and PyLong_FromSize_t implementations in longobject.c > > are just plain wrong. I've patched it as follows, but as I'm not well

Re: [Python-3000] longobject.c and Windows x64

2008-04-14 Thread Mark Dickinson
On Mon, Apr 14, 2008 at 6:02 AM, Trent Nelson <[EMAIL PROTECTED]> wrote: > > On Windows x64, sizeof(size_t) > sizeof(long), so the existing > PyLong_FromSsize_t and PyLong_FromSize_t implementations in longobject.c are > just plain wrong. I've patched it as follows, but as I'm not well versed in

Re: [Python-3000] longobject.c and Windows x64

2008-04-14 Thread Trent Nelson
> On Windows x64, sizeof(size_t) > sizeof(long), so the > existing PyLong_FromSsize_t and PyLong_FromSize_t > implementations in longobject.c are just plain wrong. There are a whole bunch of other areas where longobject.c could do with casts to silence Windows x64 compiler warnings (where it's s

[Python-3000] longobject.c and Windows x64

2008-04-14 Thread Trent Nelson
On Windows x64, sizeof(size_t) > sizeof(long), so the existing PyLong_FromSsize_t and PyLong_FromSize_t implementations in longobject.c are just plain wrong. I've patched it as follows, but as I'm not well versed in the many intricacies of longobject.c, I'd appreciate input from others. As fa