[Python-3000] PEP 3107 - Function Annotations

2006-12-27 Thread Guido van Rossum
I just noticed that PEP 3107 has quietly been checked in. Thanks Collin and Tony! After skimming it, I have one observation: the grammar in the PEP doesn't match that implemented by Tony's patch. The difference is only apparent for tuple-unpacking parameters (e.g. b and c in "def foo(a, (b, c), d)

Re: [Python-3000] PEP 3107 - Function Annotations

2006-12-27 Thread Neal Norwitz
Some of these have already been fixed in a version sent to me. I need to check that version in. I haven't reviewed it, but I believe it addresses the __signature__ issue. I should have time to get this in tonight. n -- On 12/27/06, Guido van Rossum <[EMAIL PROTECTED]> wrote: > I just noticed t

Re: [Python-3000] PEP 3107 - Function Annotations

2006-12-27 Thread Tony Lownds
On Dec 27, 2006, at 5:31 PM, Guido van Rossum wrote: > I just noticed that PEP 3107 has quietly been checked in. Thanks > Collin and Tony! > > After skimming it, I have one observation: the grammar in the PEP > doesn't match that implemented by Tony's patch. The difference is only > apparent for

Re: [Python-3000] PEP 3107 - Function Annotations

2006-12-27 Thread Neal Norwitz
On 12/27/06, Tony Lownds <[EMAIL PROTECTED]> wrote: > > On Dec 27, 2006, at 5:31 PM, Guido van Rossum wrote: > > > I just noticed that PEP 3107 has quietly been checked in. Thanks > > Collin and Tony! > > Ok, updated (and sent to Neal for checkin, thanks Neal!) I just checked in a slightly modifie

Re: [Python-3000] PEP 3107 - Function Annotations

2006-12-27 Thread Tony Lownds
On Dec 27, 2006, at 9:03 PM, Neal Norwitz wrote: > On 12/27/06, Tony Lownds <[EMAIL PROTECTED]> wrote: >> >> On Dec 27, 2006, at 5:31 PM, Guido van Rossum wrote: >> >>> I just noticed that PEP 3107 has quietly been checked in. Thanks >>> Collin and Tony! >> >> Ok, updated (and sent to Neal for ch

Re: [Python-3000] PEP 3107 - Function Annotations

2006-12-27 Thread Neal Norwitz
I checked in a modified version of the patch (rev 53170). Mostly I: * added error checking * updated N_TOKENS in Include/token.h (and Lib/token.py) since a token was added * Changed some code in Lib/compiler/pycodegen.py (I couldn't let Guido see a 2-space indent or he might think Google had co