Changes by Martin v. Löwis:
--
keywords: +patch
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1442
__
___
Python-bugs-list mailing list
Unsubscribe:
Senthil added the comment:
Not really.
RFC 1808, on which urlparse module is based, defines the following for
the PATH component when joining the relative URL to Base URL.
Step 6: The last segment of the base URL's path (anything
following the rightmost slash /, or the entire
Amaury Forgeot d'Arc added the comment:
fp_readl is indeed broken in several ways:
- decoding_buffer should be reset to NULL when all data has been read
(buflen = size).
- the (buflen size) case will cause an error on the next pass, since
the function cannot handle PyBytesObject.
IOW, the
Viktor Ferenczi added the comment:
In response to Guido:
According to pythonmeister's post (2007-09-10):
Same under Linux with Python 3.0a1.
Eats all cpu + memory
I found the bug with this version:
[EMAIL PROTECTED]:~$ python3.0 --version
Python 3.0a1
AFAIK it is the latest alpha released.
Christian Heimes added the comment:
I've a far better patch that uses Python's infrastructure to report the
error:
Index: Modules/main.c
===
--- Modules/main.c (Revision 58966)
+++ Modules/main.c (Arbeitskopie)
@@ -132,6
Guido van Rossum added the comment:
The patch looks okay, but I just thought of something -- why not make
sys.stdout and friends be undefined (i.e. NULL) instead of setting them
to None? That way this patch isn't necessary and you only need one
small change to builtin_print() -- which you need
Guido van Rossum added the comment:
Crys, can you test this on Windows and if it does, assign back to me?
--
assignee: gvanrossum - tiran
nosy: +tiran
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1439
__
Guido van Rossum added the comment:
Never mind. I must've searched for fromdf. Crys, I think this is good
to go into 2.6 and be merged into 3.0. Then in 3.0 we can simplify Bill
Janssen's patch further.
--
assignee: - tiran
__
Tracker [EMAIL
Guido van Rossum added the comment:
BTW for reference, see http://www.python.org/download/releases/2.3/mro/
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue619475
___
Guido van Rossum added the comment:
I'd like to see this applied, HOWEVER I'm confused. I don't see any
mention of fromfd in the patch except in a comment. Now, in 3.0,
fromfd() is implemented in socket.py using os.dup(); but in 2.6 i don't
see it there either. What's going in?
I am hoping
Guido van Rossum added the comment:
Go for it.
On Nov 14, 2007 10:39 AM, Christian Heimes [EMAIL PROTECTED] wrote:
Christian Heimes added the comment:
Guido van Rossum wrote:
The patch looks okay, but I just thought of something -- why not make
sys.stdout and friends be undefined (i.e.
Christian Heimes added the comment:
Neal, Thomas, what do you think about the patch? Your knowledge of the
Windows API is greater than mine. Is the duplicate_socket() function ok?
I don't want to apply a patch I don't fully understand.
+#ifdef MS_WINDOWS
+/* On Windows a socket is really a
Jim Jewett added the comment:
But you said that #2 solution was more RFC compliant...
Could you please quote the RFC part that describes this behaviour?
RFD2616
http://www.faqs.org/rfcs/rfc2616.html
section 4.3 Message Body ...
The presence of a message-body in a request is signaled by
Christian Heimes added the comment:
Guido van Rossum wrote:
The patch looks okay, but I just thought of something -- why not make
sys.stdout and friends be undefined (i.e. NULL) instead of setting them
to None? That way this patch isn't necessary and you only need one
small change to
New submission from neoone:
Initialization of member variables with lists leads to strange
behavior.
The list object is common to each instance of that class.
File attached results in:
[] [] __main__.Proof instance at 0x00BA7120
['STICKYARRAY'] [] __main__.Proof instance at 0x00BA7148
So the
Christian Heimes added the comment:
Hi Janssen!
The patch at http://bugs.python.org/issue1378 adds suport for
_socket.socket.dup() on Windows. It can't dup file descriptors but it
can dup socket handlers. Would it make your patch easier?
__
Tracker [EMAIL
Thomas Heller added the comment:
Christian Heimes schrieb:
Neal, Thomas, what do you think about the patch? Your knowledge of the
Windows API is greater than mine. Is the duplicate_socket() function ok?
I don't want to apply a patch I don't fully understand.
+#ifdef MS_WINDOWS
+/* On
Guido van Rossum added the comment:
I'm disappointed that this doesn't implement socket.fromfd() properly.
Perhaps fromfd() needs to be implemented in socketmodule.c?
Also, the whole mess with the _base slot can be gotten rid of;
accept() can use the dup() method instead.
Guido van Rossum added the comment:
Go ask on c.l.py why this is not a bug.
--
nosy: +gvanrossum
resolution: - invalid
status: open - closed
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1443
__
Christian Heimes added the comment:
Port of the socket_fromfd.patch to py3k
Added file: http://bugs.python.org/file8746/py3k_socket_fromfd.patch
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1378
__Index: Lib/socket.py
Christian Heimes added the comment:
I'm disappointed that this doesn't implement socket.fromfd() properly.
Perhaps fromfd() needs to be implemented in socketmodule.c?
On Windows socket.fromfd() is not possible. Socket handlers and file
descriptors are different types using different API
Christian Heimes added the comment:
I've checked the patch on Windows. I've run the regression tests with
-R:: for test_urllib2 test_urllib2net test_urllib test_urllibnet
test_socket. The tests are passing and no ref leak shows up.
--
assignee: tiran - gvanrossum
Guido van Rossum added the comment:
On Windows socket.fromfd() is not possible. Socket handlers and file
descriptors are different types using different API methods. Other
examples for the discrepancy are select.select() and select.poll(). On
Windows they don't work on file.
I know, but, I
Guido van Rossum added the comment:
I take it back. You can check this in.
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1440
__
___
Python-bugs-list mailing list
Unsubscribe:
Guido van Rossum added the comment:
Committed revision 58970 (with slight changes).
Bill, you can now submit your SSL code for review.
--
assignee: gvanrossum - tiran
resolution: - accepted
status: open - closed
__
Tracker [EMAIL PROTECTED]
Marc-Andre Lemburg added the comment:
The problem is also present in Python 2.4 and 2.3. Confirmed on AIX 5.3.
--
nosy: +lemburg
versions: +Python 2.3, Python 2.4
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1234
Guido van Rossum added the comment:
Crys, did you actually run the tests for the 3.0 port of the patch? I
think accept() is broken, as it checks for _can_dup_socket and will
attempt to call os.dup().
I'm thinking that we should change the C class to not create new objects
on accept() and dup()
Guido van Rossum added the comment:
Here's a new version along the lines I described. Please test on
Windows. It works on Linux and OSX. What this includes:
- the dup-on-windows implementation by R Oudkerk, with the
GetLastError() suggestion from Thomas Heller.
- Replace the C implementations
Guido van Rossum added the comment:
PS. socket.diff is for 3.0. I'll backport once this is accepted.
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1378
__
___
Python-bugs-list
Christian Heimes added the comment:
Committed in r58974
--
resolution: - fixed
status: open - closed
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1440
__
___
Bill Janssen added the comment:
Once I've tried it again.
Bill
On Nov 14, 2007 2:32 PM, Guido van Rossum [EMAIL PROTECTED] wrote:
Guido van Rossum added the comment:
Committed revision 58970 (with slight changes).
Bill, you can now submit your SSL code for review.
--
assignee:
31 matches
Mail list logo
