[issue1577] shutil.move() does not use os.rename() if dst is a directory

2007-12-10 Thread Facundo Batista
Facundo Batista added the comment: I have another way: * Check if the destination is a directory, and in such case make an os.path.join(destination, originfile), and then use os.rename() with this new destination. What do you think? Do you think this way suffers from any multiplatform issue?

[issue1202] zlib.crc32() and adler32() return value

2007-12-10 Thread Armin Rigo
Armin Rigo added the comment: The C reference code in rfc1950 for Adler-32 and in rfc1952 for CRC-32 compute with and return unsigned long values. From this point of view, returning negative values on 32-bit machines from CPython's zlib module can be considered a bug. That only leaves open the

[issue1313119] urlparse caches parses regardless of encoding

2007-12-10 Thread Tom Parker
Tom Parker added the comment: Also effects Python 2.5.1 (tested on Debian python2.5 package version 2.5.1-5) -- nosy: +palfrey versions: +Python 2.5 _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1313119 _

[issue1564] The set implementation should special-case PyUnicode instead of PyString

2007-12-10 Thread Raymond Hettinger
Raymond Hettinger added the comment: I had looked at the version 2 instead of version 3. Version 3 is much closer. A couple of comments. Don't change the brace opening/closing convention in the file -- stick with the KR style -- mixing two different styles makes the file harder to read and

[issue1579] logging documentation is unclear

2007-12-10 Thread Kylotan
New submission from Kylotan: The documentation for the logging module is quite confusing, and (I am told) seems to assume prior experience with the log4j utility or similar. In particular: - the front page has a rather confusing example of the named hierarchy system, which might mislead the

[issue1579] logging documentation is unclear

2007-12-10 Thread Facundo Batista
Facundo Batista added the comment: Do you think that can came up with a patch for this? Just the paragraphs better written, or a better example, that would be great! Thanks! -- nosy: +facundobatista __ Tracker [EMAIL PROTECTED]

[issue1578] Problems in win_getpass

2007-12-10 Thread Christian Heimes
Christian Heimes added the comment: I've added wide char API variants of the get and put commands to msvcrt in the trunk. I'm going to fix the problem with the new functions. -- assignee: - tiran keywords: +py3k nosy: +tiran priority: - normal __

[issue1322] platform.dist() has unpredictable result under Linux

2007-12-10 Thread Christian Heimes
Christian Heimes added the comment: I'm mentoring a task for GHOP which is going to fix the problem. -- assignee: - tiran priority: - normal versions: +Python 3.0 __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1322

[issue1564] The set implementation should special-case PyUnicode instead of PyString

2007-12-10 Thread Christian Heimes
Christian Heimes added the comment: I've done as you said and committed the changes in r59449. Next time I won't try to add optimizations without consulting you in the first place. :] Thanks for your advice. -- resolution: - fixed status: open - closed

[issue1530] doctest should return error if not all tests passed

2007-12-10 Thread Miki Tebeka
Miki Tebeka added the comment: Thank you for accepting it :) __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1530 __ ___ Python-bugs-list mailing list Unsubscribe:

[issue1578] Problems in win_getpass

2007-12-10 Thread Christian Heimes
Christian Heimes added the comment: Fixed in r59451 -- resolution: - fixed status: open - closed __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1578 __ ___

[issue1560] PATCH: Attribute lookup caching

2007-12-10 Thread Guido van Rossum
Guido van Rossum added the comment: Are you withdrawing this in favor of #1568? -- nosy: +gvanrossum __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1560 __ ___

[issue1577] shutil.move() does not use os.rename() if dst is a directory

2007-12-10 Thread Guido van Rossum
Guido van Rossum added the comment: We should first decide what should happen. While for command line tools mv FILE DIR is established syntax for mv FILE DIR/`basename FILE`, I'm not at all sure that shutil.move(src, dst) should do the same. I think it should be closer to the UNIX os.rename()

[issue1576] First draft of a post import hook

2007-12-10 Thread Christian Heimes
Christian Heimes added the comment: The new patch fixes some ref leaks, corner cases and adds some new unit tests. All unit tests are passing but I'm leaking lots of references in the register function. Added file: http://bugs.python.org/file8909/py3k_post_import_hook3.patch

[issue1576] First draft of a post import hook

2007-12-10 Thread Christian Heimes
Changes by Christian Heimes: Removed file: http://bugs.python.org/file8906/py3k_post_import_hook2.patch __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1576 __ ___

[issue1722225] Build on QNX

2007-12-10 Thread Matt Kraai
Matt Kraai added the comment: I'm willing to maintain the QNX 6 port, but I can't promise that I'll be able to do so for 5 years. I don't know if that's sufficient or not. _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue175

[issue1560] PATCH: Attribute lookup caching

2007-12-10 Thread Neil Toronto
Neil Toronto added the comment: Yes, as well #1700288 (Armin's attribute lookup caching patch ported to 2.6) or #1685986 (Armin's original for 2.4), or whatever Raymond finds most convenient. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1560

[issue1677872] Efficient reverse line iterator

2007-12-10 Thread Guido van Rossum
Guido van Rossum added the comment: I'd like to see the doc patches separated out and applied to 2.6 -- they'll automatically merge into 3.0 then. Make that a separate bug please. I like the idea, haven't had time to carefully review the code, but noticed one oddity: for line in

[issue1581] xmlrpclib.ServerProxy() doesn't use x509 data

2007-12-10 Thread Andreas Hasenack
New submission from Andreas Hasenack: I was trying to use xmlrpclib.ServerProxy() with https and client certificate validation (I know httplib doesn't do server certificate validation yet). I found no way to pass on host/uri as a (host,x509_dict) tuple as the connection methods support, so I

[issue1580] Use shorter float repr when possible

2007-12-10 Thread Guido van Rossum
Guido van Rossum added the comment: I like this; but I don't have time for a complete thourough review. Maybe Tim can lend a hand? If Tim has no time, I propose that if it works correctly without leaks on at least Windows, OSX and Linux, we check it in, and worry about more review later.

[issue1560] PATCH: Attribute lookup caching

2007-12-10 Thread Guido van Rossum
Changes by Guido van Rossum: -- resolution: - out of date status: open - closed __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1560 __ ___ Python-bugs-list mailing

[issue1560] PATCH: Attribute lookup caching

2007-12-10 Thread Guido van Rossum
Guido van Rossum added the comment: That's still ambiguous -- do you want any of those to be closed too? Clearly we're not going to patch 2.4. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1560 __

[issue1581] xmlrpclib.ServerProxy() doesn't use x509 data

2007-12-10 Thread Guido van Rossum
Guido van Rossum added the comment: This should be considered for 2.6, not 2.5 (which is in feature freeze). I'm hoping Bill Janssen can review this. -- assignee: - janssen nosy: +gvanrossum, janssen __ Tracker [EMAIL PROTECTED]

[issue1114345] Add SSL certificate validation

2007-12-10 Thread Andreas Hasenack
Changes by Andreas Hasenack: -- nosy: +ahasenack _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1114345 _ ___ Python-bugs-list mailing list Unsubscribe:

[issue1560] PATCH: Attribute lookup caching

2007-12-10 Thread Neil Toronto
Neil Toronto added the comment: Sorry - I'll be more clear. I'd love to see 2.6 get attribute lookup caching, and Kevin's port (#1700288) of Armin's original 2.4 patch (#1685986) does that for 2.6. #1685986 (2.4) should be closed and #1700288 (2.6) should remain open. But Raymond has indicated

[issue1582] Documentation patch for reversed() and __reversed__()

2007-12-10 Thread Mark Russell
New submission from Mark Russell: This patch adds documentation for the reversed() builtin and __reversed__() special method. -- components: Documentation files: reverse-2.6-docs.diff messages: 58369 nosy: mark_t_russell severity: normal status: open title: Documentation patch for

[issue1677872] Efficient reverse line iterator

2007-12-10 Thread Mark Russell
object. If that sounds on the right lines I'm happy to think about it a bit more and submit a patch. Added file: http://bugs.python.org/file8913/reverse-file-iterator-20071210.diff _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1677872

[issue1560] PATCH: Attribute lookup caching

2007-12-10 Thread Raymond Hettinger
Raymond Hettinger added the comment: I'm trying to look at all of them. Having it split into several patches and getting frequent updates and posts is making it difficult. Please communicate with me directly (python at rcn dot com) so I can find out which versions are the latest and the reason

[issue1469] SSL tests leak memory

2007-12-10 Thread Bill Janssen
Bill Janssen added the comment: I think I've figured it out. My initial patch to socket.py and ssl.py had an extra method defined on socket.socket, _real_close(), which did' the cleanup work of deallocating the underlying socket, and in the SSL subclass, of releasing the SSL context. Guido

[issue1581] xmlrpclib.ServerProxy() doesn't use x509 data

2007-12-10 Thread Martin v. Löwis
Martin v. Löwis added the comment: I would like to ask the submitter to review the code himself for suitability in 2.6. The underlying API has been extended a lot, so it's unlikely that this patch is still the best choice. -- nosy: +loewis __ Tracker

[issue1580] Use shorter float repr when possible

2007-12-10 Thread Christian Heimes
Christian Heimes added the comment: Applied in r59457 I had to add checks for _M_X64 and _M_IA64 to doubledigits.c. The rest was fine on Windows. -- resolution: - fixed status: open - closed __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1580

[issue1202] zlib.crc32() and adler32() return value

2007-12-10 Thread Armin Rigo
Armin Rigo added the comment: Obscure but reasonable. (I suspect you meant to say that py3k should return the *unsigned* value for better compliance with the standard.) __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1202

[issue1202] zlib.crc32() and adler32() return value

2007-12-10 Thread Guido van Rossum
Guido van Rossum added the comment: Obscure but reasonable. (I suspect you meant to say that py3k should return the *unsigned* value for better compliance with the standard.) Yes. :) __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1202

[issue1643738] Problem with signals in a single-threaded application

2007-12-10 Thread Guido van Rossum
Guido van Rossum added the comment: Discussing this with Rhamporyncus (Adam Olson) on #python-dev now. -- assignee: - gvanrossum nosy: +gvanrossum _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1643738 _

[issue1469] SSL tests leak memory

2007-12-10 Thread Bill Janssen
Bill Janssen added the comment: So, what's the final status of __del__ in py3K? The other bit of leak is due to _real_close() not being called when a socket is dropped on the floor (say, you try to connect, fail, and raise the exception back to the caller, without ever explicitly calling

[issue1469] SSL tests leak memory

2007-12-10 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc added the comment: Is it possible that you have the same problem as in http://bugs.python.org/issue1540 ? To be sure, check the gc.garbage variable at the end of the test. It may contain the references you are looking for... -- nosy: +amaury.forgeotdarc

[issue1643738] Problem with signals in a single-threaded application

2007-12-10 Thread Guido van Rossum
Guido van Rossum added the comment: Committed revision 59460 to 2.6. Will backport to 2.5 as well. -- resolution: - accepted _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1643738 _

[issue1643738] Problem with signals in a single-threaded application

2007-12-10 Thread Guido van Rossum
Guido van Rossum added the comment: Committed revision 59461 to 2.5. Thanks, Ulisses!! -- status: open - closed _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1643738 _

[issue1754489] Non-portable address length calculation for AF_UNIX sockets

2007-12-10 Thread Christian Heimes
Changes by Christian Heimes: -- type: - behavior versions: +Python 2.6, Python 3.0 _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1754489 _ ___ Python-bugs-list

[issue1469] SSL tests leak memory

2007-12-10 Thread Guido van Rossum
Guido van Rossum added the comment: So, what's the final status of __del__ in py3K? The other bit of leak is due to _real_close() not being called when a socket is dropped on the floor (say, you try to connect, fail, and raise the exception back to the caller, without ever explicitly

[issue1576] First draft of a post import hook

2007-12-10 Thread Christian Heimes
Christian Heimes added the comment: UPDATES: * no ref leaks * PyModule_IsLazy(mod) checks mod.__lazy_import__ attribute (we can argue about a nice name later) * Added imp.is_lazy(mod_or_name) Added file: http://bugs.python.org/file8914/py3k_post_import_hook4.patch

[issue1582] Documentation patch for reversed() and __reversed__()

2007-12-10 Thread Guido van Rossum
Guido van Rossum added the comment: Georg, can you handle this? -- assignee: - georg.brandl nosy: +georg.brandl, gvanrossum __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1582 __

[issue1583] Patch for signal.set_wakeup_fd

2007-12-10 Thread Adam Olsen
New submission from Adam Olsen: This adds signal.set_wakeup_fd(fd), which allows a single library to be woken when a signal comes in. -- files: python2.6-set_wakeup_fd1.diff messages: 58385 nosy: rhamphoryncus severity: normal status: open title: Patch for signal.set_wakeup_fd Added

[issue1583] Patch for signal.set_wakeup_fd

2007-12-10 Thread Adam Olsen
Adam Olsen added the comment: Guido, it looks like I can't alter the Assigned To field. You get the Nosy List instead. ;) -- nosy: +gvanrossum __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1583 __

[issue1583] Patch for signal.set_wakeup_fd

2007-12-10 Thread Guido van Rossum
Guido van Rossum added the comment: Thanks! Can you add a doc patch too? Doc/library/signal.rst -- assignee: - gvanrossum keywords: +py3k versions: +Python 2.6 __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1583

[issue1469] SSL tests leak memory

2007-12-10 Thread Bill Janssen
Bill Janssen added the comment: The other leak comes from this code: s = ssl.wrap_socket(socket.socket(), ...) s.connect((SOME BOGUS ADDRESS OR SERVER)) The connect() fails, and the SSLSocket sgets dropped on the floor, but never seems to be GC'd, (or the GC never seems to call the

[issue1469] SSL tests leak memory

2007-12-10 Thread Bill Janssen
Bill Janssen added the comment: gc.garbage is always empty. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1469 __ ___ Python-bugs-list mailing list Unsubscribe:

[issue1469] SSL tests leak memory

2007-12-10 Thread Guido van Rossum
Guido van Rossum added the comment: I wonder if Christian Heimes was correct that the ssl object needs GC support? This was part of his patch (which I checked in and then reverted because the other part of it didn't work as advertised). Alternatively, if 's' is involved in a cycle *and* any of

[issue1583] Patch for signal.set_wakeup_fd

2007-12-10 Thread Guido van Rossum
Changes by Guido van Rossum: -- priority: - normal __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1583 __ ___ Python-bugs-list mailing list Unsubscribe:

[issue1583] Patch for signal.set_wakeup_fd

2007-12-10 Thread Guido van Rossum
Changes by Guido van Rossum: -- keywords: +patch -py3k __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1583 __ ___ Python-bugs-list mailing list Unsubscribe:

[issue1564547] Py_signal_pipe

2007-12-10 Thread Guido van Rossum
Changes by Guido van Rossum: -- resolution: accepted - rejected superseder: - Patch for signal.set_wakeup_fd _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1564547 _

[issue1583] Patch for signal.set_wakeup_fd

2007-12-10 Thread Adam Olsen
Adam Olsen added the comment: version 2, adds to Doc/library/signal.rst. It also tweaks the set_wakeup_fd's docstring. I haven't verified that my formatting in signal.rst is correct. Specifically, the '\0' should be checked. Added file:

[issue1374] IDLE - minor FormatParagraph bug fix

2007-12-10 Thread Kurt B. Kaiser
Kurt B. Kaiser added the comment: r59463 Thanks for the patch! -- resolution: - accepted status: open - closed __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1374 __

[issue1580] Use shorter float repr when possible

2007-12-10 Thread Guido van Rossum
Guido van Rossum added the comment: Noam, perhaps you can help with this? We checked this in but found a problem: repr(1e5) suddenly returns '1.0'. Can you think of a cause for this? -- status: closed - open __ Tracker [EMAIL PROTECTED]

[issue1252] IDLE - patch Delegator to support callables

2007-12-10 Thread Kurt B. Kaiser
Kurt B. Kaiser added the comment: Do you have any further comments on this issue? __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1252 __ ___ Python-bugs-list mailing list

[issue1469] SSL tests leak memory

2007-12-10 Thread Bill Janssen
Bill Janssen added the comment: Ah, I see what's going on. The revision of the socket code (nice job, by the way) removed the distinction between the C socket object and the Python socket object. The C SSLContext keeps a pointer to the C socket object, which is now the Python socket object, or

[issue1469] SSL tests leak memory

2007-12-10 Thread Christian Heimes
Christian Heimes added the comment: Guido van Rossum wrote: Guido van Rossum added the comment: I wonder if Christian Heimes was correct that the ssl object needs GC support? This was part of his patch (which I checked in and then reverted because the other part of it didn't work as

[issue1580] Use shorter float repr when possible

2007-12-10 Thread Noam Raphael
Noam Raphael added the comment: I don't know, for me it works fine, even after downloading a fresh SVN copy. On what platform does it happen? __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1580 __

[issue1580] Use shorter float repr when possible

2007-12-10 Thread Christian Heimes
Christian Heimes added the comment: I've disabled the new repr() in trunk and py3k until somebody has sorted out the build problems. I've removed doubledigits.c from Makefile.in and disabled the code with #ifdef Py_BROKEN_REPR in floatobject.c. -- assignee: tiran - keywords: +py3k

[issue1580] Use shorter float repr when possible

2007-12-10 Thread Guido van Rossum
Guido van Rossum added the comment: On what platform does it happen? Linux on x86. It seems find on PPC OSX. This suggests it could be a byte order bug. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1580 __

[issue1469] SSL tests leak memory

2007-12-10 Thread Bill Janssen
Bill Janssen added the comment: I think Christian analysis is right, in that it takes a bit of GC support, but not perhaps in the specifics of his approach. I've done two things to fix this: 1) Put _real_close() back in socket.py, and then override it in ssl.SSLSocket to release the

[issue1580] Use shorter float repr when possible

2007-12-10 Thread Noam Raphael
Noam Raphael added the comment: I also use linux on x86. I think that byte order would cause different results (the repr of a random float shouldn't be 1.0.) Does the test case run ok? Because if it does, it's really strange. -- versions: -Python 2.6 __

[issue1580] Use shorter float repr when possible

2007-12-10 Thread Christian Heimes
Changes by Christian Heimes: -- versions: +Python 2.6 __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1580 __ ___ Python-bugs-list mailing list Unsubscribe:

[issue1469] SSL tests leak memory

2007-12-10 Thread Bill Janssen
Bill Janssen added the comment: Here's a patch -- take a look and let me know. I also added a real asyncore server test. Added file: http://bugs.python.org/file8919/a __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1469

[issue1580] Use shorter float repr when possible

2007-12-10 Thread Tim Peters
Tim Peters added the comment: There is nothing you can do to repr() that's sufficient by itself to ensure eval(repr(x)) == x. The other necessary part is correctly rounded float /input/ routines. The 754 standard does not require correctly rounding input or output routines. It does require

[issue1563] asyncore and asynchat incompatible with Py3k str and bytes

2007-12-10 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: There's a patch pending which should be included in the 2.6 trunk before solving issues related to py3k and/or applying other changes, imho: http://bugs.python.org/issue1736190 -- nosy: +giampaolo.rodola __ Tracker

[issue1580] Use shorter float repr when possible

2007-12-10 Thread Christian Heimes
Christian Heimes added the comment: I've written a small C program for auto config that checks the endianness of IEEE doubles. Neil has promised to add something to configure.in when I come up with a small C program. It *should* do the right thing on a BE platform but I can't test it. Tim, does

[issue1482] IMAP4 SSL isn't working

2007-12-10 Thread Bill Janssen
Bill Janssen added the comment: I'm still getting this with the latest SSL module fixes. I'm guessing this is a problem with the implementation of imaplib, but I haven't looked into it yet. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1482

[issue1482] IMAP4 SSL isn't working

2007-12-10 Thread Bill Janssen
Bill Janssen added the comment: Here's a fix for the 3K branch. Added file: http://bugs.python.org/file8921/b __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1482 __ b Description: Binary data

[issue1482] IMAP4 SSL isn't working

2007-12-10 Thread Bill Janssen
Changes by Bill Janssen: -- keywords: +patch __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1482 __ ___ Python-bugs-list mailing list Unsubscribe:

[issue1580] Use shorter float repr when possible

2007-12-10 Thread Tim Peters
Tim Peters added the comment: Again, without replacing float input routines too, this is /not/ good enough to ensure eval(repr(x)) == x even across just 100%-conforming 754 platforms. It is good enough to ensure (well, assuming the code is 100% correct) eval(repr(x)) == x across conforming 754

[issue1469] SSL tests leak memory

2007-12-10 Thread Bill Janssen
Bill Janssen added the comment: Now, about the confused signature of SSLSocket.read(). I'm not sure how confused it is. It's sui generis; SSLSocket doesn't inherit from some other class with a different read() method with a different signature. But we could change the name, perhaps to

[issue1469] SSL tests leak memory

2007-12-10 Thread Bill Janssen
Changes by Bill Janssen: Removed file: http://bugs.python.org/file8919/a __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1469 __ ___ Python-bugs-list mailing list Unsubscribe:

[issue1584] Mac OS X: building with X11 Tkinter

2007-12-10 Thread C. E. Ball
New submission from C. E. Ball: On OS X, I wanted to build my own copy of Python that used my own copy of Tkinter (built for X11). To do this, I passed LDFLAGS=-rpath,/path/to/lib to configure so that Python could find my specific lib files, but I also had to edit Python's setup.py so that

[issue1580] Use shorter float repr when possible

2007-12-10 Thread Noam Raphael
Noam Raphael added the comment: Oh, this is sad. Now I know why Tcl have implemented also a decimal to binary routine. Perhaps we can simply use both their routines? If I am not mistaken, their only real dependency is on a library which allows arbitrary long integers, called tommath, from which