[issue3609] does parse_header really belong in CGI module?

2008-08-19 Thread Bill Janssen
Bill Janssen <[EMAIL PROTECTED]> added the comment: > I imagine if they were moved (at least for a few versions) the old ones > would still work, with a deprecation warning? Yes, that's what I was thinking. ___ Python tracker <[EMAIL PROTECTED]>

[issue3614] typo in xmlrpc.client

2008-08-19 Thread Dmitry Dvoinikov
New submission from Dmitry Dvoinikov <[EMAIL PROTECTED]>: In xmlrpc.client:1204: --- headers = {} if extra_headers: for key, val in extra_headers: header[key] = val --- shouldn't it read --- headers[key] = val ^ --- ? Otherwise it bails out with --- NameError:

[issue1276] LookupError: unknown encoding: X-MAC-JAPANESE

2008-08-19 Thread Hye-Shik Chang
Changes by Hye-Shik Chang <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file11170/cjkmactemporary.diff ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3613] base64.encodestring does not actually accept strings

2008-08-19 Thread Dmitry Dvoinikov
New submission from Dmitry Dvoinikov <[EMAIL PROTECTED]>: This quote from base64.py: --- bytes_types = (bytes, bytearray) # Types acceptable as binary data ... def encodestring(s): """Encode a string into multiple lines of base-64 data. Argument and return value are bytes. """

[issue3609] does parse_header really belong in CGI module?

2008-08-19 Thread Matt Giuca
Matt Giuca <[EMAIL PROTECTED]> added the comment: These functions are for generic MIME headers and bodies, so are applicable to CGI, HTTP, Email, and any other protocols based on MIME. So I think having them in email.header makes about as much sense as having them in cgi. Isn't mimetools a bette

[issue3612] Add some basic mssing types in ctypes.wintypes

2008-08-19 Thread Hirokazu Yamamoto
New submission from Hirokazu Yamamoto <[EMAIL PROTECTED]>: This patch adds some basic mssing types in ctypes.wintypes. I think pointer type like LPDWORD would be usuful too, but maybe you cannot ignore the overhead of POINTER object creation. -- assignee: theller components: ctypes files

[issue3119] pickle.py is limited by python's call stack

2008-08-19 Thread Aaron Gallagher
Aaron Gallagher <[EMAIL PROTECTED]> added the comment: Alright, sorry this took so long. Hopefully this can still be included in 3.0. Included is a patch that no longer uses collections.deque and also adds a test case to test/test_pickle.py. The test catches RuntimeError and fails the unittest

[issue843385] help(obj) should use __doc__ when available

2008-08-19 Thread Benjamin Peterson
Benjamin Peterson <[EMAIL PROTECTED]> added the comment: I believe this has been implemented now. -- nosy: +benjamin.peterson resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]>

[issue515073] subtypable weak references

2008-08-19 Thread Benjamin Peterson
Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Does anyone still care about this? -- nosy: +benjamin.peterson ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue658693] cPickle does relative import

2008-08-19 Thread Benjamin Peterson
Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Is this still an issue? -- nosy: +benjamin.peterson ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue3611] invalid exception context

2008-08-19 Thread STINNER Victor
STINNER Victor <[EMAIL PROTECTED]> added the comment: I also noticed a crash in PyErr_SetObject(): in block , tstate->exc_value value may changes and so it's possible that tstate->exc_value becomes NULL. I added a test to avoid this crash: Index: Python/errors.c ===

[issue3611] invalid exception context

2008-08-19 Thread STINNER Victor
STINNER Victor <[EMAIL PROTECTED]> added the comment: The crash is on ProcError exception raising (line 21): 20 except IOError as err: 21 raise ProcError("Unable to open %r: %s" % (filename, --- (gdb) where #0 0x0805bcc7 in PyObject_Hash (v=0x8691034) at Objects/object.

[issue3607] test_multiprocessing failure (Unserializable message)

2008-08-19 Thread Benjamin Peterson
Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Here's a buildbot example: http://python.org/dev/buildbot/stable/amd64%20gentoo%203.0/builds/980/step-test/0 -- nosy: +benjamin.peterson ___ Python tracker <[EMAIL PROTECTED]>

[issue3611] invalid exception context

2008-08-19 Thread STINNER Victor
New submission from STINNER Victor <[EMAIL PROTECTED]>: After few seconds (30 sec to 5 minutes), my program (Fusil) crashs at: PyEval_EvalFrameEx (f=0x85b4324, throwflag=0) at Python/ceval.c:2459 Py_CLEAR(tstate->exc_traceback); It crashs because tstate->exc_traceback points to a zombi obje

[issue3139] bytearrays are not thread safe

2008-08-19 Thread Ismail Donmez
Ismail Donmez <[EMAIL PROTECTED]> added the comment: > Can you run Lib/test/test_unicode.py directly to know which test > precisely crashes? The latest py3k branch is fine now and the test passes. ___ Python tracker <[EMAIL PROTECTED]>

[issue3610] Fix gdbinit for Python 3.0

2008-08-19 Thread STINNER Victor
New submission from STINNER Victor <[EMAIL PROTECTED]>: I'm trying to track down a bug in Python 3.0 (or my program?). I fixed some functions of gdbinit: - pystack and pylocals: use the new function py_printstr - lineno: call CPython "PyCode_Addr2Line" instead of ugly gdb reimplementation Ne

[issue3609] does parse_header really belong in CGI module?

2008-08-19 Thread Bill Janssen
New submission from Bill Janssen <[EMAIL PROTECTED]>: Not sure how to class this, but shouldn't the "parse_header" function in cgi really be in email.header? And what about parse_multipart? -- components: Library (Lib) messages: 71500 nosy: janssen priority: normal severity: normal stat

[issue3318] Documentation: timeit: "lower bound" should read "upper bound"

2008-08-19 Thread unutbu
unutbu <[EMAIL PROTECTED]> added the comment: Dear Georg, Would you please reconsider this issue (http://bugs.python.org/issue3318) for a moment? The term "lower bound" as it is used in the timeit documentation is either misleading or mathematically incorrect. A lower bound is a number wh

[issue3608] memoryview constructor has no deallocator

2008-08-19 Thread Benjamin Peterson
Changes by Benjamin Peterson <[EMAIL PROTECTED]>: -- assignee: -> teoliphant nosy: +pitrou, teoliphant ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue3608] memoryview constructor has no deallocator

2008-08-19 Thread Roger Upole
Roger Upole <[EMAIL PROTECTED]> added the comment: Well it existed up until a couple hours ago ;). Looks like it was recently changed to PyMemoryView_FromBuffer. However, it still has the same issue. ___ Python tracker <[EMAIL PROTECTED]>

[issue3402] test_nis is hanging on Solaris

2008-08-19 Thread Benjamin Peterson
Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Ok. I've disabled it in r65888. -- priority: release blocker -> critical ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue3608] memoryview constructor has no deallocator

2008-08-19 Thread Benjamin Peterson
Benjamin Peterson <[EMAIL PROTECTED]> added the comment: PyMemoryView_FromMemory doesn't exist. Do you mean PyMemoryView_FromBuffer or PyMemoryView_FromObject? -- nosy: +benjamin.peterson ___ Python tracker <[EMAIL PROTECTED]>

[issue3608] memoryview constructor has no deallocator

2008-08-19 Thread Roger Upole
New submission from Roger Upole <[EMAIL PROTECTED]>: When using PyMemoryView_FromMemory to create a new object, you have to pass in a preallocated buffer. However, there's no way to specify a routine to free the memory, and it leaks when the object is destroyed. -- components: Interpret

[issue3606] 2to3: commands varible replaced by subprocess

2008-08-19 Thread Collin Winter
Collin Winter <[EMAIL PROTECTED]> added the comment: Victor: that's a common problem in most fixers. The analysis needed to statically determine whether a given identifier is a module or not is expensive and heuristic. One of our Summer of Code students has been working on adding a new feature t

[issue2394] [Py3k] Finish the memoryview object implementation

2008-08-19 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Committed in r65886 after review from Benjamin and some small fixes. I'm downgrading this to critical for the remains of the memoryview API (support for more format types, multi-dimensional objects...). Perhaps those remainings will have to w

[issue3607] test_multiprocessing failure (Unserializable message)

2008-08-19 Thread Antoine Pitrou
New submission from Antoine Pitrou <[EMAIL PROTECTED]>: I have the following deterministic failure on py3k: test test_multiprocessing failed -- Traceback (most recent call last): File "/home/antoine/py3k/__svn__/Lib/test/test_multiprocessing.py", line 932, in test_dict self.assertEqual(sor

[issue3606] 2to3: commands varible replaced by subprocess

2008-08-19 Thread Benjamin Peterson
Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Yes, this is because some of the commands module's functions have moved to subprocess in py3k. This is probably a won't fix. -- nosy: +benjamin.peterson ___ Python tracker <[EMAIL PROTECTED]>

[issue3606] 2to3: commands varible replaced by subprocess

2008-08-19 Thread STINNER Victor
New submission from STINNER Victor <[EMAIL PROTECTED]>: I tried 2to3 on my python-ptrace project and with minor changes, it works fine. One of the minor changes is to replace subprocess.split(";") by commands.split(";"). The original code was: commands = command ok = True for command

[issue3605] Py_FatalError causes infinite loop

2008-08-19 Thread Daniel Diniz
Changes by Daniel Diniz <[EMAIL PROTECTED]>: -- nosy: +ajaksu2 ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list mailing l

[issue3605] Py_FatalError causes infinite loop

2008-08-19 Thread Roger Upole
Roger Upole <[EMAIL PROTECTED]> added the comment: Well, you asked for a simple case. In practice, I'm dealing with much more complicated code that contains callbacks which may need to acquire or release the theadlock. This problem makes it very difficult to debug such code. Also, the PyErr_O

[issue3605] Py_FatalError causes infinite loop

2008-08-19 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: > Roger Upole <[EMAIL PROTECTED]> added the comment: > > Py_BEGIN_ALLOW_THREADS > PyErr_SetString(PyExc_SystemError, "bork bork bork"); > Py_END_ALLOW_THREADS Well, if you start using all kinds of internal APIs without holding th

[issue3605] Py_FatalError causes infinite loop

2008-08-19 Thread Roger Upole
Roger Upole <[EMAIL PROTECTED]> added the comment: Py_BEGIN_ALLOW_THREADS PyErr_SetString(PyExc_SystemError, "bork bork bork"); Py_END_ALLOW_THREADS ___ Python tracker <[EMAIL PROTECTED]> _

[issue3473] In function call, keyword arguments could follow *args

2008-08-19 Thread Benjamin Peterson
Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Now test_compiler is breaking for us because the compiler package can't handle the change. ___ Python tracker <[EMAIL PROTECTED]> __

[issue3605] Py_FatalError causes infinite loop

2008-08-19 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Do you have a simple code sample to showcase that? -- nosy: +pitrou ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue1878] class attribute cache failure (regression)

2008-08-19 Thread Guido van Rossum
Guido van Rossum <[EMAIL PROTECTED]> added the comment: Sure, go right ahead. ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list mai

[issue1179] [CVE-2007-4965] Integer overflow in imageop module

2008-08-19 Thread Guido van Rossum
Guido van Rossum <[EMAIL PROTECTED]> added the comment: Latest patches applied to 2.5 branch: r65878. And to 2.6 trunk: r65880. -- resolution: -> accepted status: open -> closed ___ Python tracker <[EMAIL PROTECTED]>

[issue3453] PyType_Ready doesn't ensure that all bases are ready

2008-08-19 Thread Roger Upole
Roger Upole <[EMAIL PROTECTED]> added the comment: This doesn't address the discrepancy between tp_base and tp_bases. If multiple bases are used, it's no longer 'good practice', it's an absolute requirement. IMO, it should call PyType_Ready for all bases, or none of them. Since the code assume

[issue3473] In function call, keyword arguments could follow *args

2008-08-19 Thread Benjamin Peterson
Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Done for py3k in r65877. ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list

[issue3139] bytearrays are not thread safe

2008-08-19 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Le samedi 16 août 2008 à 05:50 +, Ismail Donmez a écrit : > This seems to break test_unicode on MacOSX 10.5.4, > > test_unicode > python(80320,0xa0659fa0) malloc: *** mmap(size=2147483648) failed (error > code=12) > *** error: can't allo

[issue1878] class attribute cache failure (regression)

2008-08-19 Thread Benjamin Peterson
Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Do we want a test? ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list maili

[issue3605] Py_FatalError causes infinite loop

2008-08-19 Thread Roger Upole
New submission from Roger Upole <[EMAIL PROTECTED]>: Py_FatalError calls PyErr_Occurred() which requires a current thread state. This mean that if the original error was a thread state error Py_FatalError is triggered again, ad infinitum. -- components: Interpreter Core messages: 71478

[issue1179] [CVE-2007-4965] Integer overflow in imageop module

2008-08-19 Thread Guido van Rossum
Guido van Rossum <[EMAIL PROTECTED]> added the comment: Looking into this now. ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list ma

[issue1878] class attribute cache failure (regression)

2008-08-19 Thread Guido van Rossum
Guido van Rossum <[EMAIL PROTECTED]> added the comment: Submitted as r65874. I will block this for 3.0; 3.0 extensions that want to mess with tp_dict must explicitly disable this flag. -- resolution: -> fixed status: open -> closed ___ Python tracke

[issue2629] _Py_ForgetReference crash when called from _PyUnicode_New on MemoryError

2008-08-19 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: Verified fixed. Python 2.6b2+ (trunk:65871, Aug 19 2008, 13:10:07) >>> msg = 'A'*2000111222 [12389 refs] >>> x = msg.decode('utf8') Traceback (most recent call last): File "", line 1, in File "/usr/local/google/home/gps/python/trunk/Li

[issue815646] thread unsafe file objects cause crash

2008-08-19 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: The fix can not be committed to Python 2.5 because it breaks compatibility by adding another field to the PyFileObject struct and adding two new C API functions. ___ Python tracker <[EMAIL PROTECTED]>

[issue3473] In function call, keyword arguments could follow *args

2008-08-19 Thread Benjamin Peterson
Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Applied for 2.6 in r65872. -- status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue3604] broken link in curses module docs

2008-08-19 Thread Matt Beaumont-Gay
New submission from Matt Beaumont-Gay <[EMAIL PROTECTED]>: The link to the "Curses Programming with Python" page on the curses module doc page (http://www.python.org/doc/lib/module-curses.html) is broken; the correct link is apparently 'http://docs.python.org/dev/howto/curses.html'. -- a

[issue3473] In function call, keyword arguments could follow *args

2008-08-19 Thread Barry A. Warsaw
Barry A. Warsaw <[EMAIL PROTECTED]> added the comment: Guido's approved it, so please go ahead and add it before beta 3. -- resolution: -> accepted ___ Python tracker <[EMAIL PROTECTED]>

[issue3603] trivial typo in Include/pymath.h

2008-08-19 Thread Benjamin Peterson
Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Thanks! Fixed in r65869. -- nosy: +benjamin.peterson resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> __

[issue2394] [Py3k] Finish the memoryview object implementation

2008-08-19 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Please review at http://codereview.appspot.com/3004 ___ Python tracker <[EMAIL PROTECTED]> ___

[issue1878] class attribute cache failure (regression)

2008-08-19 Thread Guido van Rossum
Guido van Rossum <[EMAIL PROTECTED]> added the comment: Please review the patch here: http://codereview.appspot.com/3005 ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue2394] [Py3k] Finish the memoryview object implementation

2008-08-19 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: This patch changes all bytearray results (in indexing, tobytes()) to bytes, and adds the implementation the tolist(). Note: the tolist() implementation only handles one-dimensional byte buffers. It will have to be re-written using the struct

[issue1878] class attribute cache failure (regression)

2008-08-19 Thread Guido van Rossum
Guido van Rossum <[EMAIL PROTECTED]> added the comment: I like Armin's latest proposal: have Py_TPFLAGS_DEFAULT include Py_TPFLAGS_HAVE_VERSION_TAG when compiling the core only. ISTR there's a way to do this, but I can't find it right now. ___ Python tracker

[issue3603] trivial typo in Include/pymath.h

2008-08-19 Thread Santiago Gala
New submission from Santiago Gala <[EMAIL PROTECTED]>: file Include/pymath.h has the typo s/doube/double/, hidden by the fact that any sane OS defines copysign: diff --git a/Include/pymath.h b/Include/pymath.h index a3735c2..7cea9ae 100644 --- a/Include/pymath.h +++ b/Include/pymath.h @@ -19,7

[issue3352] Deficiencies in multiprocessing/threading API

2008-08-19 Thread Jesse Noller
Jesse Noller <[EMAIL PROTECTED]> added the comment: committed the v3 patch as-is in r65864 - moving from release blocker to deferred blocker pending the Docs cleanup, and outstanding debate points. -- priority: release blocker -> deferred blocker ___

[issue3352] Deficiencies in multiprocessing/threading API

2008-08-19 Thread Jesse Noller
Jesse Noller <[EMAIL PROTECTED]> added the comment: And here is v3 - I fixed all of the Docs/include/mp* scripts to reflect the new API Added file: http://bugs.python.org/file11165/mp_api_cleanup-v3.patch ___ Python tracker <[EMAIL PROTECTED]>

[issue3352] Deficiencies in multiprocessing/threading API

2008-08-19 Thread Jesse Noller
Jesse Noller <[EMAIL PROTECTED]> added the comment: I attached the wrong patch, here is v2 Added file: http://bugs.python.org/file11164/mp_api_cleanup.patch ___ Python tracker <[EMAIL PROTECTED]>

[issue3352] Deficiencies in multiprocessing/threading API

2008-08-19 Thread Jesse Noller
Changes by Jesse Noller <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file11163/mp_nohang_jnoller.patch ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue3352] Deficiencies in multiprocessing/threading API

2008-08-19 Thread Jesse Noller
Changes by Jesse Noller <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file11160/mp_api_cleanup.patch ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3352] Deficiencies in multiprocessing/threading API

2008-08-19 Thread Jesse Noller
Jesse Noller <[EMAIL PROTECTED]> added the comment: Here is a cleaned up patch (ben was right, I typo'ed a few spots) - I did not clean up the docs from the original patch except to correct the x.x(Foo) accidents. Added file: http://bugs.python.org/file11163/mp_nohang_jnoller.patch __

[issue3352] Deficiencies in multiprocessing/threading API

2008-08-19 Thread Jesse Noller
Jesse Noller <[EMAIL PROTECTED]> added the comment: > > Nick Coghlan <[EMAIL PROTECTED]> added the comment: > > Note regarding those comments - only the exitcode one is something we > should try to get sorted for the beta. Backing out the deprecation > warnings and cleaning up the documentation c

[issue3602] Move test.test_suport.catch_warning() to the 'warnings' module

2008-08-19 Thread Brett Cannon
New submission from Brett Cannon <[EMAIL PROTECTED]>: Since most UNIX distros don't ship Python's test directory, test.test_support.catch_warning() needs to be moved to the 'warnings' directory so it can be used to suppress warnings in modules outside the 'test' package. The default for 'record'

[issue2834] re.IGNORECASE not Unicode-ready

2008-08-19 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Fixed in r65860. Someone should check the docs though (at least try to generate them, and review my changes a bit since English isn't my mother tongue). -- resolution: accepted -> fixed status: open -> closed

[issue3560] redundant "base" field in memoryview objects

2008-08-19 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Well, the PEP needs some love generally speaking; many things are un- or under-specified (and I don't understand better than anyone else). As for docs, there aren't any ("grep -ri memoryview Doc/" yields only the two lines referencing the "mem

[issue2619] Document PEP 3118

2008-08-19 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: As a reminder, I want to mention that PEP 3118 itself needs to be updated (see #3560). -- nosy: +pitrou ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3352] Deficiencies in multiprocessing/threading API

2008-08-19 Thread Jesse Noller
Jesse Noller <[EMAIL PROTECTED]> added the comment: > > Nick Coghlan <[EMAIL PROTECTED]> added the comment: > > Note regarding those comments - only the exitcode one is something we > should try to get sorted for the beta. Backing out the deprecation > warnings and cleaning up the documentation c

[issue3265] Python-2.5.2/Modules/_ctypes/malloc_closure.c:70: error: `MAP_ANONYMOUS' undeclared

2008-08-19 Thread Thomas Heller
Changes by Thomas Heller <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file11161/malloc_closure.patch ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue3265] Python-2.5.2/Modules/_ctypes/malloc_closure.c:70: error: `MAP_ANONYMOUS' undeclared

2008-08-19 Thread Thomas Heller
Thomas Heller <[EMAIL PROTECTED]> added the comment: Corrected the patch. Added file: http://bugs.python.org/file11162/malloc_closure.patch ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue3265] Python-2.5.2/Modules/_ctypes/malloc_closure.c:70: error: `MAP_ANONYMOUS' undeclared

2008-08-19 Thread Thomas Heller
Thomas Heller <[EMAIL PROTECTED]> added the comment: Here is a patch for Modules/_ctypes/malloc_closure.c that may work (totally untested). The code snippet is copied from Modules/mmapmodule.c. -- keywords: +patch Added file: http://bugs.python.org/file11161/malloc_closure.patch __

[issue3554] ctypes.wstring_at and string_at call Python API without the GIL

2008-08-19 Thread Thomas Heller
Thomas Heller <[EMAIL PROTECTED]> added the comment: This is fixed now in SVN, in trunk, branches/py3k, and branches/release25-maint. Thanks again. -- resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]>

[issue3560] redundant "base" field in memoryview objects

2008-08-19 Thread Guido van Rossum
Guido van Rossum <[EMAIL PROTECTED]> added the comment: On 2008/08/19 17:18:45, GvR wrote: > PS. The PEP probably needs an update. And the docs. And Misc/NEWS http://codereview.appspot.com/3003 ___ Python tracker <[EMAIL PROTECTED]>

[issue3560] redundant "base" field in memoryview objects

2008-08-19 Thread Guido van Rossum
Guido van Rossum <[EMAIL PROTECTED]> added the comment: PS. The PEP probably needs an update. And the docs. http://codereview.appspot.com/3003 ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue3560] redundant "base" field in memoryview objects

2008-08-19 Thread Guido van Rossum
Guido van Rossum <[EMAIL PROTECTED]> added the comment: Reviewers: GvR, Message: Looks good. Go ahead and submit, assuming you've run full tests. Description: http://bugs.python.org/issue3560 Please review this at http://codereview.appspot.com/3003 Affected files: Include/memoryobject.h

[issue3600] Include Tcl/Tk 8.5.4 in the windows binary for the upcoming beta3

2008-08-19 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: or not ? the indentation in this tkFileFilter.c is fooling me, the Tcl_ListObjGetElements call is done in another block which is outside that check, so the compiler seems to be right after all. It would be good to report this problem at tk's b

[issue1342811] Tkinter.Menu.delete doesn't delete command of entry

2008-08-19 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: If this needs approval of someone else, and such thing doesn't happen in time then the earlier patch should be reverted. ___ Python tracker <[EMAIL PROTECTED]>

[issue1342811] Tkinter.Menu.delete doesn't delete command of entry

2008-08-19 Thread Robert Schuppenies
Robert Schuppenies <[EMAIL PROTECTED]> added the comment: I was thinking about returning in that new if statement, too, but decided not too. The reason is that I didn't want to anticipate _tkinter implementations, which may change (although not likely, still possible). Also, with the third beta

[issue3600] Include Tcl/Tk 8.5.4 in the windows binary for the upcoming beta3

2008-08-19 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: I don't know what this Microsoft compiler is doing but both ostypeCount and ostypeList are properly set at Tcl_ListObjGetElements, and if that call fails it skips to the bottom of this function you looked at. _

[issue3352] Deficiencies in multiprocessing/threading API

2008-08-19 Thread Benjamin Peterson
Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Barry said that is_alive should remain a method following in Guido's footsteps. ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue1589] New SSL module doesn't seem to verify hostname against commonName in certificate

2008-08-19 Thread Bill Janssen
Bill Janssen <[EMAIL PROTECTED]> added the comment: Nope. Hostname verification was never a good idea -- the "hostname" is just a vague notion, at best -- lots of hostnames can map to one or more IP addresses of the server. It's exposed to the application code, so if a client application wants

[issue2629] _Py_ForgetReference crash when called from _PyUnicode_New on MemoryError

2008-08-19 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: This should has been fixed by Amaury as part of another patch (the one which is tested for in test_raiseMemError). Could you try again? -- nosy: +pitrou ___ Python tracker <[EMAIL PROTECTED]>

[issue3600] Include Tcl/Tk 8.5.4 in the windows binary for the upcoming beta3

2008-08-19 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: Also, I was bitten by a runtime error because of an uninitialized variable. It seems that the Microsoft compiler is able to detect uninitialized values, in debug mode this causes a dialog to appear and IDLE crashes when opening the "Save

[issue3046] Locking should be removed from the new buffer protocol

2008-08-19 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: It seems to me that the patch has been applied. Can this be closed? -- nosy: +pitrou ___ Python tracker <[EMAIL PROTECTED]> __

[issue3352] Deficiencies in multiprocessing/threading API

2008-08-19 Thread Nick Coghlan
Nick Coghlan <[EMAIL PROTECTED]> added the comment: Note regarding those comments - only the exitcode one is something we should try to get sorted for the beta. Backing out the deprecation warnings and cleaning up the documentation can wait for the first release candidate. __

[issue3131] 2to3 can't find fixes_dir

2008-08-19 Thread Benjamin Peterson
Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Fixed in r65853. Hopefully we can do the real refactoring fix after the betas. -- resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]>

[issue3352] Deficiencies in multiprocessing/threading API

2008-08-19 Thread Nick Coghlan
Nick Coghlan <[EMAIL PROTECTED]> added the comment: Just saw a couple of docs checkins go by suggesting that the camelCase names will be unavailable in 3.x. Remember that the intent *isn't* to remove the old names from threading.py - we're just adding the PEP 8 names so that multiprocessing can h

[issue3601] test_unicode.test_raiseMemError fails in UCS4

2008-08-19 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: (the fix is probably trivial, it involves dividing sys.maxsize by the number of bytes of an unicode character, something like: width = sys.getsizeof("a") - sys.getsizeof("") alloc = lambda: u"a" * (sys.maxsize // width) self.asser

[issue3352] Deficiencies in multiprocessing/threading API

2008-08-19 Thread Benjamin Peterson
Benjamin Peterson <[EMAIL PROTECTED]> added the comment: The patch looks pretty good. In a few places, you replaced x.set_x(True) with x.x(True). The docs also will need a few tweaks. Otherwise, if the tests pass, I say go ahead. ___ Python tracker <[EMAIL PRO

[issue3601] test_unicode.test_raiseMemError fails in UCS4

2008-08-19 Thread Benjamin Peterson
Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Oh. Sorry, I didn't mean to assign it to you anyway. -- assignee: pitrou -> ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue3601] test_unicode.test_raiseMemError fails in UCS4

2008-08-19 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Ok, please disable the test for now, I have more important things to do for the beta :) -- components: +Tests priority: critical -> high type: -> behavior versions: +Python 2.6, Python 3.0 ___ Pyt

[issue3352] Deficiencies in multiprocessing/threading API

2008-08-19 Thread Jesse Noller
Jesse Noller <[EMAIL PROTECTED]> added the comment: Nick/Ben - here's a rough draft patch for the attribute changes for mp - could you both take a look and let me know what you think? -- keywords: +patch Added file: http://bugs.python.org/file11160/mp_api_cleanup.patch

[issue3352] Deficiencies in multiprocessing/threading API

2008-08-19 Thread Nick Coghlan
Nick Coghlan <[EMAIL PROTECTED]> added the comment: My preference actually isn't particularly strong either way, so I suggest asking Barry for a casting vote. ___ Python tracker <[EMAIL PROTECTED]> ___

[issue2394] [Py3k] Finish the memoryview object implementation

2008-08-19 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Adding some comparison tests. Added file: http://bugs.python.org/file11159/mem5.patch ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue3601] test_unicode.test_raiseMemError fails in UCS4

2008-08-19 Thread Benjamin Peterson
New submission from Benjamin Peterson <[EMAIL PROTECTED]>: == ERROR: test_raiseMemError (test.test_unicode.UnicodeTest) -- Traceback (most recent call last): F

[issue2394] [Py3k] Finish the memoryview object implementation

2008-08-19 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Here is a patch to support comparisons of memoryview objects with other objects offering the buffer interface. Two objects are equal if their buffers have the same characteristics and compare equal bytewise. It also improves the test in test_c

[issue3600] Include Tcl/Tk 8.5.4 in the windows binary for the upcoming beta3

2008-08-19 Thread Guilherme Polo
New submission from Guilherme Polo <[EMAIL PROTECTED]>: May I suggest the inclusion of Tcl/Tk 8.5.4 in the windows binary for the upcoming beta3 ? beta2 included 8.5.3, but now the 8.5.4 bugfix release arrived. -- components: Windows messages: 71427 nosy: gpolo severity: normal status: o

[issue3352] Deficiencies in multiprocessing/threading API

2008-08-19 Thread Jesse Noller
Jesse Noller <[EMAIL PROTECTED]> added the comment: On Tue, Aug 19, 2008 at 11:34 AM, Nick Coghlan <[EMAIL PROTECTED]> wrote: > > Nick Coghlan <[EMAIL PROTECTED]> added the comment: > > is_alive appears to be a potentially expensive check for the > multiprocessing side of things, which is why I'm

[issue3352] Deficiencies in multiprocessing/threading API

2008-08-19 Thread Benjamin Peterson
Benjamin Peterson <[EMAIL PROTECTED]> added the comment: On Tue, Aug 19, 2008 at 10:34 AM, Nick Coghlan <[EMAIL PROTECTED]> wrote: > > Nick Coghlan <[EMAIL PROTECTED]> added the comment: > > is_alive appears to be a potentially expensive check for the > multiprocessing side of things, which is wh

[issue3352] Deficiencies in multiprocessing/threading API

2008-08-19 Thread Nick Coghlan
Nick Coghlan <[EMAIL PROTECTED]> added the comment: is_alive appears to be a potentially expensive check for the multiprocessing side of things, which is why I'm inclined to leave it as a method. "if t.is_alive():" actually reads better to me than "if t.alive:" anyway. __

[issue2394] [Py3k] Finish the memoryview object implementation

2008-08-19 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: This patch fixes a crash in the codecs module. However, memoryview should also support comparisons (just == and !=) with bytes/bytearray objects (or any buffer-enabled objects), otherwise utf-8-sig produces wrong values (and there are no tests

[issue3599] test_pydoc after test_urllib2 causes exception in Popen.__del__

2008-08-19 Thread Benjamin Peterson
New submission from Benjamin Peterson <[EMAIL PROTECTED]>: ./python.exe Lib/test/regrtest.py -uall -f ../trunk/tests.txt test_urllib2 test_pydoc All 2 tests OK. Exception TypeError: TypeError("'NoneType' object is not callable",) in > ignored -- components: Tests messages: 71422 nosy: be

  1   2   >