[issue12022] AttributeError should report the same details when raised by lookup_special() as when raised in the REPL

2011-05-07 Thread Daniel Urban
Changes by Daniel Urban : -- nosy: +durban ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue11375] urllib2 over SOCKS doesn't use proxy for DNS

2011-05-07 Thread torstenb
Changes by torstenb : -- nosy: +torstenb ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org

[issue11164] xml shouldn't use _xmlplus

2011-05-07 Thread Georg Brandl
Georg Brandl added the comment: In MinidomTest.tearDown, the majority of the code seems to be for the stdlib version, yet you remove the whole method. Can you elaborate? -- ___ Python tracker

[issue11347] libpython3.so: Broken soname and linking

2011-05-07 Thread Georg Brandl
Changes by Georg Brandl : -- priority: normal -> release blocker ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue11347] libpython3.so: Broken soname and linking

2011-05-07 Thread Georg Brandl
Georg Brandl added the comment: Martin? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue11910] test_heapq C tests are not skipped when _heapq is missing

2011-05-07 Thread Raymond Hettinger
Raymond Hettinger added the comment: Attaching a rough draft of a way to simplify dual path testing. The idea is that the suite shouldn't have to be rewritten with self.module.heapify(...) references throughout. Instead, tests are written normally and the only thing that changes in the cont

[issue11164] xml shouldn't use _xmlplus

2011-05-07 Thread Ned Deily
Changes by Ned Deily : -- nosy: +georg.brandl ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue11164] xml shouldn't use _xmlplus

2011-05-07 Thread Arfrever Frehtes Taifersar Arahesis
Arfrever Frehtes Taifersar Arahesis added the comment: I'm attaching the patch, which fixes this issue. It would be nice if the patch was applied before releases of Python 3.1.4 and 3.2.1. -- keywords: +patch Added file: http://bugs.python.org/file21931/python-3-remove_pyxml_support.pa

[issue8407] expose signalfd(2) and pthread_sigmask in the signal module

2011-05-07 Thread STINNER Victor
STINNER Victor added the comment: Update the signalfd patch (version 4) against the default branch. Specify the minimum Linux version in signalfd() doc. The patch still lacks a structure to parse the bytes written into the file (see msg135438 for a ctypes example): a struct sequence should be

[issue9971] Optimize BufferedReader.readinto

2011-05-07 Thread John O'Connor
Changes by John O'Connor : Removed file: http://bugs.python.org/file21900/buffered_readinto2.patch ___ Python tracker ___ ___ Python-bugs-list

[issue9971] Optimize BufferedReader.readinto

2011-05-07 Thread John O'Connor
Changes by John O'Connor : Removed file: http://bugs.python.org/file21899/buffered_readinto.patch ___ Python tracker ___ ___ Python-bugs-list m

[issue9205] Parent process hanging in multiprocessing if children terminate unexpectedly

2011-05-07 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Hum, I get a strange skip on a XP buildbot: > > [224/354] test_multiprocessing > test_multiprocessing skipped -- DLL load failed: The specified > procedure could not be found. > > Yet _multiprocessing was compiled fine... Does anyone know what it > means? O

[issue8407] expose signalfd(2) and pthread_sigmask in the signal module

2011-05-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset e3cb2c99a5a9 by Victor Stinner in branch 'default': Issue #8407: Remove debug code from test_signal http://hg.python.org/cpython/rev/e3cb2c99a5a9 -- ___ Python tracker

[issue8407] expose signalfd(2) and pthread_sigmask in the signal module

2011-05-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset f8c49a930015 by Victor Stinner in branch 'default': Issue #8407: The signal handler writes the signal number as a single byte http://hg.python.org/cpython/rev/f8c49a930015 -- ___ Python tracker

[issue9971] Optimize BufferedReader.readinto

2011-05-07 Thread John O'Connor
John O'Connor added the comment: FWIW, It seems Java does something similar. They write directly into caller's buffer if outstanding bytes needed (after emptying internal buffer) is greater than internal buffer len. -- ___ Python tracker

[issue8407] expose signalfd(2) and pthread_sigmask in the signal module

2011-05-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1d8a57deddc4 by Victor Stinner in branch 'default': Issue #8407: Add pthread_kill(), sigpending() and sigwait() functions to the http://hg.python.org/cpython/rev/1d8a57deddc4 -- ___ Python tracker

[issue12013] file /usr/local/lib/python3.1/lib-dynload/_socket.so: symbol inet_aton: referenced symbol not found

2011-05-07 Thread Alex Lai
Alex Lai added the comment: The test fialed on my workstation while successul on another server. Both server has the same Pyton installation but different libc and libm version. I plan to reinstall the OS(solaris 10 pre-release) on my workstation next week and see how it goes. Regards, Alex

[issue11910] test_heapq C tests are not skipped when _heapq is missing

2011-05-07 Thread Ezio Melotti
Ezio Melotti added the comment: Thanks (for the record the changeset is a8b82c283524). > Overall, I don't think the current approach to testing both paths > is elegant. That's the most elegant way we have now. If all the Python tests pass for the C version too, a base class could be avoided a

[issue11347] libpython3.so: Broken soname and linking

2011-05-07 Thread Arfrever Frehtes Taifersar Arahesis
Arfrever Frehtes Taifersar Arahesis added the comment: I'm attaching improved patch, which adds detection of -Wl,--no-as-needed flag. This issue should be release blocker for Python 3.2.1. -- Added file: http://bugs.python.org/file21929/libpython3.so.patch

[issue9971] Optimize BufferedReader.readinto

2011-05-07 Thread John O'Connor
John O'Connor added the comment: It seems to me that the point of using readinto() is to avoid double-buffering (and the extra alloc/free that comes with read()). The slowness of using a small buffer size seems like only a natural and expected consequence. The trade-off of accommodating a sm

[issue11910] test_heapq C tests are not skipped when _heapq is missing

2011-05-07 Thread Raymond Hettinger
Raymond Hettinger added the comment: I'm imagining a cleaner testing style, like this: class TestHeap(unittest.TestCase): def test_nsmallest(self): self.assertEqual(heapq.nsmallest(3, range(10)), [0,1,2]) ... @test_support.requires('_heapq') def test_comparison_ope

[issue11347] libpython3.so: Broken soname and linking

2011-05-07 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis : Removed file: http://bugs.python.org/file20939/libpython3.so.patch ___ Python tracker ___ ___

[issue11910] test_heapq C tests are not skipped when _heapq is missing

2011-05-07 Thread Raymond Hettinger
Raymond Hettinger added the comment: Some of the tests were incorrectly marked as being C specific. I've fixed that on the 2.7 branch. Re-assigning back to Ezio. Overall, I don't think the current approach to testing both paths is elegant. Is there some alternative approach to running suit

[issue9205] Parent process hanging in multiprocessing if children terminate unexpectedly

2011-05-07 Thread Antoine Pitrou
Antoine Pitrou added the comment: Hum, I get a strange skip on a XP buildbot: [224/354] test_multiprocessing test_multiprocessing skipped -- DLL load failed: The specified procedure could not be found. Yet _multiprocessing was compiled fine... Does anyone know what it means? http://www.pytho

[issue12012] _ssl module doesn't compile with OpenSSL 1.0.0d: SSLv2_method is missing

2011-05-07 Thread Peter Eisentraut
Changes by Peter Eisentraut : -- nosy: +petere ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue12027] Optimize import this (patch to make it 10x faster)

2011-05-07 Thread Raymond Hettinger
Raymond Hettinger added the comment: Move on, nothing to see here ;-) -- resolution: -> rejected status: open -> closed ___ Python tracker ___ _

[issue10666] OS X installer variants have confusing readline differences

2011-05-07 Thread Ned Deily
Ned Deily added the comment: ́Éric, was your comment in msg135467 intended for another issue? -- ___ Python tracker ___ ___ Python-bu

[issue8407] expose signalfd(2) and pthread_sigmask in the signal module

2011-05-07 Thread Antoine Pitrou
Antoine Pitrou added the comment: > pending_signals-3.patch: > - don't check for pending signals in sigwait() > - pthread_kill() doc: it is not a good idea to say that pthread_kill() with > signum=0 can be used to check if a thread identifier is valid => such test > does crash (SIGSEGV) on m

[issue12027] Optimize import this (patch to make it 10x faster)

2011-05-07 Thread STINNER Victor
STINNER Victor added the comment: @Raymond: What do you think? Do you prefer simple or faster code? I think that the speed of "import this" do matter! -- ___ Python tracker ___

[issue11910] test_heapq C tests are not skipped when _heapq is missing

2011-05-07 Thread Ezio Melotti
Ezio Melotti added the comment: If they are not C specific they should be moved to the base class (TestHeap). TestHeapC and TestHeapPython should contain only tests specific to the C and Python versions respectively. The goal here is to make sure that they are run once with the Python versio

[issue11927] SMTP_SSL doesn't use port 465 by default

2011-05-07 Thread Antoine Pitrou
Antoine Pitrou added the comment: The patch was committed in dev and maintenance branches. Thank you! -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker ___

[issue11927] SMTP_SSL doesn't use port 465 by default

2011-05-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset bcf04ced5ef1 by Antoine Pitrou in branch '2.7': Issue #11927: SMTP_SSL now uses port 465 by default as documented. Patch by Kasun Herath. http://hg.python.org/cpython/rev/bcf04ced5ef1 -- ___ Python tra

[issue11668] _multiprocessing.Connection.poll with timeout uses polling under Windows

2011-05-07 Thread Antoine Pitrou
Antoine Pitrou added the comment: I have a full patch using overlapped I/O in issue9205 (sentinels3.patch). -- ___ Python tracker ___ ___

[issue9205] Parent process hanging in multiprocessing if children terminate unexpectedly

2011-05-07 Thread Antoine Pitrou
Antoine Pitrou added the comment: Ok, this patch seems fully debugged (under Windows and Linux). A couple of things come in addition, such as removing repeated polling in PipeConnection.poll() and _Popen.wait(). -- Added file: http://bugs.python.org/file21928/sentinels3.patch ___

[issue11927] SMTP_SSL doesn't use port 465 by default

2011-05-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset 20e9d3e49689 by Antoine Pitrou in branch '3.1': Issue #11927: SMTP_SSL now uses port 465 by default as documented. Patch by Kasun Herath. http://hg.python.org/cpython/rev/20e9d3e49689 New changeset 209744660b92 by Antoine Pitrou in branch '3.2':

[issue12022] AttributeError should report the same details when raised by lookup_special() as when raised in the REPL

2011-05-07 Thread Daniel Holth
Daniel Holth added the comment: Thank you Benjamin for following up on this issue -- ___ Python tracker ___ ___ Python-bugs-list mail

[issue12026] Support more of MSI api by exposing handles

2011-05-07 Thread Martin v . Löwis
Martin v. Löwis added the comment: What's the purpose of the patch? I.e. what can you do when you have the handle exposed? -- ___ Python tracker ___ ___

[issue12002] ftplib.FTP.abort fails with TypeError on Python 3.x

2011-05-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset 31220cd936d2 by Giampaolo Rodola' in branch '3.1': #12002 - ftplib's abort() method raises TypeError http://hg.python.org/cpython/rev/31220cd936d2 -- nosy: +python-dev ___ Python tracker

[issue11910] test_heapq C tests are not skipped when _heapq is missing

2011-05-07 Thread Raymond Hettinger
Raymond Hettinger added the comment: Are you sure those tests are C specific? Please be careful about doing unnecessary complexification of this module's tests. -- assignee: ezio.melotti -> rhettinger nosy: +rhettinger ___ Python tracker

[issue11927] SMTP_SSL doesn't use port 465 by default

2011-05-07 Thread Kasun Herath
Kasun Herath added the comment: I'm submitting another patch which includes a test in test_smtpnet. Would appreciate further feedback. -- Added file: http://bugs.python.org/file21927/smtp_default_port_with_smtpnet_test.patch ___ Python tracker

[issue11968] wsgiref's wsgi application sample code does not work

2011-05-07 Thread Phillip J. Eby
Phillip J. Eby added the comment: Yes, the 'b' is a docs error. I previously removed this in: http://hg.python.org/cpython-fullhistory/rev/2697326d4a77 It appears to have been reverted during a merge, here: http://hg.python.org/cpython-fullhistory/rev/88d04f0143c7 My browser crashed

[issue11963] Remove human verification from test suite (test_parser and test_subprocess)

2011-05-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: My title suggestion was meant to say "Yes, if you are willing to expand the scope of this issue and do more work, go ahead' ;-). I have not looked at help(test), but it should be complete if it is not. I was referring to the test module doc 25.5. Someone decid

[issue12022] AttributeError should report the same details when raised by lookup_special() as when raised in the REPL

2011-05-07 Thread Daniel Holth
Daniel Holth added the comment: Python should explain AttributeError in the same way when it's raised by the interpreter. The with: statement below should raise the second AttributeError, not the first. import transaction with transaction: pass >>> AttributeError: __exit__ import sys sys.__e

[issue11910] test_heapq C tests are not skipped when _heapq is missing

2011-05-07 Thread Ezio Melotti
Ezio Melotti added the comment: Attempting to fix import_fresh_module might be better. -- assignee: -> ezio.melotti ___ Python tracker ___ _

[issue5421] Irritating error message by socket's sendto method

2011-05-07 Thread Ezio Melotti
Ezio Melotti added the comment: I backported the patch to 2.7 in 7c3a20b5943a, and added tests to the 3.x branches. -- nosy: +ezio.melotti ___ Python tracker ___ ___

[issue10169] socket.sendto raises incorrect exception when passed incorrect types

2011-05-07 Thread Ezio Melotti
Ezio Melotti added the comment: This turned out to be a duplicate of #5421 already fixed in 3.x, so I backported the patch and added the tests to 3.x too. -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed versions: -Python 3.1, Python 3.2

[issue11743] Rewrite PipeConnection and Connection in pure Python

2011-05-07 Thread Antoine Pitrou
Antoine Pitrou added the comment: Updated patch, fixing a sporadic failure in test_spawn_close. -- Added file: http://bugs.python.org/file21926/mpconn2.patch ___ Python tracker

[issue11882] test_imaplib failed on x86 ubuntu

2011-05-07 Thread Kasun Herath
Kasun Herath added the comment: david, I'm not much familiar with c. Still trying to figure out how to do it -- status: pending -> open ___ Python tracker ___ __

[issue5421] Irritating error message by socket's sendto method

2011-05-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9222c9d747c1 by Ezio Melotti in branch '3.1': #5421: add tests. http://hg.python.org/cpython/rev/9222c9d747c1 New changeset 4b3352b49483 by Ezio Melotti in branch '3.2': #5421: merge with 3.1. http://hg.python.org/cpython/rev/4b3352b49483 New chan

[issue10169] socket.sendto raises incorrect exception when passed incorrect types

2011-05-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7c3a20b5943a by Ezio Melotti in branch '2.7': #10169: Fix argument parsing in socket.sendto() to avoid error masking. http://hg.python.org/cpython/rev/7c3a20b5943a -- nosy: +python-dev ___ Python tracker

[issue12022] improve special method lookup error message

2011-05-07 Thread Benjamin Peterson
Changes by Benjamin Peterson : -- resolution: invalid -> status: closed -> open title: 'transaction' module-as-context-manager thwarted by Python 2.7.1 -> improve special method lookup error message ___ Python tracker

[issue12027] Optimize import this (patch to make it 10x faster)

2011-05-07 Thread Georg Brandl
Georg Brandl added the comment: (And subsequently cc10b010f40b. I agree with Benjamin.) -- nosy: +georg.brandl ___ Python tracker ___ __

[issue12027] Optimize import this (patch to make it 10x faster)

2011-05-07 Thread Benjamin Peterson
Changes by Benjamin Peterson : -- nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue12027] Optimize import this (patch to make it 10x faster)

2011-05-07 Thread Benjamin Peterson
Benjamin Peterson added the comment: I suggest rejecting. See 8ae88db7843c -- ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue12002] ftplib.FTP.abort fails with TypeError on Python 3.x

2011-05-07 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: This is a nasty one and mainly it's the reason why there are no tests for abort() method. In FTP, ABOR command is supposed to be sent as OOB (out-of-band) "urgent" data and the dummy FTP server we're using for the funcional tests must handle this appopriat

[issue9516] sysconfig: $MACOSX_DEPLOYMENT_TARGET mismatch: now "10.3" but "10.5" during configure

2011-05-07 Thread Éric Araujo
Éric Araujo added the comment: > I haven't changed the CompileError handling though, that would change > a test failure into a test error. Ah, thanks for correcting my mistake. -- ___ Python tracker ___

[issue12017] Decoding a highly-nested object with json (_speedups enabled) causes segfault

2011-05-07 Thread Ezio Melotti
Ezio Melotti added the comment: Fixed, thanks Ivan for the report and Alex for suggesting Py_EnterRecursiveCall! -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker

[issue10964] Mac installer need not add things to /usr/local

2011-05-07 Thread Éric Araujo
Changes by Éric Araujo : -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue9859] Add tests to verify API match of modules with 2 implementations

2011-05-07 Thread Éric Araujo
Changes by Éric Araujo : -- nosy: +belopolsky, brett.cannon, eric.araujo, pitrou ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue12017] Decoding a highly-nested object with json (_speedups enabled) causes segfault

2011-05-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset 6fa20e360e5e by Ezio Melotti in branch '2.7': #12017: Fix segfault in json.loads() while decoding highly-nested objects using the C accelerations. http://hg.python.org/cpython/rev/6fa20e360e5e New changeset 61164d09337e by Ezio Melotti in branch '

[issue9923] mailcap module may not work on non-POSIX platforms if MAILCAPS env variable is set

2011-05-07 Thread Éric Araujo
Éric Araujo added the comment: BTW, is there a real use case that lead you to open this report, or is it just theoretical? I’m not even sure mailcap is used on non-UNIX (and even there, I think it’s not used by recent tools). -- nosy: +eric.araujo ___

[issue9923] mailcap module may not work on non-POSIX platforms if MAILCAPS env variable is set

2011-05-07 Thread Éric Araujo
Changes by Éric Araujo : -- dependencies: +No unit test for mailcap module ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue10581] Review and document string format accepted in numeric data type constructors

2011-05-07 Thread Éric Araujo
Éric Araujo added the comment: > I may be in minority, but I find it convenient to use int(), float() > etc. for data validation. A number of libraries agree: argparse, HTML form handling libs, etc. > I may be too strict, but I don't think anyone would want to see > columns with a mix of Bengal

[issue10663] configure shouldn't set a default OPT

2011-05-07 Thread Éric Araujo
Éric Araujo added the comment: Sounds reasonable. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue10666] OS X installer variants have confusing readline differences

2011-05-07 Thread Éric Araujo
Éric Araujo added the comment: FTR, readline.read_init_file() works with libedit too (provided that the config file uses libedit-style format), so you can remove the branch from your code. -- nosy: +eric.araujo ___ Python tracker

[issue10713] re module doesn't describe string boundaries for \b

2011-05-07 Thread Ezio Melotti
Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue10713] re module doesn't describe string boundaries for \b

2011-05-07 Thread Éric Araujo
Éric Araujo added the comment: Thanks for the report. Would you be interested in experimenting and/or reading the code to find the anwser and propose a doc patch? -- keywords: +easy nosy: +eric.araujo stage: -> needs patch versions: +Python 2.7, Python 3.1, Python 3.2, Python 3.3 __

[issue11963] Remove human verification from test suite (test_parser and test_subprocess)

2011-05-07 Thread Éric Araujo
Éric Araujo added the comment: Please feel free to improve titles; we’re a team, there’s no ego in bug title phrasing :) I did so on at least one bug of yours; hope you didn’t consider it rude. Are you asking about the docstring of the test module or the reST doc of test.support? A brief m

[issue12013] file /usr/local/lib/python3.1/lib-dynload/_socket.so: symbol inet_aton: referenced symbol not found

2011-05-07 Thread Éric Araujo
Éric Araujo added the comment: $ python3.1 -m test.regrtest If your distribution removes tests from the binary package, this won’t work. -- ___ Python tracker ___ _

[issue11072] Add MLSD command support to ftplib

2011-05-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset 153bd8fc22c7 by Giampaolo Rodola' in branch 'default': #11072- applying http://bugs.python.org/review/11072/show suggestions http://hg.python.org/cpython/rev/153bd8fc22c7 -- ___ Python tracker

[issue11877] Change os.fsync() to support physical backing store syncs

2011-05-07 Thread Steffen Daode Nurpmeso
Changes by Steffen Daode Nurpmeso : Removed file: http://bugs.python.org/file21771/11877.4.diff ___ Python tracker ___ ___ Python-bugs-list ma

[issue11877] Change os.fsync() to support physical backing store syncs

2011-05-07 Thread Steffen Daode Nurpmeso
Changes by Steffen Daode Nurpmeso : Removed file: http://bugs.python.org/file21749/11877.3.diff ___ Python tracker ___ ___ Python-bugs-list ma

[issue11877] Change os.fsync() to support physical backing store syncs

2011-05-07 Thread Steffen Daode Nurpmeso
Steffen Daode Nurpmeso added the comment: 11877.5.diff incorporates all changes suggested by Charles-François except for the 'auto' keyword, which is extremely important and which would need to be invented if it would not yet exist. I'm dropping the old stuff. And i think this is the final ve

[issue9205] Parent process hanging in multiprocessing if children terminate unexpectedly

2011-05-07 Thread Antoine Pitrou
Antoine Pitrou added the comment: Here is an updated patch. Much of it consists of changes in the Windows Connection implementation, where I had to use overlapped I/O in order to use WaitForMultipleObjects on named pipes. test_concurrent_futures sometimes blocks (under Windows), I'll try to d

[issue11969] Can't launch multiproccessing.Process on methods

2011-05-07 Thread Jesse Noller
Jesse Noller added the comment: Do things like this in the REPL are known not to work. Things are not protected in the if __name__ block so we can import the script properly to run it. -- ___ Python tracker _

[issue11999] sporadic failure in test_mailbox

2011-05-07 Thread Steffen Daode Nurpmeso
Steffen Daode Nurpmeso added the comment: This tracker - sorry! (I surely will try to write and offer a patch for the tracker, but first i need to understand that mailbox.py jungle for #11935, next week.) -- title: sporadic failure in test_mailbox on FreeBSD -> sporadic failure in test

[issue11877] Change os.fsync() to support physical backing store syncs

2011-05-07 Thread Steffen Daode Nurpmeso
Steffen Daode Nurpmeso added the comment: On Sat, 7 May 2011 14:20:51 +0200, Charles-François Natali wrote: > # ifdef __APPLE__ > res = fcntl(fd, F_FULLFSYNC); > # endif > # ifdef __NetBSD__ > res = fsync_range(fd, FFILESYNC|FDISKSYNC, 0, 0); > # endif > > Since __APPLE__ and __NetBSD_

[issue11877] Change os.fsync() to support physical backing store syncs

2011-05-07 Thread Steffen Daode Nurpmeso
Steffen Daode Nurpmeso added the comment: On Sat, 7 May 2011 14:20:51 +0200, Charles-François Natali wrote: > I really can't see a good reason for using it here (and > anywhere, see http://c-faq.com/decl/auto.html). You're right. > Why are you using the "auto" storage class specifier? I know

[issue12027] Optimize import this (patch to make it 10x faster)

2011-05-07 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: That's a good one, but um, no not for 2.6, unless you can argue that a delay in obtaining the received wisdom of The Timbot is a serious security hole in Python. Bag of ham. -- ___ Python tracker

[issue11277] Crash with mmap and sparse files on Mac OS X

2011-05-07 Thread Nadeem Vawda
Nadeem Vawda added the comment: sdaoden> @Nadeem: note that the committed versions of the tests would not sdaoden> show up the Mac OS X mmap() bug AFAIK, because there is an sdaoden> intermediate .close() of the file to be mmapped. Thanks for catching that. Should be fixed now. haypo> I now ag

[issue11999] sporadic failure in test_mailbox on FreeBSD

2011-05-07 Thread Steffen Daode Nurpmeso
Steffen Daode Nurpmeso added the comment: That's really a good one. (In my eyes.) -- title: sporadic failure in test_mailbox -> sporadic failure in test_mailbox on FreeBSD ___ Python tracker _

[issue11877] Change os.fsync() to support physical backing store syncs

2011-05-07 Thread Charles-François Natali
Charles-François Natali added the comment: > I'll attach 11877.4.diff A couple comments: static PyObject * posix_fsync(PyObject *self, PyObject *args, PyObject *kwargs) { PyObject *retval = NULL; auto PyObject *fdobj; auto int full_fsync = 1; Why are you using the "auto" storage c

[issue11277] Crash with mmap and sparse files on Mac OS X

2011-05-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9b9f0de19684 by Nadeem Vawda in branch '2.7': Issue #11277: Fix tests - crash will not trigger if the file is closed and reopened. http://hg.python.org/cpython/rev/9b9f0de19684 New changeset b112c72f8c01 by Nadeem Vawda in branch '3.1': Issue #112

[issue12023] non causal behavior

2011-05-07 Thread R. David Murray
R. David Murray added the comment: In 3.x, yes (the nonlocal keyword). Not in 2.7, though. -- nosy: +r.david.murray ___ Python tracker ___ _

[issue11277] Crash with mmap and sparse files on Mac OS X

2011-05-07 Thread Steffen Daode Nurpmeso
Steffen Daode Nurpmeso added the comment: (Of course this may also be intentional, say. But then i would vote against it :), because it's better the tests bring out errors than end-user apps.) -- ___ Python tracker

[issue12027] Optimize import this (patch to make it 10x faster)

2011-05-07 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: STINNER Victor wrote: > > New submission from STINNER Victor : > > Patch to optimize this: make it 10 times faster. > > Try attached benchmark script. On a debug build I got the following results: > * original: 299.8 ms > * patched: 23.2 ms > > I expec

[issue11277] Crash with mmap and sparse files on Mac OS X

2011-05-07 Thread Steffen Daode Nurpmeso
Steffen Daode Nurpmeso added the comment: @Nadeem: note that the committed versions of the tests would not show up the Mac OS X mmap() bug AFAIK, because there is an intermediate .close() of the file to be mmapped. The OS X bug is that the VMS/VFS interaction fails to provide a valid memory reg

[issue12016] Wrong behavior for '\xff\n'.decode('gb2312', 'ignore')

2011-05-07 Thread zy
zy added the comment: I do not have documents on this subject. Though, I found that GNU iconv(1) behaves the same as my proposed behavior. My reading of the source code suggests that iconv(1) treat all encodings equally, which I think should also be true for python. As of security concerns,

[issue11277] Crash with mmap and sparse files on Mac OS X

2011-05-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset 8d27d2b22394 by Nadeem Vawda in branch '2.7': Issue #11277: Add tests for mmap crash when using large sparse files on OS X. http://hg.python.org/cpython/rev/8d27d2b22394 -- ___ Python tracker

[issue11277] Crash with mmap and sparse files on Mac OS X

2011-05-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset d5d4f2967879 by Nadeem Vawda in branch '3.1': Issue #11277: Add tests for mmap crash when using large sparse files on OS X. http://hg.python.org/cpython/rev/d5d4f2967879 New changeset e447a68742e7 by Nadeem Vawda in branch '3.2': Merge: #11277: Add

[issue11994] [2.7/gcc-4.4.3] Segfault under valgrind in string.split()

2011-05-07 Thread STINNER Victor
STINNER Victor added the comment: GCC does have bugs: see a recent example with a development version of GCC 4.6 => #9880 (the bug was fixed before the final release of GCC 4.6). If you would like to go futher, you should open a bug report in GCC bug tracker (not in the Python bug tracker).

[issue12028] threading._get_ident(): remove it in the doc and make it public

2011-05-07 Thread STINNER Victor
STINNER Victor added the comment: I think that threading._get_ident() is more reliable than threading.current_thread().ident because Thread.ident can be None in some cases. -- ___ Python tracker _

[issue8407] expose signalfd(2) and pthread_sigmask in the signal module

2011-05-07 Thread STINNER Victor
STINNER Victor added the comment: The threading has a function to get directly the identifier of the current thread: threading._get_ident() instead of threading.current_thread().ident. I think that threading._get_ident() is more reliable to threading.current_thread().ident because Thread.iden

[issue12028] threading._get_ident(): remove it in the doc and make it public

2011-05-07 Thread STINNER Victor
New submission from STINNER Victor : I don't know why threading._get_ident() (which is _thread.get_ident()) is private: this function is safe. This function becomes useful with pthread_kill() which will be added by #8407. -- assignee: docs@python components: Documentation, Library (Lib

[issue8407] expose signalfd(2) and pthread_sigmask in the signal module

2011-05-07 Thread STINNER Victor
STINNER Victor added the comment: pending_signals-3.patch: doc nit, the link to Thread.ident doesn't work. The doc should be replaced by something like: *thread_id* can be read from the :attr:`~threading.Thread.ident` attribute of a :class:`threading.Thread` object. For

[issue8407] expose signalfd(2) and pthread_sigmask in the signal module

2011-05-07 Thread STINNER Victor
Changes by STINNER Victor : Removed file: http://bugs.python.org/file21883/pending_signals.patch ___ Python tracker ___ ___ Python-bugs-list ma

[issue8407] expose signalfd(2) and pthread_sigmask in the signal module

2011-05-07 Thread STINNER Victor
STINNER Victor added the comment: wakeup_signum.patch: simple patch to write the signal number (as a single byte) instead of just b'\x00' into the wake up file descriptor. It gives the ability to watch more than one signal and be able to know which one was raised. Included tests demonstrate t

[issue8407] expose signalfd(2) and pthread_sigmask in the signal module

2011-05-07 Thread STINNER Victor
STINNER Victor added the comment: About signalfd(): this patch doesn't provide any information or tool to decode data written to the file descriptor. We should expose the signalfd_siginfo structure or you cannot handle more than one signal (how do you know which signal numbers were raised?).

[issue8407] expose signalfd(2) and pthread_sigmask in the signal module

2011-05-07 Thread STINNER Victor
STINNER Victor added the comment: Note: we might expose pth_raise() which is similar to pthread_kill(), but... pth support was deprecated by the PEP 11 and pth support will be removed from Python 3.3 source code. -- ___ Python tracker

[issue8407] expose signalfd(2) and pthread_sigmask in the signal module

2011-05-07 Thread STINNER Victor
STINNER Victor added the comment: > I mistakenly removed your pending_signals-2 patch > I'm really sorry about this, could you re-post it? No problem, anyway I worked on a new version in the train. > So, if anything, you shouldn't check for a pending signal [in sigwait] Right, fixed in the ne

  1   2   >