[issue13370] test_ctypes fails when building python with clang

Ned Deily added the comment: Thanks for the analysis, Meador. So perhaps as a temporary workaround, we could tweak setup.py to set -O0 for building ctypes with clang? -- ___ Python tracker __

[issue13590] extension module builds fail with python.org OS X installers on OS X 10.7 and 10.6 with Xcode 4.2

Ned Deily added the comment: When building and installing C extension modules, distutils attempts to use the same compiler and some compiler options as Python itself was built with. For the current (3.2.2 and 2.7.2) 64-bit/32-bit python installers, the standard Apple-supplied gcc-4.2 in Xcod

[issue13742] Add a key parameter (like sorted) to heapq.merge

Raymond Hettinger added the comment: I'll look at this in the next couple of weeks. Hang tight :-) -- ___ Python tracker ___ ___ Pyt

[issue13370] test_ctypes fails when building python with clang

Meador Inge added the comment: It turns out that this isn't OS X specific. I can reproduce the exact same issue by building with clang on a 64-bit Fedora 16 box. -- components: -Macintosh title: test_ctypes fails on osx 10.7 -> test_ctypes fails when building python with clang

[issue12970] os.walk() consider some symlinks as dirs instead of non-dirs

Changes by Sung-Yu Chen : -- nosy: +Sung-Yu.Chen ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue13959] Re-implement parts of imp in pure Python

Changes by Brett Cannon : -- dependencies: +Replace __import__ w/ importlib.__import__ ___ Python tracker ___ ___ Python-bugs-list mai

[issue13959] Re-implement parts of imp in pure Python

New submission from Brett Cannon : A bunch of code in Python/import.c exists purely for the imp module, but a large chunk of it does not need to be implemented in C but instead can be implemented in Python code. Once importlib is bootstrapped in then an attempt to scale back the C code should

[issue13953] test_packaging: unused test?

Changes by Francisco Martín Brugué : -- nosy: +francismb ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue13889] str(float) and round(float) issues with FPU precision

Samuel Iseli added the comment: Completed the patch by adding the rounding-control bits to the mask (_MCW_RC) and making sure the macros only get defined for MS-VC compiler (#ifdef _MSC_VER). Ran the tests (python_d -m test.autotest) on win32. Seems OK. The tests that were skipped or failed

[issue12659] Add tests for packaging.tests.support

Francisco Martín Brugué added the comment: I've just updated “test_support.py” and tested against 'default' and 'distutils2' (after changing the imports). Just let me know what has to be changed ... BTW: in distutils2 I get (not because of this change): ==

[issue13703] Hash collision security issue

Marc-Andre Lemburg added the comment: Alex Gaynor wrote: > There's no need to cover any container types, because if their constituent > types are securely hashable then they will be as well. And of course if > the constituent types are unsecure then they're directly vulnerable. I wouldn't nece

[issue13882] PEP 410: Use decimal.Decimal type for timestamps

STINNER Victor added the comment: -return posix_do_stat(self, args, "O&:stat", STAT, "U:stat", win32_stat_w); +return posix_do_stat(self, args, kw, "O&|O:stat", STAT, "U:stat", win32_stat_w); The second format string should also be updated to "U|O:stat". -- __

[issue13882] PEP 410: Use decimal.Decimal type for timestamps

STINNER Victor added the comment: Hum, time_decimal-10.patch contains a debug message: +print("la") -- ___ Python tracker ___ __

[issue13578] Add subprocess.iter_output() convenience function

Giampaolo Rodola' added the comment: > This biggest challenge I have noticed so far in exploring > this is how to handle timeouts on Windows I haven't actually looked into it but this somewhat recalls: http://bugs.python.org/issue1191964 Since issue1191964 is supposed to provide async subproce

[issue13958] Comment _PyUnicode_FromId

STINNER Victor added the comment: Using _Py_static_string(), you can write literal UTF-8 strings using hexadecimal escape sequences. It works on any C compiler. E.g. _Py_static_string(ecute, "\xc3\xa9"). -- ___ Python tracker

[issue13958] Comment _PyUnicode_FromId

Jim Jewett added the comment: And is there a way to characterize the compilers that would break? Is it a few specific compilers, or "compilers that do not implement UTF8, which is not required by the C standard", or ... -- ___ Python tracker

[issue13958] Comment _PyUnicode_FromId

Jim Jewett added the comment: On Mon, Feb 6, 2012 at 4:25 PM, Martin v. Löwis wrote: > Martin v. Löwis added the comment: > This has nothing to do with PEP 3131. Python could (and does) > support non-ASCII identifiers just fine, regardless of C compiler > limitations. I *think* you're sayin

[issue13928] bug in asyncore.dispatcher_with_send

Giampaolo Rodola' added the comment: No problem. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue13703] Hash collision security issue

Alex Gaynor added the comment: On Mon, Feb 6, 2012 at 5:04 PM, Marc-Andre Lemburg wrote: > > Marc-Andre Lemburg added the comment: > > Alex Gaynor wrote: > > Can't randomization just be applied to integers as well? > > A simple seed xor'ed with the hash won't work, since the attacks > I posted

[issue2377] Replace __import__ w/ importlib.__import__

STINNER Victor added the comment: Is there a benchmark for import? How slow is importlib? :) -- nosy: +haypo ___ Python tracker ___ __

[issue13703] Hash collision security issue

Marc-Andre Lemburg added the comment: Alex Gaynor wrote: > Can't randomization just be applied to integers as well? A simple seed xor'ed with the hash won't work, since the attacks I posted will continue to work (just colliding on a different hash value). Using a more elaborate hash algorithm

[issue13878] test_sched failures on Windows buildbot

Charles-François Natali added the comment: Here's another failure due to the same type of race: """ == FAIL: test_queue (test.test_sched.TestCase) -- Traceback

[issue2377] Replace __import__ w/ importlib.__import__

Brett Cannon added the comment: Thanks to Benjamin, the test_capi assert failure is fixed. At this point the only failures are listed in the FAILING file and are (probably) minor. -- ___ Python tracker ___

[issue13703] Hash collision security issue

Dave Malcolm added the comment: > Can't randomization just be applied to integers as well? > It could, but see http://bugs.python.org/issue13703#msg151847 Would my patches be more or less likely to get reviewed with vs without an extension of randomization to integers? -- __

[issue4709] Mingw-w64 and python on windows x64

Ralf Schmitt added the comment: There's no need to discuss or even run configure scripts. Martin, please reread the OPs original message. It's easy enough to reason about the issue instead of trying to reproduce it. -- ___ Python tracker

[issue13957] parsedate_tz doesn't distinguish -0000 from +0000

R. David Murray added the comment: This is fixed already in 3.3. It is a behavior change that could theoretically cause some problems. Currently, you can think of None as meaning "there was no timezone info at all", which is subtly different from -, which means "this time is UTC, but I

[issue13703] Hash collision security issue

Alex Gaynor added the comment: On Mon, Feb 6, 2012 at 4:41 PM, Marc-Andre Lemburg wrote: > > Marc-Andre Lemburg added the comment: > > Gregory P. Smith wrote: > > > > Gregory P. Smith added the comment: > > > >> > >>> The release managers have pronounced: > >>> http://mail.python.org/pipermai

[issue13703] Hash collision security issue

Marc-Andre Lemburg added the comment: Gregory P. Smith wrote: > > Gregory P. Smith added the comment: > >> >>> The release managers have pronounced: >>> http://mail.python.org/pipermail/python-dev/2012-January/115892.html >>> Quoting that email: 1. Simple hash randomization is the way to

[issue13958] Comment _PyUnicode_FromId

Changes by Antoine Pitrou : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue13807] logging.Handler.handlerError() may raise AttributeError in traceback.print_exception()

Roundup Robot added the comment: New changeset 6b951f27f6a8 by Vinay Sajip in branch '3.2': Null merge for reverted fix for #13807. http://hg.python.org/cpython/rev/6b951f27f6a8 New changeset 140f7de4d2a5 by Vinay Sajip in branch 'default': Null merge for reverted fix for #13807. http://hg.pyth

[issue13958] Comment _PyUnicode_FromId

Martin v. Löwis added the comment: This has nothing to do with PEP 3131. Python could (and does) support non-ASCII identifiers just fine, regardless of C compiler limitations. -- nosy: +loewis ___ Python tracker

[issue13703] Hash collision security issue

Gregory P. Smith added the comment: > > > The release managers have pronounced: > > http://mail.python.org/pipermail/python-dev/2012-January/115892.html > > Quoting that email: > >> 1. Simple hash randomization is the way to go. We think this has the > >> best chance of actually fixing the probl

[issue13955] email: RFC 2822 has been obsoleted by RFC 5322

R. David Murray added the comment: 5322 is still a draft, according to the IETF. That said, we are paying attention to 5322. -- nosy: +r.david.murray resolution: -> invalid stage: -> committed/rejected status: open -> closed ___ Python tracker

[issue13958] Comment _PyUnicode_FromId

New submission from Jim Jewett : Add a comment explaining why _PyUnicode_FromId can (and should) assume ASCII-only identifiers. /* PEP3131 guarantees that all python-internal identifiers are ASCII-only. Violating this would break some supported C compilers. */ S

[issue13954] Add regrtest option to record test results to a file

Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue13957] parsedate_tz doesn't distinguish -0000 from +0000

New submission from Samuel Bronson : This is what I'm seeing: >>> import email.utils >>> email.utils.parsedate_tz('Fri, 09 Nov 2001 01:08:47 +') (2001, 11, 9, 1, 8, 47, 0, 1, -1, 0) >>> email.utils.parsedate_tz('Fri, 09 Nov 2001 01:08:47 -') (2001, 11, 9, 1, 8, 47, 0, 1, -1, 0) But RFC

[issue13955] email: RFC 2822 has been obsoleted by RFC 5322

Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue13956] add a note regarding building on recent versions of Debian and Ubuntu

New submission from Tshepang Lekhonkhobe : I was puzzled why the various parts, like readline and ssl, failed to be built into my Python. It was after seeing #11715 that I realized I needed to install dpkg-dev, whose binary, dpkg-architecture, helps detect the locations of those libraries ().

[issue13955] email: RFC 2822 has been obsoleted by RFC 5322

New submission from Samuel Bronson : As you can see by looking at or , RFC 2822 has been obsoleted by RFC 5322. It would probably be a good idea to update the email package to support it, if in fact anything needs changin

[issue13954] Add regrtest option to record test results to a file

New submission from Brett Cannon : The idea is that if a test succeeded then it is written to a file commented out(including skipped tests w/ the appropriate comment), and if a test failed then it is left uncommented. This way the failing tests can simply be passed to --fromfile for easy repea

[issue8184] multiprocessing.managers will not fail if listening ocket already in use

Antoine Pitrou added the comment: > Anyway, in that case, my last patch should be correct (tested on > one of the Win7 buildbots). It looks good to me. -- ___ Python tracker ___

[issue13588] Change name of internal closure functions in importlib

Changes by Brett Cannon : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue13703] Hash collision security issue

Marc-Andre Lemburg added the comment: Antoine Pitrou wrote: > > Antoine Pitrou added the comment: > >>> Right, but that doesn't contradict what I wrote about adding >>> env vars to fix a seed and optionally enable using a random >>> seed, or adding collision counting as extra protection for >

[issue13703] Hash collision security issue

Antoine Pitrou added the comment: > > Right, but that doesn't contradict what I wrote about adding > > env vars to fix a seed and optionally enable using a random > > seed, or adding collision counting as extra protection for > > cases that are not addressed by the hash seeding, such as > > e.g.

[issue13703] Hash collision security issue

Marc-Andre Lemburg added the comment: Marc-Andre Lemburg wrote: > Dave Malcolm wrote: >> The release managers have pronounced: >> http://mail.python.org/pipermail/python-dev/2012-January/115892.html >> Quoting that email: >>> 1. Simple hash randomization is the way to go. We think this has the >

[issue10811] sqlite segfault with generators

Petri Lehtinen added the comment: It's now fixed in all branches. Thanks for reporting! -- resolution: -> fixed status: open -> closed ___ Python tracker ___ __

[issue10811] sqlite segfault with generators

Roundup Robot added the comment: New changeset 631e99961c5f by Petri Lehtinen in branch '2.7': Issue #10811: Fix recursive usage of cursors. Instead of crashing, raise a ProgrammingError now. http://hg.python.org/cpython/rev/631e99961c5f New changeset d51ceef4b62f by Petri Lehtinen in branch '

[issue13703] Hash collision security issue

Marc-Andre Lemburg added the comment: Dave Malcolm wrote: > >>> So the overhead in startup time is not an issue? >> >> It is an issue. Not only in terms of startup time, but also >... >> because randomization per default makes Python behave in >> non-deterministc ways - which is not what you w

[issue13703] Hash collision security issue

Jim Jewett added the comment: On Mon, Feb 6, 2012 at 1:53 PM, Frank Sievertsen wrote: >>> BTW: If you set the limit N to e.g. 100 (which is reasonable given >>> Victor's and my tests), >> So it would take around 3Mb to cause a minute's delay... > How did you calculate that? 16 bytes/entry *

[issue13952] mimetypes doesn't recognize .csv

R. David Murray added the comment: Ah, analagous to the way keyword.py regenerates its embedded table based on the actual python grammar? Yes, that would be nice. -- ___ Python tracker __

[issue13952] mimetypes doesn't recognize .csv

Antoine Pitrou added the comment: > I'm not sure what you mean by your final comment, since by default the > system mime types are read on both Unix and Windows and merged with > the built in table. I mean to have our built-in table mirror a recent Unix system's mime-types table. There could be

[issue13703] Hash collision security issue

Dave Malcolm added the comment: On Mon, 2012-02-06 at 10:20 +, Marc-Andre Lemburg wrote: > Marc-Andre Lemburg added the comment: > > STINNER Victor wrote: > > > > STINNER Victor added the comment: > > > >> In a security fix release, we shouldn't change the linkage procedures, > >> so I

[issue13952] mimetypes doesn't recognize .csv

R. David Murray added the comment: As far as I know having it mirror the IANA registry is the intent (there's a comment in the module that can be read as implying that). So I'd be inclined to treat this one as a bug and fix it in 2.7 and 3.2 as well as 3.3. I'm not sure what you mean by your

[issue13952] mimetypes doesn't recognize .csv

Antoine Pitrou added the comment: I would argue the embedded mime-types dictionary should at least mirror current IANA assignments, which are already present in up-to-date Unix systems: >>> mimetypes.guess_type("foo.csv") ('text/csv', None) So not having text/csv is IMHO a bug. Also it would

[issue13953] test_packaging: unused test?

New submission from Tshepang Lekhonkhobe : I'm not sure what's happening here (not sure how doctest works), but I suspect that there is no test at all. Perhaps it was forgotten: http://hg.python.org/cpython/file/567767a6df02/Lib/packaging/tests/test_version.py#l68. I say this because it whatev

[issue13703] Hash collision security issue

Marc-Andre Lemburg added the comment: Jim Jewett wrote: > >> BTW: If you set the limit N to e.g. 100 (which is reasonable given >> Victor's and my tests), > > Agreed. Frankly, I think 5 would be more than reasonable so long as > there is a fallback. > >> the time it takes to process one of t

[issue13703] Hash collision security issue

Frank Sievertsen added the comment: > Agreed; it tops out with a constant, but if it takes only 16 bytes of > input to force another run through a 1000-long collision, that may > still be too much leverage. You should prepare the dict so that you have the collisions-run with a one-byte string

[issue13703] Hash collision security issue

Jim Jewett added the comment: On Mon, Feb 6, 2012 at 12:07 PM, Marc-Andre Lemburg wrote: > > Marc-Andre Lemburg added the comment: > > Jim Jewett wrote: >> The problematic case is, roughly, >> (1)  Find out what N will trigger collision-counting countermeasures. >> (2)  Insert N-1 colliding

[issue8255] Packaging step-by-step tutorial

Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue13952] mimetypes doesn't recognize .csv

R. David Murray added the comment: Yes, but text/tab-delimited-values/.tsv is older. .tsv dates from the days of Gopher, but text/csv was formalized only in October of 2005. Presumably nobody has asked for it before, for some odd reason. Now we get to debate again whether updating mimetypes

[issue13952] mimetypes doesn't recognize .csv

New submission from Ian Davis : The mimetypes module does not respond with "text/csv" for files that end in ".csv", and I think it should :) For goodness sake, "text/tab-delimited-values" is in there as ".tsv", and that seems much less used (to me). -- components: Library (Lib) mess

[issue12703] Improve error reporting for packaging.util.resolve_name

Éric Araujo added the comment: In the absence of feedback, I’m going to apply my find_object idea as described in my previous message. -- ___ Python tracker ___ ___

[issue5411] add xz compression support to shutil

Éric Araujo added the comment: I should add that a doc update will be part of the next patch. In parallel, I’ve also started updating packaging to add lzma support to the bdist command, but the situation is very disappointing: tarfile knows what format it supports, shutil has its own list, an

[issue5411] add xz compression support to shutil

Éric Araujo added the comment: This not-so-bad patch adds lzma compression support to the shutil functions, under the 'xztar' name. Please review. -- Added file: http://bugs.python.org/file24433/shutil-xz.diff ___ Python tracker

[issue13703] Hash collision security issue

Marc-Andre Lemburg added the comment: Jim Jewett wrote: > > Jim Jewett added the comment: > > On Mon, Feb 6, 2012 at 8:12 AM, Marc-Andre Lemburg > wrote: >> >> Marc-Andre Lemburg added the comment: >> >> Antoine Pitrou wrote: >>> >>> The simple collision counting approach leaves a gaping ho

[issue5302] Allow package_data specs/globs to match directories

Éric Araujo added the comment: One implementation by George Sakkis is found in this thread: http://bugs.python.org/issue2279#msg82213 There are subtle issues with this feature. For example, a glob pattern could match both package data files and Python submodules, leading to the same .py fil

[issue11805] package_data only allows one glob per-package

Éric Araujo added the comment: (I forgot that distutils2’s setup.py has its own fork of the conversion functions, for bootstrapping reasons, so I need to port the fix there.) -- ___ Python tracker ___

[issue13903] New shared-keys dictionary implementation

Changes by Mark Shannon : -- hgrepos: -109 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue13951] Seg Fault in .so called by ctypes causes the interpreter to Seg Fault

Amaury Forgeot d'Arc added the comment: [Please do not change issue titles - your recommendation was enough] Indeed, incorrect usage of ctypes can crash the program, and there is nothing Python can do. But I could not find any warning about this in the documentation, except maybe this senten

[issue4709] Mingw-w64 and python on windows x64

John Pye added the comment: Martin, Ralf is right and my as previously linked is about building a python extension. I should have been more explicit about that. FWIW I found that the configure scripts on MinGW-w64 generally work fine if you add a "--build=x86_64-w64-mingw32" argument on the .

[issue1040439] Missing documentation on how to link with libpython

Antoine Pitrou added the comment: > Is there still work to do on this issue? Not for Unix, no. I don't if it's applicable to Windows. -- ___ Python tracker ___ __

[issue13951] please close - Seg Fault in .so called by ctypes causes the interpreter to Seg Fault

Changes by Ramchandra Apte : -- title: Seg Fault in .so called by ctypes causes the interpreter to Seg Fault -> please close - Seg Fault in .so called by ctypes causes the interpreter to Seg Fault ___ Python tracker

[issue1040439] Missing documentation on how to link with libpython

Éric Araujo added the comment: Is there still work to do on this issue? -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue13938] 2to3 fails to convert types.StringTypes appropriately

Changes by Éric Araujo : -- assignee: -> benjamin.peterson nosy: +benjamin.peterson versions: +Python 2.7 -Python 3.4 ___ Python tracker ___

[issue13703] Hash collision security issue

Jim Jewett added the comment: On Mon, Feb 6, 2012 at 8:12 AM, Marc-Andre Lemburg wrote: > > Marc-Andre Lemburg added the comment: > > Antoine Pitrou wrote: >> >> The simple collision counting approach leaves a gaping hole open, as >> demonstrated by Frank. > Could you elaborate on this ? > N

[issue13951] Seg Fault in .so called by ctypes causes the interpreter to Seg Fault

Ramchandra Apte added the comment: It is the correct behaviour for an invalid usage to segfault and is also mentioned in the documentation. Can somebody close this bug as invalid? -- nosy: +ramchandra.apte ___ Python tracker

[issue13948] rm needless use of set function

Éric Araujo added the comment: Yes, this test method could be a little clearer. I’ll do this. -- assignee: tarek -> eric.araujo versions: +3rd party ___ Python tracker ___

[issue13949] rm needless use of pass statement

Éric Araujo added the comment: Sure, I’ll apply this. -- assignee: tarek -> eric.araujo versions: +3rd party ___ Python tracker ___ _

[issue13950] rm commented-out code

Éric Araujo added the comment: Before Tarek started the distutils2 project, the version code lived standalone and its README file served as doctest. Most of its text was moved to PEP 386 and the tests themselves to test_verlib (and now test_version): https://bitbucket.org/tarek/distutilsvers

[issue13590] extension module builds fail with python.org OS X installers on OS X 10.7 and 10.6 with Xcode 4.2

Changes by Éric Araujo : -- title: exension module builds fail with python.org OS X installers on OS X 10.7 and 10.6 with Xcode 4.2 -> extension module builds fail with python.org OS X installers on OS X 10.7 and 10.6 with Xcode 4.2 ___ Python track

[issue13951] Seg Fault in .so called by ctypes causes the interpreter to Seg Fault

New submission from Graeme Glass : When doing something obviously incorrect (read, wrong/stupid) while calling libX11.so.6 via ctypes, it causes a Segmentation fault, which in turn cause the python interpreter to fall over with a Segmentation fault. My question is, is this the correct behavi

[issue13703] Hash collision security issue

Marc-Andre Lemburg added the comment: Antoine Pitrou wrote: > > The simple collision counting approach leaves a gaping hole open, as > demonstrated by Frank. Could you elaborate on this ? Note that I've updated the collision counting patch to cover both possible attack cases I mentioned in h

[issue13931] os.path.exists inconsistent between 32 bit and 64 bit

zxw added the comment: I've posted the code to http://code.activestate.com/recipes/578035-disable-file-system-redirector/ -- ___ Python tracker ___

[issue13703] Hash collision security issue

Antoine Pitrou added the comment: > It is an issue. Not only in terms of startup time, but also > because randomization per default makes Python behave in > non-deterministc ways - which is not what you want from a > programming language or interpreter (unless you explicitly > tell it to behave

[issue13590] exension module builds fail with python.org OS X installers on OS X 10.7 and 10.6 with Xcode 4.2

Changes by Ned Deily : -- assignee: ronaldoussoren -> ned.deily ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13703] Hash collision security issue

Marc-Andre Lemburg added the comment: STINNER Victor wrote: > > STINNER Victor added the comment: > >> In a security fix release, we shouldn't change the linkage procedures, >> so I recommend that the LoadLibrary dance remains. > > So the overhead in startup time is not an issue? It is an i

[issue13703] Hash collision security issue

STINNER Victor added the comment: > In a security fix release, we shouldn't change the linkage procedures, > so I recommend that the LoadLibrary dance remains. So the overhead in startup time is not an issue? -- ___ Python tracker

[issue4709] Mingw-w64 and python on windows x64

Ralf Schmitt added the comment: Marting, this issue is about building python extensions with mingw-w64 not about building python itself. -- ___ Python tracker ___ __

[issue13889] str(float) and round(float) issues with FPU precision

Stefan Krah added the comment: I can run the tests on win64, but it I think it would be nice to have a patch with exactly the same logic as the gcc-asm version (Mark already mentioned _MCW_PC | _MCW_RC). Another thing: _WIN32 might be defined on MinGW, but I'm not sure. If that's the case, it w

[issue13950] rm commented-out code

New submission from Tshepang Lekhonkhobe : It does not appear that the commented-out code adds any value. If anything, it's maybe just a distraction. -- assignee: tarek components: Distutils2 files: rm-commented-out-code.patch keywords: patch messages: 152727 nosy: alexis, eric.araujo,

[issue13949] rm needless use of pass statement

New submission from Tshepang Lekhonkhobe : I found the use of the pass statement redundant. -- assignee: tarek components: Distutils2 files: rm-needless-use-of-pass-keyword.patch keywords: patch messages: 152726 nosy: alexis, eric.araujo, tarek, tshepang priority: normal severity: normal

[issue13948] rm needless use of set function

New submission from Tshepang Lekhonkhobe : I assume that the set() function was used to get rid of duplicates from self.versions, but there aren't any and the test would pass even if there were. -- assignee: tarek components: Distutils2 files: rm-needless-use-of-set-function.patch keywo