Pierre Quentel pierre.quen...@gmail.com added the comment:
Thanks for the explanation
I still think that the patch can be simplified, not using path lengths and the
found flag
collapsed_path = _url_collapse_path(self.path)
for head in self.cgi_directories:
if head==collapsed_path:
Nick Coghlan ncogh...@gmail.com added the comment:
In that case, how about we go with:
1. By default, importlib._bootstrap is never imported. Instead, it is set to be
a reference to _frozen_importlib. However, _frozen_importlib does *not* lie
about where it came from (and doesn't assume the
Tshepang Lekhonkhobe tshep...@gmail.com added the comment:
thanks so much for your rime in reviewing and committing
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14034
___
Serhiy Storchaka storch...@gmail.com added the comment:
Changeset 9118ef2b651a was broken, but the bug should have been fixed by
changeset 10ccbb90a8e9. Which revision have you been using?
I used the revision 76809:ab57e29157bb. Yes, now the bug fixed. Thank
you once again.
--
title:
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset f9344a3eaaa6 by Mark Dickinson in branch 'default':
Issue #14695: Run Tools/parser/test_unparse.py as part of test_tools.
http://hg.python.org/cpython/rev/f9344a3eaaa6
--
nosy: +python-dev
Mark Dickinson dicki...@gmail.com added the comment:
Thanks, David!
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14695
___
New submission from Larry Hastings la...@hastings.org:
If you write a PyArg_Parse converter, and your conversion hits an error, you
must raise an exception and error out. But, since your converter has no
context about the parameter, it can't provide any helpful information in the
error.
For
Changes by Larry Hastings la...@hastings.org:
--
assignee: - larry
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14739
___
___
Python-bugs-list
Changes by Larry Hastings la...@hastings.org:
--
components: +Interpreter Core
stage: - needs patch
type: - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14739
___
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset c9c2031cf16d by Mark Dickinson in branch 'default':
Add John Regehr to Misc/ACKS for his help with finding integer overflows (issue
#9530).
http://hg.python.org/cpython/rev/c9c2031cf16d
--
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset e4617650f006 by Larry Hastings in branch 'default':
Issue #14705: Added support for the new 'p' format unit to skipitem().
http://hg.python.org/cpython/rev/e4617650f006
--
Serhiy Storchaka storch...@gmail.com added the comment:
It would be better if the functions PyArg_Parse* were wrapped converter's
exception, in other exception with adding the names of function and parameter
in the message. This will save us from necessity of the introduction of the new
Changes by Mark Dickinson dicki...@gmail.com:
--
assignee: - mark.dickinson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14695
___
___
Mark Dickinson dicki...@gmail.com added the comment:
Closing as won't fix; Python is sadly far from consistent about returning
infinity versus raising OverflowError, in a wide variety of situations. For
example, compare:
* float(Decimal('1e310')) with float(Fraction('1e310')), or
*
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 064c2d0483f8 by Mark Dickinson in branch 'default':
Issue #14700: Fix two broken and undefined-behaviour-inducing overflow checks
in old-style string formatting. Thanks Serhiy Storchaka for report and
original
Changes by Mark Dickinson dicki...@gmail.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14700
___
Mike Meyer m...@mired.org added the comment:
I just ran into this issue in the logging module using 2.7. Here's the TB in
case it sheds any light on the issue
Traceback (most recent call last):
File ./crawler.py, line 531, in module
main(argv[1:]1:)
File ./crawler.py, line 522, in main
Stefan Krah stefan-use...@bytereef.org added the comment:
I agree. Fixing all this would probably require a PEP. It looks like the
original plan was to provide a facility to turn off the Overflow exception:
http://mail.python.org/pipermail/python-dev/2000-May/003990.html
--
Changes by Georg Brandl ge...@python.org:
--
nosy: +georg.brandl, loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14739
___
___
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset fc17f70292f6 by Mark Dickinson in branch '3.2':
Issue #14701: Add missing support for 'raise ... from' in parser module.
http://hg.python.org/cpython/rev/fc17f70292f6
New changeset 0dd0d56bdcc1 by Mark Dickinson in
Nick Coghlan ncogh...@gmail.com added the comment:
In going to add documentation for your patch, I realised the operator module is
not the right place for this.
The types module actually seems like the most appropriate home, but that will
require adding a _types module to back it.
I'll post
Mark Dickinson dicki...@gmail.com added the comment:
Now fixed.
Terry: I suggest opening a separate doc issue for the 'CPython-specific' issue
--
assignee: - mark.dickinson
components: +Library (Lib)
resolution: - fixed
status: open - closed
___
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 7be716a47e9d by Victor Stinner in branch 'default':
Close #14716: str.format() now uses the new unicode writer API instead of the
http://hg.python.org/cpython/rev/7be716a47e9d
New changeset ab500b297900 by Victor
Antoine Pitrou pit...@free.fr added the comment:
Disagreed. sys.stderr is not only for errors but all informational messages
of little value (warnings, debug messages etc.). Also, logging to two different
streams makes redirecting clumsier.
If you want to change this, it would more useful to
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +ezio.melotti, pitrou
stage: - needs patch
versions: +Python 3.3 -Python 2.6, Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9177
Antoine Pitrou pit...@free.fr added the comment:
I don't think mimicking EBADF is very useful. Reading from a closed socket is
usually a programming error, so it's not the kind of error you'll want to catch
at runtime.
AttributeError may not be very pretty though, so perhaps a ValueError can
Nick Coghlan ncogh...@gmail.com added the comment:
I'm currently planning to postpone fixing this until 3.4. However, if someone
else wants to pick it up for 3.3, go ahead.
--
assignee: ncoghlan -
versions: +Python 3.4 -Python 3.3
___
Python
Nick Coghlan ncogh...@gmail.com added the comment:
Superseded by issue 13585 (which will add an improved dynamic context
management API)
--
resolution: postponed - out of date
status: open - closed
superseder: - Add contextlib.ExitStack
___
Python
Changes by Nick Coghlan ncogh...@gmail.com:
--
assignee: ncoghlan -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1294232
___
___
Serhiy Storchaka storch...@gmail.com added the comment:
Mark, I deliberately have not used the exact formula for the overflow.
Comparison with the constant is much cheaper than division or multiplication.
Microbencmark:
./python -m timeit -s 'f=%.1234567890s*100;x=(,)*100' 'f%x'
Before
Mark Dickinson dicki...@gmail.com added the comment:
Sure, I realize that, but I prefer not to be sloppy in the overflow check, and
to use the same formula that's already used in stringlib. I somehow doubt that
this micro-optimization is going to have any noticeable effect in real code.
Serhiy Storchaka storch...@gmail.com added the comment:
May be proposed tests (except for the overflow) would be helpful? Right now 'f'
and 'd' parsing code is not covered by tests.
--
___
Python tracker rep...@bugs.python.org
New submission from Bob Glickstein bob.glickst...@gmail.com:
Passing both a value for i and decode=True to
email.message.Message.get_payload(), when self is a multipart, returns None
when it should return a string. The reason is that an is_multipart() test is
done on self when it should
Bob Glickstein bob.glickst...@gmail.com added the comment:
Incidentally, a workaround is:
msg.get_payload(n).get_payload(decode=True)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14740
R. David Murray rdmur...@bitdance.com added the comment:
Thanks for the report and patch suggestion, but...
This is actually the way it is designed to work. get_payload(i) returns the
ith element of a multipart payload. Your workaround is in fact the correct way
to do this operation.
Brett Cannon br...@python.org added the comment:
Should we have a separate context manager for this, or just make it a flag for
a unified import_state() decorator? Or do we want to *always* force the use of
the Python code instead of the frozen code?
--
Antoine Pitrou pit...@free.fr added the comment:
Should we have a separate context manager for this, or just make it a
flag for a unified import_state() decorator? Or do we want to *always*
force the use of the Python code instead of the frozen code?
Ideally, we would want to test both
Antoine Pitrou pit...@free.fr added the comment:
Ideally, we would want to test both versions, so that any oddity in the
freezing mechanism gets exercised and diagnosed properly.
(not to mention the speedups in import.c)
--
___
Python tracker
Eric Snow ericsnowcurren...@gmail.com added the comment:
I'm +1 on Nick's recommendation.
@Antoine
Ideally, we would want to test both versions, so that any oddity in
the freezing mechanism gets exercised and diagnosed properly.
+1
Does this mean that the whole test suite should be run
fishdude fishd...@gmx.net added the comment:
i have to report that this issue also happens on Linux and Mac as well.
no matter wether python 2.6 or 2.7 is used.
--
components: +Macintosh
nosy: +fishdude
versions: +Python 2.6
___
Python tracker
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 129289144dfb by Mark Dickinson in branch '3.2':
Issue #14697: Fix missing parser module support for set displays and set
comprehensions.
http://hg.python.org/cpython/rev/129289144dfb
New changeset 4815a4a4a852 by
Changes by Mark Dickinson dicki...@gmail.com:
--
assignee: - mark.dickinson
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14697
___
Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com added the comment:
It might be sufficient to only run tests from the following files with both
importlib._bootstrap and _frozen_importlib:
test_imp.py
test_import.py
test_importhooks.py
test_importlib.py
test_pkgimport.py
Antoine Pitrou pit...@free.fr added the comment:
It might be sufficient to only run tests from the following files with
both importlib._bootstrap and _frozen_importlib:
I was only thinking about test_importlib myself.
--
___
Python tracker
Serhiy Storchaka storch...@gmail.com added the comment:
I somehow doubt that this micro-optimization is going to have any noticeable
effect in real code.
Agree. I just found this bug, trying to optimize the code.
--
___
Python tracker
Éric Araujo mer...@netwok.org added the comment:
Thanks for the confirmation. Note that the versions field in this bug tracker
indicates the versions that will get fixed, not all versions with the bug; 2.6
only gets security fixes now.
Are you interested in updating the patch with a test
New submission from Mark Dickinson dicki...@gmail.com:
Here's a simple patch. With this and other recent patches to the parser
module, we can now correctly roundtrip all the (valid) Python files in Lib/ and
Lib/test/.
--
assignee: mark.dickinson
components: Library (Lib)
files:
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 2b1cc84bf1d9 by Mark Dickinson in branch '3.2':
Issue #14741: Fix missing support for ellipsis in parser module.
http://hg.python.org/cpython/rev/2b1cc84bf1d9
New changeset d50577c5711b by Mark Dickinson in branch
Changes by Mark Dickinson dicki...@gmail.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14741
___
Ezio Melotti ezio.melo...@gmail.com added the comment:
In the patch I'm assuming that the port number can only contain ascii digits
RFC 3986 [0] defines the port as
port = *DIGIT
and part of the authority [1] as
authority = [ userinfo @ ] host [ : port ]
userinfo =
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
versions: +Python 3.3 -Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10733
___
___
R. David Murray rdmur...@bitdance.com added the comment:
See also issue 14036.
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14072
___
Ezio Melotti ezio.melo...@gmail.com added the comment:
Can you still reproduce this?
--
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10765
___
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13936
___
___
Python-bugs-list
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10427
___
___
Python-bugs-list
Brett Cannon br...@python.org added the comment:
I would say test_importlib and test_imp (test_import really should just get
folded into test_importlib).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14657
Serhiy Storchaka storch...@gmail.com added the comment:
The patch updated to use functions encode_filter_properties and
decode_filter_properties from the lzma module. Thank you, Nadeem Vawda.
--
Added file: http://bugs.python.org/file25488/lzma_in_zip_2.patch
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file25430/lzma_in_zip.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14366
___
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset d6324941b739 by Antoine Pitrou in branch 'default':
Issue #14583: Fix importlib bug when a package's __init__.py would first import
one of its modules then raise an error.
New submission from Antoine Pitrou pit...@free.fr:
Apparently test_unparse goes a bit overboard. test_compiler in 2.x had a more
reasonable approach: it only compiled all files with -uall, otherwise it would
choose 10 at random.
--
components: Tests
messages: 160165
nosy:
New submission from Xavier de Gaye xdeg...@gmail.com:
All the problems raised in this issue are caused by self.botframe
being set in a Pdb frame.
In the following pdb session run with python 3.2.2, the first two
frames in the printed stack are Pdb frames, this is wrong. And the
second step
Antoine Pitrou pit...@free.fr added the comment:
Should be fixed now. The buildbot has been able to launch the test suite.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker
Xavier de Gaye xdeg...@gmail.com added the comment:
Note that now that this issue is fixed, issue 14743 has become more
visible.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13183
___
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +brian.curtin
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10765
___
___
Python-bugs-list
Glenn Linderman v+pyt...@g.nevcal.com added the comment:
Hi Pierre,
You are right, the found variable is not needed, I guess the reason I coded
it that way, is I had some validation code before the return, during testing,
so it was easier not to have it in three places.
Regarding
Éric Araujo mer...@netwok.org added the comment:
Sandro ported to 2.7 in 07b3fc67bf45. Thanks!
If I may make two remarks:
- Please duplicate commit messages from 3.2 and 2.7: it makes it easier to
understand what a changeset is about without having to hunt. (This does not
apply to 3.3 as
Mark Dickinson dicki...@gmail.com added the comment:
That sounds like a better approach. I'll back out the test_unparse inclusion
until this can be fixed.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14742
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset dbfacec7e368 by Mark Dickinson in branch 'default':
Issue #14742: Don't include DirectoryTestCase from test_unparse in test_tools
until we can speed it up.
http://hg.python.org/cpython/rev/dbfacec7e368
--
Sandro Tosi sandro.t...@gmail.com added the comment:
Oh sorry Éric, I completely oversaw there was an issue associated with the cset
- i'll pay more attention next time!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12298
Éric Araujo mer...@netwok.org added the comment:
No problem, what counts is that our documentation and code get better for our
users, not my ego :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12298
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 01581e8b50f2 by Victor Stinner in branch 'default':
Backout ab500b297900: the check for integer overflow is wrong
http://hg.python.org/cpython/rev/01581e8b50f2
--
___
New submission from STINNER Victor victor.stin...@gmail.com:
Since 7be716a47e9d (issue #14716), str.format() uses the unicode_writer API.
I propose to continue the work in this direction to avoid more temporary
buffers.
Python 3.3:
100 loops, best of 3: 0.573 usec per loop
10 loops,
STINNER Victor victor.stin...@gmail.com added the comment:
Comments on the patch.
-PyAPI_FUNC(PyObject *) _PyComplex_FormatAdvanced(PyObject *obj,
+PyAPI_FUNC(int) _PyComplex_FormatWriter(PyObject *obj,
Even if it is a private function, I prefer to rename it because its API does
change.
/*
New submission from Arfrever Frehtes Taifersar Arahesis
arfrever@gmail.com:
$ python3.2 -c 'open(/dev/null, w).read()'
Traceback (most recent call last):
File string, line 1, in module
io.UnsupportedOperation: not readable
$ python3.3 -c 'open(/dev/null, w).read()'
Traceback (most recent
New submission from Larry Hastings la...@hastings.org:
There's code like this in skipitem() in Python/getargs.c:
case 'b': /* byte -- very short int */
/* ... a zillion more case statements here ... */
case 'C': /* unicode char */
case 'p': /* boolean predicate */
{
Roger Serwy roger.se...@gmail.com added the comment:
Ctrl+Z followed by Return still exits the Python shell on the command prompt
under Vista.
The simplest way to get this behavior working in IDLE would be modifying the
end-of-file definition in config-keys.def, but only for the Windows
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 2cd9dadd5c6c by Benjamin Peterson in branch 'default':
explicitly set UnsupportedOperation's module rather than relying on incorrect
globals on startup (closes #14745)
http://hg.python.org/cpython/rev/2cd9dadd5c6c
Roger Serwy roger.se...@gmail.com added the comment:
Attached is an initial diff for creating a separate pager window by using a
textView widget. The recently applied patch in issue964437 allows this window
to be non-modal, which can be useful for interactive development.
The diff contains
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +skip.montanaro
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14732
___
___
Python-bugs-list
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14654
___
___
Python-bugs-list
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +eric.araujo, orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9374
___
___
Changes by Zhiping Deng kofreesty...@gmail.com:
--
nosy: +Zhiping.Deng
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5557
___
___
Python-bugs-list
Éric Araujo mer...@netwok.org added the comment:
Clearly +1 to Antoine; that’s just how unix programs do it. stdout is for the
program output, which may be formatted in a certain way in order to be piped to
another program, and stderr is for all messages for the human user. Editing
the bug
Changes by Éric Araujo mer...@netwok.org:
--
keywords: +needs review
nosy: +georg.brandl
stage: - test needed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14743
___
Changes by Éric Araujo mer...@netwok.org:
--
versions: -Python 2.6, Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14565
___
___
New submission from Alex Grönholm alex.gronholm+pyt...@nextday.fi:
Apparently they worked in 1.0a3 but not in 1.0a4 anymore.
--
assignee: eric.araujo
components: Distutils2
messages: 160184
nosy: agronholm, alexis, eric.araujo, tarek
priority: normal
severity: normal
status: open
title:
Serhiy Storchaka storch...@gmail.com added the comment:
See issue14738 for advanced optimization.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14654
___
Serhiy Storchaka storch...@gmail.com added the comment:
If this patch is accepted, it's more to go even deeper: use _PyUnicodeWriter
in long_to_decimal_string() for example.
long_to_decimal_string() is already creates a string of known size. How
_PyUnicodeWriter can help here?
Issue3451
88 matches
Mail list logo
