[issue15151] Documentation for Signature, Parameter and signature in inspect module

2012-07-16 Thread Yury Selivanov
Yury Selivanov added the comment: Larry, Brett, I compiled the documentation from the PEP (attached as inspect.pep362.1.patch). Please take a look and feel free to add/edit. -- keywords: +patch Added file: http://bugs.python.org/file26410/inspect.pep362.1.patch _

[issue14988] _elementtree: Raise ImportError when importing of pyexpat fails

2012-07-16 Thread Arfrever Frehtes Taifersar Arahesis
Arfrever Frehtes Taifersar Arahesis added the comment: > Did it happen to raise ImportError historically and only recent > changes made it RuntimeError? I'm not sure this is the case. ImportError was raised in Python 2. -- ___ Python tracker

[issue14988] _elementtree: Raise ImportError when importing of pyexpat fails

2012-07-16 Thread Eli Bendersky
Eli Bendersky added the comment: Benjamin, what "old behavior"? Did it happen to raise ImportError historically and only recent changes made it RuntimeError? I'm not sure this is the case. -- ___ Python tracker

[issue14988] _elementtree: Raise ImportError when importing of pyexpat fails

2012-07-16 Thread Eli Bendersky
Eli Bendersky added the comment: I tried blocking the import of 'pyexpat' in a test by using test.support.import_fresh_module, placing 'pyexpat' into the blocked list, but it doesn't work (i.e. pyexpat, if it exists, is still imported) -- ___ Pytho

[issue14332] Better explain "junk" concept in difflib doc

2012-07-16 Thread Eli Bendersky
Eli Bendersky added the comment: I agree. Any improvement is preferred over just letting this decay in the issue tracker ;-) -- ___ Python tracker ___ _

[issue15368] bytecode generation is not deterministic

2012-07-16 Thread Meador Inge
Meador Inge added the comment: I haven't done any benchmarking (yet), but here is a patch implementing the basic sorting approach. -- keywords: +patch Added file: http://bugs.python.org/file26409/issue15368-v0.patch ___ Python tracker

[issue1767933] Badly formed XML using etree and utf-16

2012-07-16 Thread Eli Bendersky
Eli Bendersky added the comment: I posted a message to python-dev about the performance issue -- ___ Python tracker ___ ___ Python-

[issue15374] venv environment variable should follow the conventions

2012-07-16 Thread Carl Meyer
Carl Meyer added the comment: Yes, there are a number of third-party utility packages (and many, many e.g. personal custom bash prompts) that check the value of the $VIRTUAL_ENV variable to detect whether one is currently active, and display its name. Unless there's an overriding reason, it w

[issue1767933] Badly formed XML using etree and utf-16

2012-07-16 Thread Eli Bendersky
Eli Bendersky added the comment: Fixed the invariant violation in changeset 64ff90e07d71 I'll review the performance difference separately -- ___ Python tracker ___ _

[issue15375] Trivial for fix in the subprocess documentation

2012-07-16 Thread R. David Murray
R. David Murray added the comment: Thanks. (This error existed on only in the 2.7 docs.) -- nosy: +r.david.murray resolution: -> fixed stage: -> committed/rejected status: open -> closed type: enhancement -> behavior ___ Python tracker

[issue15375] Trivial for fix in the subprocess documentation

2012-07-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset 227a22288688 by R David Murray in branch '2.7': #15375: remove duplicated word 'child' http://hg.python.org/cpython/rev/227a22288688 -- nosy: +python-dev ___ Python tracker

[issue15375] Trivial for fix in the subprocess documentation

2012-07-16 Thread Renato Cunha
New submission from Renato Cunha : The word "child" is needlessly repeated in the subprocess documentation. This trivial patch fixes this. -- assignee: docs@python components: Documentation files: subprocess.diff keywords: patch messages: 165670 nosy: docs@python, trovao priority: norma

[issue15374] venv environment variable should follow the conventions

2012-07-16 Thread Vinay Sajip
Vinay Sajip added the comment: > Which means that these third-party projects are automatically > compatible with pyvenv? I can't speak for them, but it's one less thing for people to have to change. The intention certainly was to minimise friction in this area. I would be interested in Carl's

[issue6804] IDLE: Detect Python files even if name doesn't end in .py

2012-07-16 Thread Roger Serwy
Roger Serwy added the comment: Is the error message a traceback? If so, could you open a separate issue for it? -- ___ Python tracker ___

[issue15374] venv environment variable should follow the conventions

2012-07-16 Thread Antoine Pitrou
Antoine Pitrou added the comment: > This name was picked because the virtualenv tool uses it, and keeping > the name allows any existing third-party projects and scripts which > use it to require minimal, if any, changes. Which means that these third-party projects are automatically compatible

[issue15374] venv environment variable should follow the conventions

2012-07-16 Thread Vinay Sajip
Vinay Sajip added the comment: This name was picked because the virtualenv tool uses it, and keeping the name allows any existing third-party projects and scripts which use it to require minimal, if any, changes. -- ___ Python tracker

[issue14635] telnetlib uses select instead of poll - limited to FD_SETSIZE fds

2012-07-16 Thread Gregory P. Smith
Gregory P. Smith added the comment: Those should all be fixed as of my most recent commit. -- ___ Python tracker ___ ___ Python-bugs-

[issue15364] sysconfig confused by relative paths

2012-07-16 Thread Richard Oudkerk
Richard Oudkerk added the comment: In the attached patch _safe_realpath() is only called after calculating the absolute path for srcdir. -- keywords: +patch Added file: http://bugs.python.org/file26407/sysconf.patch ___ Python tracker

[issue1492704] distinct error type if shutil.copyfile() fails because of src and dst are the same file

2012-07-16 Thread Atsuo Ishimoto
Atsuo Ishimoto added the comment: Patch updated. - SameFileError is reverted to be derived from shutil.Error as original patch. -- Added file: http://bugs.python.org/file26406/issue1492704_new_3.patch ___ Python tracker

[issue4130] Intel icc 9.1 does not support __int128_t used by ctypes

2012-07-16 Thread Alex Leach
Alex Leach added the comment: That's the same patch as I attached before actually, so sorry for the spam.. -- ___ Python tracker ___ _

[issue4130] Intel icc 9.1 does not support __int128_t used by ctypes

2012-07-16 Thread Alex Leach
Alex Leach added the comment: It skips 55, sorry, passing 1659. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue4130] Intel icc 9.1 does not support __int128_t used by ctypes

2012-07-16 Thread Alex Leach
Alex Leach added the comment: I just had a dig around my cpython build dir, and found an ffi64.c I hacked at a while back. I copied the edits over to the latest libffi git revision, rebuilt, and `make check` (of libffi) passes all tests. So as far as I can tell the below patch works, but it

[issue6493] Can not set value for structure members larger than 32 bits

2012-07-16 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- assignee: theller -> components: +Library (Lib), Windows nosy: +meador.inge stage: commit review -> patch review versions: +Python 3.3 -Python 3.1 ___ Python tracker _

[issue6493] Can not set value for structure members larger than 32 bits

2012-07-16 Thread HCT
HCT added the comment: Hirokazu's v3 patch is a clean solution for the issue and works on 3.2 any update on when it will go into 3.2/3.3? I can help if needed -- nosy: +hct ___ Python tracker

[issue6804] IDLE: Detect Python files even if name doesn't end in .py

2012-07-16 Thread Daniel Swanson
Daniel Swanson added the comment: I am also somewhat puzzled by this issue. The other day I was able to open some .txt files just to see if I could and they opened just fine. Just now I tryed to open a .jpg file and I got an error message, but then again, why would someone save a python file a

[issue15184] Test failure in test_sysconfig_module

2012-07-16 Thread Ned Deily
Changes by Ned Deily : Removed file: http://bugs.python.org/file26163/issue15184_preserve_config_vars.patch ___ Python tracker ___ ___ Python

[issue15184] Test failure in test_sysconfig_module

2012-07-16 Thread Ned Deily
Ned Deily added the comment: Georg, are you still able to reproduce this? I've subsequently tried on a Debian platform with an installed clang and could not reproduce. And, after further inspecting the current code, I really don't see how the clang substitution could happen on a non-darwin p

[issue15230] runpy.run_path doesn't set __package__ correctly

2012-07-16 Thread Antoine Pitrou
Antoine Pitrou added the comment: This broke some 3.2 buildbots, e.g.: http://buildbot.python.org/all/builders/AMD64%20Lion%203.2/builds/25 -- nosy: +pitrou status: closed -> open ___ Python tracker __

[issue15351] Add to unittest.TestCase support for using context managers

2012-07-16 Thread Chris Jerdonek
Chris Jerdonek added the comment: Attached is a patch illustrating the API I suggested for discussion. To add custom setup and teardown context managers, the user can override the following method: def executeTest(self): with self.setUpContext(): self.runTestMethod()

[issue15364] sysconfig confused by relative paths

2012-07-16 Thread Chris Jerdonek
Chris Jerdonek added the comment: Issue 15322 is a recently filed bug regarding srcdir: "sysconfig.get_config_var('srcdir') returns unexpected value" -- nosy: +cjerdonek ___ Python tracker ___

[issue15171] Fix 64-bit building for buildbot scripts (3.2)

2012-07-16 Thread Antoine Pitrou
Antoine Pitrou added the comment: David, since you are here, perhaps you could take a look at why your Windows 7 buildbot doesn't compile? http://buildbot.python.org/all/builders/x86%20Windows7%203.x I tried to e-mail you but apparently you didn't receive the message. --

[issue15373] copy.copy() does not properly copy os.environment

2012-07-16 Thread Anton Barkovsky
Anton Barkovsky added the comment: A new patch with tests. -- Added file: http://bugs.python.org/file26404/environcopy_v2.patch ___ Python tracker ___ __

[issue15314] Use importlib instead of pkgutil in runpy

2012-07-16 Thread Antoine Pitrou
Antoine Pitrou added the comment: A test fails on the XP buildbots: == FAIL: test_get_importer_avoids_emulation (test.test_pkgutil.ImportlibMigrationTests)

[issue14635] telnetlib uses select instead of poll - limited to FD_SETSIZE fds

2012-07-16 Thread Antoine Pitrou
Antoine Pitrou added the comment: This broke the buildbots without poll() (Windows). -- ___ Python tracker ___ ___ Python-bugs-list m

[issue15171] Fix 64-bit building for buildbot scripts (3.2)

2012-07-16 Thread David Bolen
David Bolen added the comment: It seems really unlikely to be related to this issue since I'm pretty sure build-amd64 doesn't get used on XP-4. >From the log it looks like it couldn't clean out and reuse the VS temporary >build directory. Manually cleaning it out and restarting the last buil

[issue15307] Patch for --symlink support in pyvenv with framework python

2012-07-16 Thread Ned Deily
Ned Deily added the comment: v7 looks good to me -- stage: -> commit review ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue15373] copy.copy() does not properly copy os.environment

2012-07-16 Thread Anton Barkovsky
Anton Barkovsky added the comment: Here's a patch. -- keywords: +patch nosy: +anton.barkovsky Added file: http://bugs.python.org/file26403/environcopy.patch ___ Python tracker _

[issue14201] Documented caching for shared library's __getattr__ and __getitem__ is incorrect

2012-07-16 Thread Erik Johansson
Erik Johansson added the comment: Document the difference between __getattr__ and __getitem__. -- keywords: +patch Added file: http://bugs.python.org/file26402/issue14201.patch ___ Python tracker _

[issue15374] venv environment variable should follow the conventions

2012-07-16 Thread Antoine Pitrou
New submission from Antoine Pitrou : pyvenv's environment variable is currently named VIRTUAL_ENV (it seems). It would be better if it followed the trend of other Python environment variables such as PYTHONHOME, PYTHONSTARTUP, etc. (so, PYTHONVENV ?) Setting as deferred blocker, since it would

[issue15372] Python is missing alternative for common quoting character

2012-07-16 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue15372] Python is missing alternative for common quoting character

2012-07-16 Thread Matthew Barnett
Matthew Barnett added the comment: A codepoint such as "é" ("\N{LATIN SMALL LETTER E WITH ACUTE}") can be decomposed to "\u0065\u0301" ("\N{LATIN SMALL LETTER E}\N{COMBINING ACUTE ACCENT"), but "\u201c" ("\N{LEFT DOUBLE QUOTATION MARK}") and "\u201d" ("\N{RIGHT DOUBLE QUOTATION MARK}") cannot

[issue15367] build_ext in a venv on Windows assumes pyconfig.h in sys.exec_prefix + '\PC'

2012-07-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset a970054a93fb by Vinay Sajip in branch 'default': Closes #15367: Corrected computation of include locations for source builds on Windows. Thanks to Richard Oudkerk for the bug report and patch. http://hg.python.org/cpython/rev/a970054a93fb

[issue15366] venv assumes header files in sys._home + '/Include'

2012-07-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset 998c8a8f2aea by Vinay Sajip in branch 'default': Closes #15366: Corrected computation of include location for source builds. Thanks to Richard Oudkerk for the bug report and patch. http://hg.python.org/cpython/rev/998c8a8f2aea -- nosy: +py

[issue15368] bytecode generation is not deterministic

2012-07-16 Thread Brett Cannon
Brett Cannon added the comment: OK, so it sounds like we need to do the equivalent of sorting those tuples when generating the bytecode. That would suggest that probably need to tweak Python/compile.c to make it deterministic. -- ___ Python tracker

[issue504714] hasattr catches only AttributeError

2012-07-16 Thread Karl Chen
Karl Chen added the comment: For the record, this was eventually fixed for Python 3.2. See http://bugs.python.org/issue9666. Adding this here because issue504714 comes up earlier than issue9666 in many web searches. -- nosy: +quarl ___ Python tra

[issue1492704] distinct error type if shutil.copyfile() fails because of src and dst are the same file

2012-07-16 Thread Hynek Schlawack
Hynek Schlawack added the comment: No, sorry if my ramblings confused you. I'm pondering about deriving Error from OSError in 3.4. That has nothing to do with this ticket. I just saw it while glancing over your patch. -- ___ Python tracker

[issue1492704] distinct error type if shutil.copyfile() fails because of src and dst are the same file

2012-07-16 Thread Atsuo Ishimoto
Atsuo Ishimoto added the comment: >> - SameFileError is now derived from EnvironmentError. > >Why? oh, sorry, I misunderstood you suggested to do so. -- ___ Python tracker __

[issue15373] copy.copy() does not properly copy os.environment

2012-07-16 Thread R. David Murray
R. David Murray added the comment: os.environ is not a dictionary, so it isn't all that surprising that a shallow copy doesn't behave like a shallow copy of a dictionary. deepcopy does what you'd expect, as does os.environ.copy(). Perhaps it is worth improving this by adding a __copy__ metho

[issue15372] Python is missing alternative for common quoting character

2012-07-16 Thread R. David Murray
R. David Murray added the comment: I don't understand why you would expect to get a ". The unicode characters aren't "s. As far as I can see (from, for example, http://codepoints.net/U+201C), Python is behaving as expected here. -- nosy: +r.david.murray resolution: -> invalid stage

[issue1492704] distinct error type if shutil.copyfile() fails because of src and dst are the same file

2012-07-16 Thread Hynek Schlawack
Hynek Schlawack added the comment: > - SameFileError is now derived from EnvironmentError. Why? -- ___ Python tracker ___ ___ Pyth

[issue15364] sysconfig confused by relative paths

2012-07-16 Thread Ronald Oussoren
Ronald Oussoren added the comment: srcdir vs. project base is quite easy: srcdir is the directory containing the source files, the project base is where you ran configure. These are the same if you run configure in the root of a checkout, but don't have to be, for example when you do: $ mkdi

[issue15364] sysconfig confused by relative paths

2012-07-16 Thread Éric Araujo
Éric Araujo added the comment: I have to add that I’m quite confused by srcdir vs. projectbase. There are a handful of open bugs related to sysconfig and built but uninstalled Pythons, and many commits changing code to use srcdir or projectbase after empirical testing or buildbot failures. :

[issue15364] sysconfig confused by relative paths

2012-07-16 Thread Éric Araujo
Éric Araujo added the comment: It is actually simple to find the revision: http://hg.python.org/lookup/r81999 :) -- ___ Python tracker ___ _

[issue15373] copy.copy() does not properly copy os.environment

2012-07-16 Thread Hartmut Goebel
New submission from Hartmut Goebel : Wehn copying os.environ usinf copy.copy(), any manipulation on the copied object will change os.environment, too. $ python Python 2.7.3 (default, Apr 22 2012, 07:46:58) [GCC 4.6.3] on linux2 Type "help", "copyright", "credits" or "license" for more informat

[issue15372] Python is missing alternative for common quoting character

2012-07-16 Thread Luca Fabbri
New submission from Luca Fabbri : Using the unicodedata.decomposition function on characters like \u201c and \u201d I didn't get back the classic quote character ("). This is a very common error when text is taken from Microsoft Word (where in italian language a couple of quoting character in

[issue1492704] distinct error type if shutil.copyfile() fails because of src and dst are the same file

2012-07-16 Thread Atsuo Ishimoto
Atsuo Ishimoto added the comment: Patch updated. - SameFileError is now derived from EnvironmentError. - Fixed documentation. - Fixed test method name. I investigated this patch: - shutil.copyfile() and shutil.copy() raises SameFileError if source and destination are same file. - shutil.mov

[issue15364] sysconfig confused by relative paths

2012-07-16 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue15364] sysconfig confused by relative paths

2012-07-16 Thread Richard Oudkerk
Richard Oudkerk added the comment: > I don't recall what the issue was the resulted in the check-in that you > mention. I think it was http://bugs.python.org/issue8577. The issue was about having srcdir != builddir. The initial patch caused a test failure, and 356d0ea8ea34 fixed (or at leas

[issue14787] pkgutil.walk_packages returns extra modules

2012-07-16 Thread Chris Jerdonek
Chris Jerdonek added the comment: > This isn't an easy one to fix - you basically need something along the lines > of a PEP 406 style import engine API in order to do the import without having > potentially adverse effects on the state in the sys module. By adverse, do you just mean side effe

[issue15238] shutil.copystat should copy Linux extended attributes

2012-07-16 Thread Hynek Schlawack
Hynek Schlawack added the comment: I removed the check for good as we check for the existence of the xattr in the next line. However we check the destination now whether the xattrs have been copied. ;) Fedora is green again. -- ___ Python tracker

[issue15367] build_ext in a venv on Windows assumes pyconfig.h in sys.exec_prefix + '\PC'

2012-07-16 Thread Richard Oudkerk
Richard Oudkerk added the comment: Updated patch which does not fail test_distutils. -- Added file: http://bugs.python.org/file26400/build_ext.patch ___ Python tracker ___ _

[issue15366] venv assumes header files in sys._home + '/Include'

2012-07-16 Thread Richard Oudkerk
Richard Oudkerk added the comment: Updated patch. Old one broke test_distutils... -- Added file: http://bugs.python.org/file26399/distutils-sysconfig.patch ___ Python tracker _

[issue15238] shutil.copystat should copy Linux extended attributes

2012-07-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset 265e36e277f3 by Hynek Schlawack in branch 'default': #15238: Fix xattr related shutil.copystat tests http://hg.python.org/cpython/rev/265e36e277f3 -- ___ Python tracker

[issue11698] Improve repr for structseq objects to show named, but unindexed fields

2012-07-16 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue15368] bytecode generation is not deterministic

2012-07-16 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue15352] importlib.h should be regenerated when the marshaling code changes

2012-07-16 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue15238] shutil.copystat should copy Linux extended attributes

2012-07-16 Thread Larry Hastings
Larry Hastings added the comment: Hynek, it's clear you understand this far better than I do. Could I get you to fix the Fedora buildbot problem, etc, etc? -- ___ Python tracker _

[issue15368] bytecode generation is not deterministic

2012-07-16 Thread Antoine Pitrou
Antoine Pitrou added the comment: Ditto. I think predictability of bytecode generation is useful, e.g. for make-like tools that examine content, or for unit testing. -- nosy: +pitrou ___ Python tracker __

[issue15364] sysconfig confused by relative paths

2012-07-16 Thread Ronald Oussoren
Ronald Oussoren added the comment: I don't recall what the issue was the resulted in the check-in that you mention. Sadly enough it is not-trivial to find that check-in I mention due to the migration from Subversion to Mercurial. How was python itself configured (configure command line)? What

[issue15368] bytecode generation is not deterministic

2012-07-16 Thread Nick Coghlan
Nick Coghlan added the comment: At least we know the hash randomisation is working :) Spurious changes when freezing modules seems like a legitimate reason to fix it - the import benchmarks would probably give the compiler enough of a workout to highlight if the sorting is excessively time co

[issue14787] pkgutil.walk_packages returns extra modules

2012-07-16 Thread Nick Coghlan
Nick Coghlan added the comment: I just realised this is going to behave strangely with namespace packages as well: the __import__ step will pick up *every* portion of the namespace package, not just those defined in the identified subset of sys.path. -- __

[issue15358] Test pkgutil.walk_packages in test_pkgutil instead of test_runpy

2012-07-16 Thread Nick Coghlan
Nick Coghlan added the comment: Note that the problem described in #14787 will limit the scope of what can be tested. -- ___ Python tracker ___

[issue15358] Test pkgutil.walk_packages in test_pkgutil instead of test_runpy

2012-07-16 Thread Nick Coghlan
Nick Coghlan added the comment: The walk_packages tests should also be enhanced to ensure correctly handling of namespace packages -- ___ Python tracker ___ ___

[issue15368] bytecode generation is not deterministic

2012-07-16 Thread Florent Xicluna
Changes by Florent Xicluna : -- nosy: +flox ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue15307] Patch for --symlink support in pyvenv with framework python

2012-07-16 Thread Ronald Oussoren
Ronald Oussoren added the comment: And a final update: don't use TAB characters -- Added file: http://bugs.python.org/file26398/venv-symlinks-v7.txt ___ Python tracker ___ _

[issue15371] test_cmd_line_script should include namespace package tests

2012-07-16 Thread Nick Coghlan
New submission from Nick Coghlan : test_cmd_line_script doesn't currently check that namespace packages and submodules of namespace packages can be executed via the -m switch -- components: Library (Lib) messages: 165614 nosy: ncoghlan priority: normal severity: normal status: open titl

[issue15370] test_runpy should include namespace package tests

2012-07-16 Thread Nick Coghlan
New submission from Nick Coghlan : test_runpy doesn't currently check that code can be correctly executed from namespace packages -- components: Tests messages: 165613 nosy: ncoghlan priority: normal severity: normal status: open title: test_runpy should include namespace package tests

[issue14787] pkgutil.walk_packages returns extra modules

2012-07-16 Thread Nick Coghlan
Nick Coghlan added the comment: At the very least, the pkgutil docs need to state clearly that walk_packages only works properly with sys.path entries, and the constraint feature may not descend into packages correctly if an entry is shadowed by a sys.modules entry or an entry earlier on sys.

[issue1492704] distinct error type if shutil.copyfile() fails because of src and dst are the same file

2012-07-16 Thread Atsuo Ishimoto
Atsuo Ishimoto added the comment: Ooops, shutil.move() will raise SameFileError if destination is directory. I'll investigate the patch further more. -- ___ Python tracker __

[issue1492704] distinct error type if shutil.copyfile() fails because of src and dst are the same file

2012-07-16 Thread Hynek Schlawack
Hynek Schlawack added the comment: Sorry, I didn’t look at zooko’s patch which was also just about copyfile. I presume it’s all about the copy fallback that happens when os.rename didn’t work out. Will look at your code more closely later. -- title: distinct error type from shutil.mo

[issue15368] bytecode generation is not deterministic

2012-07-16 Thread Mark Dickinson
Changes by Mark Dickinson : -- nosy: +mark.dickinson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue1492704] distinct error type from shutil.move()

2012-07-16 Thread Atsuo Ishimoto
Atsuo Ishimoto added the comment: Well, I happy to improve patch. But, on Linux and Windows, shutil.move() does not raise any exception if source and destination are identical. If we change the behavior, I'm afraid we would break a lot of existing applications. -- _

[issue1492704] distinct error type from shutil.move()

2012-07-16 Thread Hynek Schlawack
Hynek Schlawack added the comment: Well, then fix is for shutil.move() too please, otherwise we can’t close this ticket which is a pity after over 6 years. :) -- ___ Python tracker __

[issue1492704] distinct error type from shutil.move()

2012-07-16 Thread Atsuo Ishimoto
Atsuo Ishimoto added the comment: So, the title of this issue is misleading. The patch originally proposed by Zooko does not raise SameFileError in shutil.move(). If source and destination is same file, shutil.move() may raise exception, but the exception is NOT SameFileError but OSError or so

[issue1492704] distinct error type from shutil.move()

2012-07-16 Thread Hynek Schlawack
Hynek Schlawack added the comment: If nobody else, I’ll review it tomorrow at the latest. On a first glance I realized our shutil Exceptions are all derived from EnvironmentError which is just a compatibility alias for OSError since 3.3. Quick poll before I open a dedicated ticket, change tha

[issue14787] pkgutil.walk_packages returns extra modules

2012-07-16 Thread Nick Coghlan
Nick Coghlan added the comment: Right, this is a separate bug in pkgutil. Specifically, when it goes to import a package in order to check it for submodules, it invokes the global import system via __import__() rather than constraining the import to the path argument supplied to walk_packages

[issue1492704] distinct error type from shutil.move()

2012-07-16 Thread Atsuo Ishimoto
Atsuo Ishimoto added the comment: Behavior is not changed at all. I fixed test_shutil.py to test if SameFileError is raised in shutil.copy() instead of shutil.move(). -- ___ Python tracker _

[issue15369] pybench and test.pystone poorly documented

2012-07-16 Thread Florent Xicluna
New submission from Florent Xicluna : The benchmarking tools "pystones" and "pybench" which are shipped with the Python standard distribution are not documented. The only information is in the what's-new for Python 2.5: http://docs.python.org/dev/whatsnew/2.5.html?highlight=pybench#new-improved

[issue9102] pybench: Cannot compare 2.x and 3.x benchmarks

2012-07-16 Thread Florent Xicluna
Changes by Florent Xicluna : -- versions: +Python 3.4 -Python 3.2 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue14644] test_logging failure on OS X Tiger

2012-07-16 Thread Ronald Oussoren
Ronald Oussoren added the comment: I get failures for the same test on my machine running OSX 10.7, the machine is fairly overloaded right now because I'm running a large VM in the background. Increasing the timeout from 5.0 to 15.0 seconds ensures that the test passes. -- nosy: +rona

[issue15368] bytecode generation is not deterministic

2012-07-16 Thread Meador Inge
Meador Inge added the comment: On Mon, Jul 16, 2012 at 8:11 AM, Brett Cannon wrote: > I might come to regret asking this, but so what? Is this actually causing you > issues, > or are you literally just finding "this behavior surprising" and that's it? I noticed it in the context of working o

[issue15368] bytecode generation is not deterministic

2012-07-16 Thread Brett Cannon
Brett Cannon added the comment: I might come to regret asking this, but so what? Is this actually causing you issues, or are you literally just finding "this behavior surprising" and that's it? I mean we could simply sort the tuples, but I don't know what kind of performance hit that would ca

[issue1492704] distinct error type from shutil.move()

2012-07-16 Thread Éric Araujo
Éric Araujo added the comment: Thanks. Can you clarify what behavior changed compared to the previous patch? From the doc it looks like shutil.move now always raises SameFileError, whereas the previous patch said that on Unix it depended on the semantics of os.rename. The patch has some ver

[issue15366] venv assumes header files in sys._home + '/Include'

2012-07-16 Thread Richard Oudkerk
Richard Oudkerk added the comment: The attached patch seems to fix the problem. -- keywords: +patch Added file: http://bugs.python.org/file26397/distutils-sysconfig.patch ___ Python tracker ___

[issue15352] importlib.h should be regenerated when the marshaling code changes

2012-07-16 Thread Meador Inge
Meador Inge added the comment: On Mon, Jul 16, 2012 at 7:13 AM, Antoine Pitrou wrote: > I don't know, but you could open an issue just for the record. > People may be surprised if bytecode generation isn't deterministic. Yeah, I was somewhat surprised and it took some digging to figure out ex

[issue15368] bytecode generation is not deterministic

2012-07-16 Thread Meador Inge
New submission from Meador Inge : Consider this small example (you might have to run sample program multiple times to see a difference): $ cat dis-closure.py import dis def adder(a, b): def add(): return a + b return add print(dis.dis(adder(1, 2).__code__)) $ ./python.exe di

[issue15352] importlib.h should be regenerated when the marshaling code changes

2012-07-16 Thread Meador Inge
Meador Inge added the comment: On Mon, Jul 16, 2012 at 5:20 AM, Antoine Pitrou wrote: >> Anyway, I am hitting another problem now -- _freeze_importlib is *not* >> idempotent. > > What do you mean with "idempotent"? Deterministic? Whoops, yeah, deterministic. I got mixed up with my terminolo

[issue15307] Patch for --symlink support in pyvenv with framework python

2012-07-16 Thread Ronald Oussoren
Ronald Oussoren added the comment: The test failure in test_osx_env is in itself fairly harmless because PYTHONEXECUTABLE is only used to ensure IDLE.app works correct, and IDLE.app doesn't use the pythonw executable and hence won't hit the code that special-cases the venv location. That sai

[issue15367] build_ext in a venv on Windows assumes pyconfig.h in sys.exec_prefix + '\PC'

2012-07-16 Thread Richard Oudkerk
Richard Oudkerk added the comment: The attached patch works for me. -- keywords: +patch Added file: http://bugs.python.org/file26395/build_ext.patch ___ Python tracker ___ _

[issue1492704] distinct error type from shutil.move()

2012-07-16 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +hynek ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

  1   2   >