Martin v. Löwis added the comment:
-1. test.support is not at all too large for a single module; there is no point
in refactoring it.
Without a specific patch to review which proposes some specific change, I'm
rejecting this change request.
--
nosy: +loewis
resolution: - rejected
Catherine Devlin added the comment:
Needed to update the patch slightly for Python 3; now that filter() returns an
iterator, ``do_help``'s call to
names = self.get_names()
followed by
names.sort()
was throwing an error, so I changed get_names to return a list.
--
nosy:
Serhiy Storchaka added the comment:
Antoine, it looks like you committed the wrong patch for 3.3. Patches for 3.2
and 3.3 are different, otherwise I would have provided a one patch.
-basesize = support.calcobjsize('P2PP2PP')
+basesize = support.calcobjsize('P2nN2Pn')
Catherine Devlin added the comment:
Change to test_cmd.py to test for help displaying the name of the registered
subcommand (as well as a simple test for the basic operation of the registered
sub-CLI).
--
Added file: http://bugs.python.org/file26594/test_cmd.patch
Tim Golden added the comment:
This is a (near) duplicate of issue7443, I think.
--
nosy: +tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15496
___
New submission from Ned Deily:
getpath.c uses three OS X APIs that have been producing deprecation warnings
since at least OS X 10.5: NSModuleForSymbol, NSLookupAndBindSymbol, and
NSLibraryNameForModule. We should figure out how to live without them.
--
assignee: ronaldoussoren
Nick Coghlan added the comment:
Martin, this change has been specifically requested by me to better organise
all the support code that ISN'T in test.support.
That file is already huge, and I'm not going to make it even bigger with all
the test infrastructure needed for generating packaging
Serhiy Storchaka added the comment:
For the PyAccu, AFAICT, objects cannot leak out of it (except for
gc.getobjects in debug mode).
Not only in debug mode.
import io, gc
s=io.StringIO()
s.write('12345')
5
s.write('qwerty')
6
for o in gc.get_objects():
... if '123 in repr(o) and
Mark Dickinson added the comment:
How many extra warnings do you get by adding these flags (e.g., just by doing
'export CFLAGS= ...' before building)? It might be useful to see a sampling of
those warnings.
The addition of these flags should be conditional on gcc's version being =
4.3: gcc
Atsuo Ishimoto added the comment:
patch contains fix and test for 2.7.
With this patch, AttibuteError is captured as Tim sujested.
--
keywords: +patch
nosy: +ishimoto
Added file: http://bugs.python.org/file26595/issue15267.patch
___
Python tracker
Martin v. Löwis added the comment:
For the PyAccu, AFAICT, objects cannot leak out of it (except for
gc.getobjects in debug mode).
Not only in debug mode.
I see. I meant sys.getobjects, which is in debug mode only, but
I now see that gc.get_objects will get the list (but not the strings)
Roundup Robot added the comment:
New changeset f96579debefa by Ned Deily in branch 'default':
Issue #14018: Fix OS X Tcl/Tk framework checking when using OS X SDKs.
http://hg.python.org/cpython/rev/f96579debefa
--
nosy: +python-dev
___
Python tracker
Seamus McKenna added the comment:
Thankyou for update. Script was not using 100% cpu. I will add SMTP timeout
and increase debuglevel() within the function should this reoccur.
--
status: open - closed
___
Python tracker rep...@bugs.python.org
Martin v. Löwis added the comment:
So who is going to provide a patch for it, and when?
I don't think the tracker is the right place to keep list of things that
someone wants to do some day. There isn't an issue Python should have a JIT,
either. Tracker issues should be actionable at the time
Nick Coghlan added the comment:
As noted in the original post, this is a change which will be made once the 3.3
release is out the door. It's origin lies in the fact that one of the new
pkgutil tests currently lives in test_runpy because test_runpy has much better
infrastructure for that kind
Changes by Nick Coghlan ncogh...@gmail.com:
--
dependencies: +Move test/support.py into a test.support subpackage
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15403
___
Changes by Nick Coghlan ncogh...@gmail.com:
--
assignee: - ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15376
___
___
Python-bugs-list
Changes by Nick Coghlan ncogh...@gmail.com:
--
dependencies: +Add temp_dir() and change_cwd() to test.support
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15376
___
Changes by Nick Coghlan ncogh...@gmail.com:
--
assignee: - ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15358
___
___
Python-bugs-list
Nick Coghlan added the comment:
I've just gone through and made sure all the related issues are correctly
assigned to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15494
___
Roundup Robot added the comment:
New changeset 7232d544c811 by Ned Deily in branch '2.7':
Issue #14018: Update the OS X IDLE Tcl/Tk warning check to include
http://hg.python.org/cpython/rev/7232d544c811
New changeset 17ddc0c34d9d by Ned Deily in branch '3.2':
Issue #14018: Update the OS X IDLE
Changes by Martin v. Löwis mar...@v.loewis.de:
--
versions: -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15494
___
___
Changes by Martin v. Löwis mar...@v.loewis.de:
--
versions: +Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15494
___
___
Nick Coghlan added the comment:
OK, after a bit of experimentation, it appears both 3.2 and 3.3 eventually get
annoyed if you mess about too much with __pycache__.
1. They're both fine if __pycache__ is entirely unwritable (they just silently
skip caching the bytecode)
2. 3.2 throws EOFError
Roundup Robot added the comment:
New changeset ff7fc6a91212 by Victor Stinner in branch 'default':
Issue #15463: the faulthandler module truncates strings to 500 characters,
http://hg.python.org/cpython/rev/ff7fc6a91212
--
nosy: +python-dev
___
Changes by Anton Barkovsky swarmer...@gmail.com:
--
nosy: +anton.barkovsky
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14966
___
___
New submission from Anton Barkovsky:
webbrowser.UnixBrowser._invoke will sleep for at least 1 second after
launching browser process and then probably 4 more seconds. These numbers
are hardcoded and can't be modified which is especially problematic for
testing.
I think this code should be
STINNER Victor added the comment:
Issue #15463: the faulthandler module truncates strings to 500 characters,
It should be able for most setup. See the issue #15479 if you consider that
something better should be implemented.
Long path names are handled differently on each platform, I don't
Roundup Robot added the comment:
New changeset e0eb7dea245f by Ned Deily in branch '2.7':
Issue #14018: Fix OS X Tcl/Tk framework checking when using OS X SDKs.
http://hg.python.org/cpython/rev/e0eb7dea245f
New changeset eb0af7f6ea6d by Ned Deily in branch '3.2':
Issue #14018: Fix OS X Tcl/Tk
Nick Coghlan added the comment:
Looking at the actual code - I don't think it actually makes sense to strip the
frames in this case. Unlike the previous examples, it only comes up if someone
is doing something deliberately pathological, at which point a little noise in
the traceback is the
Changes by Nick Coghlan ncogh...@gmail.com:
Removed file:
http://bugs.python.org/file26573/issue15486_simplify_importlib_frame_removal.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15486
___
Chris Jerdonek added the comment:
Shouldn't a test be added to check that the issue has been fixed though (i.e. a
test with a path longer than the original 100 characters)?
I provided a patch to show how this can easily be done.
I would be happy to write the test.
--
Ned Deily added the comment:
The SDK test in setup.py has been extended to include files in
/Library/Frameworks (see OS X ld man page). The test in IDLE
to issue a warning message about unstable Tcl/Tk versions was
updated to include the Apple-supplied Tcl/Tk 8.5 in OS X 10.7
and 10.8. All of
STINNER Victor added the comment:
I provided a patch to show how this can easily be done.
Your patch does not create a path longer than 100 characters. I didn't want to
write such test, but I can review a patch adding such test.
The limit is not only applied on the filename, but also on the
Ned Deily added the comment:
BTW, the applied patch does fix the problem originally reported. Thanks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15463
___
Chris Jerdonek added the comment:
I didn't want to write such test, but I can review a patch adding such test.
Thank you. I will provide a patch for your review.
I think a test for the path may be better as that was the original issue
experienced.
--
Antoine Pitrou added the comment:
Ah, but the BytesIO structure is the same in 3.2 and 3.3. Ok, that's because
struct now has support for size_t and Py_ssize_t, I see.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15489
Roundup Robot added the comment:
New changeset e77c117ab024 by Antoine Pitrou in branch 'default':
Better test for BytesIO.__sizeof__, now that the struct module supports
(s)size_t.
http://hg.python.org/cpython/rev/e77c117ab024
--
___
Python tracker
Antoine Pitrou added the comment:
For some reason the new tests fail on the XP buildbots.
--
status: closed - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15425
___
Christian Heimes added the comment:
I'm getting more than thousand warnings:
$ CFLAGS=-Wconversion -Wno-sign-conversion ./configure
$ LC_ALL=C make -s -j8 21 | tee log
$ grep Wconversion log | wc -l
1163
platform: Ubuntu 12.04 x86_64
gcc: 4.6.3
--
nosy: +christian.heimes
New submission from Attila Nagy:
Python class Thread has a name argument, which sets the name of the given
thread. This name is used only internally, while there is a possibility to set
this on an OS-level.
Related discussion:
Christian Heimes added the comment:
Right now major parts of the buffer API are broken for non-trivial buffer
definitions. IMHO a backport of the fix doesn't count as a new feature although
it needs some new internal functions.
I don't quite understand why Nick thinks that ABI compatibility
Jeremy Kloth added the comment:
This is a (near) duplicate of issue7443, I think.
Partially so it seems. However, my testing with Process Monitor (from
sysinterals) shows that most of the access denied errors occur when
removing directories.
The blind rename-remove dance doesn't work when
Jeremy Kloth added the comment:
I'm getting more than thousand warnings:
$ CFLAGS=-Wconversion -Wno-sign-conversion ./configure
$ LC_ALL=C make -s -j8 21 | tee log
$ grep Wconversion log | wc -l
1163
My Win64 buildbot currentlyhas 544 conversion warnings, but it seems
something has
Nick Coghlan added the comment:
I was musing about backporting *all* the memoryview fixes, including the buffer
lifecycle ones. Antoine and Stefan rightly pointed out that was a bad idea, and
not necessary to address this problem.
So +1 for backporting just this specific fix, with the
New submission from Anton Barkovsky:
Exception classes from subprocess module are mentioned in the doc but do
not have their own entries.
I'm attaching patches for 3.3, 3.2 and 2.7
This issue supersedes #14966.
--
assignee: docs@python
components: Documentation
files:
Changes by Anton Barkovsky swarmer...@gmail.com:
Added file: http://bugs.python.org/file26599/subprocess_doc_3.2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15501
___
Changes by Anton Barkovsky swarmer...@gmail.com:
Added file: http://bugs.python.org/file26600/subprocess_doc_2.7.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15501
___
Nick Coghlan added the comment:
Ah, the perils of email readers with quote folding and issue trackers without
it. The important part of Brett's email is that PEP 420 has started splitting
the meta path finder and path entry finder APIs, but importlib still uses a
single ABC for both of them.
New submission from Nick Coghlan:
In the review of #15295, Brett noted that the APIs of meta path finders and
path entry finders have now diverged substantially thanks to PEP 420, thus it's
rather dubious that they continue to share a single Finder ABC in importlib.
--
components:
Nick Coghlan added the comment:
#15502 records Brett concern about the merged ABC
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15295
___
___
Chris Jerdonek added the comment:
Attaching patch with test case for long script path.
This test failed on my system before the fix and passes after.
--
Added file: http://bugs.python.org/file26601/issue-15463-2.patch
___
Python tracker
Changes by Eric V. Smith e...@trueblade.com:
--
nosy: +eric.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15502
___
___
Python-bugs-list
Anton Barkovsky added the comment:
An updated patch with the same issue fixed in Konqueror class.
--
Added file: http://bugs.python.org/file26602/fileclose_devnull_v2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15447
New submission from Petri Heinilä:
In concatenating string in dict somehow radically depends the added string size.
code
import timeit
s1 =
text =
for i in range(1,5):
text += 12345678901234567890
print(str cat 20: {0}s.format(timeit.timeit(s1,number=1)))
s2 =
d = dict()
Chris Jerdonek added the comment:
Is it okay for me to reopen this issue to review the patch to add a test case
for file paths longer than 100 characters, or should I create a new issue for
that?
--
___
Python tracker rep...@bugs.python.org
Changes by Atsuo Ishimoto ishim...@gembook.org:
--
nosy: +ishimoto
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1610654
___
___
Python-bugs-list
Alex Gaynor added the comment:
Actually, I would argue that it's concatentation of a local variable which has
unexpected performance. Logically it should be O(n**2), however due to hacks in
CPython it isn't.
--
nosy: +alex
___
Python tracker
Serhiy Storchaka added the comment:
Yes, the total time of repeated string concatenation is O(N**2). s3 is twice
larger s2, therefore s3 time about twice large s2 time.
In the first case Python use a special optimization which allows O(N) in some
cases. You can deactivate it:
s5 =
text =
Changes by Atsuo Ishimoto ishim...@gembook.org:
--
nosy: +ishimoto
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8847
___
___
Python-bugs-list
Changes by Atsuo Ishimoto ishim...@gembook.org:
--
nosy: +ishimoto
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14302
___
___
Python-bugs-list
Antoine Pitrou added the comment:
It's a FAQ entry:
http://docs.python.org/dev/faq/programming.html#what-is-the-most-efficient-way-to-concatenate-many-strings-together
--
nosy: +pitrou
resolution: - wont fix
status: open - closed
___
Python tracker
Changes by Atsuo Ishimoto ishim...@gembook.org:
--
nosy: +ishimoto
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6132
___
___
Python-bugs-list
Changes by Atsuo Ishimoto ishim...@gembook.org:
--
nosy: +ishimoto
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7671
___
___
Python-bugs-list
Changes by Atsuo Ishimoto ishim...@gembook.org:
--
nosy: +ishimoto
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4722
___
___
Python-bugs-list
Changes by Atsuo Ishimoto ishim...@gembook.org:
--
nosy: +ishimoto
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7686
___
___
Python-bugs-list
New submission from Philipp Lies:
I just stumbled upon a very serious bug in cPickle where cPickle stores the
data passed to it only partially without a warning/error:
#creating a 8GB long random data sting
import os
import cPickle
random_string = os.urandom(int(1.1*2**33))
print
Changes by STINNER Victor victor.stin...@gmail.com:
--
resolution: fixed -
status: closed - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15463
___
Antoine Pitrou added the comment:
For some reasons I was able to reproduce under 64-bit Windows with the 3.3b1
official build, but neither with my own VS9.0-compiled build, nor with the 3.2
official build.
To reproduce:
class T(tuple): pass
...
t = T((1,2))
[] + t
(1, 2)
[3,] + t
# crash
Antoine Pitrou added the comment:
The exact same issue happens when concatenating a list subclass to a tuple:
() + L([1,2])
[1, 2]
(3,) + L([1,2])
# crash
Also, note that in this case a list is returned, not a tuple despite the first
operand being a tuple. Conversely:
[] + T((1,2))
(1, 2)
Georg Brandl added the comment:
Raising priority. This should be investigated properly before 3.3 final.
--
nosy: +georg.brandl
priority: high - deferred blocker
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8847
New submission from Thomas Wouters:
unittest.installHandler incorrectly assumes signal.SIGINT will always be set to
a callable object, rather than signal.SIG_DFL or signal.SIG_IGN. This breaks if
the test is being executed in an environment that e.g. ignores signal.SIGINT,
like a bash script
Martin v. Löwis added the comment:
People can probably debate endless about seriousness of an issue. Keep in mind
that two factors affect seriousness: what's the impact when it happens (here it
is quite bad), and what's the chance that it happens (it's quite low, since
it requires you to
Changes by Terry J. Reedy tjre...@udel.edu:
--
nosy: +ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8847
___
___
Python-bugs-list mailing
Roundup Robot added the comment:
New changeset fd5166fdb978 by Andrew Svetlov in branch '3.2':
Issue #12288: Consider '0' and '0.0' as valid initialvalue for tkinter
SimpleDialog.
http://hg.python.org/cpython/rev/fd5166fdb978
New changeset 2f3ccf4ec193 by Andrew Svetlov in branch 'default':
Georg Brandl added the comment:
Looks good and simplifies things. Green light :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15486
___
___
Andrew Svetlov added the comment:
Fixed. Thank you, Tom.
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12288
___
New submission from Mike Frysinger:
the current configure script open codes the pkg-config look up:
AC_PATH_TOOL([PKG_CONFIG], [pkg-config])
rather than using the standard macro from pkg-config's own pkg.m4:
PKG_PROG_PKG_CONFIG
this causes the build env to not operate exactly like other
Thomas Wouters added the comment:
Patch attached.
--
keywords: +patch
stage: - patch review
Added file: http://bugs.python.org/file26604/inthandler.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15505
Stefan Krah added the comment:
Right now major parts of the buffer API are broken for non-trivial
buffer definitions. IMHO a backport of the fix doesn't count as a new
feature although it needs some new internal functions.
This particular bug fix for PyBuffer_ToContiguous() (which would
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13555
___
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15504
___
Changes by Antoine Pitrou pit...@free.fr:
--
versions: +Python 3.4 -Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15500
___
___
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15506
___
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15500
___
Daniel Holth added the comment:
Taking a second look it is pretty good.
The only other thing that might be worth mentioning explicitly is that the
always present hashes don't actually use OpenSSL.
Constructors for hash algorithms that are always present in this module are
md5(), sha1(),
Changes by Gregory P. Smith g...@krypto.org:
--
assignee: - gregory.p.smith
keywords: +needs review
nosy: +gregory.p.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15505
___
Changes by Andrew Svetlov andrew.svet...@gmail.com:
--
assignee: - asvetlov
nosy: +asvetlov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9803
___
Gregory P. Smith added the comment:
The always present hashes do use openssl if the openssl version hashlib was
compiled against supports them. otherwise it falls back to the builtin C
implementations.
--
___
Python tracker rep...@bugs.python.org
New submission from Thomas Wouters:
test_subprocess's test_send_signal assumes SIGINT is not being ignored, by
spawning a new process and expecting it to have the default SIGINT handler .
SIGINT can be set to SIG_IGN if the process running the test inherited it from
the parent process.
Changes by Alex Gaynor alex.gay...@gmail.com:
--
nosy: +alex
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8847
___
___
Python-bugs-list mailing
Thomas Wouters added the comment:
Patch attached to (briefly) set signal.SIGINT to the default in the test.
It may make sense to add a feature to subprocess.Popen to ignore/unignore
signals (it should only need to support SIG_DFL and SIG_IGN, not other signal
handlers, considering there'll be
Barry A. Warsaw added the comment:
Thanks for the review Eric. I'm slogging through these and many other
comments, but I now have the docs integrated with trunk, and will probably
land them for better or worse in the next day or so.
I'll respond just to a few of your comments. Whatever I omit
Éric Araujo added the comment:
A small note in passing: “protocol” is used for things like the sequence
protocol, the iterator protocol, or closer to home the finder and loader
protocols, so it would sound weird or potentially confusing to me. Import
system is how I’ve always thought about
New submission from Arfrever Frehtes Taifersar Arahesis:
$ python3.2 -c '__import__(os, level=-1)'
$ python3.3 -c '__import__(os, level=-1)'
Traceback (most recent call last):
File string, line 1, in module
ValueError: level must be = 0
$ python3.3 -c 'print(__import__.__doc__)'
Brett Cannon added the comment:
To answer a couple of Barry's comments in reply to Eric...
__package__ should be set to the empty string if I'm reading PEP 362 correctly
(and importlib isn't broken): When the import system encounters an explicit
relative import in a module without __package__
Changes by Brett Cannon br...@python.org:
--
assignee: - brett.cannon
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15508
Roundup Robot added the comment:
New changeset 2a4ca86cc2b7 by Brett Cannon in branch 'default':
Issue #15508: Fix the docstring for __import__ to not mention negative
http://hg.python.org/cpython/rev/2a4ca86cc2b7
--
nosy: +python-dev
___
Python
Arfrever Frehtes Taifersar Arahesis added the comment:
What about the suggested change in Doc/library/functions.rst?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15508
___
Stefan Krah added the comment:
I can reproduce this exclusively with the pgupdate build:
msbuild PCbuild\pcbuild.sln /p:Configuration=PGInstrument /p:Platform=win32
msbuild PCbuild\pcbuild.sln /p:Configuration=PGUpdate /p:Platform=win32
PCbuild\Win32-pgo\python.exe
Python 3.3.0b1 (default, Jul
1 - 100 of 136 matches
Mail list logo
