Bruno Dupuis added the comment:
I don't agree. Trash build logs are bad, trash code (I mean, in terms of
utility, not quality :-) ) is far worst IMHO.
The purpose of this bug, to me, is to try to find a neat way to suppress the
warnings without touching the code, and if we can't, wich is
Sebastian Kraft added the comment:
Contribution agreement is now attached to my account. So the review can start ;)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16525
___
Serhiy Storchaka added the comment:
I added comments in Rietveld.
--
components: +Tests
versions: +Python 3.3, Python 3.4 -Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1739648
Changes by Daniel Urban urban.dani...@gmail.com:
--
stage: - patch review
type: crash - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16584
___
Serhiy Storchaka added the comment:
The patches look good to me, except that `self.assertIn('mod1.py', names)` can
be used instead `self.assertTrue('mod1.py' in names)`.
--
nosy: +alanmcintyre, serhiy.storchaka
stage: - commit review
versions: +Python 3.2, Python 3.3, Python 3.4
Serhiy Storchaka added the comment:
Here is a patch for 3.4, which adds checks for other unpacks (except one, for
which issue14315 exists). Also BadZipfile replaced by BadZipFile and trailing
whitespaces deleted.
For 2.7 BadZipFile should be replaced by BadZipfile back.
--
stage: -
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10712
___
___
New submission from mindrones:
Hi,
at http://docs.python.org/2.7/library/pprint.html#pprint.PrettyPrinter we see:
class pprint.PrettyPrinter(...)
while at http://docs.python.org/3.3/library/pprint.html#pprint.PrettyPrinter we
see:
class pprint.PrettyPrinter(indent=1, width=80, depth=None,
Roundup Robot added the comment:
New changeset 62fed5f18681 by Ezio Melotti in branch '2.7':
#16589: fix pprint signatures in the doc (backport of 106ee4eb5970).
http://hg.python.org/cpython/rev/62fed5f18681
--
nosy: +python-dev
___
Python tracker
Ezio Melotti added the comment:
Fixed, thanks for the report!
--
assignee: docs@python - ezio.melotti
nosy: +ezio.melotti
resolution: - fixed
stage: - committed/rejected
status: open - closed
type: - enhancement
___
Python tracker
New submission from Serhiy Storchaka:
Modules/_json.c contains workarounds for Python versions 2.6. Now this code is
not needed and can be safely dropped.
This patch moved from issue16586.
--
components: Extension Modules
files: json_size_t_cleanup.patch
keywords: patch
messages:
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16590
___
___
Python-bugs-list
Roundup Robot added the comment:
New changeset 2c04d2102534 by Antoine Pitrou in branch 'default':
Issue #16590: remove obsolete compatibility code from the _json module.
http://hg.python.org/cpython/rev/2c04d2102534
--
nosy: +python-dev
___
Python
Antoine Pitrou added the comment:
Thank you :)
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16590
___
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file28171/json_size_t_cleanup.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16586
___
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file28172/json_size_t_cleanup-2.7.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16586
___
Serhiy Storchaka added the comment:
Dustin, what version of 2.7 do you use? What python2.7 -V says?
Please someone run on self-built 64-bit Python 2.7 something like (this should
require a little greater than 2GB of memory):
python -c import json; json.loads('[%22s' % ']')
I
Chris Jerdonek added the comment:
From PEP 1: If the PEP author is a Python developer, assign the bug/patch to
him, otherwise assign it to the [a] PEP editor.
Given that the list is small, something else that might make sense is adding a
PEP editors area to the Experts Index in the devguide.
Chris Jerdonek added the comment:
Btw, I will prepare a patch that incorporates the information that Barry
provided.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16581
___
New submission from Fabian Groffen:
Python fails to run python.exe on OSX when a non-framework build is requested,
due to wrong quoting in configure.ac.
Like all other RUNSHARED, it shouldn't be quoted because then `pwd` won't be
expanded, resulting in a wrong DYLD_LIBRARY_PATH when regen is
Dustin Boswell added the comment:
Python 2.7.3 (default, Aug 3 2012, 20:01:21)
[GCC 4.4.3] on linux2
Type help, copyright, credits or license for more information.
import sys;print(%x % sys.maxsize, sys.maxsize 2**32)
('7fff', True)
--
Serhiy Storchaka added the comment:
LGTM. However note, that for 2.7 the patch should be modified (maxsize -
maxint, range - xrange).
--
nosy: +serhiy.storchaka
stage: needs patch - commit review
versions: +Python 3.4
___
Python tracker
Dustin Boswell added the comment:
Yes, bug exists on 3.1 (gcc build), as well as darwin build of 2.7:
python3.1 -c import json; json.loads('[%22s' % ']')
Traceback (most recent call last):
File string, line 1, in module
File /usr/lib/python3.1/json/__init__.py, line 293, in loads
Serhiy Storchaka added the comment:
As Antoine Pitrou reported on IRC, this bug exists on 3.x. Sorry, but this bug
can't be fixed on 2.6 and 3.1.
--
versions: +Python 3.2, Python 3.3, Python 3.4 -Python 3.1
___
Python tracker rep...@bugs.python.org
Bradley Froehle added the comment:
Bikeshedding, but the fixer name of 'asserts' bugs me. I'd suggest 'unittest'
or 'unittest_asserts'.
--
nosy: +bfroehle
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10712
Antoine Pitrou added the comment:
Actually, this isn't a problem in _json.c but in the re library:
JSONDecoder.raw_decode() works fine, but JSONDecoder.decode() raises:
$ ./python -c import json.decoder;
print(json.decoder.JSONDecoder().raw_decode('[%22s' % ']'))
([], 220001)
$
Serhiy Storchaka added the comment:
Uh, this is issue10182.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16586
___
___
Python-bugs-list
Antoine Pitrou added the comment:
Uh, this is issue10182.
Indeed, the patch there seems to fix it.
--
resolution: - duplicate
stage: needs patch - committed/rejected
status: open - closed
superseder: - match_start truncates large values
___
Antoine Pitrou added the comment:
Actually, we now have a 64-bit big endian buildbot and it does not show any
test failure:
http://buildbot.python.org/all/builders/SPARC%20Solaris%2010%20%28cc%2C%2064b%29%20%5BSB%5D%203.x
[...]
checking size of int... 4
checking size of long... 8
checking size
Éric Araujo added the comment:
Any reason to not backport this?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9650
___
___
Python-bugs-list
Benjamin Peterson added the comment:
Looks fine, though. Make sure to add docs to library/2to3.rst.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10712
___
Serhiy Storchaka added the comment:
Here is a test.
--
Added file: http://bugs.python.org/file28181/buildvalue_overflow_tests.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10182
___
New submission from Antoine Pitrou:
l = [b''] * (100*1024*1024)
[104918914 refs]
d = b''.join(l)
Traceback (most recent call last):
File stdin, line 1, in module
SystemError: error return without exception set
(you'll have to adjust the list size based on your system memory size)
New submission from Daniel Shahaf:
FreeBSD make sets $$MAKEFLAGS differently than GNU make does. Attached patch
updates Makefile.pre.in to recognise that syntax too.
Preliminary versions discussed with Crys on #python-dev.
--
components: Build
messages: 176768
nosy: danielsh
Changes by Daniel Shahaf pyt...@danielsh.fastmail.net:
--
keywords: +patch
Added file: http://bugs.python.org/file28182/makedashs.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16593
___
Christian Heimes added the comment:
Thanks for your patch!
Crys
--
nosy: +christian.heimes
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16593
Roundup Robot added the comment:
New changeset 9af5a2611202 by Christian Heimes in branch 'default':
Issue #16592: stringlib_bytes_join doesn't raise MemoryError on allocation
failure
http://hg.python.org/cpython/rev/9af5a2611202
--
nosy: +python-dev
Christian Heimes added the comment:
Antoine, on Unix you can restrict the address space of a program to test the
issue without almost crashing and OOMing your box. ;)
import resource
resource.setrlimit(resource.RLIMIT_AS, (1024*1024*100, 1024*1024*100))
l = [b''] * (100*1024*70)
d =
Éric Araujo added the comment:
Adding Raymond, who thinks super is super, to the nosy list.
http://rhettinger.wordpress.com/2011/05/26/super-considered-super/
--
nosy: +eric.araujo, rhettinger
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset ceb325fdd54e by Christian Heimes in branch '3.2':
- Issue #16593: Have BSD 'make -s' do the right thing, thanks to Daniel Shahaf
http://hg.python.org/cpython/rev/ceb325fdd54e
New changeset 323f0aeba89d by Christian Heimes in branch '3.3':
Issue
Roundup Robot added the comment:
New changeset 280469ce6669 by Christian Heimes in branch '3.2':
Issue #16588: Silence unused-but-set warnings in Python/thread_pthread.h
http://hg.python.org/cpython/rev/280469ce6669
New changeset 470785a9fdd5 by Christian Heimes in branch '3.3':
Issue #16588:
Christian Heimes added the comment:
Jesús, I've used a slightly different comment in my patch.
Python 3.3 and 3.4 now compile the core and modules without any warnings. 3.2
still has some warnings.
--
nosy: +christian.heimes
resolution: - fixed
stage: patch review -
danblack added the comment:
Antoine Pitrou (pitrou) * Date: 2012-10-06 13:10
Daniel, I'll take a look.
minor nag :-)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8109
___
43 matches
Mail list logo