Марк Коренберг added the comment:
Ups. hiding EOFHeaderError is not an error.
But handilng of other errors is not perfect. Please review TarFile.next() for
cases where .tar file is corrupted. For example,
TruncatedHeaderError is re-raised only if problem at the start of the file.
Really, it
Changes by Ned Deily n...@acm.org:
--
nosy: +lars.gustaebel
versions: -Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16858
___
___
Changes by Ned Deily n...@acm.org:
--
nosy: +lars.gustaebel
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16859
___
___
Python-bugs-list mailing
Serhiy Storchaka added the comment:
Here is a patch.
--
assignee: - serhiy.storchaka
components: +Unicode
keywords: +3.3regression, patch
nosy: +ezio.melotti, serhiy.storchaka
stage: - patch review
Added file: http://bugs.python.org/file28555/unicode_append.patch
Christian Heimes added the comment:
IMO the check is better performed a couple of lines later:
if (right == NULL || left == NULL || !PyUnicode_Check(left)) {
--
nosy: +christian.heimes
___
Python tracker rep...@bugs.python.org
Christian Heimes added the comment:
+1
I think it's sufficient to parallelize the compilation step (.c - .o) and
ignore the linker step. Linking is usually so fast that it doesn't matter.
Idea:
* separate compile step from link step
* run all compile calls for all extensions in parallel until
Stefan Krah added the comment:
Daniel Shahaf rep...@bugs.python.org wrote:
Is there a requirement that it loads a particular module? Would etree
users notice the difference if pickle.load() returns an instance of the
other Element implementation than the one they pickled?
Yes: If you send
Roundup Robot added the comment:
New changeset b0926ddcab5e by Serhiy Storchaka in branch 'default':
Issue #16674: random.getrandbits() is now 20-40% faster for small integers.
http://hg.python.org/cpython/rev/b0926ddcab5e
--
nosy: +python-dev
___
Nico Möller added the comment:
I most definitely need a patch for 2.7.3
Would be awesome if you could provide a patch for that version.
--
nosy: +Nico.Möller
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9720
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16674
Kushal Das added the comment:
The patches look good. Applied successfully and tests ran ok.
--
nosy: +kushaldas
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16799
___
Roundup Robot added the comment:
New changeset 3cee61137598 by Serhiy Storchaka in branch '3.3':
Issue #16856: Fix a segmentation fault from calling repr() on a dict with
http://hg.python.org/cpython/rev/3cee61137598
New changeset fee4bc043d73 by Serhiy Storchaka in branch 'default':
Issue
Serhiy Storchaka added the comment:
IMO the check is better performed a couple of lines later:
Done.
Thank you for report, David.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker
Roundup Robot added the comment:
New changeset dea89ee34402 by Chris Jerdonek in branch '2.7':
Issue #16747: Reflow iterable glossary entry to match 3.x change e19ed347523e.
http://hg.python.org/cpython/rev/dea89ee34402
--
___
Python tracker
Charles-François Natali added the comment:
Here's a new version adressing Guido's comments (except for kqueue, for which
I'll add support later when I can test it).
I'm also attaching a benchmark to compare the implementations: as noted by
Guido, the complexity of select/poll/epoll are the
Changes by Charles-François Natali neolo...@free.fr:
Added file: http://bugs.python.org/file28557/selector_bench.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16853
___
Changes by Charles-François Natali neolo...@free.fr:
Removed file: http://bugs.python.org/file28553/selector-1.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16853
___
Serhiy Storchaka added the comment:
Here are second variant patches for 2.7 and 3.2.
--
Added file: http://bugs.python.org/file28558/zipfile_zip64_try_2-2.7.patch
Added file: http://bugs.python.org/file28559/zipfile_zip64_try_2-3.2.patch
___
Python
Charles-François Natali added the comment:
Windows provides O_NOINHERIT (_O_NOINHERIT) flag which has a similar purpose.
... and even then, many Unices don't support it.
Yes, but I bet that more and more OSes will support it :-) For example, it
looks like O_CLOEXEC is part of the POSIX
Changes by Christian Heimes li...@cheimes.de:
--
nosy: +christian.heimes
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16853
___
___
STINNER Victor added the comment:
So if we expose it and the underlying operating system doesn't support
it, do you want to fallback to fcntl (which wouldb't be atomic
anymore, but let's pretend the GIL protection is enough).
At the beginning, I was convinced that the atomicity was important
Charles-François Natali added the comment:
O_CLOEXEC solves for example a race condition in tempfile._mkstemp_inner():
fd = _os.open(file, flags, 0o600)
_set_cloexec(fd)
Hum...
diff --git a/Lib/tempfile.py b/Lib/tempfile.py
--- a/Lib/tempfile.py
+++
New submission from STINNER Victor:
os.O_CLOEXEC has been added to Python 3.3. This flag solves a race condition if
the process is forked between open() and a call to fcntl() to set the
FD_CLOEXEC flag.
The following patch written by neologix should fix this issue:
diff --git
STINNER Victor added the comment:
We should probably add this to 3.3 and default (IIRC O_CLOEXEC was
added to the os module in 3.3).
I created the issue #16860. I just realized that tempfile doesn't use open()
but os.open(), so this issue help to fix #16860.
--
STINNER Victor added the comment:
See also #16850 which proposes to expose O_CLOEXEC feature in the open()
builtin function.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16860
___
Charles-François Natali added the comment:
Here's the patch.
It also removes O_NOFOLLOW, which is basically useless (if the file is created
with O_CREAT|O_EXCL, then by definition it's not a symlink).
--
keywords: +needs review, patch
type: - behavior
Added file:
STINNER Victor added the comment:
Here is a work-in-progress patch to test my idea: add e flag to open().
Limitations/TODO:
* The unit test doesn't work on Windows (it requires fcntl)
* e mode and the opener argument are exclusive: if O_CLOEXEC and
O_NOINHERINT are missing, I don't see how
Tshepang Lekhonkhobe added the comment:
thanks
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16857
___
___
Python-bugs-list mailing list
STINNER Victor added the comment:
Here's the patch.
_set_cloexec() is still called whereas it is useless if the OS supports
O_CLOEXEC... But the call must be kept because Linux 2.6.23 just ignores
O_CLOEXEC: we would have to check _fcntl.fcntl(fd, _fcntl.F_GETFD, 0)
_fcntl.FD_CLOEXEC to
Charles-François Natali added the comment:
Brian, could you add tests to Lib/test/test_socket.py (look for CANTest, you
should be able to complete them).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15359
Nick Coghlan added the comment:
Updated issue title to better describe the symptoms of the issue (and hopefully
make it so I don't spend 5 minutes remembering the issue title every time I
want to look at it...)
--
title: Bug in code dispatching based on internal slots - Incorrect
Eli Bendersky added the comment:
On Jan 4, 2013 2:09 AM, Stefan Krah rep...@bugs.python.org wrote:
Stefan Krah added the comment:
Daniel Shahaf rep...@bugs.python.org wrote:
Is there a requirement that it loads a particular module? Would etree
users notice the difference if
Changes by Serhiy Storchaka storch...@gmail.com:
--
status: open - pending
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14807
___
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
components: +Interpreter Core
type: resource usage - performance
versions: +Python 3.4 -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9685
Todd Rovito added the comment:
A ping on this bug since it has not had any forward movement. Can somebody
please review and or commit? Thanks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5066
Changes by Serhiy Storchaka storch...@gmail.com:
--
components: +Tests -Library (Lib)
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12018
___
___
New submission from Ramchandra Apte:
In
http://docs.python.org/2/library/collections.html#namedtuple-factory-function-for-tuples-with-named-fields
, a portion of the code example is not highlighted.
---
Happy, new, melodious, joyful, etc, boring new year.
--
assignee: - docs@python
Changes by Ramchandra Apte maniandra...@gmail.com:
--
nosy: ramchandra.apte
priority: normal
severity: normal
status: open
title: Portion of code example not highlighted in collections doc
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
See also issue16550.
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9267
___
___
Ronald Oussoren added the comment:
There are tests for samefile and sameopenfile in test_genericpath.GenericTest
which is included by test_ntpath (NtCommonTest subclasses
test_genericpath.CommonTest which again subclasses GenericTest).
I cannot easily test on Windows (the only windows systems
Brian Curtin added the comment:
That's true of the default branch due to some changes I recently made in the
implementation of the functions, but we should probably put tests into 3.2/3.3.
--
___
Python tracker rep...@bugs.python.org
New submission from Ramchandra Apte:
The FAQ says It’s [Stackless] still experimental but looks very promising.
AFAIK, Stackless is mature.
--
assignee: docs@python
components: Documentation
messages: 179038
nosy: docs@python, ramchandra.apte
priority: normal
severity: normal
status:
Ramchandra Apte added the comment:
Sorry, link here,
http://docs.python.org/3/faq/design.html#can-t-you-emulate-threads-in-the-interpreter-instead-of-relying-on-an-os-specific-thread-implementation
.
--
___
Python tracker rep...@bugs.python.org
Giampaolo Rodola' added the comment:
Previous issue should have been fixed by now.
Closing.
--
status: pending - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14807
___
New submission from Charlie Dimino:
http://docs.python.org/2/howto/argparse.html
Error message in the first example is outdated, may indicate further out of
date information on page.
Example:
The tutorial says:
prog.py: error: the following arguments are required: echo
When the actual error
Guido van Rossum added the comment:
Would it make sense to explore this in the Tulip project first? It could be a
new module, tulip/selector.py. (Heck, I'll even give you commit privileges in
Tulip.)
Also, I've heard (but don't know from personal experience) that Jython supports
select but
R. David Murray added the comment:
Ah, the whole tutorial is newish. So this is a bug just in the 2.7 version of
the tutorial (it doesn't match the 2.7 code), and yes, there may be other
issues as well.
--
___
Python tracker rep...@bugs.python.org
R. David Murray added the comment:
Actually it looks like it is future-dated. The documented error message is the
one you get from 3.3. I guess someone backported a doc change for a feature
change.
--
nosy: +r.david.murray
___
Python tracker
R. David Murray added the comment:
See issue 14034. Ezio apparently left the error messages unchanged on
purpose...I'm not sure why.
--
assignee: docs@python -
nosy: +ezio.melotti, tshepang
___
Python tracker rep...@bugs.python.org
Antoine Pitrou added the comment:
I've posted a review on Rietveld. Not sure the notification e-mail was sent
since I got a weird response from the server.
should EINTR be handled (i.e. retry, with an updated timeout). I'm tempted to
say
yes, because EINTR is just a pain the user should
Serhiy Storchaka added the comment:
Can this issue be closed?
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10557
___
Changes by Tshepang Lekhonkhobe tshep...@gmail.com:
--
nosy: +tshepang
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16862
___
___
Ezio Melotti added the comment:
When I backported the patch I probably didn't want to try all the examples to
see what the py2 error was. In addition the py3 error is more clear even if it
doesn't match what you actually get.
I think this can be closed as won't fix, unless someone wants to
New submission from Jim Minter:
sqlite3 doesn't populate the lastrowid member of the Cursor object when a SQL
REPLACE statement is executed.
The following snippet doesn't work as I would expect:
cursor = db.execute(REPLACE INTO table(column) VALUES ('datum'))
print cursor.lastrowid # prints
Serhiy Storchaka added the comment:
See also issue16510.
--
nosy: +serhiy.storchaka
versions: +Python 3.4 -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9554
___
Ezio Melotti added the comment:
The part that is not highlighted is not part of the code, but the output of the
function.
--
nosy: +ezio.melotti
resolution: - invalid
stage: - committed/rejected
status: open - closed
type: - enhancement
___
Charlie Dimino added the comment:
If it's okay, don't close this just yet. I'm new to this system but I'll submit
a patch with any fixes to the tutorial I find.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16863
Roundup Robot added the comment:
New changeset 64883c614c88 by Charles-François Natali in branch 'default':
Issue #16860: In tempfile, use O_CLOEXEC when available to set the
http://hg.python.org/cpython/rev/64883c614c88
--
nosy: +python-dev
___
Charles-François Natali added the comment:
I've committed it only to default, since it's not really a bug, but rather an
improvement (if we did consider this a security bug then it should also be
backported to 2.7, 3.1, etc).
I'll wait a little before removing O_NOFOLLOW: I'm 99% sure it's
Changes by Serhiy Storchaka storch...@gmail.com:
--
keywords: +needs review
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12613
___
Changes by Charles-François Natali neolo...@free.fr:
--
stage: needs patch - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16836
___
Ezio Melotti added the comment:
Is the usual PEP 399 idiom enough, or is something more advanced required?
--
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16803
___
Ezio Melotti added the comment:
Feel free to add me to the nosy.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16748
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
3.1 gets only security fixes. In 2.7 and 3.2+ the bug has already fixed.
--
nosy: +serhiy.storchaka
resolution: - out of date
stage: patch review - committed/rejected
status: open - closed
___
Python tracker
R. David Murray added the comment:
Considering that sqlite's 'replace' is a synonym for 'insert or replace', I
think the logic error is actually in the detect_statement_type function. Since
actions are conditionally taken on the REPLACE statement type in the code,
including at least one that
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +serhiy.storchaka
versions: -Python 2.6
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8136
___
Zachary Ware added the comment:
Hi Todd, I can't commit, but I have a review in the works for you.
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5066
___
Brett Cannon added the comment:
With some tricky use of import_fresh_module() because importlib.__init__ does
some masking trickery, it should ... I think. =)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16803
Serhiy Storchaka added the comment:
This behavior doesn't reproduced more on 2.7 and 3.2+.
class MyInt(int):
... __pow__ = int.__add__
...
i = MyInt(42)
i**3
45
--
nosy: +serhiy.storchaka
resolution: - out of date
stage: patch review - committed/rejected
status: open - closed
Ezio Melotti added the comment:
Attached a new patch.
--
Added file: http://bugs.python.org/file28562/issue16835-3.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16835
___
Zachary Ware added the comment:
Looks good to me :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16835
___
___
Python-bugs-list mailing list
Ezio Melotti added the comment:
Attached a new patch.
--
Added file: http://bugs.python.org/file28563/issue13094-2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13094
___
Chris Jerdonek added the comment:
Thanks. Andrew, could you also take a quick look at this?
--
title: switch regrtest from getopt options to argparse Namespace - start using
argparse.Namespace in regrtest
___
Python tracker rep...@bugs.python.org
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +serhiy.storchaka
versions: +Python 3.4 -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1617161
___
Giampaolo Rodola' added the comment:
Is this currently being written from scratch? It shouldn't be IMO.
Instead I recommend using the existent Tornado or pyftpdlib IO loop as an
example:
https://github.com/facebook/tornado/tree/master/tornado/platform
Serhiy Storchaka added the comment:
The patch need be revised for 3.3+.
--
nosy: +jcea, serhiy.storchaka
versions: +Python 3.3, Python 3.4 -Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1611154
Changes by Tshepang Lekhonkhobe tshep...@gmail.com:
--
title: Argparse tutorial outdated - Python 2 error in Argparse tutorial
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16863
___
Serhiy Storchaka added the comment:
LGTM.
--
nosy: +serhiy.storchaka
stage: patch review - commit review
versions: +Python 3.3, Python 3.4 -Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6157
Serhiy Storchaka added the comment:
LGTM. However I am not sure should this issue be classified as behavior or
enhancement. Removed code is not usable in Tk versions which supported in
Python 2.7 and 3.2+ and can be removed safely.
--
nosy: +georg.brandl, serhiy.storchaka
versions:
Guido van Rossum added the comment:
Giampaolo, there are many details in the Tornado and pyftpdlib I/O loops that
may or may not be intentional. I wrote the Tulip pollster from scratch but am
looking to merge in relevant knowledge and features from Tornado, Twisted and
pyftpdlib. AFAIK the
R. David Murray added the comment:
Looks good to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13094
___
___
Python-bugs-list mailing list
Todd Rovito added the comment:
Thanks much appreciated!
Sent from my iPhone
On Jan 4, 2013, at 1:07 PM, Zachary Ware rep...@bugs.python.org wrote:
Zachary Ware added the comment:
Hi Todd, I can't commit, but I have a review in the works for you.
--
nosy: +zach.ware
Serhiy Storchaka added the comment:
It looks as v1.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16852
___
___
Python-bugs-list mailing list
Changes by Ed Campbell drescampb...@gmail.com:
--
nosy: +esc24
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16848
___
___
Python-bugs-list
Ross Lagerwall added the comment:
Interesting benchmark. There is no gain for epoll with a large number of
ready fds (as expected) but at least it is no worse than poll. Poll offers
a large improvement on select, in this case.
$ ./python selector_bench.py -r 2 -m 1000 -t pipe
Trying with 2
Charles-François Natali added the comment:
Indeed, tornado and pyftpdlib implementations are much more complex,
have somewhat different APIs (i.e. only support FDs), have special
cases for older python versions, lack some newer features (e.g.
context manager).
The current code is much close to
Brett Cannon added the comment:
LGTM as well. Feel free to commit it, Ezio, or assign to me and I will commit
it later (probably this weekend).
--
assignee: - eric.araujo
nosy: +eric.araujo
stage: patch review - commit review
___
Python tracker
Ezio Melotti added the comment:
Done in http://hg.python.org/peps/rev/3740f42d3b94, thanks for the reviews!
--
assignee: eric.araujo - ezio.melotti
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python
Charles-François Natali added the comment:
Ross, the select() result for a large number of ready FDs was completely skewed
because of a bug spotted by Antoine (complexity was much worse than it ought to
be).
Here are the results with the fix:
$ ./python ~/selector_bench.py -r 10 -m 1000 -t
Changes by Charles-François Natali neolo...@free.fr:
Removed file: http://bugs.python.org/file28556/selector-2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16853
___
Antoine Pitrou added the comment:
Here is an updated patch with cyclic GC support, and other small things.
--
components: +Library (Lib) -Extension Modules
Added file: http://bugs.python.org/file28565/sni.patch
___
Python tracker
Changes by Antoine Pitrou pit...@free.fr:
Removed file: http://bugs.python.org/file28565/sni.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8109
___
Changes by Antoine Pitrou pit...@free.fr:
Added file: http://bugs.python.org/file28566/sni.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8109
___
New submission from Jeffrey Bush:
The environment is Windows 8 Pro 64-bit running Python 64-bit in the WinPython
distribution. Python is v2.7.3 built on Apr 10 2012. I first found this with
create_string_buffer however I found out that it happens with an even simpler
example.
The following
Zachary Ware added the comment:
My apologies, I seem to have managed to rename the wrong file...
Here's the real v2 as v3, with the TestGenericTest comment pointing to this
issue instead of 16748.
--
Added file: http://bugs.python.org/file28567/issue16852.v3.diff
Changes by Zachary Ware zachary.w...@gmail.com:
--
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14187
___
___
Ross Lagerwall added the comment:
Ross, the select() result for a large number of ready FDs was
completely skewed because of a bug spotted by Antoine (complexity
was much worse than it ought to be).
Ah, that makes a little more sense now.
--
___
Martin v. Löwis added the comment:
Would you like to investigate a patch?
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16865
___
Ezio Melotti added the comment:
Note that adding support for 2GB arrays is a new feature and therefore can't
go in 2.7 (but it would be OK for 3.4+). The error message could be improved
though.
--
nosy: +amaury.forgeotdarc, belopolsky, ezio.melotti, meador.inge
Jeffrey Bush added the comment:
I have no idea where I would start and don't have much time...
I am not so sure it is a new features. It seems that the ctypes system is
internally using unsigned integers for length but should be using size_t (or at
least ssize_t). Seems like a bug.
1 - 100 of 138 matches
Mail list logo
