[issue15518] Provide test coverage for filecmp.dircmp.report methods.

2013-04-08 Thread Chris Calloway
Chris Calloway added the comment: The attached file test_filecmp_layouts.rst documents the directory and file layouts for complete test coverage of filecmp.dircmp report methods to aid in review discussion of patch. -- Added file:

[issue15518] Provide test coverage for filecmp.dircmp.report methods.

2013-04-08 Thread Chris Calloway
Chris Calloway added the comment: The attached file test_filecmp_reports.rst documents the reports generated by filecmp.dircmp test methods if the directory and file layouts in test_filecmp_layouts.rst are followed to aid in review discussion of patch. -- Added file:

[issue17670] expandtabs() weirdness

2013-04-08 Thread Ned Deily
Ned Deily added the comment: Yes, the behavior is by design. I think you are misunderstanding how exandtabs() works. The tabsize argument indicates the number of columns each tab position occupies. So, with a tabsize of 4, the tab positions occur every four columns; the tab positions are

[issue15518] Provide test coverage for filecmp.dircmp.report methods.

2013-04-08 Thread Chris Calloway
Chris Calloway added the comment: The attached patch issue-15518-1.patch replaces previous patch proposals for this issue. The patch implements the suggestion to factor code common to report TestCase classes into a common base class BaseReportTestCase. Apologies for not having that in the

[issue17669] Segfault caused by weird combination of imports and yield from

2013-04-08 Thread R. David Murray
R. David Murray added the comment: The crashing version has 'import logging' at the top of generators.py. I did not experience a crash when it was absent even if there was no __pycache__. It also doesn't crash if the import is moved out of the body of first_gen. FAULTHANDLER doesn't fair too

[issue17657] IDLE: about dialog should report the full version of TK

2013-04-08 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9b6de25c6054 by Roger Serwy in branch '2.7': #17657: Show full Tk version in IDLE's about dialog. http://hg.python.org/cpython/rev/9b6de25c6054 New changeset 769699f0a760 by Roger Serwy in branch '3.3': #17657: Show full Tk version in IDLE's about

[issue16427] Faster hash implementation

2013-04-08 Thread Raymond Hettinger
Changes by Raymond Hettinger raymond.hettin...@gmail.com: -- nosy: +rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16427 ___ ___

[issue17589] Make documentation about macros in C API explicit about rvalue vs statement

2013-04-08 Thread Larry Hastings
Larry Hastings added the comment: Amaury: I'd appreciate it if you'd bring those examples up on bug 17206. If we're going to change the semantics of Py_INCREF I'd prefer we did it with our eyes wide open. -- ___ Python tracker

[issue17657] IDLE: about dialog should report the full version of TK

2013-04-08 Thread Roger Serwy
Roger Serwy added the comment: Let's discuss improving the about dialog on idle-dev or in a new issue. Thanks for the patch, Todd! -- resolution: - fixed stage: commit review - committed/rejected status: open - closed ___ Python tracker

[issue17589] Make documentation about macros in C API explicit about rvalue vs statement

2013-04-08 Thread Larry Hastings
Larry Hastings added the comment: Oh, and, yes, it's true that Py_RETURN_NONE currently takes advantage of Py_INCREF being an rvalue, and changing Py_INCREF to a statement would break the existing implementation. But Py_RETURN_NONE itself is of necessity a statement. We would simply change

[issue17669] Segfault caused by weird combination of imports and yield from

2013-04-08 Thread Benjamin Peterson
Benjamin Peterson added the comment: This is the patch. I'll have to think about whether there's a self-contained way to test this. -- assignee: - benjamin.peterson keywords: +patch Added file: http://bugs.python.org/file29748/gen_fix.patch ___

[issue15518] Provide test coverage for filecmp.dircmp.report methods.

2013-04-08 Thread Chris Calloway
Changes by Chris Calloway c...@chriscalloway.org: Removed file: http://bugs.python.org/file29747/issue-15518-1.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15518 ___

[issue15518] Provide test coverage for filecmp.dircmp.report methods.

2013-04-08 Thread Chris Calloway
Chris Calloway added the comment: Fix calls to BaseReportTestCase methods in subclasses. Not an override so don't need super(). -- Added file: http://bugs.python.org/file29749/issue-15518-1.patch ___ Python tracker rep...@bugs.python.org

[issue17672] ssl clean shutdown

2013-04-08 Thread Hiroaki Kawai
New submission from Hiroaki Kawai: When using ssl module, I sometimes get unexpected error. The observed error varies in different situations. After the investigation, I found the reason was that ssl shutdown was not performed and sometimes RST was sent over the network instead of FIN. I

[issue17511] Idle find function closes after each find operation

2013-04-08 Thread Roger Serwy
Roger Serwy added the comment: I tried the patch against 2.7 and it appears to work, but might introduce another interface problem. The search dialog opens up as a modal window which disallows the user from changing the text. This may or may not be desirable. The technique of using the hit

[issue17672] ssl unclean shutdown

2013-04-08 Thread Hiroaki Kawai
Changes by Hiroaki Kawai hiroaki.ka...@gmail.com: -- title: ssl clean shutdown - ssl unclean shutdown ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17672 ___

[issue17668] re.split loses characters matching ungrouped parts of a pattern

2013-04-08 Thread Tomasz J. Kotarba
Tomasz J. Kotarba added the comment: Hi, I can still see one piece of functionality I have mentioned missing. Using my first example, even when one uses '^((.*))$' one cannot get ['', 'Homo sapiens catenin (cadherin-associated)', ''] as one will get a four-element list and need to deal with

[issue17648] test_urllib2 convert doctests to unittest

2013-04-08 Thread Roundup Robot
Roundup Robot added the comment: New changeset eb632aafff57 by Senthil Kumaran in branch 'default': #17648 - Clean up test_urllib2.py. Converted doctests to unittest for http://hg.python.org/cpython/rev/eb632aafff57 -- nosy: +python-dev ___ Python

[issue17648] test_urllib2 convert doctests to unittest

2013-04-08 Thread Senthil Kumaran
Senthil Kumaran added the comment: I have pushed the changes since they are restricted to test files. If there are review comments, I shall do make the changes. I shall consider to to make 3.3 tests close to default branch ones so that fixes can be backported. (Leaving the bug open for

[issue6640] urlparse should parse mailto: URL headers as query parameters

2013-04-08 Thread Senthil Kumaran
Senthil Kumaran added the comment: RFC3986 bears the weightage since urlparse aims to satisfy that. As per that, mailto should return the url as path, and current urlparse behaves properly. $ ./python.exe Python 3.4.0a0 (default:50164abbfc98+, Apr 8 2013, 22:19:34) [GCC 4.2.1 (Apple Inc.

[issue6640] urlparse should parse mailto: URL headers as query parameters

2013-04-08 Thread Senthil Kumaran
Changes by Senthil Kumaran sent...@uthcode.com: -- resolution: fixed - invalid ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6640 ___ ___

[issue12181] SIGBUS error on OpenBSD (sparc64)

2013-04-08 Thread Charles-François Natali
Charles-François Natali added the comment: New version hopefully good and ready for inclusion. Looks good to me. Since I assume you tested your patch on OpenBSD, to me it's ready for commit. I won't be able to do it myself before two weeks though, so if someone beats me to it, go ahead!

<    1   2