Vajrasky Kok added the comment:
Sorry, my bad. The tuple pluralization is correct. I read it wrongly.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18516
___
New submission from Ned Deily:
In the top-level setup.py, the code to define the Extension instance for the
xxlimited extension is currently incorrectly located near the end of
detect_tkinter() rather than in its parent detect_modules(). This has the
effect of skipping the build of xxlimited
Changes by Ned Deily n...@acm.org:
--
keywords: +patch
Added file: http://bugs.python.org/file30993/issue_X_setup_xxlimited.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18517
___
New submission from icedream91:
When I ran code below, it printed -1. The question is, the code in variable
snippet, has wrong syntax, it can't be run. I think timeit should return only
non-negative float type.
from timeit import timeit
snippet=
for i in range(10):
return -1
Mark Dickinson added the comment:
Searching around a bit, I did find a link to what looks like the actual version
of IEEE 854 online. I don't think it would be appropriate to add such a link
to the docs, though. It looks as though we'll have to settle for a reasonably
persistent link that
New submission from Ned Deily:
See for instance:
http://buildbot.python.org/all/builders/x86%20Tiger%203.x/builds/6626
I was also able to reproduce and bisect on an OS X 10.5 (Leopard) PPC system:
$ hg bisec -b
The first bad revision is:
changeset: 84704:48a869a39e2d
user:Victor
Ramchandra Apte added the comment:
Well, not sure if this is worth fixing, I think this is because timeit runs a
modified version of the code using exec(), with the actual code to be timed
within a function. (timeit runs something like this with exec():
def actual_code():
#The real code
Changes by Ramchandra Apte maniandra...@gmail.com:
--
title: return-ing within timeit.timeit causes wrong return value of
timeit.timeit - return-ing within code timed with timeit.timeit causes wrong
return value of timeit.timeit
___
Python tracker
Changes by Ramchandra Apte maniandra...@gmail.com:
--
title: timeit bug? - return-ing within timeit.timeit causes wrong return value
of timeit.timeit
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18518
Ramchandra Apte added the comment:
Hmm... once I actually created a short (50 lines) script which spell-checked
the comments. Problem is that many technical words (GCC, for example) were
marked incorrect by the spell-checker (Enchant), resulting in about 1000+
incorrectly spelled words.
Paul Moore added the comment:
Updated patch, as per discussion.
--
Added file: http://bugs.python.org/file30994/launcher_wrapper.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18491
___
Changes by Paul Moore p.f.mo...@gmail.com:
Removed file: http://bugs.python.org/file30966/launcher_wrapper.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18491
___
Roundup Robot added the comment:
New changeset 026593cbc006 by Victor Stinner in branch 'default':
Issue #18519, #18408: Fix sqlite authorizer callback
http://hg.python.org/cpython/rev/026593cbc006
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 026593cbc006 by Victor Stinner in branch 'default':
Issue #18519, #18408: Fix sqlite authorizer callback
http://hg.python.org/cpython/rev/026593cbc006
--
nosy: +python-dev
___
Python tracker
STINNER Victor added the comment:
It's not a crash, but an assertion that I added recently: it means that a
previous Python exception is not handled correctly.
The problem is that a first call to _authorizer_callback() raised a Python
exception and returned SQLITE_DENY, but sqlite called
Changes by STINNER Victor victor.stin...@gmail.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18519
___
Roundup Robot added the comment:
New changeset 276477d5a548 by Victor Stinner in branch 'default':
Issue #18520: Fix initsigs(), handle PyOS_InitInterrupts() error
http://hg.python.org/cpython/rev/276477d5a548
--
nosy: +python-dev
___
Python tracker
STINNER Victor added the comment:
PyStructSequence_InitTypeWithError() return type is void, whereas it can fail
and raise an exception. Can I change the return type, or should I create a new
function?
--
___
Python tracker rep...@bugs.python.org
New submission from Julien Nabet:
Hello,
I retrieved Cpython sources today and runned cppcheck (git updated today) on
the whole sources with enable=all
I attached the full report.
There are certainly false positive but some reports may help, eg:
[Python/getargs.c:379]: (style) Array index 'i'
Serhiy Storchaka added the comment:
-wcscpy(q+1, link);
+wcsncpy(q+1, link, MAXPATHLEN);
+argv0copy[2*MAXPATHLEN] = L'\0';
Should be `q[MAXPATHLEN] = L'\0';`. Otherwise there will be a bug when a length
of link is MAXPATHLEN.
--
nosy:
Christian Heimes added the comment:
The report contains too much noise to be useful. I suggest that you remove some
of the noise.
* get rid of The scope of the variable 'foo' can be reduced.. It's
nit-picking.
* ignore 3rd party code: Modules/_ctypes/libffi*, Modules/_sha3/keccak,
Eric V. Smith added the comment:
Your patch looks like the output of hg help, or similar.
--
nosy: +eric.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18514
___
Julien Nabet added the comment:
Here's a new version of the file after some filtering
(for the record, I used this command line:
grep -v 'The scope' cppcheck_reports.txt |grep -v 'Modules/_ctypes/libffi'
|grep -v Modules/_sha3/keccak| grep -v Modules/expat | grep -v
Modules/_decimal/libmpdec
Changes by Christian Heimes li...@cheimes.de:
Removed file: http://bugs.python.org/file30989/frombaseobj.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18514
___
Christian Heimes added the comment:
Oh, you are right ...
The patch is trivial: I switched the Py_DECREF() and return NULL lines.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18514
___
Eric V. Smith added the comment:
For some reason the blank link in the Coverity report confused me. Yes,
swapping the lines looks right.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18514
R. David Murray added the comment:
Do you understand why it was called again with the exception set? I'm worried
that there might be a change in behavior here that the tests aren't catching.
--
nosy: +r.david.murray
___
Python tracker
R. David Murray added the comment:
My expectation would be that we want the tests to be runnable (and be run, not
skipped) with Python installed, and thus we build the test module. (Whether or
not our tests actually *can* be run with Python installed is an open question,
though.) And
R. David Murray added the comment:
I'm inclined to agree with Ramchandra. It might be worth a doc footnote,
though.
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18518
Roundup Robot added the comment:
New changeset 25ffad2e12d6 by Christian Heimes in branch '3.3':
Issue #18514: Fix unreachable Py_DECREF() call in PyCData_FromBaseObj()
http://hg.python.org/cpython/rev/25ffad2e12d6
New changeset afe119a3619f by Christian Heimes in branch 'default':
Issue
Christian Heimes added the comment:
Thanks for the review
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18514
Vajrasky Kok added the comment:
Here is the patch for this ticket.
David Murray, am I on the right path? If yes, I'll put more robust tests, such
as the ones with Asian encodings and unusual encodings.
--
Added file: http://bugs.python.org/file30997/set_payload_binary.txt
Changes by Vajrasky Kok sky@speaklikeaking.com:
Removed file: http://bugs.python.org/file30997/set_payload_binary.txt
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18324
___
Vajrasky Kok added the comment:
Sorry, got typo for the last patch.
--
Added file: http://bugs.python.org/file30998/set_payload_binary.txt
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18324
R. David Murray added the comment:
It looks like you are still patching get_payload. This should be a really
simple patch against set_payload.
It occurs to me that there could be a backward compatibility concern if passing
binary to set_payload currently actually works in some cases, so we
STINNER Victor added the comment:
Before my change, the authorizer callback was called even if an exception
was raised. This is wrong, it is not how python works.
You can try with python 3.3 and an authorizer raising an exception and then
increment an attribute. If I understood correctly, the
R. David Murray added the comment:
Raised by what? I thought the callback *was* the thing raising the
exception? Are you sure you don't just need to clear the exception
if the callback function raises one?
--
___
Python tracker
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - docs@python
components: +Documentation -Library (Lib)
nosy: +docs@python
type: behavior - enhancement
versions: +Python 2.7, Python 3.4
___
Python tracker rep...@bugs.python.org
Marc Abramowitz added the comment:
I agree also that io is a good place for the basic version that doesn't do file
descriptor stuff and maybe the fancy file descriptor stuff should be a separate
issue and should go in subprocess.
To move this along and generate more discussion, I took code
Marc Abramowitz added the comment:
Oops, Nick = Brett.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15805
___
___
Python-bugs-list mailing
Mateusz Lenik added the comment:
I finally managed to find some time to clean up the script I used to compile
multiarch openssl.
The diff is available at
https://bitbucket.org/_mlen/cpython/commits/319f10362eb4b947b12750a6eb66fb622bbb0079
For 10.8 I had to comment out Tk related part and use
New submission from John Jefferies:
I'm having trouble with a raw string of r'\\?\' as in the following session:
a = r'\\?\'
File stdin, line 1
a = r'\\?\'
^
SyntaxError: EOL while scanning string literal
which seems like a bug to me. I see
Tim Peters added the comment:
As section 2.4.1. (String literals) of the Python reference manual says,
... (even a raw string cannot end in an odd number of backslashes).
Specifically, a raw string cannot end in a single backslash (since the
backslash would escape the following quote
New submission from Antoine Pitrou:
c31bec42e4112a49c192a16f271faffd5a44b83d (by Victor) seems to be the culprit.
See
http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/2188
==
ERROR: test_issue9324
Antoine Pitrou added the comment:
Indeed, you'll have to use a regular (non-raw) string literal for everything
ending up with a backslash. This part of Python's syntax probably won't be
changed.
--
nosy: +pitrou
resolution: - wont fix
status: open - closed
John Jefferies added the comment:
Yes, thankyou; I missed that. Another search reveals the issue has come up
under 11451 and 1271 at least.
John
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18522
Changes by R. Jayakrishnan raaj...@gmail.com:
--
resolution: - works for me
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18425
___
___
Michael Kleehammer added the comment:
Just wanted to chime in that I reported this to Apple and their response was
exactly this. (Perhaps Ronald works for Apple?)
Is there a temporary work around in the meantime other than rebuilding
everything?
--
nosy: +mkleehammer
Terry J. Reedy added the comment:
Resolution is for when the issue is closed, and I expect this to be closed as
'fixed'.
--
assignee: - terry.reedy
resolution: works for me -
stage: - patch review
___
Python tracker rep...@bugs.python.org
STINNER Victor added the comment:
This issue is a duplicate of #18396.
Le 21 juil. 2013 21:35, Antoine Pitrou rep...@bugs.python.org a écrit :
New submission from Antoine Pitrou:
c31bec42e4112a49c192a16f271faffd5a44b83d (by Victor) seems to be the
culprit.
See
Ned Deily added the comment:
If you are using an existing binary installation, you could disable readline
processing altogether by simply renaming the readline extension module, for
example:
cd /Library/Frameworks/Python.framework/Versions/3.3
cd ./lib/python3.3/lib-dynload
sudo mv
Terry J. Reedy added the comment:
Ronald or Ned, is the attached patch OK for Macs?
--
assignee: - terry.reedy
keywords: +patch
nosy: +ned.deily, ronaldoussoren
stage: needs patch - commit review
Added file: http://bugs.python.org/file30999/patchcheck.diff
Nick Coghlan added the comment:
A good start, but:
1. io is too low level to depend on unittest (or even contextlib), as
anything it imports will be imported automatically at interpreter startup.
The context manager will need to be written out directly as a class with
the appropriate methods.
Raymond Hettinger added the comment:
Agreed this should be closed as won't fix.
--
nosy: +rhettinger
resolution: - wont fix
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18518
Ned Deily added the comment:
Re the patch: it looks like there's a debugging print left in it. (Also, FYI,
the patch did not apply cleanly using normal Unix patch; I had to strip the \r
characters with (tr -d '\r' patchcheck.diff); also it's best to not include
Misc/NEWS changes in uploaded
Marc Abramowitz added the comment:
Thanks Nick! I'll work on applying your suggestions a little later. And I'll
add a note about it not working with subprocesses because I realized that I
forgot to do that.
Regarding redirect_stdfile, which is presumably what you meant by name-based
API, I
Raymond Hettinger added the comment:
I'm thinking that PrintRedirect is a better name because it coincides with the
intent of the primary use case. The more computer-sciency you make the name,
the more it becomes opaque to everyday users.
--
___
Roundup Robot added the comment:
New changeset 23b0164b9c82 by Terry Jan Reedy in branch '2.7':
Issue #18441: Make test.support.requires('gui') skip when it should.
http://hg.python.org/cpython/rev/23b0164b9c82
--
nosy: +python-dev
___
Python tracker
Terry J. Reedy added the comment:
I took a look. Not fun ;-).
Pending a more permanent fix, I am applying a revised patch, first to 2.7 to
make sure it works.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18441
Terry J. Reedy added the comment:
Sorry, I forgot to paste the patch diff into Notepad++ rather than Idle in
order to save it without \r. (That would be a useful option for Idle too.) Good
to know that I can forget about Classic Mac. I deleted the debug print.
--
Roundup Robot added the comment:
New changeset 26686d227e41 by Terry Jan Reedy in branch '3.3':
Issue #18439: Make patchcheck work on Windows for ACKS, NEWS.
http://hg.python.org/cpython/rev/26686d227e41
New changeset 13950a33f889 by Terry Jan Reedy in branch '2.7':
Issue #18439: Make
Changes by Terry J. Reedy tjre...@udel.edu:
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18439
___
Roundup Robot added the comment:
New changeset 9f922270a929 by Terry Jan Reedy in branch '2.7':
Issue #18441: fix buildbot name-error for TclError.
http://hg.python.org/cpython/rev/9f922270a929
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset e8b8279ca118 by Terry Jan Reedy in branch '2.7':
Backed out changeset: 23b0164b9c82 #18441 not working
http://hg.python.org/cpython/rev/e8b8279ca118
--
___
Python tracker rep...@bugs.python.org
R. David Murray added the comment:
Rather than closing it, we converted it to a documentation issue. I think it
is worth a footnote in the docs, since it is not obvious (without reading the
source code) that a return statement will cause timeit to return an invalid
result instead of raising
Terry J. Reedy added the comment:
(The fix was incomplete because 'delete' in the except clause should be
'remove'.) I finally realized that I could test the except clause by raising
TclError explicitly just before it.
I reverted both changes because they do not seem to work, even with the
Alexander Belopolsky added the comment:
LGTM
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18453
___
___
Python-bugs-list mailing list
Terry J. Reedy added the comment:
More noise. Much of what I said above was incorrect due to version mixup. The
one extra fix I did not commit might have been enough, but I will wait until I
have tested it.
--
stage: commit review - patch review
Raymond Hettinger added the comment:
Go ahead and add a footnote, but do consider that such footnotes are mostly
just clutter. It doesn't help someone at the moment there is an invalid return
value -- instead it just makes it so that afterward someone can say that it is
documented.
Nick Coghlan added the comment:
As Raymond noted, we should resist the temptation to generalise this too much -
generalisation almost always comes at the cost of making any *specific* case
harder (consider the difference between the complexity of the support any URL
scheme model in urllib and
Nick Coghlan added the comment:
And reviewing my own draft - the convenience functions would need docstrings
too, and the docstrings should mention that a new StringIO instance is created
by default and that as name can be used to get access to that object.
--
Vajrasky Kok added the comment:
It looks like you are still patching get_payload. This should be a really
simple patch against set_payload.
Okay, do I get it right at this time?
About your second point, I need more time to think about it.
--
Added file:
Raymond Hettinger added the comment:
Nick, it seems to me that you're going way over-board with an otherwise simple
idea. I'm aiming for something that looks much like my original posting. That
has been tried out on my students with great success.
--
Marc Abramowitz added the comment:
I like Nick's version. I don't know if __exit__ really needs error checking,
but I like the API. For me, it strikes a good balance between being intuitive
and being general enough to do all the stuff I'd like to do.
Should the docstrings mention that it
R. David Murray added the comment:
Yes, that's what I had in mind.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18324
___
___
Python-bugs-list
Zachary Ware added the comment:
Terry J. Reedy added the comment:
The problem is that this permissiveness does not apply to subsidiary files
discovered from and run by a main file, even though it should. The current
workaround is to explicitly set use_resources for the benefit of subsidiary
Changes by Zachary Ware zachary.w...@gmail.com:
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18441
___
___
Python-bugs-list
Nick Coghlan added the comment:
OK, Raymond and I had a chat on IRC about this, and I've come back around to
the idea that the simple contextlib.redirect_stdout model as Raymond
originally proposed is the way to go. There are a few pieces to that rationale:
1. Why in contextlib?
The io
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15805
___
___
New submission from Nikolaus Rath:
The read1() docstring says: Reads up to n bytes, with at most one read()
system call.
However, in the implementation read1() calls peek() to refill the buffer if
necessary, and then returns whatever is available in the buffer.
This means that read1() will
New submission from Saurabh Gupta:
I've observed that shutil fails to import WindowsError on our windows 7 systems:
from shutil import WindowsError
File file, line no, in module
from shutil import WindowsError
ImportError: cannot import name WindowsError
The same statement
Nikolaus Rath added the comment:
I think stdout redirection is very useful, and I'm actually have a very similar
context manager in my own code.
However, I'd like to raise the question if using a context manager for this
purpose should really be officially blessed in this way.
To me, the
New submission from Zachary Ware:
Here is an initial attempt at adding resource management/guarding to unittest,
a la test.support.requires.
The patch adds 6 new names to unittest.__all__; one function called
'registerResource' which explains itself, one function and one decorator
(require
Ronald Oussoren added the comment:
Building just the readline extension shouldn't be that hard, using a small
custom setup.py script. Then install by manually copying it to the right
location.
And no, I don't work for Apple.
--
___
Python tracker
Nick Coghlan added the comment:
Yeah, the docs will need to note that it isn't thread safe. However, non
thread-safe constructs are often still incredibly useful for scripting use
cases.
--
___
Python tracker rep...@bugs.python.org
85 matches
Mail list logo
