STINNER Victor added the comment:
Results on Windows 7.
Common platform:
Python unicode implementation: PEP 393
Timer info: namespace(adjustable=False, implementation='QueryPerformanceCounter(
)', monotonic=True, resolution=1e-08)
Timer: time.perf_counter
Platform: Windows-7-6.1.7601-SP1
Andrei Dorian Duma added the comment:
I'll provide a patch later tonight.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19514
___
___
STINNER Victor added the comment:
I tried different overallocator factors:
* writer (current factor): 25% (1/4)
* writer50: 50% (1/2)
* writer100: 100% (double the buffer)
-+-++---
Tests | writer |
Serhiy Storchaka added the comment:
You shouldn't cache Py_SIZE(v) because it can be changed during iteration.
Due to benchmark results in issue15381 I afraid this patch will be much slower
on Windows.
--
___
Python tracker rep...@bugs.python.org
Changes by Seydou Dia seydou...@yahoo.fr:
--
nosy: +seydou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19514
___
___
Python-bugs-list mailing
STINNER Victor added the comment:
You shouldn't cache Py_SIZE(v) because it can be changed during iteration.
Oops, I fixed the code on my PC, but I generated the patch before fixing this
issue. I agree that Py_SIZE(v) should not be cached.
Due to benchmark results in issue15381 I afraid
STINNER Victor added the comment:
Oops, writer.min_length was not computed correctly :-/ The separator length is
2 characters (, ), not 1.
--
Added file: http://bugs.python.org/file32522/list_repr_writer-2.patch
___
Python tracker
STINNER Victor added the comment:
writer_overallocate_factor.patch: patch for change the overallocation factor
from 25% to 50% on Windows.
See also issues #14716 and #14744 which contains various benchmarks on string
formatting functions.
--
Added file:
Antoine Pitrou added the comment:
Please open a separate issue for the overallocation factor patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19513
___
Serhiy Storchaka added the comment:
What about longer elements (10**3 or 10**6 characters)?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19513
___
Serhiy Storchaka added the comment:
What is the problem with these changes?
Usually CPython team avoids code churn without serious reasons. Performance
reasons for the change PySys_GetObject(stdout) to
_PySys_GetObjectId(_PyId_stdout) are ridiculous. You changed hundreds lines of
code for
Kristján Valur Jónsson added the comment:
Ah, here we are some 18 months later. Let me have another go.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8799
___
New submission from Yury V. Zaytsev:
PEP-3149 (issue9193) introduces new variables (SO and SOABI) so that one can
find out what are the supported extension suffixes.
Quote from the PEP:
sysconfig.get_config_var('SO')
'.cpython-32mu.so'
sysconfig.get_config_var('SOABI')
'cpython-32mu'
STINNER Victor added the comment:
I added recently a new _PyUnicode_CompareWithId() function: changeset
77bebcf5c4cf (issue #19512).
This function can be used instead of PyUnicode_CompareWithASCIIString() when
the right parameter is a common string. It is interesting when the right string
is
STINNER Victor added the comment:
Serhiy, Gregory, Raymond, Antoine: so what is your feeling on this issue? Is it
worth it?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16286
___
STINNER Victor added the comment:
Another problem is that PyUnicode_FromString() failure is not handled
correctly in some cases. PyUnicode_FromString() can fail because an decoder
error, but also because of a MemoryError.
It can't fail on stdout because an decoder error.
It can fail on
Georg Brandl added the comment:
You mean for PyRun_InteractiveOneObject()? Oh, it can be made private, but
what is the problem of adding yet another PyRun_Interactive*() function?
There are already a lot of them :-)
And this is a problem. Newly added function is not even documented.
New submission from STINNER Victor:
The changeset af822a6c9faf of the issue #19512 added the function
PyRun_InteractiveOneObject(). By the way, I forgot to document this function.
This issue is also a reminder for that. The purpose of the new function is to
avoid creation of temporary Unicode
Serhiy Storchaka added the comment:
See also issue1534607.
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18162
___
___
Nick Coghlan added the comment:
After thinking about this some more, perhaps a -3 warning in 2.7 would be a
better solution? That would be more robust, as it could complain any time
unicode.encode produced unicode and str.decode produced str and point users
to the codecs module level functions
Changes by Serhiy Storchaka storch...@gmail.com:
--
components: +Interpreter Core
stage: - test needed
type: - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19518
___
Serhiy Storchaka added the comment:
On Windows, these changes should allow to pass an unencodable filename on the
command line (ex: japanese script name on an english setup).
Doesn't the surrogateescape error handler solve this issue?
--
___
Changes by Ian Cordasco graffatcolmin...@gmail.com:
--
nosy: +icordasc
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19514
___
___
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17823
___
___
Sunny K added the comment:
New patch for 3.4 adds the following:
1. _fields
2. _replace()
3. _asdict()
4. eval(repr(s)) == s
Now the issues:
1. _asdict() returns a normal dictionary. I don't know if this is what
is required.
2. Both _asdict() and _replace() assume that unnamed visible
New submission from STINNER Victor:
Python parser (Parser/tokenizer.c) has a translate_into_utf8() function to
decode a string from the input encoding and encode it to UTF-8.
This function is unnecessary if the input string is already encoded to UTF-8,
which is something common nowadays.
Changes by Sunny K sunfin...@gmail.com:
Removed file: http://bugs.python.org/file32265/structseq.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11698
___
Changes by STINNER Victor victor.stin...@gmail.com:
Removed file: http://bugs.python.org/file32526/input_is_utf8.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19519
___
Sunny K added the comment:
The previous patch had a wrong mapping between keys and values. The
current implementation of repr means that duplicated keys will be
present when invisible fields are included. See points 2 and 3 in
http://bugs.python.org/issue1820#msg202330 for more explanation.
I
Sunny K added the comment:
Oops, the correct issue for improving the repr is issue11698.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1820
___
STINNER Victor added the comment:
The patch has an issue, importing test.bad_coding2 (UTF-8 with a BOM) does not
raise a SyntaxError anymore.
--
Added file: http://bugs.python.org/file32528/input_is_utf8.patch
___
Python tracker
Changes by Yuri Bochkarev baltazar...@gmail.com:
--
nosy: +Yuri.Bochkarev
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8844
___
___
Changes by Yuri Bochkarev baltazar...@gmail.com:
--
nosy: +Yuri.Bochkarev
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9634
___
___
Changes by Yuri Bochkarev baltazar...@gmail.com:
--
nosy: +Yuri.Bochkarev
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1175
___
___
STINNER Victor added the comment:
2013/11/7 Serhiy Storchaka rep...@bugs.python.org:
On Windows, these changes should allow to pass an unencodable filename on
the command line (ex: japanese script name on an english setup).
Doesn't the surrogateescape error handler solve this issue?
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19518
___
___
STINNER Victor added the comment:
Serhiy is right. You have to be responsible with the Py* namespace, and keep
new functions private unless they are useful enough to the outside and you
document them.
I created the issue #19518 to discuss this part (but also to propose other
enhancements
STINNER Victor added the comment:
Errors become more unlikely because objects are only initialized once, near
startup. So it put also less pressure on code handling errors :) (it is
usually the least tested part of the code)
If there are bugs in code handling errors, they should be fixed
Serhiy Storchaka added the comment:
I added some comments on Rietveld.
Please do not commit without documentation and tests.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19518
___
Serhiy Storchaka added the comment:
The parser should check that the input is actually valid UTF-8 data.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19519
___
STINNER Victor added the comment:
The parser should check that the input is actually valid UTF-8 data.
Ah yes, correct. It looks like input data is still checked for valid
UTF-8 data. I suppose that the byte strings should be decoded from
UTF-8 because Python 3 manipulates Unicode strings, not
Barry A. Warsaw added the comment:
Is this issue still relevant?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1294959
___
___
Python-bugs-list
R. David Murray added the comment:
What do you mean by the whole test routine failing? The test suite is
currently passing on the buildbots, so are you speaking of the new test you are
trying to write?
--
___
Python tracker rep...@bugs.python.org
jan matejek added the comment:
Yes. We still have a patch for two things:
1. fix setup.py script to look for libraries in correct (lib64) prefixes, and
2. fix values returned from sysconfig, to reflect that python resides in lib64
$prefix/lib is hardcoded in many places. Lib64 is probably not
New submission from Zachary Ware:
There is only one remaining compiler warning on 32-bit Windows, see [1]
(buildbot doubles warning counts on the Windows bots).
The warning is coming from Modules/_sha3/keccak/KeccakF-1600-opt32.c#l497,
which uses extractLanes as defined on line 213.
The
R. David Murray added the comment:
Hmm. Looking at this again, it appears as though there's no way to interrupt
IDLE if you want to, say, send an email. If you are actually using this in
code, how are you handling that situation?
--
___
Python
Martin v. Löwis added the comment:
tok-enc and tok-encoding should always have the same value, except that
tok-enc gets set earlier.
tok-enc is used when parsing from strings, to remember what codec to use. For
file based parsing, the codec object created knows what encoding to use; for
fhahn added the comment:
I've merged the _Py_IDENTIFIER identifiers mentioned above.
I stumbled over anohter instance where _Py_IDENTIFIER is used more than once:
_Py_IDENTIFIER(__setitem__) : Objects/typeobject.c#l5133
_Py_IDENTIFIER(__setitem__) : Objects/typeobject.c#l5184
--
Christian Heimes added the comment:
Thanks! I'll look into it.
I'd rather not change the reference implementation but in this case
practicality beats purity. :)
--
assignee: - christian.heimes
___
Python tracker rep...@bugs.python.org
Martin v. Löwis added the comment:
As a matter of style, I suggest that all identifiers are moved to the top of a
file if some of them live there. IOW, it's (IMO) unstylish to have some at the
top, and some in the middle (although this works perfectly fine, of course).
--
nosy:
Martin v. Löwis added the comment:
Another matter of style: I suggest alphabetical order for the identifiers, at
least when the list gets long.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19514
Roundup Robot added the comment:
New changeset 0e0dded5d616 by R David Murray in branch '3.3':
#18985: Improve fcntl documentation.
http://hg.python.org/cpython/rev/0e0dded5d616
New changeset ddf6da99b3cd by R David Murray in branch 'default':
Merge #18985: Improve fcntl documentation.
Andrei Dorian Duma added the comment:
The patch I promised above.
--
Added file: http://bugs.python.org/file32532/merge_py_identifiers.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19514
R. David Murray added the comment:
Thanks, Vajrasky (and Victor :)
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18985
Matthias Klose added the comment:
the patch in msg202343 is wrong, hardcoding lib64 on Debian/Ubuntu. At least
the configure check should check for lib64 as a directory and not a symlink,
and only then default to lib64.
two other issues with the patch:
- I would like to see any new
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: +andrei.duma, loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19515
___
___
STINNER Victor added the comment:
If most identifiers are stored in the same place, it would become possible to
have a cleanup function to clear all identifiers. Such function could be
called at Python shutdown to release as much memory as possible.
--
Andrei Dorian Duma added the comment:
I added a new patch with sorted _Py_IDENTIFIERs.
Regarding all identifiers at the top, I guess it might be more stylish, but it
might affect performance. I'm not sure, though.
--
Added file:
jan matejek added the comment:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Dne 7.11.2013 16:56, Matthias Klose napsal(a):
Matthias Klose added the comment:
the patch in msg202343 is wrong, hardcoding lib64 on Debian/Ubuntu.
This patch is provided for reference only - it works for us at
STINNER Victor added the comment:
merge_py_identifiers_sorted.patch looks good to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19514
___
New submission from Michael Haubenwallner:
Since python-3.2, there is a race condition building in parallel on AIX:
Consider these Makefile(.pre.in) rules:
$(BUILDPYTHON): ...
$(LINKCC) ... $(LINKFORSHARED) ...
Modules/_testembed: ...
$(LINKCC) ... $(LINKFORSHARED) ...
Antoine Pitrou added the comment:
What are you trying to achieve exactly? I don't think sharing identifier
structs will gain anything significant. Please don't make the source code less
readable in search for some mythical efficiency.
--
nosy: +pitrou
Roundup Robot added the comment:
New changeset 695f988824bb by Ezio Melotti in branch '2.7':
#19480: HTMLParser now accepts all valid start-tag names as defined by the
HTML5 standard.
http://hg.python.org/cpython/rev/695f988824bb
New changeset 9b9d188ed549 by Ezio Melotti in branch '3.3':
Ezio Melotti added the comment:
Fixed, thanks for the feedback!
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19480
Ezio Melotti added the comment:
3.4 is done.
3.5
strict arg removed and strict code removed
HTMLParseError removed
HTMLParser.error and calls to HTMLParser.error removed
--
Added file: http://bugs.python.org/file32535/issue15114-3.diff
___
Python
Arfrever Frehtes Taifersar Arahesis added the comment:
IMHO '*' could be used as a separator, since relation between indexable fields
and named, unindexable fields is similar to relation between
positional-or-keyword parameters and keyword-only parameters.
$./python -c import os;
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19518
___
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19512
___
Barry A. Warsaw added the comment:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On Nov 07, 2013, at 04:05 PM, jan matejek wrote:
- I would like to see any new OS-dependent locations in the sysconfig
module, not the sys module.
how would you propose to put the value into sysconfig in the
Barry A. Warsaw added the comment:
On Nov 07, 2013, at 03:40 PM, jan matejek wrote:
To reiterate, our current solution is to introduce sys.lib (and sys.arch,
but that is never used anymore) that is either lib or lib64, and use this
in place of the string lib wherever appropriate. We find the
Matthias Klose added the comment:
I disagree about sys.implementation. It's useless and wrong for cross builds.
Please use sysconfig instead. What sysconfig is maybe missing is a set of
variables which you can rely on.
--
___
Python tracker
Arfrever Frehtes Taifersar Arahesis added the comment:
configure.ac should accept an option, which allows to set any custom libdir.
Examples (architecture: libdir) in Gentoo:
x32: libx32
mips o32: lib
mips n32: lib32
mips n64: lib64
--
___
Guido van Rossum added the comment:
Fixed by revision 9c976f1b17e9.
--
assignee: - gvanrossum
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19497
Ezio Melotti added the comment:
Fixed, thanks for the review.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17080
Roundup Robot added the comment:
New changeset a73c47c1d374 by Ezio Melotti in branch 'default':
#17080: improve error message of float/complex when the wrong type is passed.
http://hg.python.org/cpython/rev/a73c47c1d374
--
nosy: +python-dev
___
Martin v. Löwis added the comment:
Victor: There already *is* a cleanup function that clears all allocated
identifier memory at interpreter shutdown. Please read the source.
--
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
Updated patch uses large overallocation factor (1/2 instead 1/8), it may
increase the speed on Windows. Fixed implementation of __sizeof__() and some
minor bugs.
--
stage: needs patch - patch review
Added file:
STINNER Victor added the comment:
Victor: There already *is* a cleanup function that clears all allocated
identifier memory at interpreter shutdown. Please read the source.
Oh, great! I never noticed _PyUnicode_ClearStaticStrings().
Call trace: Py_Finalize() -
Roundup Robot added the comment:
New changeset 4a09cc62419b by Martin v. Löwis in branch 'default':
Issue #19514: Deduplicate some _Py_IDENTIFIER declarations.
http://hg.python.org/cpython/rev/4a09cc62419b
--
nosy: +python-dev
___
Python tracker
Martin v. Löwis added the comment:
Thanks for the patch.
Note: moving all identifiers would not have made a difference. They are static
variables, so from a run-time point of view, there is no difference whether
they are inside or outside of functions.
--
resolution: - fixed
status:
Martin v. Löwis added the comment:
Well, that was one of the motivations of introducing this Py_IDENTIFIER
machinery: to be able to cleanup at the end (unlike the static variables that
were used before, which couldn't be cleaned up).
--
___
Python
Barry A. Warsaw added the comment:
On Nov 07, 2013, at 04:56 PM, Matthias Klose wrote:
I disagree about sys.implementation. It's useless and wrong for cross builds.
Please use sysconfig instead. What sysconfig is maybe missing is a set of
variables which you can rely on.
Agreed that sysconfig
Martin v. Löwis added the comment:
Wouldn't it be better if linking _testembed generated _testembed.exp instead of
generating python.exp? I hope using $@.exp somehow could help. Hard-coding the
name of the export file sounds like a flaw in the first place.
--
nosy: +loewis
Changes by Brett Cannon br...@python.org:
--
superseder: - Add index attribute to IndexError
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1534607
___
Changes by Brett Cannon br...@python.org:
--
resolution: - duplicate
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1534607
___
Roundup Robot added the comment:
New changeset cb4c964800af by Victor Stinner in branch 'default':
Issue #19514: Add Andrei Dorian Duma to Misc/ACKS for changeset 4a09cc62419b
http://hg.python.org/cpython/rev/cb4c964800af
--
___
Python tracker
STINNER Victor added the comment:
Antoine, Martin: So, what do you think? Is it worth to move most common
identifiers to a single place to not duplicate them?
If identifiers are already cleared at exit, the advantage would be to
initialize duplicated identifiers more quickly, and don't
Antoine Pitrou added the comment:
Antoine, Martin: So, what do you think? Is it worth to move most common
identifiers
to a single place to not duplicate them?
Well, worth what? :)
If you don't tell us what it brings (numbers?), I'm against it.
--
STINNER Victor added the comment:
If you don't tell us what it brings (numbers?), I'm against it.
For performances, it's probably very close to zero speed up. For the memory,
it's a few bytes per duplicated identifier.
--
___
Python tracker
Giampaolo Rodola' added the comment:
Same problem here. I'm currently uploading .exe files for psutil by hand.
Interestingly the problem occurs with certain versions of python only (2.4,
2.5, 2.7, 3.2).
--
nosy: +giampaolo.rodola
___
Python tracker
Antoine Pitrou added the comment:
If you don't tell us what it brings (numbers?), I'm against it.
For performances, it's probably very close to zero speed up. For
the memory, it's a few bytes per duplicated identifier.
Well, then IMHO it's not worth it.
--
STINNER Victor added the comment:
Well, then IMHO it's not worth it.
Ok, you are probably right :-)
@Andrei: Are you interested to work on a patch to remove identifiers duplicated
in the same file?
--
___
Python tracker rep...@bugs.python.org
STINNER Victor added the comment:
c_api_frame.patch: document some C functions of the frame object in the C API.
--
keywords: +patch
Added file: http://bugs.python.org/file32537/c_api_frame.patch
___
Python tracker rep...@bugs.python.org
Andrei Dorian Duma added the comment:
@Andrei: Are you interested to work on a patch to remove identifiers
duplicated in the same file?
Yes, I will provide a patch in a day or two.
--
___
Python tracker rep...@bugs.python.org
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16261
___
___
Python-bugs-list
STINNER Victor added the comment:
New changeset 01c4a0af73cf by Victor Stinner in branch 'default':
Issue #19512, #19515: remove shared identifiers, move identifiers where they
http://hg.python.org/cpython/rev/01c4a0af73cf
This changeset removes some identifiers duplicated in the same file.
Roundup Robot added the comment:
New changeset 01c4a0af73cf by Victor Stinner in branch 'default':
Issue #19512, #19515: remove shared identifiers, move identifiers where they
http://hg.python.org/cpython/rev/01c4a0af73cf
--
nosy: +python-dev
___
Roundup Robot added the comment:
New changeset 01c4a0af73cf by Victor Stinner in branch 'default':
Issue #19512, #19515: remove shared identifiers, move identifiers where they
http://hg.python.org/cpython/rev/01c4a0af73cf
--
___
Python tracker
STINNER Victor added the comment:
Updated patch addressing some remarks of Serhiy and adding documentation.
--
Added file: http://bugs.python.org/file32538/pyrun_object-2.patch
___
Python tracker rep...@bugs.python.org
STINNER Victor added the comment:
Updated patch addressing some remarks of Serhiy and adding documentation.
Oh, and it adds also an unit test. I didn't run the unit test on Windows yet.
--
___
Python tracker rep...@bugs.python.org
1 - 100 of 122 matches
Mail list logo
