New submission from Serhiy Storchaka:
The proposed patch makes the distutils package tests use more specific asserts.
This will provide more useful failure report.
--
components: Distutils
files: test_distutils_asserts.patch
keywords: patch
messages: 202922
nosy: eric.araujo,
New submission from Serhiy Storchaka:
The proposed patch makes the sqlite3 package tests use more specific asserts.
This will provide more useful failure report.
--
components: Tests
files: test_sqlite3_asserts.patch
keywords: patch
messages: 202923
nosy: ghaering, serhiy.storchaka
New submission from Serhiy Storchaka:
The proposed patch makes the tkinter package tests use more specific asserts.
This will provide more useful failure report.
--
components: Tests, Tkinter
files: test_tkinter_asserts.patch
keywords: patch
messages: 202924
nosy: serhiy.storchaka
New submission from Serhiy Storchaka:
The proposed patch makes test_descr use more specific asserts. This will
provide more useful failure report.
This is the largest patch in the series.
--
components: Tests
messages: 202925
nosy: serhiy.storchaka
priority: normal
severity: normal
Changes by Serhiy Storchaka storch...@gmail.com:
--
dependencies: +Use specific asserts in distutils tests, Use specific asserts in
sqlite3 tests, Use specific asserts in test_decr, Use specific asserts in
tkinter tests
___
Python tracker
Zachary Ware added the comment:
Here's a patch. It turned out to be much more extensive than I expected, and
the diff turned into a huge huge ugly monster that I hope Rietveld can help to
make sense of, since the majority of the diff is simply changes in indentation
level.
The most major
Berker Peksag added the comment:
This is fixed in 3.3 and 3.4 by changeset
http://hg.python.org/cpython/rev/5e98c4e9c909#l1.89.
I can still reproduce the NameError in 2.7:
http://hg.python.org/cpython/file/2.7/Lib/distutils/command/upload.py#l180
--
nosy: +berker.peksag, jason.coombs
Berker Peksag added the comment:
Oh, I was wrong. This is not a duplicate of issue 12853 (but they are related).
Also, the patch in issue 19226 is looks better to me.
--
nosy: +jason.coombs, labrat
resolution: duplicate -
stage: committed/rejected - patch review
status: closed - open
New submission from Serhiy Storchaka:
The proposed patch makes the array module tests use more specific asserts. This
will provide more useful failure report.
--
components: Tests
files: test_array_asserts.patch
keywords: patch
messages: 202929
nosy: serhiy.storchaka
priority: normal
New submission from Serhiy Storchaka:
The proposed patch makes the datetime module tests use more specific asserts.
This will provide more useful failure report.
--
components: Tests
files: test_datetime_asserts.patch
keywords: patch
messages: 202930
nosy: belopolsky, serhiy.storchaka
New submission from Serhiy Storchaka:
The proposed patch makes the http.cookiejar module tests use more specific
asserts. This will provide more useful failure report.
--
components: Tests
files: test_http_cookiejar_asserts.patch
keywords: patch
messages: 202931
nosy: serhiy.storchaka
New submission from Serhiy Storchaka:
The proposed patch makes the weakref module tests use more specific asserts.
This will provide more useful failure report.
--
components: Tests
files: test_weakref_asserts.patch
keywords: patch
messages: 202932
nosy: fdrake, pitrou,
Changes by Serhiy Storchaka storch...@gmail.com:
--
dependencies: +Use specific asserts in array tests, Use specific asserts in
datetime tests, Use specific asserts in http.cookiejar tests, Use specific
asserts in weakref tests
___
Python tracker
New submission from anatoly techtonik:
http://docs.python.org/devguide/
it covers pretty much complicated stuff, which takes a lot of time to grasp.
Pictures help to save hours if not weeks. There needs to be some immediate
intro picture at the top of front page illustrating transformation of
STINNER Victor added the comment:
Likely. Can you suggest a fix?
Replace the timeout of 2 seconds with a timeout of 10 seconds.
It looks like the test checks the overlapped I/O API, not the timing.
If you want to test exactly the timing, another test is needed (ex:
measure the elapsed time
Changes by Alexandre Vassalotti alexan...@peadrop.com:
Added file: http://bugs.python.org/file32639/f87b455af573.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17810
___
Nick Coghlan added the comment:
Feel free to draw some and send a patch.
--
nosy: +ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19608
___
Nick Coghlan added the comment:
Adding a dependency on the PEP 451 implementation - we should merge that first
to ensure it doesn't encounter any conflicts.
--
dependencies: +Implementation for PEP 451 (importlib.machinery.ModuleSpec)
___
Python
Changes by Alexandre Vassalotti alexan...@peadrop.com:
Added file: http://bugs.python.org/file32640/8434af450da0.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17810
___
Changes by Alexandre Vassalotti alexan...@peadrop.com:
Removed file: http://bugs.python.org/file32639/f87b455af573.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17810
___
New submission from Nick Coghlan:
The exception chaining from issue 17828 is triggering for the initial codec
lookup. This is less than helpful:
Failed example:
str(result)
Expected:
Traceback (most recent call last):
...
LookupError: unknown encoding:
Changes by Berker Peksag berker.pek...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file32642/fix-upload-cmd.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19610
___
New submission from Berker Peksag:
Python 3.4:
$ ../cpython/./python setup.py sdist upload -r test --show-response
...
...
Traceback (most recent call last):
File setup.py, line 24, in module
'License :: OSI Approved :: Mozilla Public License 2.0 (MPL 2.0)',
File
Alexandre Vassalotti added the comment:
Hi folks,
I consider my implementation of PEP-3154 mostly feature complete at this point.
I still have a few things left to do. For example, I need to update the
documentation about the new protocol. However, these can mostly be done along
the review
Nick Coghlan added the comment:
Fixed by narrowing the scope of the chaining in
http://hg.python.org/cpython/rev/4ea622c085ca
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
type: - behavior
___
Python tracker
STINNER Victor added the comment:
I never undersood why, but classifiers must be a list, not a tuple. This is a
bug in my opinion.
upload.upload_file() doesn't check if the tuple contains exactly 2 items. If
the value is a tuple, it doesn't encode the value. This is another bug. I don't
know
Nick Coghlan added the comment:
Based on a comment from MvL in issue 19550 (the Windows installer counterpart),
it may be better to say something like Install/update pip? as a prompt (since
leaving the option checked may also update an existing pip installation that is
older than the bundled
Changes by Nick Coghlan ncogh...@gmail.com:
--
assignee: - ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19552
___
___
Python-bugs-list
STINNER Victor added the comment:
upload.upload_file() ... doesn't encode the value.
fix-upload-cmd.diff should fix this specific bug, but the first bug (accept
tuple for classifiers) should be fixed before or you will get an unexpected
behaviour (only send 1 classifier?).
--
New submission from Ned Batchelder:
In 2.7, set comprehensions are compiled to code objects expecting an argument
named .0. This convention is also used for the unnamed arguments needed by
tuple arguments. inspect.getcallargs understands the tuple argument case, but
not the set
Ned Batchelder added the comment:
BTW: I don't hold any illusions that this bug is important enough to fix, but I
would be interested in hearing ideas about how I could work around it...
--
___
Python tracker rep...@bugs.python.org
Nick Coghlan added the comment:
Patch looks good to me.
--
nosy: +ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1180
___
___
Stefan Behnel added the comment:
Thanks!
--
nosy: +scoder
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19609
___
___
Python-bugs-list mailing
Nick Coghlan added the comment:
Patch looks good to me.
--
nosy: +ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6516
___
___
Nick Coghlan added the comment:
I reviewed the latest PEP text at http://www.python.org/dev/peps/pep-0456/
I'm almost prepared to accept the current version of the implementation, but
there's one technical decision to be clarified and a few placeholders in the
PEP that need to be cleaned up
anatoly techtonik added the comment:
Thanks for the proposal, but you know perfectly that I am not a designer. I
don't believe that there are no talented people who find this ticket
interesting. You just need to add tag:easy to is (or allow others to do), so it
became visible to these people
Stefan Krah added the comment:
To my surprise, this line is 10% faster with a freelist:
./python -m timeit -s import array; a = array.array('B', [0]*100); m =
memoryview(a) m[30:40]
I think the reason is that PyObject_GC_NewVar() is quite slow.
--
Changes by Nick Coghlan ncogh...@gmail.com:
--
assignee: ncoghlan - christian.heimes
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19183
___
___
Brett Cannon added the comment:
These tests can't be removed because the classes are inheriting from an ABC to
make sure that those test cases are considered and dealt with, either by
explicitly testing them or ignoring them because they don't apply to the
finder/loader.
And since they are
Serhiy Storchaka added the comment:
In this case we should do
test_package = None # Built-in modules cannot be a package.
test_module_in_package = None # Built-in modules cannobt be in a package.
...
And then tests will be skipped and not shown in test report.
--
Brett Cannon added the comment:
As long as setting them to None satisfies the ABC that's fine with me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19596
___
Roundup Robot added the comment:
New changeset d48ec67b3b0e by Guido van Rossum in branch 'default':
asyncio: Longer timeout in Windows test_popen. Fixes issue 19598.
http://hg.python.org/cpython/rev/d48ec67b3b0e
--
nosy: +python-dev
___
Python
Changes by STINNER Victor victor.stin...@gmail.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19598
___
New submission from STINNER Victor:
The test failed on a buildbot, see the message below. By the way, the test
should use a value based on test.support.PIPE_MAX_SIZE rather than an hardcoded
size of 2**20 bytes.
R. David Murray added the comment:
Additional changes look good to me.
Unless (pun intended) Barry objects, I think I'll come down in favor of
backporting all of these changes. The tipping point is that I've always found
myself experiencing cognitive dissonance reading the 'unless' calls,
New submission from STINNER Victor:
http://buildbot.python.org/all/builders/AMD64%20Ubuntu%20LTS%203.x/builds/3024/steps/test/logs/stdio
==
ERROR: test_article_head_body (test.test_nntplib.NetworkedNNTP_SSLTests)
New submission from R. David Murray:
Based on this error on one of the buildbots, it is clear that support.temp_cwd
should be calling support.rmtree, and not shutil.rmtree, during cleanup:
[...]
During handling of the above exception, another exception occurred:
Traceback (most recent call
New submission from Edward Catmur:
foo.c:
#include Python.h
static PyMethodDef mth[] = { {NULL, NULL, 0, NULL} };
static struct PyModuleDef mod = { PyModuleDef_HEAD_INIT, foo, NULL, -1, mth };
PyMODINIT_FUNC PyInit_foo(void) { return PyModule_Create(mod); }
bar.c:
#include Python.h
static
Barry A. Warsaw added the comment:
assertTrue(dtrt)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19590
___
___
Python-bugs-list mailing list
Roundup Robot added the comment:
New changeset b9c9c4b2effe by Andrew Kuchling in branch 'default':
Issue #19544 and Issue #6516: Restore support for --user and --group parameters
to sdist command as found in Python 2.7 and originally slated for Python 3.2
but accidentally rolled back as part
Roundup Robot added the comment:
New changeset b9c9c4b2effe by Andrew Kuchling in branch 'default':
Issue #19544 and Issue #6516: Restore support for --user and --group parameters
to sdist command as found in Python 2.7 and originally slated for Python 3.2
but accidentally rolled back as part
Changes by Jason R. Coombs jar...@jaraco.com:
--
resolution: accepted - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6516
___
Changes by Jason R. Coombs jar...@jaraco.com:
--
assignee: akuchling - jason.coombs
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1180
___
___
Edward Catmur added the comment:
Report dlerror() if dlsym() fails.
The error output is now something like:
ImportError: /.../foo.cpython-34dm.so: undefined symbol: PyInit_bar
--
keywords: +patch
Added file: http://bugs.python.org/file32643/dynload_report_dlerror.patch
Antoine Pitrou added the comment:
Agreed with both Brett and Serhiy.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19596
___
___
Roundup Robot added the comment:
New changeset bbb227b96c45 by Vinay Sajip in branch '2.7':
Issue #19523: Closed FileHandler leak which occurred when delay was set.
http://hg.python.org/cpython/rev/bbb227b96c45
New changeset 058810fe1b98 by Vinay Sajip in branch '3.3':
Issue #19523: Closed
Roundup Robot added the comment:
New changeset e9d9bebb979f by Vinay Sajip in branch '2.7':
Issue #19504: Used American spelling for 'customize'.
http://hg.python.org/cpython/rev/e9d9bebb979f
New changeset 1c714c35c02a by Vinay Sajip in branch '3.3':
Issue #19504: Used American spelling for
Roundup Robot added the comment:
New changeset b08868fd5994 by Christian Heimes in branch 'default':
Issue #19544 and Issue #6516: quick workaround for failing builds
http://hg.python.org/cpython/rev/b08868fd5994
--
___
Python tracker
New submission from Brett Cannon:
Should help with traceback/test failure reporting.
--
assignee: brett.cannon
messages: 202971
nosy: brett.cannon
priority: low
severity: normal
stage: needs patch
status: open
title: Fix test.test_importlib.util.test_both() to set __module__
versions:
Roundup Robot added the comment:
New changeset b08868fd5994 by Christian Heimes in branch 'default':
Issue #19544 and Issue #6516: quick workaround for failing builds
http://hg.python.org/cpython/rev/b08868fd5994
--
___
Python tracker
Roundup Robot added the comment:
New changeset 015463176d2e by Victor Stinner in branch 'default':
Issue #19544, #6516: no need to catch AttributeError on import pwd/grp
http://hg.python.org/cpython/rev/015463176d2e
--
___
Python tracker
Roundup Robot added the comment:
New changeset 015463176d2e by Victor Stinner in branch 'default':
Issue #19544, #6516: no need to catch AttributeError on import pwd/grp
http://hg.python.org/cpython/rev/015463176d2e
--
___
Python tracker
Changes by Rob rob.raym...@hp.com:
--
nosy: +raymondr
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17849
___
___
Python-bugs-list mailing list
New submission from STINNER Victor:
On Windows 64-bit, Visual Studio generates a lot of warnings because Py_ssize_t
values are downcasted to int.
Attached patch fixes all warnings and move the final downcast into
compiler_addop_i(). This function uses an assertion to check that integer
STINNER Victor added the comment:
Ping myself.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18294
___
___
Python-bugs-list mailing list
STINNER Victor added the comment:
The I parser format does not check for integer overflow.
The O format can be used with _PyLong_AsInt() instead.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18294
STINNER Victor added the comment:
At changeset 015463176d2e2530e4f07cfbe97e41abac540a57,
test_make_distribution_owner_group() was failing on some buildbots.
test_distutils works fine on my Linux box, I ran the test as my haypo user and
as root.
Roundup Robot added the comment:
New changeset c35311fcc967 by Andrew Kuchling in branch 'default':
Issue #19544 and Issue #1180: Restore global option to ignore
~/.pydistutils.cfg in Distutils, accidentally removed in backout of distutils2
changes.
Roundup Robot added the comment:
New changeset c35311fcc967 by Andrew Kuchling in branch 'default':
Issue #19544 and Issue #1180: Restore global option to ignore
~/.pydistutils.cfg in Distutils, accidentally removed in backout of distutils2
changes.
Benjamin Peterson added the comment:
You could use the Py_SAFE_DOWNCAST macro everywhere.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19617
___
Changes by Jason R. Coombs jar...@jaraco.com:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1180
___
___
Python-bugs-list
Jason R. Coombs added the comment:
emxccompiler is no longer present in Python 3.4, so this ticket has become
invalid.
--
resolution: fixed - invalid
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6466
Charles-François Natali added the comment:
mpb added the comment:
Someone wrote a kernel patch based on my bug report.
http://www.spinics.net/lists/netdev/msg257653.html
It's just a patch to avoid returning garbage in the address.
But AFAICT, recvfrom() returning 0 is enough to know that
Charles-François Natali added the comment:
R. David Murray added the comment:
neologix noted that *when redirection is used* the way that *all* windows
file handles are inherited changes.
That's true (but that was from Richard actually).
--
___
STINNER Victor added the comment:
At changeset 015463176d2e2530e4f07cfbe97e41abac540a57,
test_make_distribution_owner_group() was failing on some buildbots.
The problem is that tempfile.mkdtemp() creates a directory with the
group 0. Files created in this directory also have the group 0.
STINNER Victor added the comment:
I think it's simply due to file descriptor inheritance
File handles are now non-inheritable by default in Python 3.4 (PEP 446). Does
it change anything?
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
STINNER Victor added the comment:
Seen on another buildbot.
http://buildbot.python.org/all/builders/AMD64%20OpenIndiana%203.x/builds/6809/steps/test/logs/stdio
==
FAIL: test_async_timeout
Jason R. Coombs added the comment:
Thanks Victor.
Yes, it appears that there's yet another unported issue #7408, a follow-up to
#6516.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19544
Jason R. Coombs added the comment:
In issue #19544, #6516 was ported to Python 3.4. After doing so, this issue
re-emerges.
--
assignee: tarek - jason.coombs
nosy: +jason.coombs
resolution: accepted -
status: closed - open
versions: +Python 3.4
___
Changes by Guido van Rossum gu...@python.org:
--
nosy: +larry
priority: normal - release blocker
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16596
___
Guido van Rossum added the comment:
I'd love it if someone could review this. This would be a great improvement to
debugging coroutines in asyncio.
--
stage: - patch review
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset f4b364617abc by Jason R. Coombs in branch 'default':
Issue #7408: Forward port limited test from Python 2.7, fixing failing buildbot
tests on BSD-based platforms.
http://hg.python.org/cpython/rev/f4b364617abc
--
nosy: +python-dev
Jason R. Coombs added the comment:
I'm declaring this fixed and watching the buildbots for confirmation.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7408
Terry J. Reedy added the comment:
I presume a test could detect docstring stripping with
def f(): 'docstring'
if f.__doc__ is None: skip test that expects them
This would cover the test_functools case, but I don't know about the others.
--
nosy: +terry.reedy
New submission from Berker Peksag:
This is probably related to issue 17679.
==
FAIL: test_sysconfig_module (distutils.tests.test_sysconfig.SysconfigTestCase)
Changes by Terry J. Reedy tjre...@udel.edu:
--
nosy: +terry.reedy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19539
___
___
Python-bugs-list
Changes by Terry J. Reedy tjre...@udel.edu:
--
versions: -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19548
___
___
Python-bugs-list
Changes by Terry J. Reedy tjre...@udel.edu:
--
versions: -Python 2.6, Python 3.1, Python 3.2, Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19554
___
Changes by Terry J. Reedy tjre...@udel.edu:
--
components: -Devguide
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19557
___
___
Python-bugs-list
New submission from STINNER Victor:
I propose to add new input_type and output_type to CodecInfo. These attributes
would only be defined for base64, hex, ... codecs which are not the classic
encode: str=bytes, decode: bytes=str codecs.
I also propose to modify str.encode() and bytes.encode()
Jason R. Coombs added the comment:
I believe all identified issues have been ported/fixed.
--
assignee: eric.araujo - jason.coombs
resolution: - fixed
stage: - committed/rejected
status: open - closed
type: - behavior
___
Python tracker
Terry J. Reedy added the comment:
Since failed asserts print the failed assert, repeating the assertion in a
message is useless.
assert 1 = i
Traceback (most recent call last):
File pyshell#3, line 1, in module
assert 1 = i
AssertionError
It is already obvious that i must be = 1. So I
Changes by Terry J. Reedy tjre...@udel.edu:
--
versions: +Python 3.4 -Python 2.7, Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19562
___
Guido van Rossum added the comment:
I think this is not ready for inclusion. It works wonderfully when stepping
over a yield[from], but I can't seem to get it to step nicely *out* of a
generator. (Details on request -- basically I put a pdb.set_trace() call in
Tulip's fetch3.py example and
Changes by Jason R. Coombs jar...@jaraco.com:
--
assignee: tarek - jason.coombs
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12853
___
___
Roundup Robot added the comment:
New changeset aa3a7d5e0478 by Jason R. Coombs in branch '2.7':
Issue #12853: Correct NameError in distutils upload command.
http://hg.python.org/cpython/rev/aa3a7d5e0478
--
nosy: +python-dev
___
Python tracker
Changes by Jason R. Coombs jar...@jaraco.com:
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
versions: +Python 3.3, Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12853
Jason R. Coombs added the comment:
Berker reports in issue12853, msg202927 that the issue is fixed for Python 3.3
and 3.4 by the patch for issue6286 applied as part of issue19544.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
Terry J. Reedy added the comment:
Looking further, the current code has a message object, the month that fails
the test and your patch removes that in adding the redundant message. I also
see that your change would make the first assert match the next 2. But I would
rather change the next
Christian Heimes added the comment:
Here are benchmarks on two Linux machine. It looks like SipHash24 takes
advantage of newer CPUs. I'm a bit puzzled about the results. Or maybe my super
simple and naive analyzer doesn't give sensible results...
1 - 100 of 108 matches
Mail list logo
