Terry J. Reedy added the comment:
Some issues that I think of off the top of my head, without looking into the
details of the code.
0. I am not sure how I would use this. I am thus not sure why I might push
this, especially given that there are a hundred other Idle issues, many with
patches
Charles-François Natali added the comment:
Should be fixed now.
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20065
Paul Moore added the comment:
I had not noticed that, but yes. It would be unreasonable on Windows to install
pip3 and pip3.4 but not plain pip. So +1 on this change.
(In fact, on Windows, omitting the versioned names would conform more closely
to how Python is installed, but it's not
Larry Hastings added the comment:
Here's a first cut at a patch. With this applied Python passes the whole test
suite.
I was surprised at how ticklish the OSError object was about adding a fifth
member, with this weird exception tuples can only have two members policy.
But test_exceptions
Larry Hastings added the comment:
Marking as closed and opening a new issue as per Serhiy's suggestion.
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
New submission from Larry Hastings:
The Windows buildbots are currently broken due to a codec issue. I populated
the nosy list based on the unicode experts from the Experts Index.
http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/4040
test_streamreaderwriter
Larry Hastings added the comment:
Note that this appears to be in Windows-specific code (CP_UTF8), rather than
being cross-platform code which happens to only fail on Windows. So we need
someone who does both Windows and Unicode.
--
___
Python
Changes by Serhiy Storchaka storch...@gmail.com:
--
components: +Unicode, Windows
nosy: +doerwalter, lemburg, serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20571
___
Larry Hastings added the comment:
Use #3.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20283
___
___
Python-bugs-list mailing list
Larry Hastings added the comment:
pattern should be keyword-only, and if used the function should generate a
DeprecationWarning.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20283
___
Dmitry Shachnev added the comment:
Thank you for committing this!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14983
___
___
Python-bugs-list
Larry Hastings added the comment:
Added a test checking that the error messages show up properly.
--
assignee: - larry
stage: needs patch - patch review
Added file: http://bugs.python.org/file34005/larry.oserror.add.filename2.2.diff
___
Python
Serhiy Storchaka added the comment:
Could you try test_ttk_guionly after test_all, test_builtins, test_tcl? If the
issue is not reproduced, try to use binary search: divide the tests before
test_ttk_guionly on to parts, and run tests with one half, then with other.
Repeat until found the
Serhiy Storchaka added the comment:
Unfortunately this patch doesn't fix issue19021. Popen.__del__ is called when
whiping the idlelib.rpc module which was collected in a weaklist. But the
builtins module also was collected in a weaklist and wiped before idlelib.rpc.
Here is revised patch
New submission from Giampaolo Rodola':
http://hg.python.org/cpython/file/29d9638bf449/Lib/subprocess.py#l1144
This was introduced in revision 6b627e121573 and is currently not documented.
I'm not sure whether this is a documentation issue or endtime should have
been _endtime instead.
STINNER Victor added the comment:
It looks to be related to changeset e988661e458c5402c0236cd1084a8671249a760d
Issue #20538: UTF-7 incremental decoder produced inconsistant string when
input was truncated in BASE64 section.
--
___
Python tracker
Giampaolo Rodola' added the comment:
Sorry: revision a161081e8f7c.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20572
___
___
Python-bugs-list
Larry Hastings added the comment:
Serhiy said on IRC that he doesn't have a Windows development environment, so
he didn't think he could help.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20571
Serhiy Storchaka added the comment:
UTF-7 decoder is not related to this test.
The test_readline test was broken from the born, and a part of this test was do
nothing. After fixing it in issue20520, new bugs were exposed: issue20538 and
this. This bug was hidden until fixing issue20538.
Note
Serhiy Storchaka added the comment:
Threading and subprocess tests also evoke a suspicion.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20567
___
Ned Deily added the comment:
$ /usr/local/bin/python3.3 -m test -w -uall test_idle test_ttk_guionly
[1/2] test_idle
[2/2] test_ttk_guionly
can't invoke event command: application has been destroyed
while executing
event generate $w ThemeChanged
(procedure ttk::ThemeChanged line 6)
STINNER Victor added the comment:
The test tries to decode a partial UTF-8 bytes string. The problem is that
codecs.code_page_decode() doesn't implement fully partial decoders. The decoder
only supports partial decoding for a few code pages: 932, 936, 949, 950, and
1361. The partial decoding
Changes by Ned Deily n...@acm.org:
--
versions: +Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20567
___
___
Python-bugs-list mailing
New submission from Vladimir Rutsky:
http://docs.python.org/2/library/repr.html page contains several links on
built-in function `repr()` (search for built-in repr() on page), but links
goes to `Repr.repr()` functions of `Repr` module instead of
Changes by Ned Deily n...@acm.org:
--
versions: +Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20567
___
___
Python-bugs-list mailing
Ned Deily added the comment:
The combination of just test_idle followed by test_ttk_guionly also produces
the application has been destroyed messages on Debian Linux and when run from
a build directory (e.g. not installed) and with 2.7, 3.3, and default.
--
title: test_ttk_guionly
Changes by Ned Deily n...@acm.org:
--
assignee: - docs@python
components: +Documentation
nosy: +docs@python
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20573
___
Roundup Robot added the comment:
New changeset 6b10943a5916 by Serhiy Storchaka in branch '2.7':
Issue #20437: Fixed 43 potential bugs when deleting objects references.
http://hg.python.org/cpython/rev/6b10943a5916
New changeset 6adac0d9b933 by Serhiy Storchaka in branch '3.3':
Issue #20437:
Roundup Robot added the comment:
New changeset 4f6499fc2f09 by Victor Stinner in branch 'default':
Issue #20571: skip test_readline() of test_codecs for Windows code page 65001.
http://hg.python.org/cpython/rev/4f6499fc2f09
--
nosy: +python-dev
___
Serhiy Storchaka added the comment:
_send_bytes() now looks a little complicated.
There are no need in separate branches for n==0. header + buf where buf is b''
is fast (it is not slower than additional check n 0). So this
microoptimization is not needed.
The chunks list is not needed, we
Changes by Antoine Pitrou pit...@free.fr:
--
resolution: rejected - fixed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20540
___
___
Serhiy Storchaka added the comment:
Are *WithUnicodeFilenames() functions needed? Py_UNICODE API considered as
deprecated and there is no need to support compatibility with older versions.
--
___
Python tracker rep...@bugs.python.org
Larry Hastings added the comment:
There aren't any deprecation warnings in the code.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20517
___
Serhiy Storchaka added the comment:
http://docs.python.org/3/c-api/unicode.html#deprecated-py-unicode-apis
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20517
___
Jeroen Ruigrok van der Werven added the comment:
Nick et al,
currently trying b3 and using the bundled pip (1.5.2) to update the bundled
setuptools from 2.1 to 2.2 on Windows 7 and I get the following. Any idea if
this is still an issue with the newer versions (and thus might be relevant to
Tal Einat added the comment:
It's an old patch and it may not be in a properly recognized format.
I'll create a new patch soon.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3068
___
Larry Hastings added the comment:
But the PyErr_ functions that accept Py_UNICODE aren't marked deprecated.
http://docs.python.org/3.4/c-api/exceptions.html#unicode-exception-objects
--
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
Perhaps they should be. Note that all functions that accept Py_UNICODE are not
a part of stable API.
In any case I don't think we should add *new* functions with deprecated API.
--
___
Python tracker
New submission from STINNER Victor:
(Follow up of issue #20538 and #20571.) Attached patch implements incremental
decoders for multibyte code pages (on Windows), especially for CP_UTF8 aka
cp65001 in Python.
Code pages 932, 936, 949, 950 and 1361 already have an incremental decoder
since:
STINNER Victor added the comment:
I opened #20574 to implement the missing feature for cp65001.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20571
New submission from Oscar Benjamin:
As of issue20481, the statistics module for Python 3.4 will disallow any mixing
of numeric types with the exception of int that can mix with any other type
(but only one at a time). My understanding is that this change was not
necessarily considered to be a
New submission from Larry Hastings:
I just realized that the signatures for builtin slot functions (__iadd__,
__delitem__, etc) only accept positional-only arguments. But when I added the
signatures by hand to all the slots I didn't mark them as positional-only. The
attached patch remedies
Serhiy Storchaka added the comment:
Nice.
Could you please also add test_partial for CP65001 (if this will make sense)?
What is performance regression of this patch?
I considered this issue as a bug. And if performance regression is not too big,
I think it can be applied to 3.3+. Otherwise a
Glenn Langford added the comment:
OK, code is ready for review at
http://code.google.com/p/tulip/source/detail?r=674355412f33
This looks like a link to an old revision.
--
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
Thanks Larry and Antoine for your reviews.
--
assignee: - serhiy.storchaka
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Changes by Serhiy Storchaka storch...@gmail.com:
--
components: +IDLE
nosy: +kbk, roger.serwy, terry.reedy
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20567
___
Georg Brandl added the comment:
I agree.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20517
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
Attached is patch #3. This one has been tested on Linux, Windows 7 64-bit, and
Snow Leopard 64-bit. Windows Server 2008 32-bit and 64-bit
are running now, looking good so far.
Changes:
* The order of arguments for OSError is now:
(errno, string,
Terry J. Reedy added the comment:
Ned, do you actually *see* this on 2.7, 3.3? The message looks suspiciously
like the somewhat strange 3.4-only shutdown message suppressed by #20167.
--
___
Python tracker rep...@bugs.python.org
R. David Murray added the comment:
Indeed, there's no issue number or NEWS entry. It's not clear from the limited
context why this parameter was added. It doesn't appear to be consistent with
the rest of the stdlib: the application can compute timeout from its desired
endtime, which is how
R. David Murray added the comment:
Also, the implementation as it stands is in any case flawed, since specifying
both timeout and endtime is allowed by the code, and results in endtime
overriding timeout silently, and in the posix version the resulting timeout
error message will have the
Serhiy Storchaka added the comment:
Here is a patch which fixes symptoms. Maybe we'll find better solution.
These messages are produced when the ttk::ThemeChanged command called from a
callback for already destroyed Tk root window.
--
keywords: +patch
Added file:
Terry J. Reedy added the comment:
Please do; the devguide says which format is preferred. While you are at it,
please
1. write it against 3.3, leaving a 2.7 backport for last;
2. just add the new stuff, leaving format-paragraph changes for a separate
patch;
3. consider the format points I
Serhiy Storchaka added the comment:
I'm not sure that PyErr_SetFromWindowsErrWithFilenames() and
PyErr_SetExcFromWindowsErrWithFilenames() will be useful. const char*
filenames are not recommended on Windows. Victor can say more.
--
nosy: +haypo
Tal Einat added the comment:
I'm glad that adding features to IDLE is being considered! However, I really
think that new features should be chosen with extreme care. Adding advanced
features aimed mostly at power users should be avoided unless really
necessary, IMO.
The reason I'm pushing
Terry J. Reedy added the comment:
Running just the two tests fails on windows also, with all three versions. For
2.7, test_ttk_guionly is skipped with test_ttk_guionly skipped -- tk not
available: Can't find a usable init.tcl in the following directories:. This in
spite of the fact that the
Serhiy Storchaka added the comment:
Clipboard history is OS feature, an application shouldn't duplicate it. Every
modern Linux DE has builtin clipboard history manager, and I believe there are
third-party programs for Windows.
--
nosy: +serhiy.storchaka
Larry Hastings added the comment:
New patch incorporating Serhiy's suggestions. Thanks, Serhiy!
Did more testing with the buildbots. Windows Server 2008 32-bit and 64-bit
were both fine. So were ARMv7, OpenIndiana 64-bit, Gentoo 32-bit, FreeBSD 10
64-bit, and PowerLinux PPC 64-bit. (This
New submission from Tal Einat:
Following up issue3068, this is a separate patch which moves the paragraph
reformat width setting from the general tab in IDLE's config dialog to the
relevant place in the extensions configuration.
--
components: IDLE
files:
taleinat.20140209
from this patch the moving of the line width setting for the
FormatParagraph extension from the base config dialog to the extensions config.
See separate patch for this in issue20577.
--
Added file:
http://bugs.python.org/file34014/taleinat.20140209
Serhiy Storchaka added the comment:
Thank you Martin.
May be this issue was fixed in issue19020.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5712
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - duplicate
stage: needs patch - committed/rejected
status: open - pending
superseder: - Regression: Windows-tkinter-idle, unicode, and 0xxx filename
___
Python tracker
Larry Hastings added the comment:
One more tweak from Serhiy.
--
Added file: http://bugs.python.org/file34015/larry.oserror.add.filename2.5.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20517
STINNER Victor added the comment:
It might be faster, or (more likely) has zero impact on performances.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20574
___
STINNER Victor added the comment:
Support of bytes filenames has ben deprecated on Windows, Unicode is really
the native type.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20517
___
Nick Coghlan added the comment:
I believe that may be an actual bug in the 3.4b3 email module (especially
if pip 1.5.2 behaves itself in 3.3). If you can reproduce the error with
the default branch (or rc1 when it's available), please file a new issue
(with me, Larry and R. David Murray on the
Serhiy Storchaka added the comment:
Here is updated patch (after committing issue20368 which made main
refactoring). It makes PythonCmd never fail due to arguments decoding error.
--
Added file: http://bugs.python.org/file34016/tkinter_pythoncmd_args_2.patch
Nick Coghlan added the comment:
Good catch, and the patch looks fine to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20576
___
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6815
___
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19974
___
___
Serhiy Storchaka added the comment:
I think we can close this issue as far as the bug is in third-party software
and we can't do anything with this.
--
status: open - pending
___
Python tracker rep...@bugs.python.org
Giampaolo Rodola' added the comment:
I'd be for just getting rid of it for 3.4 now that we still can.
Being that this parameter is 1) not documented and 2) it's not even clear what
it does I think it's unlikely that there's people using it.
--
nosy: +georg.brandl, larry
priority:
Arfrever Frehtes Taifersar Arahesis added the comment:
AFAIK distutils is no longer frozen.
--
nosy: +Arfrever
resolution: wont fix -
stage: committed/rejected - patch review
status: closed - open
versions: +Python 3.5 -Python 3.4
___
Python tracker
Antoine Pitrou added the comment:
This sounds fine.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20535
___
___
Python-bugs-list mailing list
Jeroen Ruigrok van der Werven added the comment:
Yes, looks like it is just the email module:
F:\Python33Scripts\pip3.3.exe install -U setuptools
Downloading/unpacking setuptools from
R. David Murray added the comment:
Yes, that issue was fixed on Friday. It is *possible* the fix still has a
problem though, since the code in question is still different from that in
3.3.3.
--
nosy: +r.david.murray
___
Python tracker
New submission from Nikolaus Rath:
It would be nice to have a readinto1 method to complement the existing read,
readinto, and read1 methods of io.BufferedIOBase.
--
components: Library (Lib)
messages: 210794
nosy: nikratio
priority: normal
severity: normal
status: open
title:
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20578
___
___
Python-bugs-list
Nikolaus Rath added the comment:
(I'll work on a patch for this myself, this bug is just to prevent duplicate
work)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20578
___
Larry Hastings added the comment:
Okay. I have revived the Py_UNICODE functions I removed in patch #3. The
patch now works fine on my Ubuntu 13.10 64-bit box, and at least compiled on a
Windows buildbot. It's now building on nine buildbots.
Assuming the buildbots look good, can I check
Vajrasky Kok added the comment:
So why check specifically for 8bit and base64?
I was in hurry when creating this patch. I think that was part of the debug
code. This patch was created with the purpose to illuminate the culprit of this
bug. And it served its purpose.
After uploading this
Roundup Robot added the comment:
New changeset 081a9d8ba3c7 by Larry Hastings in branch 'default':
Issue #20517: Functions in the os module that accept two filenames
http://hg.python.org/cpython/rev/081a9d8ba3c7
--
nosy: +python-dev
___
Python
Changes by Martin Panter vadmium...@gmail.com:
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20318
___
___
Python-bugs-list
Roundup Robot added the comment:
New changeset 28aef6e22736 by Larry Hastings in branch 'default':
Issue #20530: The signatures for slot builtins have been updated
http://hg.python.org/cpython/rev/28aef6e22736
--
___
Python tracker
Vajrasky Kok added the comment:
Now, that we have fixed this bug in Python 3.4 with this commit
http://hg.python.org/cpython/rev/081a9d8ba3c7, what should we do with the bug
in Python 3.3?
Use my patch (omitting filenames)?
Keep the status quo (one filename)? If yes, close this ticket as
Larry Hastings added the comment:
It's in! And the buildbots look healthy.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20517
Larry Hastings added the comment:
I used a different issue number in Misc/NEWS, but this was fixed in revision
28aef6e22736 checked in just a little while ago.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
Vajrasky Kok added the comment:
Yeah, you are right, Serhiy. I check the behaviour of GNU tar command line. It
always replaces the target no matter what kind of file source and target are.
--
___
Python tracker rep...@bugs.python.org
88 matches
Mail list logo