[issue17482] functools.update_wrapper mishandles __wrapped__

2014-02-18 Thread Nick Coghlan
Nick Coghlan added the comment: Mike, could you file a new issue for that? It's a genuine regression in the inspect module. -- ___ Python tracker ___

[issue20648] 3.4 cherry-pick: multiple changesets for asyncio

2014-02-18 Thread Guido van Rossum
Guido van Rossum added the comment: Thanks for checking! On Tuesday, February 18, 2014, Larry Hastings wrote: > > Larry Hastings added the comment: > > For what it's worth, > > Lib/asyncio/* > Lib/test/test_asyncio/* > Doc/library/async* > > are all exactly the same between default and the tar

[issue20648] 3.4 cherry-pick: multiple changesets for asyncio

2014-02-18 Thread Larry Hastings
Larry Hastings added the comment: For what it's worth, Lib/asyncio/* Lib/test/test_asyncio/* Doc/library/async* are all exactly the same between default and the tarball I published this evening. (Minus Yury's cleanup patch of course.) -- ___ Pytho

[issue20648] 3.4 cherry-pick: multiple changesets for asyncio

2014-02-18 Thread Guido van Rossum
Guido van Rossum added the comment: Actually I am trying to quell the tide. :-). But nobody sent me a review request for those... On Tuesday, February 18, 2014, Larry Hastings wrote: > > Larry Hastings added the comment: > > Perhaps, but if they request cherry-picking for revisions after > 2e8

[issue20648] 3.4 cherry-pick: multiple changesets for asyncio

2014-02-18 Thread Yury Selivanov
Yury Selivanov added the comment: > Perhaps, but if they request cherry-picking for revisions after 2e8a142dbccc, > skipping 2e8a142dbccc will make the cherry-picking a lot harder. Yes, it may make it harder, it's probably better to merge it (no functional changes in it). I now think that pep

[issue20648] 3.4 cherry-pick: multiple changesets for asyncio

2014-02-18 Thread Larry Hastings
Larry Hastings added the comment: Perhaps, but if they request cherry-picking for revisions after 2e8a142dbccc, skipping 2e8a142dbccc will make the cherry-picking a lot harder. And I bet I haven't seen the last request for cherry-picking asyncio changes for 3.4.0. --

[issue20648] 3.4 cherry-pick: multiple changesets for asyncio

2014-02-18 Thread Guido van Rossum
Guido van Rossum added the comment: TBH I don't think typos or pep8 cleanups ought to be CP'ed... On Tuesday, February 18, 2014, Larry Hastings wrote: > > Larry Hastings added the comment: > > 2e8a142dbccc just missed today's cherry-picking session. I'll add it > tomorrow. > > -- > >

[issue4806] Function calls taking a generator as star argument can mask TypeErrors in the generator

2014-02-18 Thread pfctdayelise
Changes by pfctdayelise : -- nosy: +pfctdayelise ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue20648] 3.4 cherry-pick: multiple changesets for asyncio

2014-02-18 Thread Larry Hastings
Larry Hastings added the comment: 2e8a142dbccc just missed today's cherry-picking session. I'll add it tomorrow. -- ___ Python tracker ___ __

[issue20648] 3.4 cherry-pick: multiple changesets for asyncio

2014-02-18 Thread Yury Selivanov
Yury Selivanov added the comment: changeset: 89268:2e8a142dbccc tag: tip user:Yury Selivanov date:Tue Feb 18 22:56:15 2014 -0500 files: Lib/asyncio/base_events.py Lib/asyncio/subprocess.py Lib/test/test_asyncio/t description: asyncio: pep8-ify the code.

[issue20648] 3.4 cherry-pick: multiple changesets for asyncio

2014-02-18 Thread Yury Selivanov
Yury Selivanov added the comment: Minor stuff: changeset: 89267:2b0e65df8821 tag: tip user:Yury Selivanov date:Tue Feb 18 22:27:48 2014 -0500 files: Lib/asyncio/events.py Lib/asyncio/protocols.py Lib/asyncio/selector_events.p description: asyncio: Fix spelling a

[issue20676] 3.4 cherry-pick: a63327162063 Mangle __parameters in __annotations__ dict properly

2014-02-18 Thread Larry Hastings
Larry Hastings added the comment: ok. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.or

[issue20679] 3.4 cherry-pick: 587fd4b91120 improve Enum subclass behavior

2014-02-18 Thread Larry Hastings
Larry Hastings added the comment: I'd like a second opinion about this before it goes in, just due to the size of the patch. -- ___ Python tracker ___ __

[issue20670] 3.4 cherry-pick: 2dd4922c9371 set line and column numbers for keyword-only arg nodes (#20619)

2014-02-18 Thread Larry Hastings
Larry Hastings added the comment: ok. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.or

[issue20675] 3.4 cherry-pick: 69d13cdc4eeb fix 64-bit build on 32-bit Windows

2014-02-18 Thread Larry Hastings
Larry Hastings added the comment: ok. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.or

[issue20665] 3.4 cherry-pick: 400a8e4599d9 rename posix_close to avoid namespace clash

2014-02-18 Thread Larry Hastings
Larry Hastings added the comment: (And obviously this is okay by me.) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue20647] 3.4 cherry-pick: d50a95fab002 add tracemalloc.Traceback.format() method

2014-02-18 Thread Larry Hastings
Larry Hastings added the comment: ok. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.or

[issue20653] Pickle enums by name

2014-02-18 Thread Larry Hastings
Larry Hastings added the comment: If you want this in 3.4.0, please create a "3.4 cherry-pick" issue for it. Personally I would feel a lot more confident in the change if there was any evidence of it being reviewed before it was checked in. All I see is a four-minute window between the patch

[issue20677] Minor typo in enum docs

2014-02-18 Thread Saimadhav Heblikar
Saimadhav Heblikar added the comment: Corrects the typo. -- keywords: +patch nosy: +sahutd Added file: http://bugs.python.org/file34142/enum-typo-fix.diff ___ Python tracker ___

[issue20678] re does not allow back references in {} matching operator

2014-02-18 Thread Matthew Barnett
Matthew Barnett added the comment: Yes. If it's not a valid repeat, then it's treated as a literal. Perl does the same. By the way, "\1" isn't a group reference; it's the same as "\x01". You should be either doubling the backslashes ("\\1") or using a raw string literal (r"\1"). --

[issue19748] test_time failures on AIX

2014-02-18 Thread David Edelsohn
David Edelsohn added the comment: With the patch, the results are: ERROR: test_ctime (test.test_time.TimeTestCase) -- Traceback (most recent call last): File "/home/dje/src/cpython/Lib/test/test_time.py", line 239, in test_cti

[issue20682] test_create_ssl_unix_connection() of test_asyncio failed on "x86 Tiger 3.x"

2014-02-18 Thread Yury Selivanov
Yury Selivanov added the comment: Looking at a man page for getsockname on Mac OS X (10.9): BUGS: Names bound to sockets in the UNIX domain are inaccessible; getsockname() returns a zero-length address. If you are not on macos: http://www.manpages.info/macosx/getsockname.2.html -- __

[issue17482] functools.update_wrapper mishandles __wrapped__

2014-02-18 Thread mike bayer
mike bayer added the comment: OK well, let me just note what the issue is, and I think this is pretty backwards-incompatible, and additionally I really can't find any reasonable way of working around it except for just deleting __wrapped__. It would be nice if there were some recipe or docume

[issue20682] test_create_ssl_unix_connection() of test_asyncio failed on "x86 Tiger 3.x"

2014-02-18 Thread Yury Selivanov
Changes by Yury Selivanov : -- priority: normal -> release blocker ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue20682] test_create_ssl_unix_connection() of test_asyncio failed on "x86 Tiger 3.x"

2014-02-18 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +hynek, ned.deily, ronaldoussoren ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue20682] test_create_ssl_unix_connection() of test_asyncio failed on "x86 Tiger 3.x"

2014-02-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset 64ad965a2fd4 by Victor Stinner in branch 'default': Issue #20682: test_asyncio, _basetest_create_connection() checks also the http://hg.python.org/cpython/rev/64ad965a2fd4 -- nosy: +python-dev ___ Python

[issue17482] functools.update_wrapper mishandles __wrapped__

2014-02-18 Thread mike bayer
mike bayer added the comment: i think I found the problem. sorry for the noise. -- ___ Python tracker ___ ___ Python-bugs-list mailin

[issue20628] csv.DictReader

2014-02-18 Thread Sean Rodman
Sean Rodman added the comment: That is supposed to say I couldn't find the subsection that I needed to reference in the documentation. -- ___ Python tracker ___

[issue20678] re does not allow back references in {} matching operator

2014-02-18 Thread steven Michalske
steven Michalske added the comment: The RE compiler will not error out, with a back reference in there... It treats the {\1} as a literal {\1} in the string. In [180]: re.search("(\d) fo.{\1}", '3 foo{\1}').group(0) Out[180]: '3 foo{\x01}' -- ___ Pyt

[issue20628] csv.DictReader

2014-02-18 Thread Sean Rodman
Sean Rodman added the comment: Here is the equivalent 2.7 patch. I used a relative link with the format `sequence `_ in order to link to the collections page. I tried to use the reference syntax but I could find the subsection that I needed to reference in the documentation. If you would like

[issue20682] test_create_ssl_unix_connection() of test_asyncio failed on "x86 Tiger 3.x"

2014-02-18 Thread STINNER Victor
New submission from STINNER Victor: http://buildbot.python.org/all/builders/x86%20Tiger%203.x/builds/7907/steps/test/logs/stdio == FAIL: test_create_ssl_unix_connection (test.test_asyncio.test_events.KqueueEventLoopTests) -

[issue17482] functools.update_wrapper mishandles __wrapped__

2014-02-18 Thread mike bayer
mike bayer added the comment: this is actually biting me, I think, though I'm having a very hard time getting a small Python script to duplicate it :/. https://bitbucket.org/zzzeek/alembic/issue/175/test-suite-failure-under-python34 refers to the current problems I'm having. I am not reall

[issue20671] test_create_at_shutdown_with_encoding() of test_io hangs on "SPARC Solaris 10 OpenCSW 3.x"

2014-02-18 Thread STINNER Victor
STINNER Victor added the comment: Oh... A single build on this buildbot takes 10 hours. Maybe the buildbot is slow or busy? Maybe the timeout on this buildbot should be increased? Other hangs: http://buildbot.python.org/all/builders/SPARC%20Solaris%2010%20OpenCSW%203.x/builds/803/steps/test/l

[issue20671] test_create_at_shutdown_with_encoding() of test_io hangs on "SPARC Solaris 10 OpenCSW 3.x"

2014-02-18 Thread Larry Hastings
Larry Hastings added the comment: For what it's worth I don't mind the noise, if indeed it's a false alarm. I'm glad you're keeping an eye on the buildbots too. -- ___ Python tracker _

[issue20671] test_create_at_shutdown_with_encoding() of test_io hangs on "SPARC Solaris 10 OpenCSW 3.x"

2014-02-18 Thread STINNER Victor
STINNER Victor added the comment: > It looks like a serious regression. Oops, I am no more sure. Tests of the build 814 didn't hang. -- priority: release blocker -> ___ Python tracker

[issue20671] test_create_at_shutdown_with_encoding() of test_io hangs on "SPARC Solaris 10 OpenCSW 3.x"

2014-02-18 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +benjamin.peterson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue20671] test_create_at_shutdown_with_encoding() of test_io hangs on "SPARC Solaris 10 OpenCSW 3.x"

2014-02-18 Thread STINNER Victor
STINNER Victor added the comment: It looks like a serious regression. -- nosy: +larry priority: normal -> release blocker ___ Python tracker ___ _

[issue20648] 3.4 cherry-pick: multiple changesets for asyncio

2014-02-18 Thread STINNER Victor
STINNER Victor added the comment: changeset: 89265:089ce5ddc147 tag: tip user:Victor Stinner date:Wed Feb 19 01:45:59 2014 +0100 files: Lib/asyncio/unix_events.py Lib/test/test_asyncio/test_unix_events.py description: asyncio, Tulip issue 143: UNIX domain methods

[issue20648] 3.4 cherry-pick: multiple changesets for asyncio

2014-02-18 Thread STINNER Victor
STINNER Victor added the comment: changeset: 89264:2406566d2c04 tag: tip user:Victor Stinner date:Wed Feb 19 01:40:41 2014 +0100 files: Lib/asyncio/proactor_events.py Lib/asyncio/selector_events.py Lib/asyncio/unix_events.py Lib/test/test_asyncio/test_proactor_ev

[issue20676] 3.4 cherry-pick: a63327162063 Mangle __parameters in __annotations__ dict properly

2014-02-18 Thread Yury Selivanov
Yury Selivanov added the comment: And this one: http://hg.python.org/cpython/rev/5202aca8a673 changeset: 89261:5202aca8a673 user:Victor Stinner date:Tue Feb 18 22:07:56 2014 +0100 summary: Issue #20625: Fix compilation issue -- _

[issue20648] 3.4 cherry-pick: multiple changesets for asyncio

2014-02-18 Thread Yury Selivanov
Yury Selivanov added the comment: http://hg.python.org/cpython/rev/72dba0d11235 changeset: 89263:72dba0d11235 user:Yury Selivanov date:Tue Feb 18 18:41:13 2014 -0500 summary: asyncio.transports: Make _ProactorBasePipeTransport use _FlowControlMixin -- __

[issue20635] Fix the grid geometry manager and add tests for geometry managers

2014-02-18 Thread Ned Deily
Ned Deily added the comment: With test_geometry_managers_2.patch, test_tk now passes with all of the previously tested OS X Tk versions. -- ___ Python tracker ___ __

[issue20648] 3.4 cherry-pick: multiple changesets for asyncio

2014-02-18 Thread Yury Selivanov
Yury Selivanov added the comment: changeset: 89262:7c1de1ebb894 tag: tip user:Yury Selivanov date:Tue Feb 18 18:02:19 2014 -0500 files: Lib/asyncio/base_events.py Lib/asyncio/events.py Lib/asyncio/futures.py Lib/asyncio/proactor_events.py Lib/asyncio/selector_ev

[issue20681] asyncio: New error handling API

2014-02-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7c1de1ebb894 by Yury Selivanov in branch 'default': asyncio: New error handling API. Issue #20681. http://hg.python.org/cpython/rev/7c1de1ebb894 -- nosy: +python-dev ___ Python tracker

[issue20681] asyncio: New error handling API

2014-02-18 Thread Yury Selivanov
New submission from Yury Selivanov: This is a proxy issue for https://code.google.com/p/tulip/issues/detail?id=80 -- assignee: yselivanov messages: 211566 nosy: gvanrossum, haypo, yselivanov priority: normal severity: normal status: open title: asyncio: New error handling API type: enhan

[issue20681] asyncio: New error handling API

2014-02-18 Thread Yury Selivanov
Changes by Yury Selivanov : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue19612] test_subprocess: sporadic failure of test_communicate_epipe() on Windows 8

2014-02-18 Thread STINNER Victor
STINNER Victor added the comment: > Sorry, forget everything I said. (That includes the LGTM, sadly -- as I wrote > earlier I don't know this code very well.) Don't worry, I'm confident in my change :) -- ___ Python tracker

[issue20628] csv.DictReader

2014-02-18 Thread R. David Murray
R. David Murray added the comment: Yes, that does sound better. If you can make an equivalent 2.7 patch I will apply them. -- versions: +Python 3.3 ___ Python tracker ___ _

[issue19612] test_subprocess: sporadic failure of test_communicate_epipe() on Windows 8

2014-02-18 Thread Guido van Rossum
Guido van Rossum added the comment: Sorry, forget everything I said. (That includes the LGTM, sadly -- as I wrote earlier I don't know this code very well.) -- ___ Python tracker __

[issue6839] zipfile can't extract file

2014-02-18 Thread Adam Polkosnik
Adam Polkosnik added the comment: It might not be a regular "security" issue, but it is not extracting some files that it should. There's a possible scenario, where it can be a security issue. -- ___ Python tracker

[issue20677] Minor typo in enum docs

2014-02-18 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +ethan.furman ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue20510] Test cases in test_sys don't match the comments

2014-02-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: What about following test? with self.assertRaises(SystemExit) as cm: sys.exit() self.assertIsNone(cm.exception.code) -- nosy: +serhiy.storchaka ___ Python tracker

[issue12691] tokenize.untokenize is broken

2014-02-18 Thread Gareth Rees
Gareth Rees added the comment: Thanks for your work on this, Terry. I apologise for the complexity of my original report, and will try not to do it again. -- ___ Python tracker

[issue20680] Pickle socket enums by names

2014-02-18 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: As far as socked enums are platform depending, pickling them by value makes not much sense. Here is a patch which makes AddressFamily and SocketType members be pickled by name. -- components: Library (Lib) files: socket_enums_pickle_by_name.patch k

[issue19612] test_subprocess: sporadic failure of test_communicate_epipe() on Windows 8

2014-02-18 Thread STINNER Victor
STINNER Victor added the comment: > LGTM. Thanks for the review. > Please commit in both repos and add to the list of cherrypicks for Larry. Both repos? You mean Tulip? This issue is specific to subprocess not asyncio (asyncio.subprocess). This sporadic bug is not new. IMO it exists since Py

[issue19612] test_subprocess: sporadic failure of test_communicate_epipe() on Windows 8

2014-02-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset 83013a7be836 by Victor Stinner in branch '3.3': Issue #19612: On Windows, subprocess.Popen.communicate() now ignores http://hg.python.org/cpython/rev/83013a7be836 New changeset 423cb79640eb by Victor Stinner in branch 'default': (Merge 3.3) Issue #1

[issue20625] Argument names in __annotations__ are not mangled for functions defined inside class scope

2014-02-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5202aca8a673 by Victor Stinner in branch 'default': Issue #20625: Fix compilation issue http://hg.python.org/cpython/rev/5202aca8a673 -- ___ Python tracker ___

[issue20653] Pickle enums by name

2014-02-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Ha! You just has committed a patch which I write right now. Thank you Guido for your time machine. -- ___ Python tracker ___ ___

[issue20678] re does not allow back references in {} matching operator

2014-02-18 Thread Matthew Barnett
Matthew Barnett added the comment: I don't know of any regex implementation that lets you do that. -- type: behavior -> enhancement ___ Python tracker ___ ___

[issue15871] Online docs: make index search always available.

2014-02-18 Thread Terry J. Reedy
Terry J. Reedy added the comment: I believe I somewhere proposed that there be an option to get more *if one wanted more*. The real waste is not using the available index resources. -- ___ Python tracker _

[issue20679] 3.4 cherry-pick: 587fd4b91120 improve Enum subclass behavior

2014-02-18 Thread Ethan Furman
New submission from Ethan Furman: 587fd4b91120: Better pickle support for Enum subclasses. -- assignee: larry messages: 211552 nosy: ethan.furman, larry priority: release blocker severity: normal stage: commit review status: open title: 3.4 cherry-pick: 587fd4b91120 improve Enum subclas

[issue20678] re does not allow back references in {} matching operator

2014-02-18 Thread steven Michalske
New submission from steven Michalske: When writing a regular expression to match the following text. d = """num interesting lines: 3 1 2 3 foo""" # I only want to match the interesting lines. m = re.match(".+?: (\d+)\n((?:.+\n){\1})", d) print(m) # prints: None # Expected a match object. print

[issue20653] Pickle enums by name

2014-02-18 Thread Ethan Furman
Ethan Furman added the comment: Proposal to switch to pickle by name rejected, but Enum now allows __reduce_ex__ to be overwridden in subclasses. -- priority: release blocker -> normal ___ Python tracker _

[issue20653] Pickle enums by name

2014-02-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset 587fd4b91120 by Ethan Furman in branch 'default': Close issue20653: allow Enum subclasses to override __reduce_ex__ http://hg.python.org/cpython/rev/587fd4b91120 -- nosy: +python-dev resolution: -> fixed stage: patch review -> committed/rej

[issue9974] tokenizer.untokenize not invariant with line continuations

2014-02-18 Thread Terry J. Reedy
Terry J. Reedy added the comment: The \ continuation bug is one of many covered by #12691 and its patch, but this came first and it focused on only this bug. With respect to this issue, the code patches are basically the same; I will use tests to choose between them. On #12691, Gareth notes th

[issue20660] Starting a second multiprocessing.Manager causes INCREF on all object created by the first one.

2014-02-18 Thread Richard Oudkerk
Richard Oudkerk added the comment: On Unix, using the fork start method (which was the only option till 3.4), every sub process will incref every shared object for which its parent has a reference. This is deliberate because there is not really any way to know which shared objects a subproces

[issue20628] csv.DictReader

2014-02-18 Thread Sean Rodman
Changes by Sean Rodman : Removed file: http://bugs.python.org/file34136/DictReader_DictWriter_python3.patch ___ Python tracker ___ ___ Python

[issue20628] csv.DictReader

2014-02-18 Thread Sean Rodman
Sean Rodman added the comment: What about if I put "The *fieldnames* parameter is a :mod:`sequence ` whose elements are associated with the fields of the input data in order. These elements become the keys of the resulting dictionary." It contains all of the information that you have but it fe

[issue20653] Pickle enums by name

2014-02-18 Thread Ethan Furman
Ethan Furman added the comment: Patch allows subclass to override __reduce_ex__, which is useful if a mixed-in type does not have proper pickle support. -- Added file: http://bugs.python.org/file34138/issue20653.stoneleaf.01.patch ___ Python tracker

[issue12691] tokenize.untokenize is broken

2014-02-18 Thread Terry J. Reedy
Terry J. Reedy added the comment: I fixed the assert and dropped first iter compat-mode token bugs one-by-one by writing narrow unittests that fail and code that makes them pass. I am now working on the '\' continuation issue. That is the subject of #9974, which has a nearly identical patch. W

[issue20653] Pickle enums by name

2014-02-18 Thread Ethan Furman
Ethan Furman added the comment: And it is now possible to override and pickle by name if your custom subclass so chooses. -- ___ Python tracker ___ _

[issue20653] Pickle enums by name

2014-02-18 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Feb 18, 2014, at 07:57 PM, Serhiy Storchaka wrote: >This is sad. Because after a release, change it will be much harder. OTOH, if default-pickling-by-name could be overridden, so can default-pickling-by-value. -- __

[issue20653] Pickle enums by name

2014-02-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This is sad. Because after a release, change it will be much harder. -- ___ Python tracker ___ ___

[issue20653] Pickle enums by name

2014-02-18 Thread Guido van Rossum
Guido van Rossum added the comment: It should not be changed after the release either. On Tue, Feb 18, 2014 at 11:57 AM, Serhiy Storchaka wrote: > > Serhiy Storchaka added the comment: > > This is sad. Because after a release, change it will be much harder. > > -- > > __

[issue20653] Pickle enums by name

2014-02-18 Thread Guido van Rossum
Guido van Rossum added the comment: For the record I'm against it, but I don't have time to explain until after 3.4 has been released. -- nosy: +gvanrossum ___ Python tracker __

[issue20631] python readline module crashing on NULL access

2014-02-18 Thread Todd Fiala
Todd Fiala added the comment: Cleaned up the proposed patch a bit. Moves HIST_ENTRY* into a tighter block and removes the second call to history_get() since the value is already stashed in the NULL-checked local. -- Added file: http://bugs.python.org/file34137/python_2.7.6_module_rea

[issue20648] 3.4 cherry-pick: multiple changesets for asyncio

2014-02-18 Thread Guido van Rossum
Guido van Rossum added the comment: This one needs to be CP'ed together with Yuri's UNIX sockets one. changeset: 89257:f81106f36656 tag: tip user:Guido van Rossum date:Tue Feb 18 10:24:30 2014 -0800 summary: asyncio: Make tests pass on Windows. -- ___

[issue20677] Minor typo in enum docs

2014-02-18 Thread flashk
New submission from flashk: On line 142 in the enum library documentation, I believe the text is missing "you". It should be changed from: "If have an enum member and need its name or value:" to: "If you have an enum member and need its name or value:" -- assignee: docs@python compon

[issue20628] csv.DictReader

2014-02-18 Thread R. David Murray
R. David Murray added the comment: This looks pretty good. In the DictReader part, it might be good to add something analogous to the DictWriter clarifying what the order of the sequence means. Something like "a :mod:`sequence ` whose elements are associated with the fields of the input data

[issue20628] csv.DictReader

2014-02-18 Thread Sean Rodman
Sean Rodman added the comment: Ok, I have take the approach I used with the original patch and applied it to this one, listing that fieldnames is a sequence. Then, I added a link to the collections abstract on that instance of the word sequence. I did this for both DictReader and DictWriter as

[issue20628] csv.DictReader

2014-02-18 Thread Sean Rodman
Changes by Sean Rodman : Removed file: http://bugs.python.org/file34135/DictReader_python3.patch ___ Python tracker ___ ___ Python-bugs-list m

[issue20628] csv.DictReader

2014-02-18 Thread Sean Rodman
Changes by Sean Rodman : Removed file: http://bugs.python.org/file34109/DictReader_DictWriter_2.patch ___ Python tracker ___ ___ Python-bugs-l

[issue20676] 3.4 cherry-pick: a63327162063 Mangle __parameters in __annotations__ dict properly

2014-02-18 Thread Yury Selivanov
New submission from Yury Selivanov: Revision: a63327162063 Larry, please consider including this in 3.4. It's a small bug, that was in python since the time annotations were introduced. It's a shame that it was undiscovered for such a long time, and I think it should absolutely be fixed in 3.4,

[issue20628] csv.DictReader

2014-02-18 Thread R. David Murray
R. David Murray added the comment: I'd like to combine the two approaches: mention that fieldnames is a sequence (with the link) as soon as fieldnames is introduced in the paragraph, analogous to what you did in the first patch. Whether you then make what becomes the second occurrence of the

[issue20625] Argument names in __annotations__ are not mangled for functions defined inside class scope

2014-02-18 Thread Yury Selivanov
Changes by Yury Selivanov : -- assignee: -> yselivanov resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python

[issue20625] Argument names in __annotations__ are not mangled for functions defined inside class scope

2014-02-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset a63327162063 by Yury Selivanov in branch 'default': Mangle __parameters in __annotations__ dict properly. Issue #20625. http://hg.python.org/cpython/rev/a63327162063 -- nosy: +python-dev ___ Python tracke

[issue15871] Online docs: make index search always available.

2014-02-18 Thread Georg Brandl
Georg Brandl added the comment: What a waste indeed. After all, when I want to search I only ever want one single match to be displayed. -- ___ Python tracker ___ __

[issue20675] 3.4 cherry-pick: 69d13cdc4eeb fix 64-bit build on 32-bit Windows

2014-02-18 Thread Zachary Ware
New submission from Zachary Ware: I broke cross-building 64-bit binaries on 32-bit Windows in issue #19788, 69d13cdc4eeb fixes it. -- assignee: larry components: Build, Windows messages: 211529 nosy: larry, zach.ware priority: release blocker severity: normal stage: commit review status

[issue20628] csv.DictReader

2014-02-18 Thread Sean Rodman
Sean Rodman added the comment: Here is a patch for DictReader that adds a mod link to the sequence abstract as requested. Please review this if you could and let me know what you think. Note: This patch is for python 3 and if you like how I have done it on here I will go ahead and create a pat

[issue20609] Always running kill_python breaks building x64 on 32-bit Windows machine

2014-02-18 Thread Zachary Ware
Zachary Ware added the comment: Fixed, thanks for the report! -- assignee: -> zach.ware resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___

[issue20609] Always running kill_python breaks building x64 on 32-bit Windows machine

2014-02-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset d610a2740b5f by Zachary Ware in branch '3.3': Issue #20609: Fix building 64-bit binaries on 32-bit Windows. http://hg.python.org/cpython/rev/d610a2740b5f New changeset 69d13cdc4eeb by Zachary Ware in branch 'default': Issue #20609: Merge with 3.3. h

[issue20674] Update comments in dictobject.c

2014-02-18 Thread Raymond Hettinger
New submission from Raymond Hettinger: The hash function comments in Objects/dictobject.c no longer match the implementation: """ /* Major subtleties ahead: Most has

[issue20673] asyncio: Add support for UNIX Domain Sockets.

2014-02-18 Thread Yury Selivanov
Changes by Yury Selivanov : -- nosy: +gvanrossum ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue20648] 3.4 cherry-pick: multiple changesets for asyncio

2014-02-18 Thread Yury Selivanov
Yury Selivanov added the comment: Two new cherry-picks: changeset: 89253:d6c7d1f18915 tag: tip user:Yury Selivanov date:Tue Feb 18 12:21:57 2014 -0500 files: Misc/NEWS description: Misc/NEWS: Add a news item for UNIX Sockets support in asyncio. Cleanup WS. cha

[issue20673] asyncio: Add support for UNIX Domain Sockets.

2014-02-18 Thread Yury Selivanov
New submission from Yury Selivanov: This is a proxy issue for: https://code.google.com/p/tulip/issues/detail?id=81 -- assignee: yselivanov messages: 211523 nosy: yselivanov priority: normal severity: normal status: open title: asyncio: Add support for UNIX Domain Sockets. versions: Pytho

[issue20673] asyncio: Add support for UNIX Domain Sockets.

2014-02-18 Thread Yury Selivanov
Changes by Yury Selivanov : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue15871] Online docs: make index search always available.

2014-02-18 Thread Terry J. Reedy
Terry J. Reedy added the comment: We have collectively spent much time creating reasonably good module and term indexes and more improvements can and will be made. I strongly feel that they should be made as easily searchable and usable as the full text searches that are generally less useful

[issue20622] Python3.3 venv pip fails to run if path contains spaces

2014-02-18 Thread Éric Araujo
Éric Araujo added the comment: another program specified shebang → another program specified using a shebang -- ___ Python tracker ___ ___

[issue20622] Python3.3 venv pip fails to run if path contains spaces

2014-02-18 Thread Éric Araujo
Éric Araujo added the comment: > Wow that is a very compelling argument that I am hesitant to raise a counter > point against. I was not making an argument to describe a choice made by Python developers, but describing how unix shells have been working for the last decades. The behavior you

[issue19612] test_subprocess: sporadic failure of test_communicate_epipe() on Windows 8

2014-02-18 Thread Guido van Rossum
Guido van Rossum added the comment: LGTM. Please commit in both repos and add to the list of cherrypicks for Larry. On Tue, Feb 18, 2014 at 1:40 AM, STINNER Victor wrote: > > STINNER Victor added the comment: > > If I add a sleep of 1 second before stdin.write(), the test always fail > with OSE

  1   2   >