Larry Hastings added the comment:
An even slighter tweak to the patch, just using De Morgan's law to make the
code easier to read.
--
Added file:
http://bugs.python.org/file34168/larry.fix.help.on.bound.methods.5.diff
___
Python tracker
David Edelsohn added the comment:
With the latest patch, test_time passes.
time.mktime((-100, 1, 10) + (0,)*6)
Traceback (most recent call last):
File stdin, line 1, in module
OverflowError: mktime argument out of range
time.mktime((-100, 1, 10) + (0,)*6)
Traceback (most recent call last):
Matthew Iversen added the comment:
Hi, I'm wondering why this branch was never merged in?
AFIAK, it's roundabout here -
http://hg.python.org/cpython/log/28e4cd8fd864/Lib/packaging/command/upload.py
It'd be great to have distutils submit forms that are compliant with the MIME
spec (in my use
Ethan Furman added the comment:
More explanation:
__getnewargs__ is not used by pickle protocol 0 and 1; to support those
protocols we need __reduce_ex__. Since __reduce_ex__ works for 0, 1, 2, 3, 4,
... there's no reason to have both __reduce_ex__ *and* __getnewargs__.
--
Eli Bendersky added the comment:
If you were enlightened about how to use the pickle protocols, please explains
this better in the code. Currently the code says:
# check for a supported pickle protocols, and if not present sabotage
+# pickling, since it won't work anyway.
+
dongwm added the comment:
Yes, it has tests. I just modified do_longs and short_has_arg. In
Lib/test/test_getopt.py, test_do_longs and test_short_has_arg can do it.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20457
dongwm added the comment:
I have signed the contributor agreement form. The new version of the official
web site seem some css style display problems.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20457
Ethan Furman added the comment:
Larry,
If I make changes to the patch, should I reverse the original and then commit
one new one so you only have one to merge in, or do you mind having two to do?
--
___
Python tracker rep...@bugs.python.org
Yury Selivanov added the comment:
Updated patch. The entire test suite pass.
--
Added file: http://bugs.python.org/file34169/sig_bound_02.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20711
Eli Bendersky added the comment:
The discussion in #20653 is ongoing but I have to say I don't feel confident
about this issue at all.
If anything, I'd prefer to explicitly mark advanced pickling support for
enums as provisional in 3.4 - this is a simple documentation fix Larry should
have
Ethan Furman added the comment:
Thanks for your comments, Eli, I'll work on getting better comments in the code.
The qualname comment is partially related to the pickling changes as it's
necessary for protocol 4 (I forgot to put that comment in on the previous
pickling change that addressed
Ethan Furman added the comment:
Can we do that? If a doc change can make it so we're not locked in to
supporting __getnewargs__ I could live with that.
Although, to be honest, I'd rather get the change in *and* have a doc warning
that pickling specifics are subject to change in 3.5. Really,
Larry Hastings added the comment:
I bet you want this cherry-picked; please create a separate issue for that.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20711
___
Larry Hastings added the comment:
If you've committed something already, and want to change it, then please
request both revisions be cherry-picked.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20679
Roundup Robot added the comment:
New changeset 2000c27ebe80 by Yury Selivanov in branch 'default':
inspect: Fix getfullargspec to support builtin module-level functions. Issue
#20711
http://hg.python.org/cpython/rev/2000c27ebe80
--
nosy: +python-dev
Yury Selivanov added the comment:
Thanks Larry!
I bet you want this cherry-picked
Very much so! I'll create a new issue.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20711
New submission from Yury Selivanov:
Larry, please consider cherry-picking 2000c27ebe80.
Another bug in newly renovated 'inspect.getfullargspec()', this time with
module-level builtins. Would be great if it supports them well in 3.4.
changeset: 89314:2000c27ebe80
tag: tip
user:
Changes by Yury Selivanov yselivanov...@gmail.com:
--
keywords: -3.4regression
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20715
___
___
Larry Hastings added the comment:
Updated with tests. And I built without docstrings and it still passed. And
if I revert the change to Lib/pydoc.py the tests fail.
--
Added file:
http://bugs.python.org/file34170/larry.fix.help.on.bound.methods.6.diff
Larry Hastings added the comment:
We still have a couple of weeks left. Ethan, can you start a discussion in
python-dev about cherry-picking this for 3.4?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20679
Larry Hastings added the comment:
I went ahead and added tests for os.stat, and the unbound versions of the two
class methods. Total of five new tests now.
--
Added file:
http://bugs.python.org/file34171/larry.fix.help.on.bound.methods.7.diff
___
Larry Hastings added the comment:
You're right, that was the exact same test ;-)
So what I did was: move the other tests down into that test class, as that's a
better fit, and keep the new version of the test.
--
Added file:
Yury Selivanov added the comment:
Looks good to me. Those unit tests give some confidence ;)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20710
___
Roundup Robot added the comment:
New changeset 5e73bb72662e by Larry Hastings in branch 'default':
Issue #20710: The pydoc summary line no longer displays the self parameter
http://hg.python.org/cpython/rev/5e73bb72662e
--
nosy: +python-dev
___
New submission from Larry Hastings:
5e73bb72662e
--
assignee: larry
components: Library (Lib)
messages: 211817
nosy: larry
priority: release blocker
severity: normal
status: open
title: 3.4 cherry-pick: 5e73bb72662e pydoc shouldn't display self for bound
methods
versions: Python 3.4
Changes by Larry Hastings la...@hastings.org:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20710
___
Changes by Larry Hastings la...@hastings.org:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20716
___
Yury Selivanov added the comment:
With this patch 'help' now correctly renders classmethods, yay
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20710
___
Martin v. Löwis added the comment:
I cannot reproduce the problem. It works fine for me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20641
___
Éric Araujo added the comment:
Hi, I'm wondering why this branch was never merged in?
It was, see the comment before with the changeset link.
AFIAK, it's roundabout here -
http://hg.python.org/cpython/log/28e4cd8fd864/Lib/packaging/command/upload.py
I don’t understand what you mean.
101 - 130 of 130 matches
Mail list logo
