Georg Brandl added the comment:
OK, a hopefully complete overview of the network-using tests and the services
they use, checked by tracing connect() calls during a test run:
* test_codecencodings_*, test_normalization, test_ucn: some Unicode-related
data files from
unicode.org:80
Changes by Roumen Petrov bugtr...@roumenpetrov.info:
--
nosy: +rpetrov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22724
___
___
Ned Deily added the comment:
I believe it is the case that none of these proposed changes would have any
effect on Aqua (native, non-X11) OS X Tk variants (Cocoa or Carbon). Unlike on
Windows and X11, standard OS X menus in conforming GUI apps do not have
underline letter shortcuts. (OS X
Changes by Stefan Krah stefan-use...@bytereef.org:
--
nosy: +doko
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22724
___
___
Python-bugs-list
Vajrasky Kok added the comment:
Here is the preliminary patch. It's a thin wrapper of strsignal.
Some issues and things:
1. About Benjamin Peterson's request, what is the name of the dictionary
supposed to be? Is everyone okay with Benjamin's suggestion?
2. About George Brandl's question: Is
Christian Boos added the comment:
`--user-access-control auto` doesn't work for me...
With Python 2.7.8 installed ''for all'' in C:/Program Files (x86)/Python27,
an installer built with `bdist_wininst --user-access-control auto` will *not*
ask for permission elevation and will crash as
Brett Cannon added the comment:
LGTM
--
assignee: - pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22728
___
___
Python-bugs-list mailing
Mark Lawrence added the comment:
ping.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19980
___
___
Python-bugs-list mailing list
Unsubscribe:
Christian Boos added the comment:
The reason of the crash is pretty trivial, there's no check for success of the
creation of the installation logfile. Trapping this and aborting (with a hint
to use Run as administrator) would be enough to fix the issue, I think.
--
keywords: +patch
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19980
___
___
Changes by Kieran Colford colfo...@gmail.com:
--
nosy: +Kieran.Colford
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13719
___
___
R. David Murray added the comment:
Added a couple review comments on possible further improvements.
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20069
___
New submission from Steve Dower:
I'd like to be able to run ensurepip in the 3.5 installer with pythonw.exe, to
avoid having the console window appear.
Unfortunately, pip requires a valid value for sys.__stdout__. This patch adds a
dummy value for __stdout__ that allows pip to be
Donald Stufft added the comment:
This looks OK to me.
I'm not a Windows person are there changes in pip that would make sense to make
it work without this patch?
--
nosy: +Marcus.Smith, pmoore
___
Python tracker rep...@bugs.python.org
New submission from Steve Dower:
The test_capi.test_forced_io_encoding test currently requires that newlines
match when checking the results. This apparently does not occur with VC10
builds, but does appear with newer versions of the compiler.
This patch normalises the line endings in the
New submission from Steve Dower:
The test_pass_pointer and test_int_pointer_arg tests are inconsistent between
32-bit and 64-bit builds because c_long is always 32 bits but the function
being called may return a 64-bit value (it's a pointer, so c_long may truncate
it).
I'd prefer to have a
New submission from Steve Dower:
The ffi_prep_args function in libffi_msvc/ffi.c needs the attached patch to
handle 64-bit parameters with the correct padding.
Without this patch, garbage may appear in the top part of 64-bit arguments as
the values are not zeroed out by the memcpy.
I'm not
New submission from Steve Dower:
This patch decreases the stack depth limit for Windows debug builds to prevent
the recursion test from failing. (Apparently VC14 uses more stack space for
each frame than VC10, but the release build is unaffected.)
Not sure who the correct nosy for marshal is,
R. David Murray added the comment:
I don't understand why this patch is necessary. The test already joins the
expected output with os.linesep (and doesn't test against err, that's just for
verbose informational purposes). Are you saying that the generated output is
not using os.linesep? In
Steve Dower added the comment:
virtualenv is definitely chattier - it prints out the path where the env will
be and when it is installing setuptools and pip.
That's all that's really needed here too, IMHO - just enough to let users know
that venv has heard them and is doing something (not
Steve Dower added the comment:
I think the only thing pip could do is to stop using print(), which is not a
reasonable request.
It may be reasonable to change pythonw to use dummy IO streams by default, but
that may cause programs to print() messages expecting the user to see them.
It's also
Donald Stufft added the comment:
The development version of pip switches things over to using the Python logging
framework instead of a homegrown one which more or less relies on print().
Probably we could detect if we don't have a stdout and just not output
anything? People can pass a
Steve Dower added the comment:
The generated output is using os.linesep, but the result from
run_embedded_interpreter() is not.
I assume there's a difference (fix) in MSVCRT between VC10 and VC12 (maybe VC11
- didn't test) that causes '\n' to flow through Popen.communicate() where it
Steve Dower added the comment:
That change sounds like it'll be enough, and I'd be surprised if the logging
module doesn't already handle the case with no streams.
(Aside: it'd be nice for ensurepip to have a log file parameter that can be
passed through.)
I'll hold off on merging this in
New submission from Eldar Abusalimov:
The attached patch fixes several bugs revealed by providing a custom mro().
Most of these bugs are reentrancy issues (mainly, cls.__bases__ assignment
within mro() which causes incorrect refcounting), but there are also some
issues when using incomplete
Changes by Eldar Abusalimov eldar.abusali...@gmail.com:
Added file:
http://bugs.python.org/file37026/0001-minor-test_mro-test-case-stub-and-helpers.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
Changes by Eldar Abusalimov eldar.abusali...@gmail.com:
Added file:
http://bugs.python.org/file37029/0004-minor-type_set_bases-move-undoing-logic-to-the-end.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
Changes by Eldar Abusalimov eldar.abusali...@gmail.com:
Added file:
http://bugs.python.org/file37027/0002-test-crashers-NULL-old_mro-and-over-decref-on-reent.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
Changes by Eldar Abusalimov eldar.abusali...@gmail.com:
Added file:
http://bugs.python.org/file37030/0005-minor-type_set_bases-extract-add_all_subclasses.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
Changes by Eldar Abusalimov eldar.abusali...@gmail.com:
Added file:
http://bugs.python.org/file37028/0003-minor-mro_internal-extract-mro_invoke-and-mro_check.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
Changes by Eldar Abusalimov eldar.abusali...@gmail.com:
Added file:
http://bugs.python.org/file37031/0006-minor-mro_subclasses-loop-over-a-list-of-subclasses.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
Eldar Abusalimov added the comment:
This is a patch with most significant changes, please review it carefully.
--
Added file:
http://bugs.python.org/file37032/0007-fix-handle-tp_mro-overwritten-through-reentrancy.patch
___
Python tracker
Changes by Eldar Abusalimov eldar.abusali...@gmail.com:
Added file:
http://bugs.python.org/file37033/0008-test-crashers-tp_base-tp_subclasses-inherit-cycles.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
Changes by Eldar Abusalimov eldar.abusali...@gmail.com:
Added file:
http://bugs.python.org/file37034/0009-minor-PyType_IsSubtype-extract-a-check-using-tp_base.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
Changes by Eldar Abusalimov eldar.abusali...@gmail.com:
Added file:
http://bugs.python.org/file37035/0010-fix-type_set_bases-inherit-cycles-and-reent-checks.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
Changes by Eldar Abusalimov eldar.abusali...@gmail.com:
Added file:
http://bugs.python.org/file37037/0012-minor-mro_implementation-pmerge-refactory.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
Changes by Eldar Abusalimov eldar.abusali...@gmail.com:
Added file:
http://bugs.python.org/file37038/0013-fix-mro_implementation-check-base-tp_mro-is-not-NULL.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
Changes by Eldar Abusalimov eldar.abusali...@gmail.com:
Added file:
http://bugs.python.org/file37036/0011-test-behavior-error-on-extending-an-incomplete-type.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
Changes by Eldar Abusalimov eldar.abusali...@gmail.com:
Added file:
http://bugs.python.org/file37039/0014-test-crasher-attr-lookup-on-super-with-uninitialized.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
Changes by Eldar Abusalimov eldar.abusali...@gmail.com:
Added file:
http://bugs.python.org/file37040/0015-fix-super_getattro-check-type-tp_mro-and-refactory.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
Eldar Abusalimov added the comment:
Just in case, the previous message about reviewing is about [PATCH 07/15] (fix)
handle tp_mro overwritten through reentrancy
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22735
Paul Moore added the comment:
This looks reasonable to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22730
___
___
Python-bugs-list mailing
Paul Moore added the comment:
Wait, sorry I misread the discussion (long day here). If we can do this in pip
yes that would be better. It looks like we can detect when we're being run via
pythonw by checking if sys.stdout is None.
--
___
Python
Changes by Martin Panter vadmium...@gmail.com:
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22678
___
___
Python-bugs-list
Antoine Pitrou added the comment:
Why not use c_size_t? Or is that incorrect in some cases?
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22732
___
Antoine Pitrou added the comment:
This looks harmless to me.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22734
___
___
Martin Panter added the comment:
The new text seems reasonable to me on its own, however I still think the
heapsort() docstring needs updating as well
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22237
New submission from Van Ly:
IMO the box highlight at the top of module documentation, for example, re
module (library/re.html#module-re), ought to place book recommendations at the
very bottom in a section called 'Further Readings'. Why? Because being at the
top of the documentation should
Martin Panter added the comment:
If you adjusted the detect_encoding() logic according to Pete Cordell’s table
at the bottom of
http://www.ietf.org/mail-archive/web/json/current/msg01959.html, it might
work for standalone strings.
However since the RFC encourages UTF-8 for best
eryksun added the comment:
Why not use c_size_t? Or is that incorrect in some cases?
Strictly speaking, size_t doesn't have to encompass the entire addressable
range, such as for architectures that use segmented addressing (e.g. near and
far pointers). Practically speaking, no platform
R. David Murray added the comment:
That's my point. What comes out of communicate *should* be os.linesep, unless
I'm missing something. So this test failing indicates a bug. Of course, I've
never worked with an embedded interpreter, so there could be something I'm
missing. But, you say
paul j3 added the comment:
I'm exploring modifying that patch by adding a 'subnamespace' attribute to the
subparsers Action object. This would give the user, or the main parser control
over the namespace that is passed to a subparser.
For example:
subnamespace = getattr(self,
Van Ly added the comment:
Reference by the guide to next() should stay for the same reason in
re.compile() a regular expression object is returned and the two methods are
mentioned, match() and search(). They are useful to know in that context in as
much as next() is useful to know here. IMO.
New submission from Joshua Harlow:
When a future can't be accepted by an executor that it is has been submitted to
it would be really nice to throw have a type of 'RejectedExecutionException'
(this is the name the java folks have used) to denote that the executors policy
does not allow for
Changes by Martin Panter vadmium...@gmail.com:
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21650
___
___
Python-bugs-list
Changes by Ned Deily n...@acm.org:
--
nosy: +bquinlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22737
___
___
Python-bugs-list mailing list
New submission from Van Ly:
I was looking at sys.argv from the reference guide.
The font mix and change from v.2.7.5 to v.3.5.0a0 for sentence two of sys.argv
(library/sys.html#module-sys) has made the second rendering of -c look capital
when in fact it isn't.
--quote: from v.3.5.0a0 at
57 matches
Mail list logo
