Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - berker.peksag
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23581
___
Ethan Furman added the comment:
Slight reordering of code removed the one user visible change.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23486
___
eryksun added the comment:
To me, the reference to the windows internal function is
worse than useless and should perhaps be removed.
The docs could add an example commandline to edit the per-user .ini:
NT 6: notepad %LOCALAPPDATA%\py.ini
NT 5: notepad %USERPROFILE%\Local
Roundup Robot added the comment:
New changeset 2545bfe0d273 by Ethan Furman in branch 'default':
Close issue23486: performance boost for enum member lookup
https://hg.python.org/cpython/rev/2545bfe0d273
--
nosy: +python-dev
resolution: - fixed
stage: commit review - resolved
status:
Changes by Ethan Furman et...@stoneleaf.us:
--
stage: - test needed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23640
___
___
Python-bugs-list
David Beazley added the comment:
inal comment. It seems that one can generally avoid a lot of nastiness if
importlib.reload() is used instead. For example:
mod = sys.modules[spec.name] = module_from_spec(spec)
importlib.reload(mod)
This works for both source and Extension modules and
Brett Cannon added the comment:
Egg files are not a part of the Python stdlib and so I don't understand why you
expected them to be supported by imp? Anyway, because egg files are not from
Python itself but a third-party project they shouldn't be referenced from the
official docs as it would
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +brett.cannon, eric.snow, ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23642
___
STINNER Victor added the comment:
You should also update the PEP 461.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23467
___
___
Roundup Robot added the comment:
New changeset 611fa301b807 by Ethan Furman in branch 'default':
Close issue23467: add %r compatibility to bytes and bytearray
https://hg.python.org/cpython/rev/611fa301b807
--
nosy: +python-dev
resolution: - fixed
stage: - resolved
status: open -
Ethan Furman added the comment:
The only solution that is coming to mind is to have EnumMeta go through the
other base classes, wrap any classmethods it finds, and ensure that they return
their appropriate type and not an Enum type.
Any other ideas?
--
David Beazley added the comment:
Sorry. I take back the previous message. It still doesn't quite do what I
want. Anyways, any insight or thoughts about this would be appreciated ;-).
--
___
Python tracker rep...@bugs.python.org
Changes by Serhiy Storchaka storch...@gmail.com:
--
dependencies: +unittest.mock.MagicMock doesn't support matmul (@) operator
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23641
___
Changes by Ethan Furman et...@stoneleaf.us:
--
keywords: +patch
stage: test needed - needs patch
Added file: http://bugs.python.org/file38444/issue23640.stoneleaf.01.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23640
New submission from David Beazley:
I have been investigating some of the new importlib machinery and the addition
of ModuleSpec objects. I am a little curious about the intended handling of C
Extension modules going forward.
Backing up for a moment, consider a pure Python module. It seems
Thomas Guettler added the comment:
Dear Bret Cannon,
I don't ask for egg support in the imp module.
I don't want to change the implemenation of imp.find_module()
I just want to update the docs.
Most people run a python version which supports loading zipped eggs.
Please reopened this, since I
Roundup Robot added the comment:
New changeset 2b4a04c3681b by Serhiy Storchaka in branch '3.4':
Issue #23192: Fixed generator lambdas. Patch by Bruno Cauet.
https://hg.python.org/cpython/rev/2b4a04c3681b
New changeset a3b889e9d3f3 by Serhiy Storchaka in branch 'default':
Issue #23192: Fixed
Brett Cannon added the comment:
LGTM as well. You want to commit, Serhiy? If not assign to me and I will get to
it on Friday.
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23615
Roundup Robot added the comment:
New changeset 383ba3699084 by Serhiy Storchaka in branch '3.4':
Issue #23615: Modules bz2, tarfile and tokenize now can be reloaded with
https://hg.python.org/cpython/rev/383ba3699084
New changeset 6e736a57a482 by Serhiy Storchaka in branch 'default':
Issue
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: commit review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23615
___
Éric Araujo added the comment:
I think like Ezio does. Python covers itself by saying that all names starting
and ending with two underscores are reserved, and documents those that are
interesting for users. On the other hand, many third-party
frameworks/libs/apps invent their own __names__
Changes by Peter Otten __pete...@web.de:
--
nosy: +peter.otten
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23639
___
___
Python-bugs-list
Steve Dower added the comment:
For a per-user install, the launcher does not go in C:\Windows (note that
Python 3.4 does not really have per-users installs). The correct location for
the ini file in every case is alongside the executable, and it must always be
named py.ini.
py.exe is put
Nathan Jensen added the comment:
I'm not sure this was fixed in an optimal way.
We have a set of processes using the SocketHandler to send log records to a
single log process. Some of these log records have the msg attribute as a
dictionary that contained a variety of extra information about
STINNER Victor added the comment:
Is there a method to detect other reload bugs?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23615
___
___
Changes by Ned Deily n...@acm.org:
--
nosy: -ned.deily
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23643
___
___
Python-bugs-list mailing list
Ned Deily added the comment:
Isn't this a duplicate of Issue5765 and Issue11383?
--
nosy: -ronaldoussoren
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23643
___
Changes by Ned Deily n...@acm.org:
--
components: -Macintosh
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23643
___
___
Python-bugs-list mailing
New submission from Michael Klein:
I have gotten Segmentation Fault: 11 with the newest version of Python 2.7
and nothing but standard functions. The program is of the following form
(attached to this email):
def loopcountaux(a1, a2, a3, a4, a5, a6, a7, a8, a9, a10, a11, a12, a13, a14,
a15,
Serhiy Storchaka added the comment:
Only grep.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23615
___
___
Python-bugs-list mailing list
Changes by Michael Klein michael14...@gmail.com:
--
type: - crash
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23643
___
___
Python-bugs-list
Michael Klein added the comment:
I found a simpler one, like Amaury's eval(+1 * 748580):
def f(x):
y = x+x+x+x+x
return y
print f(0)
(Except there are 74875 x+'s. This is exactly enough for a segfault, one less
runs fine.)
I've tried something like:
loopcount = 0
loopcount +=
Amaury Forgeot d'Arc added the comment:
Probably a stack overflow, when the AST is too deep:
eval(+1 * 748580) also crashed for me
--
nosy: +amaury.forgeotdarc
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23643
Steve Dower added the comment:
NT 5 would be Vista and earlier in this case, I believe. Specifying
%LOCALAPPDATA% should be sufficient, though %USERPROFILE% (e.g. C:\Users\Steve)
would also be okay.
%ProgramData% is not writable by limited users, but we don't want the global
.ini to be
eryksun added the comment:
Specifying %LOCALAPPDATA% should be sufficient, though
%USERPROFILE% (e.g. C:\Users\Steve) would also be okay.
The command using %USERPROFILE% was for XP (NT 5.1), since the %LOCALAPPDATA%
environment variable was added in Vista (NT 6.0).
%ProgramData% is not
Terry J. Reedy added the comment:
Good idea, but what do 'NT5' and 'NT6' correspond to in user terms -- Vista,
Win 7, Win 8, and Win 10?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23633
eryksun added the comment:
Good idea, but what do 'NT5' and 'NT6' correspond to in user terms
-- Vista, Win 7, Win 8, and Win 10?
Don't worry about NT 5 if Python's no longer supporting Windows XP in any
fashion. Vista, Windows 7, Windows 8, Windows 8.1, and Windows 10 are
respectively NT
Ethan Furman added the comment:
I think the classmethod-as-constructor behavior is correct, so it's up to
IntEnum (or EnumMeta, or foo, or ...), to work around the issue.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23640
SilentGhost added the comment:
This seems to work on linux (returning 0), but fails on 3.4 with RuntimeError:
maximum recursion depth exceeded during compilation. I wonder if the two are
related.
--
nosy: +SilentGhost
___
Python tracker
Changes by Martin Panter vadmium...@gmail.com:
Added file: http://bugs.python.org/file38448/utf8-null.v3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23088
___
Martin Panter added the comment:
Posting a new patch updating the documentation for some of the extra functions
Serhiy mentioned. Also changed references of “NUL”, “nul” and “0” characters to
“null”. I’m not very familiar with Python’s C API, so I am mainly relying on
what you guys say
Martin Panter added the comment:
In case it’s not clear to others, the first bit of code is from the
shutil.copytree() implementation at Lib/shutil.py:303.
The documentation currently says “The destination directory . . . must not
already exist”. Yuriy seems to be proposing to make copytree()
Larry Hastings added the comment:
Oh, I read the code. But it's a performance hack, and the rules say we only
accept security fixes and bug fixes at this stage of the release, and they're
the rules for good reasons.
--
___
Python tracker
Martin Panter added the comment:
The patches at Issue 19771 should remove the part of the message that
incorrectly says “. . . is a package and cannot be directly executed”. However
that still leaves the problem of the suppressed traceback.
I am posting runpy-traceback.patch here which adds
New submission from Lukáš Němec:
File /usr/lib/python2.7/warnings.py, line 29, in _show_warning
file.write(formatwarning(message, category, filename, lineno, line))
File /usr/lib/python2.7/warnings.py, line 38, in formatwarning
s = %s:%s: %s: %s\n % (filename, lineno,
Martin Panter added the comment:
Posting a new patch with the following changes:
* Added Poleto’s original tests, updated according to review comments. Combined
the flag and source code string parameters.
* Used a different approach to guessing where the offending ImportError came
from. Now
Martin Panter added the comment:
Posting finding-spec.patch which just has another test I wrote. It tests if
AttributeError/ValueError/TypeError gets wrapped in the “finding spec”
ImportError, though I’m not sure if this is a bug or a feature, hence I kept it
separate. And again I’m not sure
Ethan Furman added the comment:
Argh, sorry -- that was supposed to be *does not* change user behavior nor the
API, it's *just* a performance increase.
Does that change your inclination?
--
___
Python tracker rep...@bugs.python.org
eryksun added the comment:
I guess you were mainly testing with Python 2. Python 3 on Linux
does not raise any error either
In Python 3 os.fdopen delegates to io.open, which calls io.FileIO to create the
raw file object. This doesn't verify a compatible mode on the file descriptor.
New submission from Serhiy Storchaka:
Here are lists of special names used in Python core and the stdlib, but absent
in documentation index.
Module level names used in pydoc:
__author__
__credits__
__date__
__version__
Module level name used in doctest:
__test__
Other
Martin Panter added the comment:
I think this one can be closed. Let me know if I was mistaken :)
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23526
STINNER Victor added the comment:
issue23566_update.patch looks good to me, but I suggested some minor changes.
Usually, I do such changes myself, but I proposed this issue on the Python
menthorship list, so I prefer to do the changes to learn the process of
reviewing patches and taking
STINNER Victor added the comment:
I think this one can be closed. Let me know if I was mistaken :)
Correct, I forgot to close it, thanks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23526
Mario Figueiredo added the comment:
This patch is a huge improvement over the current situation, which is we don't
have a cross-platform curses implementation in the standard library.
The alternatives listed by Mark aren't sufficient. For the two reasons given
below:
- The implementation at
New submission from yuriy_levchenko:
We have a code:
names = os.listdir(src)
if ignore is not None:
ignored_names = ignore(src, names)
else:
ignored_names = set()
os.makedirs(dst)
errors = []
But if I had created this folder. I have exception.
Paul Moore added the comment:
The patch would need updating to be applicable. Minimum changes I would expect
to be required:
1. Update to build for Python 3.5 (the patch will *not* be included in earlier
versions, as it is a new feature), which means it needs the Visual Studio 2015
build
Changes by Berker Peksag berker.pek...@gmail.com:
--
stage: commit review - resolved
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23526
___
___
Berker Peksag added the comment:
Serhiy already reviewed the latest patch. Just one more comment: The deprecated
API should be documented in Doc/whatsnew/3.5.rst and
Doc/library/http.cookies.rst.
--
___
Python tracker rep...@bugs.python.org
Yann Sionneau added the comment:
Here is a test related to Sebastien's patch.
--
nosy: +ysionneau
Added file: http://bugs.python.org/file38441/asyncio_multibind_test.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23630
STINNER Victor added the comment:
Combine patch written for CPython tree, so we get the review button.
--
Added file: http://bugs.python.org/file38442/multibind.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23630
New submission from Serhiy Storchaka:
Example:
import socket
x = socket.AddressFamily.from_bytes(b'\1', 'big')
type(x)
enum 'AddressFamily'
int(x)
1
str(x)
Traceback (most recent call last):
File stdin, line 1, in module
File /home/serhiy/py/cpython/Lib/enum.py, line 464, in __str__
Ezio Melotti added the comment:
I think most of these are either implementation details or private names, so
there is no need to document them. The ones that are intended to be used by
developers or that are useful to understand the functioning of a public API
should be documented. If these
Bruno Cauet added the comment:
Here is a working test, testing yield by lambda function as well as lambda
and function yielding from those.
--
Added file:
http://bugs.python.org/file38440/0001-Add-tests-for-issue-23192.patch
___
Python tracker
Changes by Serhiy Storchaka storch...@gmail.com:
--
dependencies: +__sizeof__ is not documented
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23639
___
Ben Hoyt added the comment:
Note specifically in the unsymlink() example Serhiy gave, you probably don't
*want* os.walk() to recurse into a
symlink-to-a-directory-that's-changed-to-a-directory, and you probably haven't
thought about it doing so, so maybe the new behaviour is fine?
--
Martin Panter added the comment:
I’m not very familiar with the mock module so can't comment if removing div is
sensible there. But all the other changes seem reasonable. I just left a few
suggestions for further tweaks on Rietveld.
--
nosy: +vadmium
Changes by Martin Panter vadmium...@gmail.com:
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23639
___
___
Python-bugs-list
Ben Hoyt added the comment:
To Victor and Serhiy:
1) Serhiy's point about not needing to build the symlinks set when followlinks
is True is a good one, because it'll never get used. Just a if not
followlinks: ... around that try/except would do it. Though this is a small
optimization, as I
New submission from Serhiy Storchaka:
Proposed patch gets rid of uses and mentions of bad dunder names. I.e. names
inherited from Python 2: __cmp__, __nonzero__, __getslice__, __unicode__,
__div__, etc. They are replaced by correct names (__truediv__, __floordiv__,
__eq__, __bool__, etc) or
Berker Peksag added the comment:
Also added support for __matmul__ and __getnewargs_ex__ in unittest.mock [...]
See issue 23581 for __matmul__ support.
--
nosy: +berker.peksag
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
This is not a regression (there were no enums before 3.4), slow down is not
critical (only constant factor, not increased computational complexity), there
is a workaround, and the code that just use constants that were converted to
IntEnum is not affected.
Barry A. Warsaw added the comment:
Poor performance could fall under the category of bug fixes, so for an
in-maintenance mode release, a fix that does not in any way change user visible
behavior could be acceptable. It would probably be fine for 3.4 but I'm just
+0 on it. Larry's call.
Ethan Furman added the comment:
In getting everything fixed up and tested I realized there was one slight
user-facing change: with this patch it is now possible to say:
SomeEnum.SomeMember = SomeMember
In other words, it is possible to set a value on the class as long as it is the
same
Changes by Michael Klein michael14...@gmail.com:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23643
___
___
Martin Panter added the comment:
Encountered this when trying to add some fields to urllib.parse.SplitResult for
Issue 22852. Issue 1173475 has a patch; I haven’t tried using it though.
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
Changes by Martin Panter vadmium...@gmail.com:
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1173475
___
___
Python-bugs-list
Ben Hoyt added the comment:
@Scott Dial: just a response about this benchmark: note that this benchmark
isn't really valid, as it says Using slower ctypes version of scandir, which
is the slow all-Python version. You want it to be saying Using Python 3.5's
builtin os.scandir().
--
Mark Lawrence added the comment:
The functionality described here certainly seems wanted and there's been some
other work on the traceback module recently so could we get this into 3.5?
--
nosy: +BreamoreBoy
versions: +Python 3.5 -Python 3.4
___
78 matches
Mail list logo