Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +lukasz.langa
type: crash - behavior
versions: +Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23835
___
Serhiy Storchaka added the comment:
The patch for issue3999 was rejected because Python internal state may be
corrupted when the SIGSEGV signal is raised. This is not the case of this
issue. gdbm fatal function is called when Python is in consistent state. So we
free to use any Python C-API.
STINNER Victor added the comment:
sock_call-2.patch: add an inner looop in sock_call() to only retry func() when
func() is interrupted by a signal. Limit also changes: try to only modify ctx
around to call to sock_call(), move back some variables to the parent function.
Rename the variable
Changes by STINNER Victor victor.stin...@gmail.com:
Added file: http://bugs.python.org/file38776/traceback_eintr.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23836
___
Changes by STINNER Victor victor.stin...@gmail.com:
Added file: http://bugs.python.org/file38777/faulthandler_eintr.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23836
___
New submission from STINNER Victor:
While working on the PEP 475, I noticed that the faulthandler module doesn't
handle well reentrant calls to its signal handlers. If a signal is received
while faulthandler is displaying the traceback, faulthandler restarts to
display a new traceback (and
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: +neologix
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23836
___
___
STINNER Victor added the comment:
New issue #23836: Enhance faulthandler to handle better reentrant calls.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23648
___
STINNER Victor added the comment:
2015-04-01 10:39 GMT+02:00 Serhiy Storchaka rep...@bugs.python.org:
Other external libraries used by the stdlib also can crash, and perhaps
crashes can be converted to exceptions. This issue is only first in the
series.
I don't think that it's a good
Roundup Robot added the comment:
New changeset 8ec4acfdb851 by Victor Stinner in branch 'default':
Issue #23618: Fix EINTR handling on Windows
https://hg.python.org/cpython/rev/8ec4acfdb851
--
___
Python tracker rep...@bugs.python.org
Changes by STINNER Victor victor.stin...@gmail.com:
--
dependencies: +PEP 475: Enhance faulthandler to handle better reentrant calls
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23648
___
New submission from Mathias Fröjdman:
Script attached which reproduces the issue.
Steps to reproduce:
0) Use python 3.4.3 on Linux. Does not repro with 3.4.0 or 3.4.2.
1) Create a child process with asyncio.create_child_exec and stdout=PIPE
2) loop yield from child.read(n) (i used n=2048, any
Roundup Robot added the comment:
New changeset f8358f6e50e7 by Serhiy Storchaka in branch '2.7':
Issue #23799: Added test.test_support.start_threads() for running and
https://hg.python.org/cpython/rev/f8358f6e50e7
New changeset 8987218adc99 by Serhiy Storchaka in branch '3.4':
Issue #23799:
Changes by Piotr Dobrogost p...@bugs.python.dobrogost.net:
--
nosy: +piotr.dobrogost
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23841
___
___
Serhiy Storchaka added the comment:
We should try to know how it impacts a performance. I suppose not too much, but
may be my intuition lies me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23839
Serhiy Storchaka added the comment:
getlines() already returns an empty list on OSError. Clearing the cache on
MemoryError will help to avoid other MemoryErrors. And after this there is a
large chance the repeated reading will be successful. In any case it wouldn't
make worse.
If don't
New submission from sorin:
The standard library implementation of an OrderedDict (which is included in
Python 3.4) uses a weakref for the root reference.
https://hg.python.org/cpython/file/534b26837a13/Lib/collections/__init__.py#l74
This was reported initially on
Martin Panter added the comment:
The incremental improvement thing sounds good. Here are some things which I
think are orthogonal to sensible chunked encoding:
* Automagic seeking to determine Content-Length
* Setting Content-Length for iterables that are neither strings, iterators nor
files
Serhiy Storchaka added the comment:
max_rss is a little larger 500 MB after ran all testsuite (except bigmem tests)
on 32-bit Linux. Only few tests needs more than 200 MB. But may be some 64-bit
only tests consume more memory. If a test consume more than 1GiB of memory and
is not decorated
Changes by Serhiy Storchaka storch...@gmail.com:
--
components: +Library (Lib)
stage: - needs patch
type: - resource usage
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23840
___
Arfrever Frehtes Taifersar Arahesis added the comment:
Also please apply inherit-doctype.v2.patch in 3.4 branch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +rhettinger
type: compile error - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23841
___
STINNER Victor added the comment:
Maybe tests known to fill caches should clear theirself caches at cleanup?
Always clearing all caches may have an impact on performances and so makes
tests longer. Caches are designed to speedup Python :-)
We may add some helper functions in test.support for
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: +rbcollins
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23839
___
___
STINNER Victor added the comment:
2015-04-01 14:02 GMT+02:00 Serhiy Storchaka rep...@bugs.python.org:
getlines() already returns an empty list on OSError.
Oh, I misread getlines(), you're right.
Clearing the cache on MemoryError will help to avoid other MemoryErrors. And
after this there
Stefan Krah added the comment:
I have a somewhat general concern: In the last year or so, issues seem
to expand far beyond the scope that's indicated by the issue title.
For example, I don't particularly care about the definition of
bytes-like, but the patch contains changes to areas I *do*
STINNER Victor added the comment:
By the way, a workaround is also to run each test (file) in a new fresh
process. It's a common way to work around memory fragmentation ;-)
On some machines with limited resources this can cause multiple MemoryErrors.
Do you have an idea of the memory usage
Martin Panter added the comment:
Actual post by Raymond:
https://mail.python.org/pipermail/python-dev/2010-December/106790.html
Just noticed there are some arguments for trailing commas in the FAQ:
Serhiy Storchaka added the comment:
OK, here is a patch that just clear the cache and returns an empty result.
It is hard to write reliable test, but I think we will see the result on
OpenIndiana buildbot.
The question is left: should the patch be applied only on 3.5 or all versions?
STINNER Victor added the comment:
It is hard to write reliable test
Ah? Why not using something like mock.patch('mock.updatecache',
side_effect=MemoryError)?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23838
Serhiy Storchaka added the comment:
+1 for the idea overall and the patch LGTM.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23756
___
___
STINNER Victor added the comment:
I sent an email to the python core mentorship mailing list to find a volunteer
to fix this easy issue.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23840
New submission from Serhiy Storchaka:
When format a traceback of MemoryError, linecache tries to read all lines of
source file and likely raises a MemoryError. For example:
http://buildbot.python.org/all/builders/x86%20OpenIndiana%203.x/builds/9712/steps/test/logs/stdio
Traceback (most recent
New submission from Serhiy Storchaka:
Some caches can grow unlimitedly during running the testsuite (in particular
linecache). On some machines with limited resources this can cause multiple
MemoryErrors. Many of these MemoryErrors can be avoided if clear caches between
tests.
Martin Panter added the comment:
After doing a bit of reading and experimenting, I think we should at least
restrict bytes-like objects to “C-contiguous”. Any looser definition risks
memoryview(byteslike).tobytes() returning the bytes in a different order than
their true in-memory order.
STINNER Victor added the comment:
Proposed patch clears the cache and repeats an attempt to read source file,
and returns empty result if the second attempt fails (as when the source file
can't be read).
IMO it's a bad idea. You should not retry an operation on MemoryError but only
do you
New submission from STINNER Victor:
If TextIOWrapper constructor fails in tokenize.open(), the open binary file is
not closed and a ResourceWarning is emited.
Try attached patch:
$ python3 -Wd ~/tokenize_open_bug.py
tokenize.open failed: unknown encoding for 'test.py': xxx
STINNER Victor added the comment:
Serhiy: you look to be interested in fixing Python to not fail badly under low
memory condition. You may take a look at #19817 which proposes a function to
arbitrary limit the memory allocated to Python. I fixed a lot of issues found
by failmalloc, but they
Serhiy Storchaka added the comment:
On other side, linecache tests already use updatecache(). Here is a patch with
a test.
--
Added file: http://bugs.python.org/file38783/linecache_memoryerror_3.patch
___
Python tracker rep...@bugs.python.org
STINNER Victor added the comment:
linecache_memoryerror_3.patch reviewed (comments on Rietveld).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23838
___
R. David Murray added the comment:
The header folding algorithm is...not all that smart. There's a better one in
the new policies in email in python3, which does not have this problem (it does
have a few others, but the plan is to treat them as bugs and fix them :)
IMO this isn't worth
R. David Murray added the comment:
behavior vs enhancment for doc changes is really pretty meaningless/arbitrary,
IMO.
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23484
STINNER Victor added the comment:
The question is left: should the patch be applied only on 3.5 or all versions?
linecache_memoryerror_2.patch looks good to me, but it would be better with an
unit test.
IMO Python 2.7 and 3.4 can be fixed too.
--
Serhiy Storchaka added the comment:
This test depends on implementation details. I prefer to avoid adding such
tests for trivial changes.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23838
Changes by Serhiy Storchaka storch...@gmail.com:
--
type: - resource usage
versions: +Python 2.7, Python 3.4, Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23838
___
R. David Murray added the comment:
Heh, I thought it was closed. I guess my eyes were distracted by the 'fixed'
resolution.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
___
R. David Murray added the comment:
And I'm telling you that *this is how Python is designed*, and it is not going
to change. Class attributes are *special*, for a reason.
Please do not reopen this issue again. If you wish to pursue this further, the
language design discussion forum is the
R. David Murray added the comment:
Looks good to me, thanks.
--
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23779
___
STINNER Victor added the comment:
Oh, it looks like all pause_reading() and resume_reading() methods of
transports check the status the transport (especially the _closing attribute),
except two transports: _UnixReadPipeTransport and _SSLProtocolTransport.
For _SSLProtocolTransport, I don't
Roundup Robot added the comment:
New changeset 26778732099d by Serhiy Storchaka in branch '3.4':
Issue #23821: Fixed test_pdb failure under -O.
https://hg.python.org/cpython/rev/26778732099d
New changeset 23442d957793 by Serhiy Storchaka in branch 'default':
Issue #23821: Fixed test_pdb failure
Roundup Robot added the comment:
New changeset d96e714a by Serhiy Storchaka in branch '2.7':
Issue #23838: linecache now clears the cache and returns an empty result on
https://hg.python.org/cpython/rev/d96e714a
New changeset 88a0e6cd93c3 by Serhiy Storchaka in branch '3.4':
Issue
Serhiy Storchaka added the comment:
Thank you for your review Xavier.
--
assignee: - serhiy.storchaka
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
R. David Murray added the comment:
Oh, and about the general concern: I agree that this issue was apparently about
the glossary entry, so making other changes is suspect and at a minimum
requires adding relevant people from the experts list to nosy to get proper
review of other proposed
R. David Murray added the comment:
I found the explanation of C-contiguous vs Fortran-contiguous helpful (and I've
programmed in both of those languages, though granted not much :). However,
based on that it is not obvious to me why having a fortran-contiguous buffer
prevents it from being
Serhiy Storchaka added the comment:
Thank you for your review Victor. Will look on OpenIndiana buildbot.
--
assignee: - serhiy.storchaka
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker
Serhiy Storchaka added the comment:
What people are needed? The patch looks as great improvement to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23756
___
R. David Murray added the comment:
Stefan, since he's the current maintainer of the memoryview implementation.
Fortunately he spotted the issue :) Maybe Antoine, too; he's done work in this
area. I'll add him.
--
nosy: +pitrou
___
Python tracker
Neale Ferguson added the comment:
Thanks. Question/responses in-line
On 4/1/15, 11:14 AM, Amaury Forgeot d'Arc rep...@bugs.python.org wrote:
Amaury Forgeot d'Arc added the comment:
Hi,
First, please fill and submit a Contribution Agreement:
https://www.python.org/psf/contrib/
Done but I
Roundup Robot added the comment:
New changeset 65ac8e587bb0 by Victor Stinner in branch 'default':
Issue #22117, issue #23485: Fix _PyTime_AsMilliseconds() and
https://hg.python.org/cpython/rev/65ac8e587bb0
--
___
Python tracker
Changes by Brett Cannon br...@python.org:
Removed file: http://bugs.python.org/file38785/be7d966b660a.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23731
___
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23842
___
___
Python-bugs-list
Amaury Forgeot d'Arc added the comment:
Hi,
First, please fill and submit a Contribution Agreement:
https://www.python.org/psf/contrib/
Then about the patch:
- This is a patch against Python2.7, which is frozen for new developments. This
change will only be applied to python 3.5 or later.
-
Roundup Robot added the comment:
New changeset 65ac8e587bb0 by Victor Stinner in branch 'default':
Issue #22117, issue #23485: Fix _PyTime_AsMilliseconds() and
https://hg.python.org/cpython/rev/65ac8e587bb0
--
___
Python tracker
Serhiy Storchaka added the comment:
See also issue23376.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23756
___
___
Python-bugs-list mailing
Changes by Brett Cannon br...@python.org:
--
hgrepos: +303
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23731
___
___
Python-bugs-list mailing
Changes by Brett Cannon br...@python.org:
--
keywords: +patch
Added file: http://bugs.python.org/file38785/be7d966b660a.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23731
___
Brett Cannon added the comment:
Here is a patch that implements PEP 488 **except** for Windows installer stuff.
I don't think the Windows changes need to block this patch going in, but I will
need someone on Windows to help fix up PC/, PCbuild/, Tools/msi,
Lib/distutils/command/bdist_msi.py,
New submission from Matthias Klose:
an unreleased version of cinder fails a test when run with python 2.7 from the
branch. I don't have a test case yet, but looking at the error message and
list of fixed issues after the 2.7.9 release, the fix for issue #23098 could be
the culprit.
FAIL:
Terry J. Reedy added the comment:
The CA ack is a * added after your name here. May take a week.
If you are asking whether to submit a new patch against 3.5, with suggested
fixes, yes, please do
.
--
nosy: +terry.reedy
stage: - patch review
versions: +Python 3.5 -Python 2.7
STINNER Victor added the comment:
return '%d:%d' % (os.major(st.st_rdev), os.minor(st.st_rdev))
Can you check if the error comes from os.major() or os.minor(), and please
provide the value of st_rdev?
You can modify the unit test to catch SystemError and raise a new exception
with more
Berker Peksag added the comment:
I use enhancement for non-trivial documentation patches.
Also, quoting from https://docs.python.org/devguide/triaging.html#type
Also used for improvements in the documentation and test suite and for other
refactorings.
In this case, your patch fixes a
Changes by Brett Cannon br...@python.org:
Added file: http://bugs.python.org/file38786/8ce8e9b1f3e7.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23731
___
Matt Chung added the comment:
Updated patch based off of haypo's comment. Changed except Exception as err:
- except
--
Added file: http://bugs.python.org/file38795/tokenize.patch
___
Python tracker rep...@bugs.python.org
Antoine Pitrou added the comment:
From a cursory glance, I still think this is the wrong approach. There's a lot
of complication due to the simple fact that it is subclassing from dict (and
therefore trying to be ABI-compatible, kind of). The linked list scheme should
be much simpler (perhaps
Changes by xiaobing jiang s7v7nisla...@gmail.com:
--
nosy: +s7v7nisla...@gmail.com
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12849
___
___
Martin Panter added the comment:
All the other occurrences of capitalized %X that I can find are not using
Python’s string formatting functions. Please point them out if you can, but all
I can see are some using a Microsoft vfwprintf_s() API, some calling standard C
sprintf(), sscanf(),
Roundup Robot added the comment:
New changeset 920b700d9509 by Victor Stinner in branch 'default':
Issue #23834: Fix sock_call(), set deadline_initialized to recompute the timeout
https://hg.python.org/cpython/rev/920b700d9509
--
___
Python tracker
shiyao.ma added the comment:
Based upon the previous review.
Catch the TextWrapper, move the test into a function.
--
Added file: http://bugs.python.org/file38796/tokenizeV2.patch
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 1ad7c0253abe by Benjamin Peterson in branch '3.4':
replace 512 bit dh key with a 2014 bit one (closes #23844)
https://hg.python.org/cpython/rev/1ad7c0253abe
New changeset 4f2391e86643 by Benjamin Peterson in branch '2.7':
replace 512 bit dh key
Antoine Pitrou added the comment:
Not sure why you're using wrap_socket() directly. Most of the time you should
be using a higher-level library instead (for example a HTTP(S) library).
In any case, the doc already mentions that Starting from Python 3.2, it can be
more flexible to use
Wei Wu added the comment:
@haypo, would you review issue23566_fd_tests_v2.patch? It's been a time since
the last update of it.
However I think the fd tests on windows is just fine to be skipped. So what's
the next plan? Shall we continue to work on it or just resolve this issue?
--
Eric Snow added the comment:
Thanks for speaking up, Antoine. Keep in mind that a C implementation of
OrderedDict has a strict compatibility requirement with the existing pure
Python one. The Python implementation subclasses dict so the C implementation
must as well. I agree that it would
New submission from SeungHyun.Hwang:
I tested on python3.4.2, windows 7
1. Only proactorEvent issued.
2. ThreadPoolExecutor has many workers (in the attached example file, worker
count 20,000)
3. The loop does run_in_executor more call than worker count (in the attached
example file, 40,000
Gregory P. Smith added the comment:
This is blocking Python auto formatters from working properly on Python 3
syntax code. For example: https://github.com/google/yapf/issues/61
--
assignee: - gregory.p.smith
nosy: +gregory.p.smith
priority: low - normal
Changes by Demian Brecht demianbre...@gmail.com:
Added file: http://bugs.python.org/file38797/issue12319_5.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12319
___
Matt Chung added the comment:
Based off of storchaka's comment, moving the
--
Added file: http://bugs.python.org/file38799/tokenize.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23840
Changes by SeungHyun.Hwang thewhiteap...@gmail.com:
--
type: crash - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23846
___
___
Changes by Gregory P. Smith g...@krypto.org:
--
versions: +Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19511
___
___
Python-bugs-list
Changes by Gregory P. Smith g...@krypto.org:
--
versions: -Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19511
___
___
Martin Panter added the comment:
read-defaults.v3.patch:
* Split off test_RawIOBase_readall()
* Changed BufferedIOBase tests to matrix of tuples
* Added tests for empty buffer
* Test that unused part of buffer remains untouched
--
Added file:
Antoine Pitrou added the comment:
Thanks for the patch. It should probably also remove the old file, unless it's
also used somewhere else?
--
nosy: +pitrou
stage: - patch review
versions: +Python 2.7, Python 3.4, Python 3.5
___
Python tracker
Martin Panter added the comment:
pos-defaults.v2.patch includes the results of “make clinic” to fix the doc
strings.
Is there a consensus to use PEP 457’s slash “/” notation? At one point I think
I saw Serhiy was concerned that it might be confusing.
--
Added file:
Martin Panter added the comment:
Serhiy, regarding _getresp() calling resp.decode(): You are probably right that
a failure decoding the response line is recoverable in some circumstances, such
a GROUP command. But in other cases, say an ARTICLE command, the response won’t
have been fully
Eric Snow added the comment:
Thanks for doing this, Brett. It's so simple a change yet such a great one. :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23731
___
Changes by Dan O'Reilly oreil...@gmail.com:
--
nosy: +dan.oreilly
versions: +Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6766
___
___
Matthias Klose added the comment:
so the culprit is an optimization:
Committed to 2.7 with small change: stat() and makedev() should return int
instead of long if possible.
the test case however expects a long. st_dev is now not always a long, but an
int or long depending on the value.
Matthias Klose added the comment:
no, simpler:
import os
os.minor(os.makedev(8,65))
Traceback (most recent call last):
File stdin, line 1, in module
SystemError: ../Objects/longobject.c:998: bad argument to internal function
os.major(os.makedev(8,65))
Traceback (most recent call last):
Changes by Matthias Klose d...@debian.org:
--
nosy: +benjamin.peterson
priority: normal - release blocker
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23842
___
Roundup Robot added the comment:
New changeset 60e001ec141d by Victor Stinner in branch 'default':
Issue #23836: Add _Py_write_noraise() function
https://hg.python.org/cpython/rev/60e001ec141d
New changeset d9b9e2a68e7c by Victor Stinner in branch 'default':
Issue #23836: Document functions
Changes by STINNER Victor victor.stin...@gmail.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23836
___
1 - 100 of 131 matches
Mail list logo
