Tina Zhang added the comment:
Created Quick Reference table subsection under the add_argument() method
section - used the table originally created by xmorel, replacing ticks with 'x'
and adding links to the sections in the documentation for each parameter names.
Removed the 'version' column
Carol Willing added the comment:
@ezio.melotti I've reviewed the second version of the patch and it links as you
requested to 1.1.1. It is ready to be merged.
Thanks ttz.
--
___
Python tracker rep...@bugs.python.org
Brett Cannon added the comment:
Did you happen to run the test suite with this change, Shiz? There's actually a
test to make sure that the part of the traceback you're avoiding isn't lost in
case there's a bug in importlib itself.
Can you show that your change won't actually affect finding
New submission from Ernest:
What the hell. I will create this because there doesn't seem to be a issue
being tracked related to it with the keyword Google and Login in it.
--
messages: 240763
nosy: ozialien
priority: normal
severity: normal
status: open
title: Google Login not working
Ned Deily added the comment:
This also appears to be due to not building with an up-to-date version of the
source (see msg240759 in Issue23939).
--
resolution: - out of date
stage: - resolved
status: open - pending
___
Python tracker
Zachary Ware added the comment:
Thanks for the patch!
--
nosy: +zach.ware
versions: -Python 3.6
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23730
___
Ned Deily added the comment:
For what it's worth, the resolution of Issue23476 uses an API that was added in
OpenSSL 1.0.2.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23686
___
Nick Coghlan added the comment:
It sounds like at least a somewhat functional dis module is a pragmatic
requirement for a Python implementation to support introspection, so +1 for
reverting to the mandatory dependency on dis rather than duplicating its logic.
--
nosy: +ncoghlan
Eric V. Smith added the comment:
I added numeric_owner to the self.chown() call when adding directories. I'm
reasonably sure this is correct.
I added tests for dirs, although they need some cleaning up to be simpler and
cleaner. I'll do that cleanup shortly, but I want to check this in before
Matthias Klose added the comment:
here is the more general approach encoding the triplet into the extension name.
This is tested with GCC and clang (clang at least on x86_64, x86, powerpc,
powerpc64le, arm and aarch64.
--
Added file: http://bugs.python.org/file38964/ma.diff
Changes by Raúl Cumplido raulcumpl...@gmail.com:
--
nosy: +raulcd
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23773
___
___
Python-bugs-list
Al Sweigart added the comment:
+1 to this idea. In classroom settings when I look over the shoulder of
students, usually they're working with IDLE or an editor in a much smaller
window. When I point out how to maximize it, they always enjoy the additional
space.
It seems like a minor thing,
Roundup Robot added the comment:
New changeset 03ff92b26fa9 by Larry Hastings in branch 'default':
Issue #22631: Added Linux-specific socket constant CAN_RAW_FD_FRAMES.
https://hg.python.org/cpython/rev/03ff92b26fa9
--
nosy: +python-dev
___
Python
Changes by Alex Lord lostdogs...@gmail.com:
--
components: +Macintosh
nosy: +ned.deily, ronaldoussoren
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23939
___
Changes by Gregory P. Smith g...@krypto.org:
--
resolution: - rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17630
___
Changes by Antoine Pitrou pit...@free.fr:
--
stage: needs patch - patch review
versions: +Python 3.5 -Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20309
___
Thomas Ballinger added the comment:
Patch reformatted to be non-git style, NEWS item removed
--
Added file: http://bugs.python.org/file38965/issue21217-v5.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21217
Antoine Pitrou added the comment:
here is the more general approach encoding the triplet into the extension
name.
Thanks. Two comments:
- is it possible to avoid the hardcoded list? Maintaining this will be a burden
- it would be nice to have a test
--
Ofer Schwarz added the comment:
I couldn't reproduce this on my machine, but I have no idea if I'm using the
wrong sequence of operations, or type of pool, or if my machine is just faster
or something else entirely.
Johannes, can you upload a repro code for this?
--
nosy: +blackfawn
Yury Selivanov added the comment:
The patch looks good.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23934
___
___
Python-bugs-list mailing
New submission from Alex Lord:
On a fresh clone of cpython 3.5.0a0 if you run
$ ./configure --with-pydebug make -j2
$ ./python.exe -m test.test__osx_support -j3
on osx 10.10.2 (14C109) these two test failures are reported.
Changes by Alex Lord lostdogs...@gmail.com:
--
components: +Macintosh
nosy: +ned.deily, ronaldoussoren
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23940
___
Matthias Klose added the comment:
On 04/13/2015 11:01 PM, Antoine Pitrou wrote:
Antoine Pitrou added the comment:
here is the more general approach encoding the triplet into the extension
name.
Thanks. Two comments:
- is it possible to avoid the hardcoded list? Maintaining this will
Nick Coghlan added the comment:
Maintaining the arch list can be delegated to the platform maintainers, but I
agree a test would be valuable.
I'd suggest a test in the platform module tests that cross-checks the settings
in SOABI. This will also be useful in defining an algorithm that
Changes by Raúl Cumplido raulcumpl...@gmail.com:
--
nosy: +raulcd
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23642
___
___
Python-bugs-list
Carol Willing added the comment:
@ned.deily Thanks for the review. Please push for me. Thanks :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23924
___
Joe Jevnik added the comment:
I have updated the test to make another test that does not have a __len__.
--
Added file: http://bugs.python.org/file38952/bigmem-update.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5438
Ilia Kurenkov added the comment:
This fix has been retested with 2.7, I'm uploading the relevant patch files.
--
nosy: +copper-head
Added file: http://bugs.python.org/file38958/20362_py27.patch
___
Python tracker rep...@bugs.python.org
Changes by Arnon Yaari wiggi...@gmail.com:
Removed file: http://bugs.python.org/file38947/bytes.hex.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9951
___
New submission from Alex Lord:
On a fresh clone of cpython 3.5.0a0 if you run
$ ./configure --with-pydebug make -j2
$ ./python.exe -m test.test__osx_support -j3
on osx 10.10.2 (14C109) these two test failures are reported.
Matthias Klose added the comment:
@barry, worth updating PEP 3149?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22980
___
___
Python-bugs-list
Zachary Ware added the comment:
Steve, Andrew, does either of you want to take care of this or shall I give it
a shot? I'm figuring on using the patch here and re-adding PyCFunction_New as
it had been.
--
___
Python tracker rep...@bugs.python.org
Andrew Svetlov added the comment:
Will do up to weekend.
—
Sent from Mailbox
On Mon, Apr 13, 2015 at 4:58 PM, Zachary Ware rep...@bugs.python.org
wrote:
Zachary Ware added the comment:
Steve, Andrew, does either of you want to take care of this or shall I give
it a shot? I'm figuring on
Changes by Raúl Cumplido raulcumpl...@gmail.com:
--
nosy: +raulcd
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23723
___
___
Python-bugs-list
Marc-Andre Lemburg added the comment:
Are you sure you want to go with OpenSSL 1.0.2a ? It typically takes a few
patch level releases for them to clear out all the major bugs (including
security relevant ones).
For egenix-pyopenssl, we've chose to stay with 1.0.1 for the time being until
the
Shiz added the comment:
Ah, that is a very good point. I'll run the suite as soon as I find the time
and will report back.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23773
___
Zachary Ware added the comment:
Here's an updated patch for clean application. Larry, could you give this a
look?
--
Added file: http://bugs.python.org/file38969/issue20586.v3.diff
___
Python tracker rep...@bugs.python.org
Maciej Szulik added the comment:
Lita always look for them next to your uploaded file, there's a review link
that points to Rietveld Code Review Tool. There you'll find all those
information, just for future use :)
--
___
Python tracker
Changes by Ned Deily n...@acm.org:
--
nosy: +twouters
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4254
___
___
Python-bugs-list mailing list
John Ehresman added the comment:
I think at a minimum, a return should be added in the cases that call
GenerateConsoleCtrlEvent and it fails.
Here's a more radical proposal, though: deprecate kill() on Windows and add a
function that calls GenerateConsoleCtrlEvent and another that calls
Christie added the comment:
Okee dokee, I'll tackle that first!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9517
___
___
Python-bugs-list
Dustin J. Mitchell added the comment:
This fixes the four cases Nick referred to, although not in the functions
expected:
- str.encode no longer exists
- unicode.decode no longer exists
- encoders used by str.encode must return bytes (does not apply to
codecs.encode)
- decoders used by
Jamiel Almeida added the comment:
As pointed by ncoghlan, the test needs to (by definition) not use -E or -I, but
PYTHONSTARTUP env var breaks the test, so the patch makes the env not have any
pre-existing PYTHON* env vars.
Ideally this should be another type of helper in script_helper, no?
Changes by Terry J. Reedy tjre...@udel.edu:
--
versions: +Python 3.5 -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17445
___
___
R. David Murray added the comment:
I've added some review comments. I did not download the patch and run the
tests etc; it would be great if you could find another sprinter (or anyone :)
to do that level of review.
--
___
Python tracker
Marc-Andre Lemburg added the comment:
On 14.04.2015 01:41, Donald Stufft wrote:
I'm pretty massively +1 in Python shipping 1.0.2 (or really, whatever the
latest OpenSSL is) wherever it can, including the OSX installers even on
systems where Apple ships it's ancient OpenSSL.
Eventually,
New submission from Piotr Kasprzyk:
Correct misspellings in various files.
--
assignee: docs@python
components: Documentation
files: misspellings.patch
keywords: patch
messages: 240825
nosy: docs@python, kwadrat
priority: normal
severity: normal
status: open
title: Misspellings in a few
James Edwards added the comment:
Thanks Berker, I responded to most of your comments in rietveld.
A few of your comments suggested we should get rid of X, and while I can't
say I disagree, I really tried to limit the scope of the changes to whitespace
and formatting.
As far as the script
Gijsbert Anthony van der Linden added the comment:
Updated the patch and added tests. Fixed a problem with the previous patch:
result of map function was assumed to be list, however map in Python3 returns
an interator. So I replaced it with a list comprehension.
--
nosy:
Zachary Ware added the comment:
I left a comment on Rietveld. Also, the test doesn't pass on Windows:
test test_unittest failed -- Traceback (most recent call last):
File C:\Data\code\CPython\hg.python.org\devinabox\cpython\lib\unittest\test\t
est_discovery.py, line 677, in
Joe Jevnik added the comment:
here is a patch and test case.
I added an entry to Misc/NEWS. I tried to follow the format; however, let me
know if I have done this incorrectly.
--
keywords: +patch
nosy: +ll
Added file: http://bugs.python.org/file38972/skipitems.patch
Arnon Yaari added the comment:
Creating an automatic test for this issue proves difficult, as using curses to
resize the terminal already updates the values, and using ioctls to try to
bypass curses, doesn't work.
I'm adding a manual test program (mostly taken from
Maciej Szulik added the comment:
Uploading updated version of the patch.
--
Added file: http://bugs.python.org/file38974/issue16914.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16914
Matthias Klose added the comment:
it would be nice to have these constants backported to both 2.7 and 3.4. It may
be good to check for other missing consgtants in this module in 2.7 and 3.4.
--
nosy: +doko
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset e1457e9f340f by R David Murray in branch 'default':
#11754: test contents of string module attributes.
https://hg.python.org/cpython/rev/e1457e9f340f
--
nosy: +python-dev
___
Python tracker
Zachary Ware added the comment:
That's a fair point. So to make my plan work, we'd really need a good
way to differentiate CTRL_C_EVENT and 0. If anybody has any good
ideas on that, I still like my plan. If not, I'm afraid I have to
agree that os.kill will need to go down as doomed by
Terry J. Reedy added the comment:
The blue feather is the tk 8.6 icon. The tk 8.5 and before icon is a red
script 'Tk'.
The title bar icons for Idle were added in #20406. It was a bit of a challenge
to get them to work right and look good enough for all versions on all systems.
The icons
Roundup Robot added the comment:
New changeset e75fd221a53e by Zachary Ware in branch 'default':
Issue #20586: Argument Clinic now ensures signatures on functions without
docstrings.
https://hg.python.org/cpython/rev/e75fd221a53e
--
nosy: +python-dev
Zachary Ware added the comment:
Thanks Larry
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
versions: -Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20586
Donald Stufft added the comment:
I think 1.0.2 is the only version of OpenSSL that has the ability to short
circuit the chain validation which is something that makes it easier for
libraries like requests to remove the weak 1024 bit roots from their SSL
certificate store.
It's also needed
Zachary Ware added the comment:
I think what I'd rather do is deprecate the use of os.kill (on Windows) with a
signal other than CTRL_C_EVENT and CTRL_BREAK_EVENT, document very clearly that
os.kill is strictly for sending signals, and add os.terminate to implement
TerminateProcess.
R. David Murray added the comment:
I think it would be better to move the summary table to the end (just before
the Action section), and add another link to the summary to the sentence The
following sections describe how each of these are used. That is, follow that
sentence with something
R. David Murray added the comment:
Looks like the right approach, I hadn't thought of the design FAQ, but it makes
sense as a place to put it. I made a couple of review comments.
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
Marc-Andre Lemburg added the comment:
On 14.04.2015 01:36, Ned Deily wrote:
https://github.com/openssl/openssl/pull/218
(certificate expiry checks not working)
That issue appears to have been fixed in 1.0.2a, no?
Yes, but it shows the kind of errors to expect in the early
stages of a new
Cyd Haselton added the comment:
Unfortunately starting from scratch did not solve the issue. Still getting a
segfault when the newly built binary tries to run sysconfig
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23496
John Ehresman added the comment:
Here's the 1st draft of a test for interrupts during time.sleep(). It creates
a thread to generate the ctrl-c events which seems to work well (note that
kill() on win32 is quite limited in terms of sending events to other
processes). The creation and use of
New submission from Zachary Ware:
For example:
_winapi_CreateFile_impl(PyModuleDef *module, LPCTSTR file_name, DWORD
desired_access, DWORD share_mode, LPSECURITY_ATTRIBUTES security_attributes,
DWORD creation_disposition, DWORD flags_and_attributes, HANDLE template_file)
--
R. David Murray added the comment:
I made some review comments on ways to use test.support and test.subTest to
simplify the code and make it even clearer. Also, I suggest not using Mock
unless necessary (see review comments).
--
nosy: +r.david.murray
Roundup Robot added the comment:
New changeset 24536e980c9e by Ned Deily in branch 'default':
Issue #21400: Update the code coverage section to remove out-of-date
https://hg.python.org/devguide/rev/24536e980c9e
--
nosy: +python-dev
___
Python tracker
Larry Hastings added the comment:
LGTM
--
assignee: - zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20586
___
___
Python-bugs-list
chalmer_lowe added the comment:
Based on review comments, in order to reduce unnecessary redundancy in the
tests:
- composed later strings from previously defined substrings, where it made
sense to do so.
--
Added file: http://bugs.python.org/file38975/issue11754_patch_2.txt
Ned Deily added the comment:
I don't have a really strong feeling one way or the other. It's not a big
issue for the OS X installers as this only affects the much-less-used
32-bit-only installer for old systems. So this is really primarily an issue
affecting the Windows installers. I guess
Stéphane Wirtel added the comment:
Hi all,
If you think the patch is ok, please merge it, we will close this issue.
Thanks
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13850
___
John Ehresman added the comment:
A problem with os.kill with CTRL_C_EVENT is that CTRL_C_EVENT == 0 and on unix
kill w/ a signal number of 0 is how you test to see if a process is running.
This means that code written on unix to see if a process exists will try to
send a ctrl-c to the other
Larry Hastings added the comment:
If you give me a test case I'll knock this out.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23944
___
___
Ned Deily added the comment:
Done. Thanks for the patch, Heather. (By the way, if you plan to contribute
more changes, please sign the PSF Contributor Form as described here:
https://docs.python.org/devguide/coredev.html#sign-a-contributor-agreement)
--
nosy: +ned.deily
resolution:
R. David Murray added the comment:
Apparently I was imaginig that script_helpers had been moved into test.support.
test.support was changed into a module in prep for doing so, but as far as I
can see it was never moved. So that does remain to be done as well, and should
be done first.
New submission from Maciej Szulik:
During the lifecycle of a bug you do:
1. submit a patch
2. get a review with some comments
3. re-submit the patch
Talking to R. David Murray I got info there's no convention on naming those, I
think it will be valuable to have some information in the devguide
Roundup Robot added the comment:
New changeset 94c3cd410cf6 by Benjamin Peterson in branch '3.4':
remove useless word (closes #23929)
https://hg.python.org/cpython/rev/94c3cd410cf6
New changeset feb0717c1004 by Benjamin Peterson in branch '2.7':
remove useless word (closes #23929)
Changes by Arnon Yaari wiggi...@gmail.com:
Added file: http://bugs.python.org/file38971/manual_test_4254.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4254
___
Marc-Andre Lemburg added the comment:
On 14.04.2015 00:29, Ned Deily wrote:
For what it's worth, the resolution of Issue23476 uses an API that was added
in OpenSSL 1.0.2.
Hmm, I don't think that's a good move at this time.
Most Linux users won't benefit from this since their system
Changes by Arnon Yaari wiggi...@gmail.com:
Added file: http://bugs.python.org/file38973/patch_4254.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4254
___
R. David Murray added the comment:
Thanks, Chalmer. Hopefully Benjamin won't be too annoyed by these :)
--
resolution: - fixed
stage: needs patch - resolved
status: open - closed
versions: -Python 2.7, Python 3.4
___
Python tracker
Zachary Ware added the comment:
As an aside: Pam, I got a bounce notice from the email that Rietveld tried to
send you. It claims that your email account is disabled, though I suspect that
might be it's way of saying it thinks Rietveld is spam (since it tries to send
in the reviewer's name).
Ilia Kurenkov added the comment:
Thanks for the quick response, Berker! Let me address your comments in the
order you made them.
#1: removing checking for kot in the exception args.
This line was causing the tests to fail, which is how I noticed it. The reason
it fails (I think) is caused by
Joe Jevnik added the comment:
So I think the patch could be applied to 3.4; I will look into moving the other
back sometime this week.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22631
Demian Brecht added the comment:
I think it's ok to slightly break a non-public API since it's required to fix
an obvious bug.
To play devil's advocate here, /is/ this really non-public API? According to
documented Python naming conventions, HTTPResponse is part of the public API.
From
Demian Brecht added the comment:
Vincent: The logic to determine content length is undergoing a bit of an
overhaul as part of #12319, which I'm hoping to wrap up in the next week or so.
--
___
Python tracker rep...@bugs.python.org
Zachary Ware added the comment:
Will do in the morning.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23944
___
___
Python-bugs-list mailing
Eric V. Smith added the comment:
Other than Misc/NEWS, I think this is the final version of this patch.
--
Added file:
http://bugs.python.org/file38981/tarfile-numeric-owner-with-tests-3.diff
___
Python tracker rep...@bugs.python.org
Berker Peksag added the comment:
* +.. method:: TarFile.extractall(path=., members=None, numeric_owner=False)
numeric_owner can be a keyword-only argument.
* TarFile.extract and TarFile.extractall docs need a versionchanged directive.
* It would be nice to add an entry to
Joe Jevnik added the comment:
Steve, we talked about the possibility of having you run some of these tests on
a machine with a large amount of ram; I am adding you to the nosy list.
--
nosy: +steve.dower
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 2c53a5302058 by Antoine Pitrou in branch '3.4':
Issue #23309: Avoid a deadlock at shutdown if a daemon thread is aborted
https://hg.python.org/cpython/rev/2c53a5302058
New changeset 8a3da91737cf by Antoine Pitrou in branch 'default':
Issue #23309:
Antoine Pitrou added the comment:
I've pushed the patch, thank you!
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23726
Antoine Pitrou added the comment:
Is it still relevant, now that #23529 has been committed?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19051
___
Brett Cannon added the comment:
Thanks to Paul and Eric for the review and everyone who provided input!
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
Jeff McNeil added the comment:
Actually, never mind that suggestion. Now that I think a bit more about it,
that actually doesn't do anything since I'd still need to set the updated
timeout on the current socket object anyway. Whoops.
I'll leave it up to you as to whether we go with an
Ned Deily added the comment:
In general, references in the devguide to UNIX are intended to include OS X.
In other words, in the guide UNIX is generally equivalent to not Windows at
least for Python 3 now that other, ancient non-POSIX platforms, like classic
MacOS or VMS or OS/2 are no
Antoine Pitrou added the comment:
Pro tip: when editing the docs, please build them (make html) to detect any
formatting issues ;-)
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23732
Christie added the comment:
Okay thanks @r.david.murray, I'll take a look at doing this. I'll open an issue
when I figure out which module to start on.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9517
101 - 200 of 309 matches
Mail list logo
