[issue9014] Incorrect documentation of the PyObject_HEAD macro

2015-04-14 Thread Gregory P. Smith
Gregory P. Smith added the comment: i used wiggin15's patch to start with. I'm now looking at akuchling's patch and will incorporate any additional things it adds (I missed that earlier). -- assignee: docs@python - gregory.p.smith nosy: +gregory.p.smith

[issue9014] Incorrect documentation of the PyObject_HEAD macro

2015-04-14 Thread A.M. Kuchling
A.M. Kuchling added the comment: Did you intend to remove the discussion of Py_TRACE_REFS completely? (I've reworked your patch a little bit, adding some markup such as :c:macro:`Py_REFCNT`.) -- nosy: +akuchling Added file: http://bugs.python.org/file39000/issue.txt

[issue9014] Incorrect documentation of the PyObject_HEAD macro

2015-04-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset 760c5cfacbaa by Gregory P. Smith in branch '3.4': issue9014: Properly document PyObject_HEAD and friends post-PEP-3123. https://hg.python.org/cpython/rev/760c5cfacbaa New changeset 7dc8f0075d60 by Gregory P. Smith in branch 'default': issue9014:

[issue23953] test_mmap uses cruel and unusual amounts of disk space

2015-04-14 Thread Larry Hastings
New submission from Larry Hastings: My laptop is running 64-bit Linux (14.10). It has 4.6GB of free disk space. Naturally that's not enough to run test_mmap. When I run the test suite, test_mmap consumes all available disk space, then fails. (Hopefully freeing all its temporary files!) If

[issue17898] gettext bug while parsing plural-forms metadata

2015-04-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset c3d269c01671 by Andrew Kuchling in branch '2.7': #17898: reset k and v so that the loop doesn't use an old value https://hg.python.org/cpython/rev/c3d269c01671 -- nosy: +python-dev ___ Python tracker

[issue17898] gettext bug while parsing plural-forms metadata

2015-04-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset 54df02192bfc by Andrew Kuchling in branch '3.4': #17898: reset k and v so that the loop doesn't use an old value https://hg.python.org/cpython/rev/54df02192bfc -- ___ Python tracker

[issue23945] webbrowser.open opens twice on Windows if BROWSER is set

2015-04-14 Thread andig2
andig2 added the comment: Last but not least: this is due to using BROWSER for defining the executable path. Workaround: set BROWSER=firefox and add firefox to path. -- resolution: - not a bug status: open - closed ___ Python tracker

[issue5438] test_bigmem.test_from_2G_generator uses more memory than expected

2015-04-14 Thread Steve Dower
Steve Dower added the comment: It's running fine, but not really exercising the limit. I ran with -M 440G and we haven't gone past 38GB usage yet. I'll post a timeline plot when it finishes (on Windows - not sure how to collect the data but I'm also running on Ubuntu), but it looks like we

[issue8882] socketmodule.c`getsockaddrarg() should not check the length of sun_path

2015-04-14 Thread A.M. Kuchling
A.M. Kuchling added the comment: No changes seems to be necessary, per MvL's comment. -- nosy: +akuchling resolution: - wont fix stage: - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8882

[issue21148] avoid needless pointers initialization in small tuple creation

2015-04-14 Thread Gregory P. Smith
Gregory P. Smith added the comment: Running the https://hg.python.org/benchmarks suite against this change (edited to not have the warning about PyTupleObject* vs PyObject* types) I see no repeatably significant benefits and one that is consistently a few percent slower no matter how many

[issue16501] deprecate RISCOS support

2015-04-14 Thread A.M. Kuchling
A.M. Kuchling added the comment: Nothing left to do for this ticket; closing. -- nosy: +akuchling resolution: - fixed stage: - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16501

[issue5438] test_bigmem.test_from_2G_generator uses more memory than expected

2015-04-14 Thread Steve Dower
Steve Dower added the comment: I'm up to test_from_2G_generator. It says the peak will be 36GB. Memory grew in chunks up to about 40GB and has been stuck there for 10 minutes. -- ___ Python tracker rep...@bugs.python.org

[issue3353] make built-in tokenizer available via Python C API

2015-04-14 Thread Dustin J. Mitchell
Dustin J. Mitchell added the comment: Here's an updated patch for #1: Existing Patch: - move tokenizer.h from Parser/ to Include/ - Add PyAPI_Func to export tokenizer functions New: - Removed unused, undefined PyTokenizer_RestoreEncoding - Include PyTokenizer_State with limited ABI

[issue21039] pathlib strips trailing slash

2015-04-14 Thread A.M. Kuchling
A.M. Kuchling added the comment: The general mood on python-dev seemed to be that the trailing slash shouldn't be normalized. Can this still be fixed, or is it too late since pathlib was shipped in 3.4? The python-dev discussion was at

[issue21327] socket.type value changes after using settimeout()

2015-04-14 Thread Raúl Cumplido
Raúl Cumplido added the comment: While reproducing it I've seen that this has been already solved: sock = socket.socket(type=socket.SOCK_STREAM) sock.type SocketKind.SOCK_STREAM: 1 sock.settimeout(2) sock.type SocketKind.SOCK_STREAM: 1 But the next is still not correct: sock =

[issue22812] Documentation of unittest -p usage wrong on windows.

2015-04-14 Thread Zachary Ware
Zachary Ware added the comment: Looking deeper at this, I think the best solution is to use '*.py' instead of '*.py' without changing the code at all. Quoting on the Windows shell is somewhat of a nightmare (see my example on Rietveld), but using double quotes works on both Windows and

[issue16405] Explain how to set up the whitespace commit hook locally

2015-04-14 Thread Carol Willing
Carol Willing added the comment: Adds whitespace checking hook setup information to Minimal Configuration section of devguide [1]. Patch is ready for review. [1] https://docs.python.org/devguide/committing.html#minimal-configuration -- keywords: +patch stage: needs patch - patch

[issue2771] Test issue

2015-04-14 Thread Ezio Melotti
Ezio Melotti added the comment: ping -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2771 ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21327] socket.type value changes after using settimeout()

2015-04-14 Thread Raúl Cumplido
Raúl Cumplido added the comment: after conversation with @r.david.murray I understand that we only want to return the type, not all the flags, so the function will return just the socket.SOCK_STREAM or socket.SOCK_DGRAM ... -- ___ Python tracker

[issue23811] Python py_compile error message inconsistent and missing newline

2015-04-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1e139b3c489e by Berker Peksag in branch '3.4': Issue #23811: Add missing newline to the PyCompileError error message. https://hg.python.org/cpython/rev/1e139b3c489e New changeset d39fe1e112a3 by Berker Peksag in branch 'default': Issue #23811: Add

[issue23852] Wrong computation of max_fd on OpenBSD

2015-04-14 Thread William Orr
William Orr added the comment: Given that OpenBSD returns *bad* data via sysconf(3), I'm not sure that there's a good way to validate other than *only* calling getrlimit(3) on OpenBSD. Is that an acceptable approach? -- ___ Python tracker

[issue23936] Wrong references to deprecated find_module instead of find_spec

2015-04-14 Thread Brett Cannon
Brett Cannon added the comment: You're right, it should be find_spec. -- nosy: +ncoghlan ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23936 ___

[issue21271] reset_mock needs parameters to also reset return_value and side_effect

2015-04-14 Thread Kushal Das
Kushal Das added the comment: Updated patch with the suggestions from Berker. -- Added file: http://bugs.python.org/file38989/issue21271v2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21271

[issue21327] socket.type value changes after using settimeout()

2015-04-14 Thread Raúl Cumplido
Raúl Cumplido added the comment: @haypo Would you expect the new function to return a tuple? i.e: socket.get_socket_type(sock) (socket.SOCK_STREAM, socket.SOCK_NONBLOCK) socket.get_socket_type(sock2) (socket.SOCK_STREAM,) -- nosy: +raulcd ___

[issue1745108] 2.5.1 curses panel segfault in new_panel on aix 5.3

2015-04-14 Thread A.M. Kuchling
A.M. Kuchling added the comment: Closing this ticket as outdated; AIX 5.3 is from 2004. -- nosy: +akuchling resolution: - wont fix stage: - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1745108

[issue23948] Deprecate os.kill() on Windows

2015-04-14 Thread John Ehresman
New submission from John Ehresman: os.kill() on Windows cannot act like it does on non-windows platforms because of differences in the underlying platforms. I think only kill() with a signal number of 9 (terminate process unconditionally) and a signal number of 0 (test to see if process

[issue20669] OpenBSD: socket.recvmsg tests fail with OSError: [Errno 40] Message too long

2015-04-14 Thread William Orr
William Orr added the comment: In the case of EINVAL, OpenBSD returns this if multiple cmsghdrs are attached to a message with sendmsg(2). In this case, those tests should probably be skipped. I've attached the patch that combines haypo's patch with skips referencing this issue wrt. multiple

[issue9014] Incorrect documentation of the PyObject_HEAD macro

2015-04-14 Thread Arnon Yaari
Arnon Yaari added the comment: PEP 3123 is the one that describes this change. I'm submitting a file with the proposed changes to the docs. -- keywords: +patch nosy: +wiggin15 Added file: http://bugs.python.org/file38991/issue9014.diff ___ Python

[issue17898] gettext bug while parsing plural-forms metadata

2015-04-14 Thread A.M. Kuchling
Changes by A.M. Kuchling a...@amk.ca: -- assignee: - akuchling resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17898

[issue20309] Not all method descriptors are callable

2015-04-14 Thread Nick Coghlan
Nick Coghlan added the comment: I agree with Raymond's recommendation - actually supporting this would mean adding code that would need to be maintained indefinitely without providing a compensating practical benefit, so I'm flagging this as not a bug. Thanks Christian for nudging us to make

[issue23947] Add mechanism to import stdlib package bypassing user packages

2015-04-14 Thread Brett Cannon
Brett Cannon added the comment: Just so I don't forget, we also discussed introducing something like importlib.import_stdlib_module() which does what Steve mentions. That would handle aliasing in sys.modules cleanly. In the situation where the module is already in sys.modules and not the same

[issue9741] msgfmt.py generates invalid mo because msgfmt.make() does not clear dictionary

2015-04-14 Thread A.M. Kuchling
A.M. Kuchling added the comment: Éric: do you still want to apply this patch? (I don't think any of the 'global MESSAGES' statements in msgfmt.py are necessary; none of those functions is doing 'MESSAGES = something', just calling methods or setting keys in the dictionary.) -- nosy:

[issue20309] Not all method descriptors are callable

2015-04-14 Thread Christian Hudon
Christian Hudon added the comment: As a newbie to the CPython source code (and as someone who started working on this bug because it was on the lists of easy bugs for PyCon 2014), I don't have a strong attachment either way, as long as some kind of decision is reached, and I can check this

[issue23941] Google Login not working

2015-04-14 Thread Brett Cannon
Brett Cannon added the comment: FYI logging in using Google works for me. -- nosy: +brett.cannon ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23941 ___

[issue17284] create mercurial section in devguide's committing.rst

2015-04-14 Thread Carol Willing
Carol Willing added the comment: I've reviewed this issue at the PyCon sprint. While I agree that there are sections that new contributors might wish to skip over, I believe that there is content that would benefit contributors that are not yet core developers. Going forward we can try to

[issue14484] missing return in win32_kill?

2015-04-14 Thread John Ehresman
John Ehresman added the comment: I've created issue #23948 for the idea of deprecating os.kill(). Is a patch needed for adding a return in the error case? It's that way in 2.7 and I'm struggling to come up with a reason why it shouldn't be added other than strict backward compatibility.

[issue21146] update gzip usage examples in docs

2015-04-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset ae1528beae67 by Andrew Kuchling in branch 'default': #21146: give a more efficient recipe in gzip docs https://hg.python.org/cpython/rev/ae1528beae67 -- nosy: +python-dev ___ Python tracker

[issue21146] update gzip usage examples in docs

2015-04-14 Thread A.M. Kuchling
Changes by A.M. Kuchling a...@amk.ca: -- resolution: - fixed stage: - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21146 ___

[issue21146] update gzip usage examples in docs

2015-04-14 Thread A.M. Kuchling
A.M. Kuchling added the comment: Applied to trunk. Wolfgang Maier: thanks for your patch! -- nosy: +akuchling ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21146 ___

[issue9859] Add tests to verify API match of modules with 2 implementations

2015-04-14 Thread Laura Rupprecht
Laura Rupprecht added the comment: Created a patch to check whether classes define the same attributes. This adds a test for RawIOBase, where Python and and C implementations are out of sync, but skips one of the tests as the issue (issue9858) is still outstanding. -- keywords:

[issue23910] C implementation of namedtuple (WIP)

2015-04-14 Thread Joe Jevnik
Joe Jevnik added the comment: I am updating the patch to include an entry in Misc/NEWS. -- Added file: http://bugs.python.org/file38994/namedtuple-indexer-with-news.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23910

[issue23725] update tempfile docs to say that TemporaryFile is secure

2015-04-14 Thread R. David Murray
R. David Murray added the comment: Thanks for reformatting the patch. I made some review comments. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23725 ___

[issue22812] Documentation of unittest -p usage wrong on windows.

2015-04-14 Thread R. David Murray
R. David Murray added the comment: I should clarify that some unix shells will pass the glob through if there are no files that match, while some will generate the 'no matching files' error message. The former is actually worse, since that means that sometimes it works without the quotes,

[issue22980] C extension naming doesn't take bitness into account

2015-04-14 Thread Matthias Klose
Matthias Klose added the comment: updated patch and test case. Nick's suggestion to use platform.machine() for the test is wrong. This would test for the environment, not for the just built binary. Try to run a 32bit executable on a 64bit kernel, you'll see x86_64. Same thing with

[issue23948] Deprecate os.kill() on Windows

2015-04-14 Thread Steve Dower
Steve Dower added the comment: This feels like an unnecessary incompatibility between the platforms. I'd rather change the parameter values for CTRL+C events so we can distinguish when someone calls with that and then fix it internally on Windows. --

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

2015-04-14 Thread Christie
Christie added the comment: Hey there @flipmcf, is the change which adds `script_helpers` to test.support is missing from your patch? import test.support.script_helper Traceback (most recent call last): File stdin, line 1, in module ImportError: No module named 'test.support.script_helper'

[issue23962] Incorrect TimeoutError referenced in concurrent.futures documentation

2015-04-14 Thread Ryder Lewis
Ryder Lewis added the comment: I attached a small patch that fixes the documentation, and also documents the other missing exceptions from concurrent.futures documentation. -- keywords: +patch Added file: http://bugs.python.org/file39029/issue23962.patch

[issue23725] update tempfile docs to say that TemporaryFile is secure

2015-04-14 Thread Zbyszek Jędrzejewski-Szmek
Zbyszek Jędrzejewski-Szmek added the comment: Ping? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23725 ___ ___ Python-bugs-list mailing list

[issue23961] IDLE autocomplete window does not automatically close when selection is made

2015-04-14 Thread Al Sweigart
New submission from Al Sweigart: All autocomplete features (for example, Eclipse Android Studio) cause the autocomplete window to disappear when a selection is made. When tab is pressed in IDLE, the window does not disappear. IDLE should be changed so that the window goes away when tab is

[issue22812] Documentation of unittest -p usage wrong on windows.

2015-04-14 Thread Pam McA'Nulty
Pam McA'Nulty added the comment: Thanks, Zach for both the comments and the mention of the email bounce. I changed jobs and didn't have this site listed in my must update email address list (fixed now) Should I re-update the doc patch and put in double quotes? --

[issue22812] Documentation of unittest -p usage wrong on windows.

2015-04-14 Thread R. David Murray
R. David Murray added the comment: Ah, but the quotes *are* necessary on unix. Without the quotes, the shell will try to fill in the glob, which will either fail with an error that no files match or (worse) succeed and turn the pattern into a list of filenames. Which is why Zach is

[issue1481347] parse_makefile doesn't handle $$ correctly

2015-04-14 Thread Ned Deily
Ned Deily added the comment: Thanks for investigating this, Kasia. It appears that this problem was fixed some time ago in the changes associated with Issue5201. -- nosy: +ned.deily resolution: - duplicate stage: test needed - resolved status: open - closed superseder: - Using

[issue19543] Add -3 warnings for codec convenience method changes

2015-04-14 Thread Ned Deily
Changes by Ned Deily n...@acm.org: -- stage: needs patch - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19543 ___ ___

[issue23962] Incorrect TimeoutError referenced in concurrent.futures documentation

2015-04-14 Thread Ryder Lewis
New submission from Ryder Lewis: The documentation at https://docs.python.org/3/library/concurrent.futures.html has several functions that case raise a TimeoutError. The hyperlink generated for TimeoutError links to the built-in exception

[issue22812] Documentation of unittest -p usage wrong on windows.

2015-04-14 Thread Pam McA'Nulty
Pam McA'Nulty added the comment: This version of the patch just updates the docs. Since the quotes aren't really necessary for the example to work, the patch removes the single quotes from the example. I don't think that the python unittest documentation should explain/document the

[issue17800] Add gc.needs_finalizing() to check if an object needs finalising

2015-04-14 Thread Benjamin Peterson
Changes by Benjamin Peterson benja...@python.org: -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17800 ___ ___

[issue23725] update tempfile docs to say that TemporaryFile is secure

2015-04-14 Thread R. David Murray
R. David Murray added the comment: I'm re-uploading the patch as an hg diff so that it gets a review link. -- Added file: http://bugs.python.org/file39026/tempfile_docs.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23725

[issue23612] 3.5.0a2 Windows installer does not remove 3.5.0a1

2015-04-14 Thread Steve Dower
Steve Dower added the comment: To be precise, 3.5.0a3 and later will uninstall 3.5.0a2 and later. 3.5.0a1 has to be uninstalled manually, because it's the one with the bug... -- ___ Python tracker rep...@bugs.python.org

[issue20669] OpenBSD: socket.recvmsg tests fail with OSError: [Errno 40] Message too long

2015-04-14 Thread William Orr
William Orr added the comment: I'm adding another patch, as adding multiple cmsg's to a single message with sendmsg is a Linux-specific extension. This only enables the problematic patches on Linux. This solves the AIX failures in #20718 as well. -- Added file:

[issue3353] make built-in tokenizer available via Python C API

2015-04-14 Thread Ned Deily
Changes by Ned Deily n...@acm.org: -- stage: test needed - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3353 ___ ___

[issue23953] test_mmap uses cruel and unusual amounts of disk space

2015-04-14 Thread Larry Hastings
Larry Hastings added the comment: Wall time was 3 minutes 38 seconds. % time ./python -m test test_mmap [1/1] test_mmap test test_mmap failed -- multiple errors occurred; run in verbose mode for details 1 test failed: test_mmap ./python -m test test_mmap 0.40s user 22.41s system 10% cpu

[issue21217] inspect.getsourcelines finds wrong lines when lambda used argument to decorator

2015-04-14 Thread Thomas Ballinger
Thomas Ballinger added the comment: Thanks Antoine! Could you add Allison Kaptur to NEWS and ACKS? This was an update to her original patch, and we paired on the whole thing. -- ___ Python tracker rep...@bugs.python.org

[issue23961] IDLE autocomplete window does not automatically close when selection is made

2015-04-14 Thread Al Sweigart
Al Sweigart added the comment: Edit: Looking into it further, this behavior was originally for when the Show Completions dropdown wasn't being displayed. In that case, pressing tab would complete only up to the first ambiguous completion. For example, typing os.ge and pressing tab would

[issue23962] Incorrect TimeoutError referenced in concurrent.futures documentation

2015-04-14 Thread Ned Deily
Changes by Ned Deily n...@acm.org: -- nosy: +bquinlan stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23962 ___ ___

[issue16405] Explain how to set up the whitespace commit hook locally

2015-04-14 Thread Carol Willing
Carol Willing added the comment: Patch is ready for review. Ned's feedback on pretxncommit hook is added. -- Added file: http://bugs.python.org/file39031/iss-hooks-1.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16405

[issue23935] Clean up Clinic's type expressions of buffers

2015-04-14 Thread Larry Hastings
Larry Hastings added the comment: Latest patch, with another round of lovely comments from Serhiy. -- Added file: http://bugs.python.org/file39030/larry.clinic.buffer.conceptual.cleanup.4.txt ___ Python tracker rep...@bugs.python.org

[issue23949] Number of elements display in error message is wrong while unpacking in traceback

2015-04-14 Thread Martin Panter
Martin Panter added the comment: Either option would be an improvement. I think I prefer issue23949.diff by Arnon. I guess it would then look like this: name,shares,price,date,value = data Traceback (most recent call last): File stdin, line 1, in module ValueError: not enough values to

[issue23703] urljoin() with no directory segments duplicates filename

2015-04-14 Thread Martin Panter
Martin Panter added the comment: Any chance this regression can be fixed before the next release? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23703 ___

[issue21217] inspect.getsourcelines finds wrong lines when lambda used argument to decorator

2015-04-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset 582e8e71f635 by Benjamin Peterson in branch 'default': add Allison Kaptur (#21217) https://hg.python.org/cpython/rev/582e8e71f635 -- ___ Python tracker rep...@bugs.python.org

[issue23935] Clean up Clinic's type expressions of buffers

2015-04-14 Thread Larry Hastings
Larry Hastings added the comment: In the case of namedtuple and Enum, the parameter represents a sequence of strings--order is significant. With the 'types' parameter for converters, the internal model was always meant to be a *set* of strings. The order was explicitly *not* significant.

[issue6631] Disallow relative files paths in urllib*.open()

2015-04-14 Thread Martin Panter
Martin Panter added the comment: I’m confused what the intention of this bug is. The normal urllib.request.urlopen() function (or equivalent) still allows file URLs with relative paths, in various Python versions I tried, ranging from 2.6 to 3.5: import urllib.request

[issue23935] Clean up Clinic's type expressions of buffers

2015-04-14 Thread Larry Hastings
Larry Hastings added the comment: New patch revision, including the new API change (the types argument to a constructor must now be a set of strings). -- Added file: http://bugs.python.org/file39001/larry.clinic.buffer.conceptual.cleanup.3.txt ___

[issue23944] Argument Clinic: wrap impl's declaration if it's too long

2015-04-14 Thread Zachary Ware
Zachary Ware added the comment: You can even have the whole thing, with lots of samples :) -- Added file: http://bugs.python.org/file39002/_winapi.c ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23944

[issue23944] Argument Clinic: wrap impl's declaration if it's too long

2015-04-14 Thread Larry Hastings
Larry Hastings added the comment: I wish the Python bug tracker had a way of attaching files to issues, so we didn't have to just copy and paste into and out of the comments. Ah well, wishful thinking! -- ___ Python tracker rep...@bugs.python.org

[issue9014] Incorrect documentation of the PyObject_HEAD macro

2015-04-14 Thread Gregory P. Smith
Gregory P. Smith added the comment: We no longer describe the contents of PyObject in the docs so mentioning Py_TRACE_REFS does not seem worth it as that just changes Py_HEAD_EXTRA which adds the doubly linked list to PyObject (today). Py_TRACE_REFS isn't useful for anyone to know about

[issue21271] reset_mock needs parameters to also reset return_value and side_effect

2015-04-14 Thread Kushal Das
Kushal Das added the comment: A patch without NEWS and whatsnew update. I will fill them before commit. The reset_mock function now has two parameters, return_value, and side_effect. Passing True value to any of these will reset that attribute. -- keywords: +patch Added file:

[issue19121] Documentation guidelines enhancements

2015-04-14 Thread Carol Willing
Changes by Carol Willing willi...@willingconsulting.com: -- stage: - resolved ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19121 ___ ___

[issue16405] Explain how to set up the whitespace commit hook locally

2015-04-14 Thread Carol Willing
Changes by Carol Willing willi...@willingconsulting.com: -- assignee: - willingc nosy: +willingc ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16405 ___

[issue23943] Misspellings in a few files

2015-04-14 Thread Piotr Kasprzyk
Piotr Kasprzyk added the comment: Thank you for accepting the patch! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23943 ___ ___

[issue23809] RFE: emit a warning when a module in a traceback shadows a stdlib module

2015-04-14 Thread Steve Dower
Changes by Steve Dower steve.do...@microsoft.com: -- nosy: +steve.dower ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23809 ___ ___

[issue21271] reset_mock needs parameters to also reset return_value and side_effect

2015-04-14 Thread Berker Peksag
Berker Peksag added the comment: I left a couple of comments of Rietveld. -- nosy: +berker.peksag stage: needs patch - patch review type: behavior - enhancement ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21271

[issue13164] importing rlcompleter module writes a control sequence in stdout

2015-04-14 Thread R. David Murray
R. David Murray added the comment: Duplicate of 19884. -- nosy: +r.david.murray resolution: - duplicate stage: - resolved status: open - closed superseder: - Importing readline produces erroneous output ___ Python tracker rep...@bugs.python.org

[issue9859] Add tests to verify API match of modules with 2 implementations

2015-04-14 Thread Gregory P. Smith
Changes by Gregory P. Smith g...@krypto.org: -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9859 ___

[issue23852] Wrong computation of max_fd on OpenBSD

2015-04-14 Thread Gregory P. Smith
Gregory P. Smith added the comment: yeah, that's fine. just surround the call to getrlimit with appropriate openbsd ifdef's and a comment. it is _probably_ async signal safe given the nature of the function in most implementations even though it isn't on the official posix list (many things

[issue9859] Add tests to verify API match of modules with 2 implementations

2015-04-14 Thread Berker Peksag
Berker Peksag added the comment: Thanks :) -- stage: patch review - resolved ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9859 ___ ___

[issue23936] Wrong references to deprecated find_module instead of find_spec

2015-04-14 Thread Raúl Cumplido
Raúl Cumplido added the comment: Added changes on both places where there was still references to find_module without specifying that has been deprecated. -- keywords: +patch Added file: http://bugs.python.org/file39021/issue23936.patch ___ Python

[issue17784] the test suite should honor an http_proxy for running the test suite

2015-04-14 Thread Raúl Cumplido
Changes by Raúl Cumplido raulcumpl...@gmail.com: -- nosy: +raulcd ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17784 ___ ___ Python-bugs-list

[issue9246] os.getcwd() hardcodes max path len

2015-04-14 Thread William Orr
William Orr added the comment: Revisiting this, I've updated python3 to calculate this and use gradual dynamic allocation like the python2 implementation. -- nosy: +worr versions: +Python 3.5 -Python 2.7, Python 3.2, Python 3.3 Added file:

[issue23955] Add python.ini file for embedded/applocal installs

2015-04-14 Thread Steve Dower
New submission from Steve Dower: When Python starts running we (getpathp.c) looks in the registry for its library directory. To avoid this, you can set PYTHONPATH and PYTHONHOME environment variables, but this isn't always easy if you've copied Python into your app's directory. We should

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

2015-04-14 Thread Michael McFadden
Michael McFadden added the comment: bobcatfish: Sorry, I didn't refresh and see your comment before submitting my patch. It only moves script_helpers, but doesn't address the original OP. Hopefully I made your life easier, not harder. -- ___

[issue23951] Update devguide style to use a similar theme as Docs

2015-04-14 Thread Carol Willing
Carol Willing added the comment: Zach, Good point. Perhaps a different highlight color across the top would be enough to indicate that you are in the dev guide. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23951

[issue9859] Add tests to verify API match of modules with 2 implementations

2015-04-14 Thread Laura Rupprecht
Laura Rupprecht added the comment: Thanks Berker! I've added some updates to the patch taking your suggestions into account. There is also a change from using detect_module_matches to detect_api_mismatch, as it is a more general (and accurate) description. Also, adding tests for the

[issue13866] {urllib, urllib.parse}.urlencode should not use quote_plus

2015-04-14 Thread Arnon Yaari
Arnon Yaari added the comment: Updated patch to the correct format, added a test and some more documentation. -- nosy: +wiggin15 versions: +Python 3.5 -Python 3.4 Added file: http://bugs.python.org/file39006/issue13866.patch ___ Python tracker

[issue1481347] parse_makefile doesn't handle $$ correctly

2015-04-14 Thread Kasia Jachim
Kasia Jachim added the comment: Tested on 2.7.6 (default from Ubuntu) and 3.5.0a3+ (built from sources), in both cases $$ seems to work correctly, returned {'FOO': '${bar} bla bla'} for the input from msg60909. -- nosy: +kjachim ___ Python tracker

[issue16405] Explain how to set up the whitespace commit hook locally

2015-04-14 Thread Carol Willing
Carol Willing added the comment: Ned, Thanks for the review and feedback. It seems reasonable to me to mention both the pretxncommit hook as well as the commit hook as well as your brief comments on the difference between the two. I'll make that change to the patch and resubmit. --

[issue23954] Pressing enter/return or clicking IDLE's autocomplete does not select the option

2015-04-14 Thread Al Sweigart
New submission from Al Sweigart: Currently, when you press Ctrl+Space or select Edit Show Completions, a dropdown menu appears and lets you select an autocomplete option. If you press Tab, the highlighted option in the dropdown is selected and your typing autocompletes. However, pressing

[issue13472] devguide doesn’t list all build dependencies

2015-04-14 Thread Ned Deily
Changes by Ned Deily n...@acm.org: -- nosy: +willingc ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13472 ___ ___ Python-bugs-list mailing list

[issue9859] Add tests to verify API match of modules with 2 implementations

2015-04-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9903368b9d7b by Gregory P. Smith in branch 'default': issue9859: rename CPyMatchTest to APIMismatchTest and add @support.cpython_only. https://hg.python.org/cpython/rev/9903368b9d7b New changeset cbdd56d07123 by Gregory P. Smith in branch

[issue21916] Create unit tests for turtle textonly

2015-04-14 Thread Gregory Loyse
Gregory Loyse added the comment: Thanks David for your review! I have added a new patch in response. Note the file has a new name -- Added file: http://bugs.python.org/file39018/test_turtle.patch ___ Python tracker rep...@bugs.python.org

[issue23944] Argument Clinic: wrap impl's declaration if it's too long

2015-04-14 Thread Larry Hastings
Larry Hastings added the comment: Attached is a patch. This causes a lot of churn, darn. Should I copy paste the patch into this text box too? Maybe that would be more convenient! -- Added file: http://bugs.python.org/file39008/larry.clinic.wrap.long.impl.decls.1.txt

<    1   2   3   >