[issue25596] regular files handled as directories in the glob module

Xavier de Gaye added the comment: This second patch rewrites the conditionals that decide whether to call _iglob() recursively, in a more natural way and without changing the behavior from the first patch. Note that when 'dirname == pathname', then basename is empty and glob2() or glob1() are

[issue25263] test_tkinter fails randomly on the buildbots "AMD64 Windows10" (3.4, 3.5, 3.x)

Serhiy Storchaka added the comment: Tk bug looks fixed in next releases of Tk 8.5 and 8.6. Here is a patch that adds a workaround for the test. -- keywords: +patch stage: -> patch review type: -> behavior Added file: http://bugs.python.org/file41000/tkinter_test_use_workaround.patch

[issue25596] regular files handled as directories in the glob module

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka nosy: +serhiy.storchaka priority: normal -> low stage: -> patch review ___ Python tracker

[issue25594] enum docs outdated re attribute access

Ethan Furman added the comment: Nope, that would be a bug. -- assignee: docs@python -> ethan.furman stage: -> test needed type: -> behavior ___ Python tracker

[issue25598] Fix memory_hex (#9951) for non-contiguous buffers

New submission from Stefan Krah: memory_hex from #9951 fails for non-contiguous buffers. -- assignee: skrah files: memhex.diff keywords: patch messages: 254454 nosy: skrah priority: normal severity: normal status: open title: Fix memory_hex (#9951) for non-contiguous buffers type: crash

[issue25597] unittest.mock does not wrap dict objects correctly

New submission from Darragh Bailey: Both unittest.mock and the backported release for earlier pythons don't appear to support mocking of dictionary objects. Specifically I'm expecting that any of the methods used to test for membership, or get items from a mock object wrapping a dictionary

[issue25589] test_ascii_formatd fails on Mac when built with Intel compiler

R. David Murray added the comment: Someone can correct me if I'm wrong, but my expectation would be that since we use ICC for the main compile on the ICC buildbots, we also compile the bundled ctypes using it. It is hard to see how any of the other modules would affect this. --

[issue25589] test_ascii_formatd fails on Mac when built with Intel compiler

Chris Hogan added the comment: I guess since no one can reproduce the error, it must be a problem with how I'm building it. We build our own dependencies (zlib, bzip, sqlite3, openssl, etc.) with the Intel compiler, so it could be any number of things causing the issue. Closing as not a bug.

[issue25599] asyncio.iscoroutinefunction returns unexpected results when presented with unittest.mock.Mock

Guido van Rossum added the comment: Hm... I don't know what answer you would expect. Who says your mock shouldn't behave like a coroutine? In general, passing mocks to functions is likely to return a mock -- even boolean functions. Can you provide more context? --

[issue6598] calling email.utils.make_msgid frequently has a non-trivial probability of generating colliding ids

Roundup Robot added the comment: New changeset 3c0a817ab616 by Serhiy Storchaka in branch '3.4': Issue #6598: Avoid clock wrapping around in test_make_msgid_collisions. https://hg.python.org/cpython/rev/3c0a817ab616 New changeset e259c0ab7a69 by Serhiy Storchaka in branch '3.5': Issue #6598:

[issue25594] enum docs outdated re attribute access

SilentGhost added the comment: Here is the test, it seems to have been 2545bfe0d273 that caused it (issue23486): test passes prior to it and fails on it (and I assume uniformly after). -- keywords: +patch Added file: http://bugs.python.org/file41003/test_issue25594.diff

[issue25598] Fix memory_hex (#9951) for non-contiguous buffers

Roundup Robot added the comment: New changeset f3d8bb3ffa98 by Stefan Krah in branch '3.5': Iaaue #25598: Fix memory_hex from #9951 for non-contiguous buffers. https://hg.python.org/cpython/rev/f3d8bb3ffa98 -- nosy: +python-dev ___ Python tracker

[issue9951] introduce bytes.hex method (also for bytearray and memoryview)

Roundup Robot added the comment: New changeset f3d8bb3ffa98 by Stefan Krah in branch '3.5': Iaaue #25598: Fix memory_hex from #9951 for non-contiguous buffers. https://hg.python.org/cpython/rev/f3d8bb3ffa98 -- ___ Python tracker

[issue25599] asyncio.iscoroutinefunction returns unexpected results when presented with unittest.mock.Mock

New submission from Theron Luhn: >>> asyncio.iscoroutinefunction(unittest.mock.Mock()) This is an unexpected response, both in type (Mock rather than boolean) and value (truthy). inspect.iscoroutinefunction behaves as expected. Workaround: >>> m = unittest.mock.Mock() >>> m._is_coroutine =

[issue6598] calling email.utils.make_msgid frequently has a non-trivial probability of generating colliding ids

Serhiy Storchaka added the comment: http://buildbot.python.org/all/builders/x86%20Tiger%202.7/builds/3246/steps/test/logs/stdio == FAIL: test_make_msgid_collisions (email.test.test_email.TestMiscellaneous)

[issue25593] _sock_connect_cb can be called twice resulting in InvalidStateError

Guido van Rossum added the comment: Please show us how to repro -- there's no way we can figure out how this "impossible" event could happen in your code without understanding your code. Is it possible that multiprocessing forked your event loop or something similarly esoteric? --

[issue25599] asyncio.iscoroutinefunction returns unexpected results when presented with unittest.mock.Mock

STINNER Victor added the comment: >>> asyncio.iscoroutinefunction(unittest.mock.Mock()) Yeah, I already had this issue when I wrote unit tests using mock :-/ I didn't find an obvious fix for this issue, and it's quite easy to workaround it. It looks like the "m._is_coroutine = False" is not

[issue24848] Warts in UTF-7 error handling

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue25339] sys.stdout.errors is set to "surrogateescape"

Serhiy Storchaka added the comment: The default encoding of sys.stdio and sys.stdout is determined by (in order of increasing precedence): 1. locale 2. PYTHONIOENCODING 3. Py_SetStandardStreamEncoding() The default error handler before 3.5 was determined by: 1. 'strict' 2. PYTHONIOENCODING

[issue25594] enum instance attribute access possible

Changes by SilentGhost : -- components: -Documentation stage: test needed -> needs patch title: enum docs outdated re attribute access -> enum instance attribute access possible ___ Python tracker

[issue25595] test_deleted_cwd in test_importlib is failed on AIX

Martin Panter added the comment: Wow this is tricky to get right. Victor, you are right to not trust TemporaryDirectory, because when cleanup() fails you don’t get a second chance, and it will leave the directory behind. According to the Microsoft _mkdir() web page

[issue25437] Issue with ftplib.FTP_TLS and server forcing SSL connection reuse

Changes by Stephen Ash : -- nosy: +Stephen Ash ___ Python tracker ___ ___

[issue25558] Use static asserts in C code

STINNER Victor added the comment: This issue can now be closed, no? (I don't think that it's worth to add a new macro and make the existing macro more strict.) -- ___ Python tracker

[issue25597] unittest.mock does not wrap dict objects correctly

R. David Murray added the comment: Looking at the source, it's not clear that wraps is supported for __ methods, despite what the documentation implies. That is, MagicProxy doesn't seem to look at the wraps information. I suspect it is doable, but it may be an enhancement request rather

[issue25594] enum docs outdated re attribute access

New submission from SilentGhost: In enum docs[0], there is a suggestion that the attribute access on members should raise an AttributeError: >>> Color.red.blue Traceback (most recent call last): ... AttributeError: 'Color' object has no attribute 'blue' which is demonstrably wrong in either

[issue25586] socket.sendall broken when a socket has a timeout

Jakub Stasiak added the comment: That's fair and thanks for the links. Please find a quick patch attached, feel free to use that or any modification of it. While I believe the documentation is technically correct right now it won't hurt to clarify this I think. -- keywords: +patch

[issue25595] test_deleted_cwd in test_importlib is failed on AIX

Serhiy Storchaka added the comment: Thank you Victor for your review. Here is fixed patch that implements your suggestions. -- Added file: http://bugs.python.org/file40997/test_deleted_cwd_aix_2.patch ___ Python tracker

[issue25595] test_deleted_cwd in test_importlib is failed on AIX

Serhiy Storchaka added the comment: And here is simple alternative patch based on Martin's original suggestion in msg236122. -- Added file: http://bugs.python.org/file40998/test_deleted_cwd_aix_alt.patch ___ Python tracker

[issue25590] tab-completition on instances repeatedly accesses attribute/descriptors values

Martin Panter added the comment: getattr-once.patch handles my first two points. It backports the set() change, and avoids the hasattr() check. I guess we apply this to 3.4+; expect merge conflicts with 3.6. As for the last point, I will make another patch to include special attributes that

[issue25586] socket.sendall broken when a socket has a timeout

Martin Panter added the comment: That was kind of what I had in mind. The only change I would make is to restore the comma to “On error (including socket timeout), an exception . . .”. I’ll try to commit this in a few days if nobody has anything else to say. -- stage: -> patch review

[issue25595] test_deleted_cwd in test_importlib is failed on AIX

New submission from Serhiy Storchaka: test_deleted_cwd in test_importlib is failed on AIX. http://buildbot.python.org/all/builders/PPC64%20AIX%203.x/builds/4318/steps/test/logs/stdio == ERROR: test_deleted_cwd

[issue25596] regular files handled as directories in the glob module

New submission from Xavier de Gaye: The glob module happily joins names of regular files together with os.path.join() or attempts to list the files contained into a regular file (sic). The same 'except os.error' statement is used to handle both these cases and the case of a non readable

[issue25584] a recursive glob pattern fails to list files in the current directory

Xavier de Gaye added the comment: New issue 25596 entered: regular files handled as directories in the glob module. Thanks for fixing this Serhiy. -- ___ Python tracker

[issue25595] test_deleted_cwd in test_importlib is failed on AIX

STINNER Victor added the comment: -1, review on Rietveld. -- nosy: +haypo ___ Python tracker ___ ___

[issue25600] argparse, argument_default=argparse.SUPPRESS seems to have no effect

New submission from mcer45: The parameter argument_default=argparse.SUPPRESS seems to have no effect. Example: = help_dirs='ahoy parser = argparse.ArgumentParser(

[issue25590] tab-completition on instances repeatedly accesses attribute/descriptors values

Martin Panter added the comment: uncreated-attr.patch is against the 3.6 branch, and includes the excessive getattr() test, and new code to include uncreated attribute names. I added a paragraph to What’s New describing the new completion behaviour. -- Added file:

[issue25590] tab-completition on instances repeatedly accesses attribute/descriptors values

Serhiy Storchaka added the comment: Both patches LGTM. Thank you Martin. > Would we consider this a new feature for 3.6? We can consider this a fix of the regression in issue449227. But this behavior here is so long. I agree with applying it to 3.6 only. For nicer Mercurial history, it would

[issue25595] test_deleted_cwd in test_importlib is failed on AIX

Serhiy Storchaka added the comment: Martin's original code looked nicer to me. It' a pity we can't use it. test_deleted_cwd_aix_3.patch LGTM. Thanks Martin! -- assignee: -> serhiy.storchaka ___ Python tracker

[issue25595] test_deleted_cwd in test_importlib is failed on AIX

Roundup Robot added the comment: New changeset d4dc36586f24 by Serhiy Storchaka in branch '3.5': Issue #25595: Fixed test_deleted_cwd in test_importlib on AIX. https://hg.python.org/cpython/rev/d4dc36586f24 New changeset 3f392050d519 by Serhiy Storchaka in branch 'default': Issue #25595: Fixed

[issue25595] test_deleted_cwd in test_importlib is failed on AIX

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue25498] Python 3.4.3 core dump with simple sample code

Serhiy Storchaka added the comment: Added new comments on Rietveld. Would be nice to add tests for read-only and non-contiguous buffers. eryksun, what is your real name? What we have to add in the Misc/ACKS file? -- ___ Python tracker

[issue24661] CGIHTTPServer: premature unescaping of query string

Martin Panter added the comment: The CGI server no longer unquotes the query string thanks to the fix for Issue 24657. The fix should be in the next (2.7.11) release. -- nosy: +martin.panter resolution: -> out of date stage: -> resolved status: open -> closed superseder: ->

[issue25583] os.makedirs with exist_ok=True raises PermissionError on Windows 7^

Daniel Plachotich added the comment: Yes, it's probably a better solution. If had been more careful, I wouldn't have scribbled so much text here :) . But is there any sense in adding Windows-specific test with EACCES since the problem with errno may affect other platforms as well (at least in

[issue25263] test_tkinter fails randomly on the buildbots "AMD64 Windows10" (3.4, 3.5, 3.x)

Roundup Robot added the comment: New changeset 385b3aaf8401 by Serhiy Storchaka in branch '3.4': Issue #25263: Fixed the tkinter.test.test_tkinter.test_font.FontTest test https://hg.python.org/cpython/rev/385b3aaf8401 New changeset db168611c6c8 by Serhiy Storchaka in branch '3.5': Issue #25263:

[issue25595] test_deleted_cwd in test_importlib is failed on AIX

STINNER Victor added the comment: test_deleted_cwd_aix_alt.patch: I don't trust tempfile.TemporaryDirectory(), I prefer your patch. test_deleted_cwd_aix_2.patch looks good to me. -- ___ Python tracker

[issue25263] test_tkinter fails randomly on the buildbots "AMD64 Windows10" (3.4, 3.5, 3.x)

Serhiy Storchaka added the comment: The other failure is not Windows specific. It can be reproduced if run test_tk twice. FontTest.setUpClass() incorrectly call parent's method and the root attribute is set in parent class. tearDownClass() sets the root attribute to None in child class, and

[issue25583] os.makedirs with exist_ok=True raises PermissionError on Windows 7^

Martin Panter added the comment: It is good to add a regression test for any bug if it’s not too hard. Yes this is not a Windows-only issue, but I understand it is much simpler to produce with Windows. Otherwise you need a special file system setup and a more obscure OS. Please review my

[issue25498] Python 3.4.3 core dump with simple sample code

Martin Panter added the comment: I propose this patch, based on Eryksun’s patch (thanks Eryksun). New changes: * Added test case * Applied Serhiy’s review suggestion * Changed the new BufferError exceptions back to TypeError to match previous behaviour and test cases -- nosy: +eryksun

[issue7759] mhlib fails on Btrfs filesystem (test_mhlib failure)

Serhiy Storchaka added the comment: The new buildbot edelsohn-sles-z is red from its setting at 19 Aug 2015. test_mhlib is the only failed test. http://buildbot.python.org/all/builders/s390x%20SLES%202.7/builds/114/steps/test/logs/stdio