[issue25251] Unknown MS Compiler version 1900

Ateik Al-Zehla added the comment: how to apply patch file : patch.diff ? plz help -- nosy: +Ateik Al-Zehla ___ Python tracker ___

[issue25615] Document unsorted behaviour of glob.glob

Dave Jones added the comment: Ah, sorry about that - force of habit. I did wonder if it was preferable to have a nicely wrapped patch, or to have a clean diff but obviously figured wrong! I'll know for future :) -- ___ Python tracker

[issue25628] Make namedtuple "verbose" and "rename" parameters into keyword only arguments

Changes by Raymond Hettinger : -- title: Make namedtuple "verbose" and "renanme" parameters into keyword only arguments -> Make namedtuple "verbose" and "rename" parameters into keyword only arguments ___ Python tracker

[issue25627] distutils : file "bdist_rpm.py" allows Shell injection in "name"

R. David Murray added the comment: Since setup.py can run arbitrary python code, it is pointless to worry about this from a security perspective. The change is otherwise not a bad idea, though, since it avoids filename quoting problems. Is there any chance this would break existing setup.py

[issue25627] distutils : file "bdist_rpm.py" does not quote filenames when executing the rpm command

Changes by R. David Murray : -- title: distutils : file "bdist_rpm.py" allows Shell injection in "name" -> distutils : file "bdist_rpm.py" does not quote filenames when executing the rpm command ___ Python tracker

[issue25615] Document unsorted behaviour of glob.glob

Raymond Hettinger added the comment: +1 for the doc update. For future reference, the doc patches are much easier to review if you don't rewrap the text (we can easily do that part before applying the patch). -- nosy: +rhettinger ___ Python tracker

[issue25628] Make namedtuple "verbose" and "renanme" parameters into keyword only arguments

New submission from Raymond Hettinger: This is a usability and readability improvement made possible by Python 3's keyword only arguments. Usability is improved by getting a much less confusing response from the following mistake: namedtuple('Point', 'x', 'y')

[issue25629] Move set fill/used updates out of set_insert_clean()

New submission from Raymond Hettinger: Will need to update the comment block over set_insert_clean() as well. -- components: Interpreter Core files: set_faster_resize2.diff keywords: patch messages: 254692 nosy: rhettinger priority: normal severity: normal stage: patch review status:

[issue25628] Make namedtuple "verbose" and "rename" parameters into keyword only arguments

Serhiy Storchaka added the comment: I like the idea. But this is backward incompatible change. I would first add a warning. Here is a patch. Yes, the code looks a little cumbersome, but this is only for one or two releases. -- nosy: +serhiy.storchaka stage: -> patch review Added

[issue16394] Reducing tee() memory footprint

Raymond Hettinger added the comment: Unlike the other "equivalents" in the docs, this one is further away from the actual implementation. So, I think I should add a clarification that the example code is a "rough logical equivalent" but that actual implementation may have shared queues

[issue25609] Add a ContextManager ABC and type

Changes by Raymond Hettinger : -- nosy: +rhettinger ___ Python tracker ___ ___

[issue21134] Segfault when stringifying UnicodeEncodeError (or UnicodeDecodeError) created with __new__()

STINNER Victor added the comment: > Do you have a patch Victor? Nope. -- ___ Python tracker ___ ___

[issue25609] Add a ContextManager ABC and type

Raymond Hettinger added the comment: -0 on this one. This is slightly more useful than the other "one-trick-ponies" like Container, Hashable, and Iterable. Those each provide some "recognition" capabilities using isinstance() but don't provide any useful "mixin" capabilities. In

[issue23564] Patch fixing sanity check for ordered fd sequence in _posixsubprocess.c

Gregory P. Smith added the comment: Hisham, could you sign the Python contributor agreement? https://www.python.org/psf/contrib/contrib-form/ thanks! -- ___ Python tracker

[issue25630] SIGSEGV in os.putenv()

New submission from Paweł Krawczyk: A numerical value argument of the os.putenv() call causes my python3.5 to crash with SIGSEGV, for example: Python 3.5.0+ (default, Oct 11 2015, 09:05:38) [GCC 5.2.1 20151010] on linux Type "help", "copyright", "credits" or "license" for more information.

[issue24928] mock.patch.dict spoils order of items in collections.OrderedDict

Changes by Raymond Hettinger : -- assignee: -> michael.foord ___ Python tracker ___

[issue25623] Keep the link to Python implementation of OrderedDict

Raymond Hettinger added the comment: I think we should stick with fixing bugs as found (even if that process spills into 3.5.2). The current tests do a good job of making sure the basic functionality is in place and there has been use in the field. Also, you've already done a good job

[issue6973] subprocess.Popen.send_signal doesn't check whether the process has terminated

Roundup Robot added the comment: New changeset 6bd3c8623bb2 by Gregory P. Smith in branch '3.4': Fix issue #6973: When we know a subprocess.Popen process has died, do https://hg.python.org/cpython/rev/6bd3c8623bb2 New changeset bc907c76f054 by Gregory P. Smith in branch '3.5': Fix issue #6973:

[issue6973] subprocess.Popen.send_signal doesn't check whether the process has terminated

Gregory P. Smith added the comment: I chose to go with the "there should not be an error" approach similar to how Python deals with multiple file closes. Both are technically programming errors but the point of Python is make life easier. Reasoning? I don't want someone to ever think they

[issue23883] __all__ lists are incomplete

Mauro S. M. Rodrigues added the comment: New version. -- Added file: http://bugs.python.org/file41052/issue23883_fileinput.v2.patch ___ Python tracker

[issue25623] Keep the link to Python implementation of OrderedDict

Raymond Hettinger added the comment: > This would have the side-effect of allowing people relying > on the pure Python implementation details to use them Right. That's why we don't want to do this. -- ___ Python tracker

[issue25616] Extract OrderedDict tests into separate file

Raymond Hettinger added the comment: If it helps with all the great work you're doing, go ahead and move the OD tests out to a separate file. -- ___ Python tracker

[issue25611] test_deque failure on Gentoo and OpenIndiana buildbots on 2.7

Changes by Raymond Hettinger : -- assignee: -> rhettinger ___ Python tracker ___

[issue6973] subprocess.Popen.send_signal doesn't check whether the process has terminated

Changes by Gregory P. Smith : -- assignee: -> gregory.p.smith nosy: +gregory.p.smith ___ Python tracker ___

[issue17131] subprocess.Popen.terminate can raise exception on Posix

Changes by Gregory P. Smith : -- resolution: -> duplicate status: open -> closed superseder: -> subprocess.Popen.send_signal doesn't check whether the process has terminated ___ Python tracker

[issue25623] Keep the link to Python implementation of OrderedDict

Emanuel Barry added the comment: I would personally suggest a more permanent and accessible way, in the way the decimal module handles it. I'd add a '_pycollections' module holding the pure Python implementations of OrderedDict and _count_elements, then have the collections package import

[issue25631] Segmentation fault with invalid Unicode command-line arguments in embedded Python

New submission from Itai Bar-Natan: The following embedded application, which calls Py_Main with a "-W X" argument where X is not a valid Unicode string, returns a segmentation fault: ``` #include "Python.h" main() { wchar_t *invalid_str; invalid_str = malloc(2*sizeof(wchar_t));

[issue23564] Patch fixing sanity check for ordered fd sequence in _posixsubprocess.c

Martin Panter added the comment: FWIW I think this patch is trivial enough not to need an agreement. -- nosy: +martin.panter ___ Python tracker ___

[issue25632] Document BUILD_*_UNPACK opcodes

New submission from Antony Lee: The additional unpack generalizations provided by Python3.5 rely on a new set of opcodes, BUILD_{TUPLE,LIST,DICT,SET}_UNPACK, that are not documented in the docs for the dis module. -- assignee: docs@python components: Documentation messages: 254715

[issue19081] zipimport behaves badly when the zip file changes while the process is running

Gregory P. Smith added the comment: I'm unassigning as i won't be figuring out how to hackishly fix this again. The best solution is a complete rewrite of zipimport. this remains a known issue: if you use zipimport, do not allow the zip file to change out from underneath your running process

[issue23564] Patch fixing sanity check for ordered fd sequence in _posixsubprocess.c

Gregory P. Smith added the comment: heh, you're right. it's a trivial obvious fix for the mistake in the existing implementation. writing a test and committing. the other option would be to get rid of the sanity check entirely or change it not to use the odd "require a sorted list" code.

[issue23564] Patch fixing sanity check for ordered fd sequence in _posixsubprocess.c

Roundup Robot added the comment: New changeset 55f7a99a5433 by Gregory P. Smith in branch '3.5': Fixes #23564: Fix a partially broken sanity check in the _posixsubprocess https://hg.python.org/cpython/rev/55f7a99a5433 New changeset 97e2a6810f7f by Gregory P. Smith in branch 'default': Fixes

[issue23564] Patch fixing sanity check for ordered fd sequence in _posixsubprocess.c

Gregory P. Smith added the comment: I didn't bother adding the fix to 3.4, it isn't high value. -- resolution: -> fixed status: open -> closed versions: +Python 3.5, Python 3.6 ___ Python tracker

[issue25630] SIGSEGV in os.putenv()

Roundup Robot added the comment: New changeset 3ae62099d70b by Benjamin Peterson in branch '3.5': make the PyUnicode_FSConverter cleanup set the decrefed argument to NULL (closes #25630) https://hg.python.org/cpython/rev/3ae62099d70b New changeset d8d67b502bcc by Benjamin Peterson in branch

[issue25628] Make namedtuple "verbose" and "rename" parameters into keyword only arguments

Raymond Hettinger added the comment: I don't think a warning is necessary because of what "verbose" does. -- ___ Python tracker ___

[issue25611] test_deque failure on Gentoo and OpenIndiana buildbots on 2.7

Raymond Hettinger added the comment: I believe this was fixed by changesets a2a518b6ded4 and d920b09d22ce . The buildbots show green for the latest build. -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue25628] Make namedtuple "verbose" and "rename" parameters into keyword only arguments

Serhiy Storchaka added the comment: Existing scripts can contain passing positional 'rename' argument: namedtuple('Point', 'x y', False, True). -- ___ Python tracker

[issue25626] Gzip fails for file over 2**32 bytes

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___

[issue25628] Make namedtuple "verbose" and "rename" parameters into keyword only arguments

Raymond Hettinger added the comment: My judgment call is that the keyword-only change can be made directly, that the costs and clutter of deprecation and delay aren't worth in it this case, that the nature of the "verbose" and "rename" arguments puts this in the rare-to-non-existent category,

[issue25626] Gzip fails for file over 2**32 bytes

Martin Panter added the comment: Ben: By adding the cap, it means when the lower-level zlib module is asked to decode say 5 GiB, it will decode at most 4 GiB (rather than raising an exception). The 4 GiB limit (UINT_MAX to be precise) is due to the underlying zlib library; it’s not Python’s

[issue25628] Make namedtuple "verbose" and "rename" parameters into keyword only arguments

Serhiy Storchaka added the comment: OK, leave it to you. But may be worth to add a versionchanged directive. -- ___ Python tracker ___