[issue25698] test regressions introduced with the fix for #22995

Martin Panter added the comment: Duplicate or related to Issue 25601? -- nosy: +martin.panter ___ Python tracker ___

[issue24731] Incorrect assert in str_subtype_new

Serhiy Storchaka added the comment: Thank you for your report Kevin and sorry for the delay. I confirm the bug and agree with your solution. The same bug exists for ints and floats. Here are patches that fix crashes. -- keywords: +patch nosy: +mark.dickinson stage: needs patch ->

[issue25691] Crash on deleting Element attribute

Martin Panter added the comment: The patch looks good to me. This may be a side effect of poor documentation. I guess the documentation at and/or the referenced functions should mention that the they also delete

[issue25695] test___all__ and test_support alter execution environment

Martin Panter added the comment: This was introduced with revision f8fa7bc837a3. I guess I overlooked the new messages because I run the tests with -Wall, which is affected by Issue 18383. It seems a bad idea to create a temporary directory when you import the test_support module. I propose

[issue25701] Document that tp_setattro and tp_setattr are used for deleting attributes

New submission from Serhiy Storchaka: tp_setattro and tp_setattr fields of PyTypeObject are used for deleting attributes. In this case the third argument is NULL. This should be documented. Not awareness of this can cause a segmentation fail (for example see issue25698). -- assignee:

[issue25688] File leak in ElementTree.iterparse()

Martin Panter added the comment: What’s the point of the catch_warnings() and filterwarnings() calls in the tests? They don’t seem to be doing much; I think the CleanContext manager is already enabling warnings. Perhaps you could call simplefilter("error", ResourceWarning) instead. Also I’m

[issue25688] File leak in ElementTree.iterparse()

Serhiy Storchaka added the comment: Warning is emitted in destructor, and exceptions in destructors are ignored. Hence turning it into error makes the test passed. Tests were not correct, here is fixed patch. Yes, CleanContext does the work. But depending on it looks fragile. CleanContext

[issue25624] shutil.make_archive makes invalid directory entries

Serhiy Storchaka added the comment: Thank you Benjamin. -- resolution: -> fixed stage: test needed -> resolved status: open -> closed ___ Python tracker

[issue25691] Crash on deleting Element attribute

Roundup Robot added the comment: New changeset 852c9ed9115c by Serhiy Storchaka in branch '3.4': Issue #25691: Fixed crash on deleting ElementTree.Element attributes. https://hg.python.org/cpython/rev/852c9ed9115c New changeset 3a44f06907f1 by Serhiy Storchaka in branch '3.5': Issue #25691:

[issue25701] Document that tp_setattro and tp_setattr are used for deleting attributes

Changes by Serhiy Storchaka : -- stage: -> needs patch ___ Python tracker ___ ___

[issue25701] Document that tp_setattro and tp_setattr are used for deleting attributes

Changes by Serhiy Storchaka : -- Removed message: http://bugs.python.org/msg255130 ___ Python tracker ___

[issue25701] Document that tp_setattro and tp_setattr are used for deleting attributes

New submission from Serhiy Storchaka: tp_setattro and tp_setattr fields of PyTypeObject are used for deleting attributes. In this case the third argument is NULL. This should be documented. Not awareness of this can cause a segmentation fail (for example see issue25691). --

[issue25701] Document that tp_setattro and tp_setattr are used for deleting attributes

Changes by Serhiy Storchaka : -- priority: normal -> high ___ Python tracker ___ ___

[issue25691] Crash on deleting Element attribute

Serhiy Storchaka added the comment: Thank you for your review Martin. Opened issue25701 for documenting. Interestingly, 2.7 is free from this bug. It has a check for NULL. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 2.7

[issue8304] time.strftime() and Unicode characters on Windows

Eryk Sun added the comment: The problem from issue 10653 is that internally the CRT encodes the time zone name using the ANSI codepage (i.e. the default system codepage). wcsftime decodes this string using mbstowcs (i.e. multibyte string to wide-character string), which uses Latin-1 in the C

[issue25624] shutil.make_archive makes invalid directory entries

Larry Hastings added the comment: This change didn't make it into 3.5.1. It will be released with 3.5.2. I've already updated the Misc/NEWS entry. -- ___ Python tracker

[issue25691] Crash on deleting Element attribute

Larry Hastings added the comment: This change didn't make it into 3.5.1. It will be released with 3.5.2. I've already updated the Misc/NEWS entry. -- nosy: +larry ___ Python tracker

[issue25697] Fix rough alphabetical order in Misc/ACKS

Martin Panter added the comment: I left one review comment about Maćkowiak. The other changes look okay. -- nosy: +martin.panter ___ Python tracker ___

[issue25680] Selector.select() hangs when there is nothing to select

Guido van Rossum added the comment: I don't think we should "fix" the select module; it's advertised as a wrapper around the various syscalls, and if the platforms disagree on what that syscall (e.g. select()) does we shouldn't try to fix it. (Documenting the differences is fine.) However

[issue25698] test regressions introduced with the fix for #22995

Serhiy Storchaka added the comment: In your report test_cpickle has number 93. What other 92 tests were ran before? Could you run tests few times and find minimal list of tests that precede failing test_cpickle? This failure is not related to issue22995 because the same failure was reported

[issue24731] Incorrect assert in str_subtype_new

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file41127/issue24731-2.7.patch ___ Python tracker ___

[issue25698] test regressions introduced with the fix for #22995

Matthias Klose added the comment: looks like re-running the tests in verbose mode using -w is affected by this issue. the first cpickle subtest failing is: == ERROR: test_recursive_dict_subclass_and_inst

[issue25698] test regressions introduced with the fix for #22995

Serhiy Storchaka added the comment: Yes, it is a duplicate of issue25601. And I can't reproduce it locally. Matthias, can you reproduce test failure every time when run tests? If yes, could you please run tests in verbose mode and found what tests in test_cpickle were failed first?

[issue25700] namedtuple documentation

New submission from Laur Joost: collections.namedtuple documentation has an example about changing the resulting class docstrings: Docstrings can be customized by making direct assignments to the ``__doc__`` fields: >>> Book = namedtuple('Book', ['id', 'title', 'authors']) >>>

[issue25700] namedtuple documentation

Zachary Ware added the comment: I wonder if it's worth a ..versionchanged note in the namedtuple docs pointing out that __doc__ assignment on fields only works in 3.5+ due to property docstrings becoming writable. -- nosy: +zach.ware stage: -> resolved

[issue25624] shutil.make_archive makes invalid directory entries

Roundup Robot added the comment: New changeset 43208b0f2535 by Benjamin Peterson in branch '2.7': Issue #25624: ZipFile now always writes a ZIP_STORED header for directory entries. Patch by Dingyuan Wang. https://hg.python.org/cpython/rev/43208b0f2535 --

[issue25700] namedtuple documentation

Laur Joost added the comment: Did my testing on 3.4.3 (other computer). My apologies. -- resolution: -> not a bug status: open -> closed ___ Python tracker

[issue25694] test.libregrtest not installed

New submission from Arfrever Frehtes Taifersar Arahesis: test.libregrtest is not installed, which breaks running of test suite from installed Python. Probably LIBSUBDIRS in Makefile.pre.in should be updated. $ python3.5 -m test test_int [1/1] test_int 1 test OK. $ python3.6 -m test test_int

[issue25693] test_asyncio prints some messages

New submission from Arfrever Frehtes Taifersar Arahesis: When running full test suite, test_asyncio prints some messages. ResourceWarnings should be fixed. Other messages should not be shown, at least without --verbose. [171/398] test_epoll [172/398] test_optparse [173/398] test_socket

[issue25695] test___all__ and test_support alter execution environment

New submission from Arfrever Frehtes Taifersar Arahesis: test___all__ and test_support alter execution environment. Problem seems to be present only in Python 3.6. $ python3.5 -m test test___all__ test_support [1/2] test___all__ [2/2] test_support All 2 tests OK. $ python3.6 -m test

[issue25696] "make install" fails because bininstall target requires the libainstall target

STINNER Victor added the comment: Output: --- $ make install --debug=v (...) Must remake target 'bininstall'. (...) (cd /opt/py36/lib/pkgconfig; ln -s python-3.6.pc python-3.6dm.pc); (...) (...) /bin/sh: ligne 4 : cd: /opt/py36/lib/pkgconfig: Aucun fichier ou dossier de ce type ---

[issue25697] Fix rough alphabetical order in Misc/ACKS

New submission from Serhiy Storchaka: the list in Misc/ACKS is intended to be in rough alphabetical order by last names. But some lines breaks this order. Proposed patch restores ordering. It also removes duplicates for Richard Oudkerk. Correct sorting is not easy due to different letter

[issue25680] Selector.select() hangs when there is nothing to select

Aleksey Kladov added the comment: >I disagree, we can do better than documenting "bugs" :-) The result of `select.select([], [], [], None)` should defintelly be documented. Three platoforms made three different decisions in similar situation, so any behavior is reasonable and it should be

[issue25696] "make install" fails because bininstall target requires the libainstall target

New submission from STINNER Victor: I'm unable to install Python 3.6, "make install" doesn't copy .py files because the bininstall target failed. It failed because /opt/py36/lib/pkgconfig doesn't exist. Try: --- export MAKEFLAGS=-j9 rm -rf /opt/py36 ./configure --prefix=/opt/py36 make make

[issue25694] test.libregrtest not installed

STINNER Victor added the comment: Hum, not only libregrtest was not installable, but test_regrtest didn't work on installed Python. Can you please retry? It would be nice to modify test_regrtest to *not* write into the test package, but I failed to find a way to load tests from a different

[issue25680] Selector.select() hangs when there is nothing to select

STINNER Victor added the comment: Aleksey Kladov: "To show surprising platform-dependent API behavior." Hum ok, it makes sense :-) I agree that it would be better to have a portable behaviour in the selectors module which is supposed to be an abstraction providing a portable behaviour. We

[issue25694] test.libregrtest not installed

Roundup Robot added the comment: New changeset 1f563b259f09 by Victor Stinner in branch 'default': Issue #25694: Install test.libregrtest to be able to run tests on the installed https://hg.python.org/cpython/rev/1f563b259f09 New changeset fea86d0049d2 by Victor Stinner in branch 'default':

[issue19687] Fixes for elementtree integer overflow

Serhiy Storchaka added the comment: Christian's patch fixes two things: integer overflow and memory leak. First I'll commit a fix for memory leak (with cleanup and tests). Integer overflow looks already fixed in recent releases, there is nothing to commit. This part should be applied only to

[issue19687] Fixes for elementtree integer overflow

Roundup Robot added the comment: New changeset d51d420f3e9d by Serhiy Storchaka in branch '3.4': Issue #19687: Fixed memory leak on failed Element slice assignment. https://hg.python.org/cpython/rev/d51d420f3e9d New changeset 4d5417444961 by Serhiy Storchaka in branch '3.5': Issue #19687: Fixed

[issue22218] Fix more compiler warnings "comparison between signed and unsigned integers"

Stéphane Wirtel added the comment: a patch for 3.6 for the unicodeobject.c file -- versions: +Python 3.6 -Python 3.5 Added file: http://bugs.python.org/file41121/issue22218-2.patch ___ Python tracker

[issue19687] Fixes for elementtree integer overflow

Serhiy Storchaka added the comment: Here is updated patch for 3.4. Added new overflow checks in element_resize(), some runtime checks are replaced with asserts (conditions are always true), check for buffer size is copied from 3.5, followed Eli's suggestions about nchildren and index.

[issue25455] Some repr implementations don't check for self-referential structures

Serhiy Storchaka added the comment: Raymond, could you please make a review of the first patch? -- ___ Python tracker ___

[issue12869] PyOS_StdioReadline is printing the prompt on stderr

Adam Bartoš added the comment: > * The interactive interpreter always reads from the original standard input, > whether Readline is used or not. This is not true – the interactive interpreter reads via PyOS_Readline, which may call whatever readline hook is installed. I think the situation

[issue25684] ttk.OptionMenu radiobuttons aren't unique between two instances of OptionMenu

Serhiy Storchaka added the comment: Could you provide a patch Bryan? -- ___ Python tracker ___ ___

[issue25695] test___all__ and test_support alter execution environment

SilentGhost added the comment: test_support has this line: TESTDIRN = os.path.basename(tempfile.mkdtemp(dir='.')) Which is the culprit. The reason it gets so far as to import the module is due to the "fuzzy logic" check looking for __all__ What I'd suggest is replacing simple "in" string

[issue25694] test.libregrtest not installed

Changes by Serhiy Storchaka : -- priority: normal -> release blocker ___ Python tracker ___

[issue25624] shutil.make_archive makes invalid directory entries

Roundup Robot added the comment: New changeset e7d1df56f70b by Serhiy Storchaka in branch '3.4': Issue #25624: ZipFile now always writes a ZIP_STORED header for directory https://hg.python.org/cpython/rev/e7d1df56f70b New changeset 0f8d426e0d0c by Serhiy Storchaka in branch '3.5': Issue #25624:

[issue25693] test_asyncio prints some messages

Changes by Martin Panter : -- resolution: -> duplicate status: open -> closed superseder: -> asyncio tests are getting noisy ___ Python tracker

[issue4744] asynchat documentation needs to be more precise

Stéphane Wirtel added the comment: Ping, what's the status of this issue ? maybe we can close it and open an new one with a new description. -- ___ Python tracker

[issue25624] shutil.make_archive makes invalid directory entries

Serhiy Storchaka added the comment: Thank you for your contribution Dingyuan. Benjamin, I think this fix should be in 2.7.11. It was a regression in 2.7.11 that had made shutil.make_archive() unusable with the zip format. -- nosy: +benjamin.peterson, larry priority: normal -> release

[issue25455] Some repr implementations don't check for self-referential structures

Raymond Hettinger added the comment: >Raymond, could you please make a review of the first patch? Will do. Also, we should ask Antoine Pitrou to look at the TextIO patch and ask Stephan Krah to look at the ElementTree patch. -- nosy: +skrah ___

[issue25698] test regressions introduced with the fix for #22995

New submission from Matthias Klose: seen with the 2.7.11 release candidate; I'm not yet 100% if this is the fix for #22995 causing these test regressions. [ 93/395] test_cpickle test test_cpickle failed -- multiple errors occurred; run in verbose mode for details [101/395/2] test_decimal test

[issue25696] "make install" fails because bininstall target requires the libainstall target

Arfrever Frehtes Taifersar Arahesis added the comment: This problem in bininstall target seems to exist since Python 2.7 and 3.1. bininstall target depends on altbininstall target, which contains: @for i in $(BINDIR) $(LIBDIR); \ do \ if test ! -d $(DESTDIR)$$i;

[issue24858] python3 -m test -ugui -v test_tk gives 3 failures under Debian unstable (sid)

Serhiy Storchaka added the comment: Matthias, can you confirm that this is Debian packaging issue? -- status: open -> pending ___ Python tracker ___

[issue25699] Easier way to specify reduced globals for doctest

New submission from John Mark Vandenberg: Currently doctest.testmod `globals` defaults to including everything in the module scope, and tools like pyflakes assume that doctests run with globals as a copy of __dict__ . It is relatively simple to exclude everything using

[issue4744] asynchat documentation needs to be more precise

Martin Panter added the comment: I think it would be okay to keep this issue open to address the other mentions of “strings”. Nitika’s patch is missing the special --- and @@ indicator lines at the top, which is probably why it was rejected. Usually you make a patch by using a “diff” command

[issue25251] Unknown MS Compiler version 1900

Matt Hickford added the comment: Hi Ateik. Find cygwinccompiler.py on your computer and copy the patch to the same folder. Then run the command `patch < patch.diff`. It that doesn't work, just open both files in a text editor and copy and paste the lines to the right place, you'll work it out.