[issue25695] test___all__ and test_support alter execution environment

Roundup Robot added the comment: New changeset fb72d6d7703c by Martin Panter in branch 'default': Issue #25695: Defer creation of TESTDIRN until the test case is run https://hg.python.org/cpython/rev/fb72d6d7703c -- nosy: +python-dev ___ Python

[issue25717] tempfile.TemporaryFile fails when dir option set to directory residing on host OS mount

Changes by Serhiy Storchaka : -- nosy: +haypo ___ Python tracker ___ ___

[issue25715] Python 3.5.1 installer shows wrong upgrade path

Steve Dower added the comment: Launcher detection still isn't quite right - another patch coming. -- ___ Python tracker ___

[issue25727] os.startfile implementation for other OS'es besides Windows

Elizabeth Myers added the comment: I'm not going to reopen that can of worms. Sorry to waste your time. -- ___ Python tracker ___

[issue25668] Deadlock in logging caused by a possible race condition with "format"

Vinay Sajip added the comment: handle() and emit() are high level methods of a handler, and format() is at a lower level. Not all emit() methods will call format(). For example, socket-based and queue-based handlers don't. So it is not in general possible to separate format() out - you will

[issue25725] Memory leak on unpickling bogus data

Serhiy Storchaka added the comment: You patch is just the first version of my patch. :-) But tests are crashed with it. -- ___ Python tracker ___

[issue25728] email parser ignores inner multipart boundary when outer message duplicates it

R. David Murray added the comment: Who is to say that the outer message is defective and not the inner one? How can a parser decide which part belongs to which message? It isn't an AI. The whole message is defective, so all bets are off :) The library can't successfully parse such a

[issue25728] email parser ignores inner multipart boundary when outer message duplicates it

Forest added the comment: RFC 2046 says that the outer message is defective, since it uses a boundary delimiter that is quite obviously present inside one of the encapsulated parts: https://tools.ietf.org/html/rfc2046#section-5.1 "The boundary delimiter MUST NOT appear inside any of the

[issue25728] email parser ignores inner multipart boundary when outer message duplicates it

Forest added the comment: > The library can't successfully parse such a message It could successfully parse such a message, if it matched against inner message boundaries before outer message boundaries. (One implementation would be to keep a list of all ancestor boundaries and traverse the

[issue25300] Enable Intel MPX (Memory protection Extensions) feature

Raymond Hettinger added the comment: I'm wary of making such extensive changes throughout the codebase for an optional processor-specific feature of limited benefit and unproven worth. With each new macro and trick (Py_VARIABLE_SIZE and Py_INIT_BOUNDS), we make it harder for people to

[issue10796] Improve doc for readline.set_completer_delims()

Martin Panter added the comment: I propose to address this with the general documentation bug, Issue 6953 -- dependencies: +readline documenation needs work nosy: +martin.panter title: readline completion flaw -> Improve doc for readline.set_completer_delims()

[issue25664] Unexpected UnicodeDecodeError in logging module

Zephor Wu added the comment: sorry, i forgot this: logging.basicConfig(format='%(name)s %(message)s') the error raised at the processing of the format while the name is 'utf-8' encoded and the message is an unicode -- ___ Python tracker

[issue6953] readline documenation needs work

Martin Panter added the comment: This patch addresses the following points: 1: Moved add_history() into new “History file” section with related functions. 2: Documented that remove_ and replace_history_item() are zero-based. 3: Documented that get_history_item() is one-based. 4: Listed the

[issue6953] readline documenation needs work

Changes by Martin Panter : -- stage: -> patch review versions: +Python 3.6 ___ Python tracker ___

[issue25664] Unexpected UnicodeDecodeError in logging module

Zephor Wu added the comment: here is the case, sorry again for just typing it before and not testing it myself :) # coding=utf-8 import logging logging.basicConfig(format='%(name)s %(message)s') logger = logging.getLogger(u'测试') logger.error(u'测试') btw, i'm using python2.7.10, mac osx

[issue25705] Fix regex_compile benchmark crash

Zachary Ware added the comment: Fixed in f7283190e896. I had actually already fixed this in my sandbox repo for speed.python.org; I just went ahead and pushed it (and a couple other very minor changes) to the main benchmark repo. Thanks for the report and patch! -- nosy: +zach.ware

[issue25719] Deprecate spitfire benchmark

Zachary Ware added the comment: +1 Unless anybody else objects in the next couple days, I'll commit this. -- nosy: +zach.ware stage: -> commit review versions: -Python 2.7 ___ Python tracker

[issue25576] Remove “Content-Type: application/x-www-form-urlencoded; charset” advice

Roundup Robot added the comment: New changeset 16fec577fd8b by Martin Panter in branch '3.4': Issue #25576: Remove application/x-www-form-urlencoded charset advice https://hg.python.org/cpython/rev/16fec577fd8b New changeset 95ae5262d27c by Martin Panter in branch '3.5': Issue #25576: Merge

[issue25508] LogRecord attributes are not tuple, when logging only dict

Roundup Robot added the comment: New changeset a365fb0dd5e1 by Vinay Sajip in branch '2.7': Issue #25508: Clarify documentation on LogRecord args attribute. https://hg.python.org/cpython/rev/a365fb0dd5e1 New changeset 01998efb605a by Vinay Sajip in branch '3.4': Issue #25508: Clarify

[issue20923] ConfigParser should nested [] in section names.

Terry J. Reedy added the comment: Discussion continues because my close message was, I now realize, incomplete and therefore unsatisfying. Ditto for the doc. So I complete my close message here and reopen issue to augment the doc. The discussion has so far has glossed over the key question:

[issue25726] sys.setprofile / sys.getprofile asymetry

New submission from Stefan Seefeld: I'm using the `cProfile` module to profile my code. I tried to temporarily disable the profiler by using: prof = sys.getprofile() sys.setprofile(None) ... sys.setprofile(prof) resulting in an error. The reason is that with `cProfile`,

[issue16198] IDLE - tabbing in a string always brings up file completion window

Tom F added the comment: I've found this to be annoying as well especially in docstrings, hopefully this will help in the meantime. If you SHIFT + Tab it will at least resolve the problem of bringing up files and remains as the usual tab function. It makes me wonder if it is a bug at all

[issue25725] Memory leak on unpickling bogus data

STINNER Victor added the comment: I reviewed load_counted_tuple_leak.patch. Forget my patch, Serhiy's patch is better. -- ___ Python tracker ___

[issue25695] test___all__ and test_support alter execution environment

Martin Panter added the comment: This should be fixed now. Thanks for the report Arfrever and the analysis Ghost. I still get these warnings, but they are discussed in Issue 18383: Warning -- warnings.filters was modified by test___all__ Warning -- warnings.filters was modified by

[issue25576] Remove “Content-Type: application/x-www-form-urlencoded; charset” advice

Changes by Martin Panter : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue25728] email parser ignores inner multipart boundary when outer message duplicates it

New submission from Forest: When a multipart message erroneously defines a boundary string that conflicts with an inner message's boundary string, the parser ignores the (correct) inner message's boundary, and treats all matching boundary lines as if they belong to the (defective) outer

[issue25728] email parser ignores inner multipart boundary when outer message duplicates it

Forest added the comment: I thought at first that this might be deliberate behavior in order to comply with RFC 2046 section 5.1.2. https://tools.ietf.org/html/rfc2046#section-5.1.2 After carefully re-reading that section, I see that it is just making sure an outer message's boundary will

[issue25717] tempfile.TemporaryFile fails when dir option set to directory residing on host OS mount

Martin Panter added the comment: This patch restores the previous behaviour of tolerating fstat() failures other than EBADF. Hans, if you are able to apply it to your compiled version of Python, it might prove that my fstat() theory is correct. -- keywords: +patch Added file:

[issue25725] Memory leak on unpickling bogus data

STINNER Victor added the comment: Oh... I didn't notice that you wrote a patch :-) I started to write a similar patch: see attached pickle.patch. -- Added file: http://bugs.python.org/file41156/pickle.patch ___ Python tracker

[issue25664] Unexpected UnicodeDecodeError in logging module

Vinay Sajip added the comment: I cannot reproduce, see below. Which exact version of Python are you using, and on what platform, and with what locale? $ more logtest9.py # coding=utf-8 import logging logger = logging.getLogger(u'测试') logger.error(u'测试') $ python2.7 logtest9.py No handlers

[issue25727] os.startfile implementation for other OS'es besides Windows

New submission from Elizabeth Myers: os.startfile can be implemented on other OS'es besides Windows relatively easily (although the operation parameter should probably be limited to Windows; it can be implemented elsewhere, but is probably not worth the trouble). On Unix-like operating

[issue25727] os.startfile implementation for other OS'es besides Windows

R. David Murray added the comment: Duplicate of Issue 3177, which has quite a bit of discussion and some patch proposals. You might want to add yourself as nosy to that issue and see what you think of the proposals (I did not read through it to see what the status is...there hasn't been any

[issue25717] tempfile.TemporaryFile fails when dir option set to directory residing on host OS mount

Hans Lawrenz added the comment: Emanuel, sorry, I missed the request for sys.version earlier. The tempfile.py I attached earlier is from the python 3.5 pulled from a ppa. I wouldn't be surprised if it has some patches applied by debian/ubuntu. To be clear though the problem also presents

[issue25701] Document that tp_setattro and tp_setattr are used for deleting attributes

Martin Panter added the comment: I agree it might be safer not to document that PyObject_SetAttr etc can delete (move that change to the tp_setattro etc method slot). I’ll also review the other functions you mentioned when I get a chance. -- ___

[issue25725] Memory leak on unpickling bogus data

New submission from Serhiy Storchaka: New tests added in issue23914 exposed memory leak on unpickling TUPLE1..TUPLE3 opcodes with insufficient stack. Proposed patch fixes the leak. -- assignee: serhiy.storchaka components: Library (Lib) keywords: patch messages: 255289 nosy:

[issue25725] Memory leak on unpickling bogus data

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___

[issue25725] Memory leak on unpickling bogus data

Serhiy Storchaka added the comment: $ ./python -m test.regrtest -R 3:3 -m test_bad_stack test_pickle [1/1] test_pickle beginning 6 repetitions 123456 .. test_pickle leaked [20, 20, 20] references, sum=60 test_pickle leaked [12, 14, 14] memory blocks, sum=40 1 test failed: test_pickle

[issue25723] ConfigParser should never write broken configurations

STINNER Victor added the comment: Terry: "Since anything else without ']' is valid (...)" A Python script can be used to generate a configuration read by another application. This application can more more strict on the configuration format than Python, so I would prefer to deny '\n', '[' and

[issue25729] update pure python datetime.timedelta creation

Changes by Brian Kearns : Removed file: http://bugs.python.org/file41158/timedelta.patch ___ Python tracker ___

[issue25729] update pure python datetime.timedelta creation

Changes by Brian Kearns : Added file: http://bugs.python.org/file41159/timedelta.patch ___ Python tracker ___

[issue25664] Unexpected UnicodeDecodeError in logging module

STINNER Victor added the comment: $ cat x.py # coding=utf-8 import logging logging.basicConfig(format='%(name)s %(message)s') logger = logging.getLogger(u'测试') logger.error(u'测试') $ python2.7 x.py Traceback (most recent call last): File "/usr/lib64/python2.7/logging/__init__.py", line 859,

[issue25729] update pure python datetime.timedelta creation

New submission from Brian Kearns: Brings timedelta creation up to par with the (simpler) C equivalent. Gives a nice speed boost on the pure-py version (not worth much on CPython but useful on other implementations like PyPy). Included in a few other small bug fixes/cleanups, should be

[issue25715] Python 3.5.1 installer shows wrong upgrade path

Steve Dower added the comment: Fix attached: * moves the UI update to the correct time (*after* we've detected the path) * fixes a launcher detection issue I noticed * removes a duplicated function -- keywords: +patch Added file: http://bugs.python.org/file41152/25715_1.patch

[issue25717] tempfile.TemporaryFile fails when dir option set to directory residing on host OS mount

Hans Lawrenz added the comment: Serhiy and Emanuel, I'll paste below the surrounding code and attach the exact tempfile.py. It is the version distributed with the 3.5.0 release. If you take a look at the github repo I linked in the first comment you can also try it out for yourself if you've

[issue20923] ConfigParser should nested [] in section names.

Sebastian Bank added the comment: Terry: I am not so sure about that interpretation. Do we agree that the INI-files are the data/message? ConfigParser refuses to accept dirty INI-Files (with ']' in section names) but will produce this kind of files. I we see the arguments given to ConfigParser

[issue20923] ConfigParser should nested [] in section names.

Terry J. Reedy added the comment: Sebastian: you have it backwards. A paraphrase of Postel's recommendation (calling it a Law is wrong) is 'accept dirty data, emit clean data'. This is the current behavior. See https://en.wikipedia.org/wiki/Robustness_principle. This article also explains

[issue20923] ConfigParser should nested [] in section names.

SpaceOne added the comment: Sorry about that! I created http://bugs.python.org/issue25723. -- ___ Python tracker ___

[issue25718] itertools.accumulate __reduce__/__setstate__ bug

Serhiy Storchaka added the comment: __reduce__() and __setstate__() methods of itertools.accumulate() look correct. The problem is not in itertools.accumulate(), but in the copy module. It uses the same __reduce__ protocol as pickle, but in different way. In the pickle module (in both Python

[issue25718] itertools.accumulate __reduce__/__setstate__ bug

Changes by Serhiy Storchaka : -- keywords: +patch Added file: http://bugs.python.org/file41151/copy_state_is_false.patch ___ Python tracker

[issue20923] ConfigParser should nested [] in section names.

Mark Lawrence added the comment: Why the debate on an issue that was closed over 18 months ago? -- nosy: +BreamoreBoy ___ Python tracker ___

[issue25701] Document that tp_setattro and tp_setattr are used for deleting attributes

Serhiy Storchaka added the comment: Thank you Martin. In general the patch LGTM, but I'm not expert in English writing. There are other functions and slots with twofold purpose: PyObject_SetItem, PySequence_SetItem, PySequence_SetSlice, PyMapping_SetItemString, PySequenceMethods.sq_ass_item,

[issue25717] tempfile.TemporaryFile fails when dir option set to directory residing on host OS mount

Serhiy Storchaka added the comment: Is your file system NFS? -- ___ Python tracker ___ ___ Python-bugs-list

[issue25721] Fix pybench always_display error

Changes by Brett Cannon : -- type: crash -> ___ Python tracker ___ ___ Python-bugs-list

[issue25712] Dead link in the PEP-3147

Changes by Brett Cannon : -- assignee: -> brett.cannon nosy: +brett.cannon ___ Python tracker ___

[issue25717] tempfile.TemporaryFile fails when dir option set to directory residing on host OS mount

Emanuel Barry added the comment: Your file has a lot of shenanigans that are triggered if 'shutil' fails to be imported, adding an extra 139 lines at the top of the file, which is exactly how offset your traceback is compared to our lines. The rest of the file is virtually identical. This

[issue25717] tempfile.TemporaryFile fails when dir option set to directory residing on host OS mount

Hans Lawrenz added the comment: The file system causing the problem is of type vboxsf which is the Virtualbox shared folder file system type. -- ___ Python tracker

[issue25723] ConfigParser should never write broken configurations

Terry J. Reedy added the comment: This strikes me as an overt bug. .add_section should add one new empty section, not a section with an item and a second section. Since a section name cannot contain \n, I would agree that passing a string containing \n should raise ValueError("Section names

[issue25718] itertools.accumulate __reduce__/__setstate__ bug

New submission from Armin Rigo: itertools.accumulate() has got methods __reduce__() and __setstate__() which fail at saving/restoring the state in all cases. Example: >>> a = itertools.accumulate([0.0, 42]) >>> next(a) 0.0 >>> b = copy.deepcopy(a) >>> next(a) 42.0 >>>

[issue21679] Prevent extraneous fstat during open()

Martin Panter added the comment: The change made here no longer tolerates fstat() returning an error, which seems to be the cause of Issue 25717. -- nosy: +martin.panter ___ Python tracker

[issue25717] tempfile.TemporaryFile fails when dir option set to directory residing on host OS mount

Martin Panter added the comment: Thanks for the strace output. I think the actual error is the fstat() call a bit after that first open() call. FileNotFoundError is ENOENT: open("/vagrant/tmpy5ioznh4", O_RDWR|O_CREAT|O_EXCL|O_NOFOLLOW|O_CLOEXEC, 0600) = 4 unlink("/vagrant/tmpy5ioznh4")

[issue25709] Problem with string concatenation and utf-8 cache.

Serhiy Storchaka added the comment: Fixed yet one bug (thanks Victor again). Test is improved, now it doesn't rely on implementation detail of particular builtin. -- Added file: http://bugs.python.org/file41146/issue25709_4.patch ___ Python tracker

[issue25718] itertools.accumulate __reduce__/__setstate__ bug

Changes by Raymond Hettinger : -- assignee: -> kristjan.jonsson nosy: +kristjan.jonsson ___ Python tracker ___

[issue25714] Consider isinstance(..., numbers.Integral) instead of isinstance(..., int) or isinstance(..., (int, long)) in datetime.py

Changes by Raymond Hettinger : -- nosy: +tim.peters ___ Python tracker ___ ___

[issue25709] Problem with string concatenation and utf-8 cache.

Marc-Andre Lemburg added the comment: On 24.11.2015 02:30, Steven D'Aprano wrote: > > Steven D'Aprano added the comment: > > On Mon, Nov 23, 2015 at 09:48:46PM +, STINNER Victor wrote: > >> * the string has a cached UTF-8 byte string (ex: int(s) was called before >> the resize) > > Why

[issue25709] Problem with string concatenation and utf-8 cache.

Serhiy Storchaka added the comment: > Why do strings cache their UTF-8 encoding? Mainly for compatibility with existing C API. Common way to parse function arguments in implemented in C function is to use special argument parsing API: PyArg_ParseTuple, PyArg_ParseTupleAndKeywords, or

[issue25034] string.Formatter accepts empty fields but displays wrong when nested

Bill Tutt added the comment: I don't suppose this change could make it into 2.7.11 as well? Thanks, Bill -- nosy: +Bill Tutt ___ Python tracker ___

[issue25709] Problem with string concatenation and utf-8 cache.

STINNER Victor added the comment: issue25709_4.patch now looks good to me, but I added some minor comments on the review. -- ___ Python tracker ___

[issue25719] Deprecate spitfire benchmark

New submission from Florin Papa: Hi all, This is Florin Papa from the Server Languages Optimizations Team at Intel Corporation. The patch submitted here deprecates the spitfire benchmark, which uses psyco. Psyco is "unmaintained and dead", according to their website

[issue25714] Consider isinstance(..., numbers.Integral) instead of isinstance(..., int) or isinstance(..., (int, long)) in datetime.py

Serhiy Storchaka added the comment: C implementation almost everywhere (except strftime/strptime) accepts long as well as int, but not general integral numbers. Python implementation of the datetime module is not entire compatible with C implementation (default in CPython), therefore

[issue25660] tabs don't work correctly in python repl

R. David Murray added the comment: We try our best to support libedit, but support for it did come after readline, so there are issues with the support. However, if we are (as we are) enabling completion by default, I think that has to work with libedit, since that's what is used on OSX

[issue20923] ConfigParser should nested [] in section names.

R. David Murray added the comment: The enhancement request was rejected. At this point I think it would be better to open a new bug requesting that an error be raised if the supplied section name contains a ']'. The question there is if there are backward compatibility issues. That can be

[issue25721] Fix pybench always_display error

Changes by Florin Papa : -- type: -> crash ___ Python tracker ___ ___

[issue20923] ConfigParser should nested [] in section names.

SpaceOne added the comment: IMHO your rejection is stupid. User input should always be validated. At least a ValueError should be raised if add_section() is called with a string containing ']\x00\n['. As this will always create a broken configuration. Otherwise ConfigParser cannot be used to

[issue25720] Fix curses module compilation with ncurses6

New submission from Ismail Donmez: ncurses6 turned on NCURSES_OPAQUE, so now you have to use some helper functions instead of accessing the structs directly. This _should_ be compatible with ncurses5 though I didn't test it. Original patch is from openSUSE. -- components: Extension

[issue25721] Fix pybench always_display error

New submission from Florin Papa: Hi all, This is Florin Papa from the Server Languages Optimizations Team at Intel Corporation. The patch submitted here solves a crash occurring on Python 2.7 after running pybench from perf.py (python perf.py -r -b pybench base_python modified_python). The

[issue25721] Fix pybench always_display error

Changes by Florin Papa : -- keywords: +patch Added file: http://bugs.python.org/file41149/fix_pybench_results.patch ___ Python tracker

[issue25300] Enable Intel MPX (Memory protection Extensions) feature

Antoine Pitrou added the comment: Hi, I've reviewed the latest patch. I have a more general question: the patch sprinkles some Py_INIT_BOUNDS() calls in various places. What the macro does is set the pointer's bounds to "INIT", which basically means disable any checks (the pointer is allowed

[issue25722] Lib/ssl.py breaks certificate validation for wildcard domains, e.g. *.s3.amazonaws.com

New submission from Alexander Todorov: The latest ssl.py file tries to validate hostnames vs certificates but includes a faulty regexp which causes any wildcard domains (e.g. *.s3.amazonaws.com) to fail validation. Steps to Reproduce: >>> import ssl >>>

[issue25722] Lib/ssl.py breaks certificate validation for wildcard domains, e.g. *.s3.amazonaws.com

Christian Heimes added the comment: This is not a bug. It's actually the way how wildcards in X.509 certificates work. For hostnames a wildcard only matches one label. There can only be one wildcard and the wildcard must be in the left-most label.

[issue25720] Fix curses module compilation with ncurses6

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka, twouters stage: -> patch review type: -> compile error ___ Python tracker

[issue25709] Problem with string concatenation and utf-8 cache.

Serhiy Storchaka added the comment: Georg, I ask for applying this fix to 3.3. -- nosy: +georg.brandl versions: +Python 3.3 ___ Python tracker ___

[issue25717] tempfile.TemporaryFile fails when dir option set to directory residing on host OS mount

Hans Lawrenz added the comment: Unfortunately changing the tempfile call isn't an easy option for me. The situation in which I'm encountering the error is running tox on our project which is mounted in the /vagrant directory in the VM (this is standard for vagrant). Tox makes its own temp

[issue25723] ConfigParser should never write broken configurations

Changes by R. David Murray : -- nosy: +lukasz.langa versions: -Python 3.2, Python 3.3, Python 3.4 ___ Python tracker ___

[issue25724] SSLv3 test failure on Ubuntu 16.04 LTS

New submission from Marc Deslauriers: In order to disable SSLv3 in OpenSSL without breaking ABI, Ubuntu 16.04 LTS will ship with OP_NO_SSLv3 forced on by default. This is causing the test_ssl.py test to fail. Attached is a patch to fix the issue. -- components: Tests files:

[issue25723] ConfigParser should never write broken configurations

New submission from SpaceOne: >>> from configparser import ConfigParser >>> from io import StringIO >>> from configparser import ConfigParser >>> c = ConfigParser() >>> c.add_section('foo]\nbar=baz\n[bar') >>> fd = StringIO() >>> c.write(fd) >>> print(fd.getvalue()) [foo] bar=baz [bar] User

[issue25723] ConfigParser should never write broken configurations

SpaceOne added the comment: I would have expected something like ValueError('A section must not contain any of ...') or at least that the characters are simply stripped. -- ___ Python tracker

[issue25717] tempfile.TemporaryFile fails when dir option set to directory residing on host OS mount

Serhiy Storchaka added the comment: What is exact version of you Python? I can't identify the line in the traceback. There are few lines "newline=newline, encoding=encoding)" in tempfile.py, but no one is closer to line 753. -- nosy: +serhiy.storchaka

[issue25717] tempfile.TemporaryFile fails when dir option set to directory residing on host OS mount

Emanuel Barry added the comment: I'm with Serhiy, the line number is inane. Could you put the exact contents of your /usr/lib/python3.5/tempfile.py file somewhere for us to see? Output of sys.version would be nice, too. -- nosy: +ebarry ___ Python