[issue25925] Coverage support for CPython 2

Zachary Ware added the comment: Left a couple of review comments on Rietveld. -- nosy: +zach.ware stage: -> patch review ___ Python tracker ___

[issue25925] Coverage support for CPython 2

Alecsandru Patrascu added the comment: Thank you for the reviews. I've added a new patch (v02) to correct the issues. -- Added file: http://bugs.python.org/file41386/coverage-2.7-v02.patch ___ Python tracker

[issue4709] Mingw-w64 and python on windows x64

Nathaniel Smith added the comment: > We are working on the Fortran issue in a few different ways, one of which is > your work on MinGW compatibility so that gfortran can be used. But that isn't > the only solution to this whole problem, and it's not even preferable for a > lot of Python

[issue25599] asyncio.iscoroutinefunction returns unexpected results when presented with unittest.mock.Mock

Guido van Rossum added the comment: No I just misremembered. --Guido (mobile) -- ___ Python tracker ___ ___

[issue25599] asyncio.iscoroutinefunction returns unexpected results when presented with unittest.mock.Mock

Yury Selivanov added the comment: > Now we missed the 3.5.2 deadline. Did you mean 3.5.1? Or Larry is going to rush 3.5.2 soon? -- ___ Python tracker

[issue8604] Adding an atomic FS write API

Марк Коренберг added the comment: instead of realpath, os.lstat() may be used in order to detect if target file object is not plain file. Also, os.rename() cannot be used since it follows symlinks by default. -- ___ Python tracker

[issue19475] Add timespec optional flag to datetime isoformat() to choose the precision

Alessandro Cucci added the comment: Thanks SilentGhost! -- Added file: http://bugs.python.org/file41391/issue19475_v9.patch ___ Python tracker ___

[issue19475] Add timespec optional flag to datetime isoformat() to choose the precision

Alessandro Cucci added the comment: Sorry @SilentGhost, I didn't seen your comment at the bottom of the review. With this patch is microsecond is 0, the time will display 6 zeroes. -- Added file: http://bugs.python.org/file41388/issue19475_v8.patch

[issue25919] htp.client PUT method ignores error responses sent immediatly after headers

Wiktor Niesiobedzki added the comment: Maybe something like this? Doesn't look too complicated and I haven't noticed any breakage yet. -- keywords: +patch Added file: http://bugs.python.org/file41390/http.client.put.fix.patch ___ Python tracker

[issue19475] Add timespec optional flag to datetime isoformat() to choose the precision

Changes by Alessandro Cucci : Added file: http://bugs.python.org/file41387/issue19475_v7.patch ___ Python tracker ___

[issue8604] Adding an atomic FS write API

Марк Коренберг added the comment: Also, modern kernels allows to replace entire directory! renameat2() + RENAME_EXCHANGE So, there should be more atomic operations -- ___ Python tracker

[issue21579] Python 3.4: tempfile.close attribute does not work

Марк Коренберг added the comment: David Murray, in your code, if temporary file cannot be created, it attempts to unlink unknown name :). But, I already have almost the same solution in production. I mention it sources in issue8604. -- ___ Python

[issue11588] Add "necessarily inclusive" groups to argparse

Changes by Chris Mayo : -- nosy: +cjmayo ___ Python tracker ___ ___ Python-bugs-list

[issue19475] Add timespec optional flag to datetime isoformat() to choose the precision

SilentGhost added the comment: I think the patch is nearly finalised, but I'd appreciate if someone else would carefully go over the new C code. After that, I think, the patch could be committed. -- ___ Python tracker

[issue4709] Mingw-w64 and python on windows x64

Steve Dower added the comment: "We" is a lot of different companies and individuals. Anyone distributing prebuilt binaries is helping here, a few people are working on the licensing concerns for some components, other people are working on C BLAS libraries. I see the issue approximately as

[issue24840] implement bool conversion for enums to prevent odd edge case

Gregory P. Smith added the comment: This change breaks existing code that is relying on the behavior of the enum API as shipped in 3.4 and 3.5. Please do NOT do this. Worse, you've landed this change in a "stable" release of the enum34 "backport" module (1.1.1) despite it never having been

[issue21815] imaplib truncates some untagged responses

Lita Cho added the comment: Sounds good. On Tuesday, December 22, 2015, Maciej Szulik wrote: > > Maciej Szulik added the comment: > > Lita can you please apply the changes from latest review (from > SilentGhost). Especially the one regarding newline, which currently

[issue25930] os.unlink != os.remove in python3.5

Anthony Sottile added the comment: Breaks this function: ``` def rmtree(path): """On windows, rmtree fails for readonly dirs.""" def handle_remove_readonly(func, path, exc): # pragma: no cover (windows) excvalue = exc[1] if func in (os.rmdir, os.remove) and

[issue25251] Unknown MS Compiler version 1900

Tod Haren added the comment: In addition to patching cygwincompiler.py I also had to patch numpy\distutils\misc_util.py and numpy\distutils\mingw32ccompiler.py to handle the new dll name. A pull request has been submitted for the numpy patches. https://github.com/numpy/numpy/pull/6875

[issue25930] Document that os.remove is semantically identical to os.unlink

Brett Cannon added the comment: I think it's reasonable to say the documentation could be misconstrued -- as Anthony has shown -- and so a patch changing the os.remove docs to say "This function is semantically identical to os.unlink()" would be acceptable. -- assignee: ->

[issue25929] When doing string.replace, it uses the entire 'find' string and doesn't let it get reused...

R. David Murray added the comment: No, you aren't missing anything, it is working as designed. -- nosy: +r.david.murray resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker

[issue25770] expose name, args, and kwargs from methodcaller

Joe Jevnik added the comment: Is there a decision on the name? I can update the patch if needed. -- ___ Python tracker ___

[issue24379] operator.subscript

Joe Jevnik added the comment: > and the latter might give the impression it was some sort of special > method/attribute when it was not. Wouldn't adding this be special because it is specifically reserved by CPython as an implementation detail? Also, would adding this name (__stub or

[issue25930] os.unlink != os.remove in python3.5

Larry Hastings added the comment: Unless you can explain what bugs this is causing, I don't see any need to change the behavior. -- resolution: -> not a bug status: open -> closed ___ Python tracker

[issue25930] os.unlink != os.remove in python3.5

Anthony Sottile added the comment: When calling shutil.rmtree on windows on a readonly directory, the error handler is called with os.unlink as the first argument `func` which fails the check `func in (os.rmdir, os.remove)` which succeeded on previous python versions --

[issue15068] fileinput requires two EOF when reading stdin

Benjamin Peterson added the comment: That individually is probably okay. It's more a question of whether the entire change is appropriate for 2.7. Note PendingDeprecationWarning is fairly useless, since it's rarely enabled. On Sat, Dec 19, 2015, at 00:34, Serhiy Storchaka wrote: > > Serhiy

[issue21998] asyncio: support fork

Adam Bishop added the comment: A note about this issue should really be added to the documentation - on OS X, it fails with the rather non-sensical "OSError: [Errno 9] Bad file descriptor", making this very hard to debug. I don't have any specific requirement for fork support in asyncio as

[issue25930] os.unlink != os.remove in python3.5

Larry Hastings added the comment: How does it break? Maybe you could explain more. -- ___ Python tracker ___

[issue25931] os.fork() command distributed in windows Python27 (in SocketServer module)

New submission from Sam Lobel: I ran into this bug while using multiprocessing in Flask, which deep down uses the SocketServer.py module. There's a call to os.fork() in the windows version , which obviously doesn't work. So SocketServer.py can't be used on windows. Maybe replace it with

[issue24379] Add operator.subscript as a convenience for creating slices

Changes by Emanuel Barry : -- nosy: +ebarry stage: resolved -> patch review title: operator.subscript -> Add operator.subscript as a convenience for creating slices ___ Python tracker

[issue4709] Mingw-w64 and python on windows x64

Nathaniel Smith added the comment: Hi Steve- okay, thanks for clarifying! I think you already know this, but for the general record: the reason for the apparent fixation on this solution is that after a lot of struggle it's emerged as basically the only contender for

[issue25927] add dir_fd for mkstemp, and also maybe to all tempfile.*

New submission from Марк Коренберг: dir_fd support is good in `os` module. but tempfile module lack support of that great feature. Please add. -- messages: 256856 nosy: mmarkk priority: normal severity: normal status: open title: add dir_fd for mkstemp, and also maybe to all tempfile.*

[issue25860] os.fwalk() silently skips remaining directories when error occurs

Roundup Robot added the comment: New changeset 767262c149ca by Serhiy Storchaka in branch '3.5': Issue #25860: os.fwalk() no longer skips remaining directories when error occurs. https://hg.python.org/cpython/rev/767262c149ca New changeset a85675dabb8f by Serhiy Storchaka in branch 'default':

[issue25928] Improve performance of statistics._decimal_to_ratio and fractions.from_decimal

John Walker added the comment: Heres the output of running the benchmark on my machine: Testing proposed implementation number = 1 0.07098613299967838 number = 10 0.6952260910002224 number = 100 6.948197601999709 Testing current implementation number = 1 0.141816276996

[issue25928] Improve performance of statistics._decimal_to_ratio and fractions.from_decimal

Changes by John Walker : -- type: -> performance ___ Python tracker ___ ___

[issue25929] When doing string.replace, it uses the entire 'find' string and doesn't let it get reused...

New submission from Mark Cline: The Title might be a bit awkward but this is what I mean: before = '' after = before.replace(',,', ',null,') print(after) >,null,,null, I suspect it is starting the second search at the start of the first find + length of the find? ie: 0123 Starting

[issue21815] imaplib truncates some untagged responses

Maciej Szulik added the comment: Lita can you please apply the changes from latest review (from SilentGhost). Especially the one regarding newline, which currently fails to apply this patch on default. If all those will be cleaned I'll recommend this patch for David for inclusion. --

[issue12797] io.FileIO and io.open should support openat

Eryk Sun added the comment: Марк, os.open added dir_fd support in 3.3, which is implemented on POSIX systems by calling openat. The dir_fd parameter is available for many os functions. This is discussed in section 1.5, Files and Directories [1]. It would be nice if we could support dir_fd on

[issue25860] os.fwalk() silently skips remaining directories when error occurs

Roundup Robot added the comment: New changeset 7995a81236b6 by Serhiy Storchaka in branch '3.5': Issue #25860: Fixed test failure caused by inconsistency of os.walk() and https://hg.python.org/cpython/rev/7995a81236b6 New changeset dcf9e9ae5393 by Serhiy Storchaka in branch 'default': Issue

[issue25919] htp.client PUT method ignores error responses sent immediatly after headers

Wiktor Niesiobedzki added the comment: Here is revised patch. Also covers changes to tests. -- Added file: http://bugs.python.org/file41392/http.client.put.fix.patch ___ Python tracker

[issue24840] implement bool conversion for enums to prevent odd edge case

Ethan Furman added the comment: The enum34 backport has been fixed to not have 3.6 only features (assuming the __bool__ change was the only one). Was that your only objection, or do you not want this change in 3.6 either? -- ___ Python tracker

[issue25928] Improve performance of statistics._decimal_to_ratio and fractions.from_decimal

New submission from John Walker: In statistics, there is a FIXME on Line 250 above _decimal_to_ratio that says: # FIXME This is faster than Fraction.from_decimal, but still too slow. Half of the time is spent in a conversion in d.as_tuple(). Decimal internally stores the digits as a string,

[issue25930] os.unlink != os.remove in python3.5

New submission from Anthony Sottile: I've confirmed this bug is present on both windows and linux, the outputs below are from linux however. Compare: ``` $ python3.4 --version Python 3.4.3 $ python3.4 -c 'import os; print(os.unlink == os.remove)' True ``` ``` $ python3.5 --version Python

[issue23846] asyncio : ProactorEventLoop raised BlockingIOError when ThreadPoolExecutor has many workers

Yury Selivanov added the comment: > Why are you using 2 threads? That's a good question. In any case it looks like self-pipe sock's buffer was overflown because call_soon_threadsafe was called too many times, and loop._read_from_self couldn't empty the buffer promptly. Then, at some

[issue8604] Adding an atomic FS write API

Марк Коренберг added the comment: You also forgot about two things: 1. set temporary file permissions before rename 2. fsync(open(os.dirname(temporaryfile))) 3. if original file name is symlink, replace will works wrong. os.realpath should be used. So, here are real life function, that we use

[issue12797] io.FileIO and io.open should support openat

Марк Коренберг added the comment: But... os.openat() is still missing... why status is closed() ?! -- nosy: +mmarkk ___ Python tracker ___

[issue4709] Mingw-w64 and python on windows x64

Steve Dower added the comment: And FTR, there are plenty of major Python-using companies that insist on compiling from scratch and also refuse to touch GPL at all, no matter how many exemptions are in the licenses. GFortran is not the ideal solution for these users. --

[issue25919] htp.client PUT method ignores error responses sent immediatly after headers

SilentGhost added the comment: There is a test suite which can be run to test for breakages: ./python -m test test_httplib If you do that you'll notice that some things are broken, I got error in 5 different tests related to you select.select call: TypeError: argument must be an int, or have

[issue25919] htp.client PUT method ignores error responses sent immediatly after headers

SilentGhost added the comment: That was a testing issue, apparently test.test_httplib.FakeSocket is not fake enough. -- ___ Python tracker ___

[issue25930] os.unlink != os.remove in python3.5

Eryk Sun added the comment: This is due to using argument clinic in Modules/posixmodule.c: /*[clinic input] os.remove = os.unlink builtin_function_or_method instances are equal if m_self (the module in this case) and m_ml->ml_meth (the C function) are the same. In 3.4, the function

[issue24840] implement bool conversion for enums to prevent odd edge case

Gregory P. Smith added the comment: lets collect some examples of where it causes problems (someone ran into the problem at work which is why i hunted down this bugs.python.org issue) before deciding. If it stays in, it needs a mention in both Misc/NEWS and What's New as it will require some

[issue24658] open().write() fails on 2 GB+ data (OS X)

Ian Carroll added the comment: Write still fails on 3.5.1 and OS X 10.11.2. I'm no dev, so can someone explain how to use the patch while it's under review? -- nosy: +Ian Carroll ___ Python tracker

[issue25913] base64.a85decode adobe flag incorrectly utilizes <~ as a marker causing error

Changes by Swati Jaiswal : Added file: http://bugs.python.org/file41393/iss_25913_2.patch ___ Python tracker ___

[issue4709] Mingw-w64 and python on windows x64

Ralf Gommers added the comment: > "We" is a lot of different companies and individuals. Anyone distributing > prebuilt binaries is helping here, a few people are working on the licensing > concerns for some components, other people are working on C BLAS libraries. Note that we by default

[issue4709] Mingw-w64 and python on windows x64

Ralf Gommers added the comment: > I'm happy and keen to help so please feel free to poke me if you need > assistance with anything. I'll keep an eye out too - is it actively being > discussed on any list? Thanks Henry. There's no ongoing discussion on a list right now, but give it a week or

[issue25931] os.fork() command distributed in windows Python27 (in SocketServer module)

Eryk Sun added the comment: Starting a Windows process is expensive. Who not use threading, e.g. SocketServer.ThreadingTCPServer? It seems to me that it's a bug to even define ForkingMixIn, ForkingTCPServer, and ForkingUDPServer on Windows. Those should be conditionally defined depending on

[issue13317] building with 2to3 generates wrong import paths because build_ext is run after build_py

Swati Jaiswal added the comment: Can someone help with tests? I just need a pointer on how to do it. -- keywords: +patch Added file: http://bugs.python.org/file41394/iss_13317.patch ___ Python tracker

[issue25599] asyncio.iscoroutinefunction returns unexpected results when presented with unittest.mock.Mock

Joseph Gordon added the comment: I uploaded a patch that appears to fix the issue. -- keywords: +patch Added file: http://bugs.python.org/file41396/issue25599.patch ___ Python tracker

[issue21815] imaplib truncates some untagged responses

Lita Cho added the comment: Here is a patch after SlientGhost's review. I have added back the newline and included the comments for the imaplib documentation. -- Added file: http://bugs.python.org/file41395/imaplib_after_silentghost_review.patch

[issue25913] base64.a85decode adobe flag incorrectly utilizes <~ as a marker causing error

Martin Morrison added the comment: The proposed patch does stop requiring the leading <~, but still trims the first two characters off the data set. This will no doubt fail in cases where there is no leading marker. I think it will need to explicitly handle the case where the leading marker

[issue23846] asyncio : ProactorEventLoop raised BlockingIOError when ThreadPoolExecutor has many workers

Guido van Rossum added the comment: Why are you using 2 threads? --Guido (mobile) On Dec 22, 2015 02:03, "Joseph Gordon" wrote: > > Changes by Joseph Gordon : > > > -- > nosy: +josephgordon > >

[issue23894] lib2to3 doesn't recognize rb'...' as a raw byte string in Python 3

Joseph Gordon added the comment: With the changes in the uploaded patch it looks like strings of the form rb'...' are now recognized as raw byte strings. -- keywords: +patch Added file: http://bugs.python.org/file41382/issue23894.patch ___ Python

[issue25661] tokenize.untokenize does not maintain the order of tabbed indentations and leading spaces

Changes by Joseph Gordon : -- nosy: +josephgordon ___ Python tracker ___ ___

[issue19873] There is a duplicate function in Lib/test/test_pathlib.py

Changes by Joseph Gordon : -- nosy: +josephgordon ___ Python tracker ___ ___

[issue25922] canceling a repair install breaks the ability to uninstall, repair, or re-install

Steve Dower added the comment: Does rebooting allow you to keep going? -- ___ Python tracker ___ ___

[issue4709] Mingw-w64 and python on windows x64

Steve Dower added the comment: We are working on the Fortran issue in a few different ways, one of which is your work on MinGW compatibility so that gfortran can be used. But that isn't the only solution to this whole problem, and it's not even preferable for a lot of Python users, so expect

[issue25900] unittest ignores the first ctrl-c when it shouldn't

Marius Gedminas added the comment: Somewhat unrelated nitpick: I'm not very happy that _InterruptHandler doesn't return early after calling the original handler. It's all very well, if the original handler raises or does nothing at all, but if it's a user-installed handler that does something

[issue25599] asyncio.iscoroutinefunction returns unexpected results when presented with unittest.mock.Mock

Changes by Joseph Gordon : -- nosy: +josephgordon ___ Python tracker ___ ___

[issue25900] unittest ignores the first ctrl-c when it shouldn't

Marius Gedminas added the comment: Here's an updated patch with tests -- Added file: http://bugs.python.org/file41383/dont-ignore-first-ctrl-c-with-tests.patch ___ Python tracker

[issue4709] Mingw-w64 and python on windows x64

Henry Gomersall added the comment: Thanks Ralf - I'm happy and keen to help so please feel free to poke me if you need assistance with anything. I'll keep an eye out too - is it actively being discussed on any list? -- ___ Python tracker

[issue25900] unittest ignores the first ctrl-c when it shouldn't

Marius Gedminas added the comment: I looked for any existing tests (by grepping for 'signals' and 'import' on the same line), didn't find any (because my assumption that 'signals' would have to be explicitly imported was wrong). Wrote some new tests, which made me also make some further

[issue25664] Logging cannot handle Unicode logger names

Changes by Joseph Gordon : -- nosy: +josephgordon ___ Python tracker ___ ___

[issue25324] Importing tokenize modifies token

Changes by Joseph Gordon : -- nosy: +josephgordon ___ Python tracker ___ ___

[issue23846] asyncio : ProactorEventLoop raised BlockingIOError when ThreadPoolExecutor has many workers

Changes by Joseph Gordon : -- nosy: +josephgordon ___ Python tracker ___ ___

[issue25597] unittest.mock does not wrap dict objects correctly

Changes by Joseph Gordon : -- nosy: +josephgordon ___ Python tracker ___ ___

[issue25924] investigate if getaddrinfo(3) on OSX is thread-safe

New submission from Ronald Oussoren: https://emptysqua.re/blog/getaddrinfo-deadlock/ claims that getaddrinfo may deadlock when using threads and fork on (amongst others) OSX due to using a global lock. That lock is used when getaddrinfo is believed to be not thread safe, see the relevant

[issue25923] More const char

New submission from Serhiy Storchaka: Proposed patch adds the const qualifier to char* parameter declarations and static char arrays if appropriate. This makes the code more strict and can help to catch bugs or generate more efficient code. In additional it can decrease memory consumption by

[issue25848] Tkinter tests failed on Windows buildbots

R. David Murray added the comment: Well, it clutters up the buildbot web interface with builders that aren't being used. Our historical pattern has been to deactivate the builders after a release goes into security-fix-only mode. Zach, would it be practical to just comment them out and then

[issue25925] Coverage support for CPython 2

Changes by Emanuel Barry : -- nosy: +ebarry ___ Python tracker ___ ___ Python-bugs-list

[issue25925] Coverage support for CPython 2

New submission from Alecsandru Patrascu: Hi All, This is Alecsandru from Server Scripting Languages Optimization team at Intel Corporation. I would like to submit a patch that adds extended support for coverage, in the same way that it is used in CPython3. Used in conjunction with the

[issue25926] problems with "times" keyword in itertools.repeat

New submission from Thomas Feldmann: According to the docs `itertools.repeat(object[, times])` is equivalent to ``` def repeat(object, times=None): # repeat(10, 3) --> 10 10 10 if times is None: while True: yield object else: for i in range(times):

[issue25926] problems with "times" keyword in itertools.repeat

R. David Murray added the comment: Huh. I always thought the wording was "roughly equivalent to". This is a consequence of C vs python, and is the reason the docstring uses the [] notation. -- nosy: +r.david.murray, rhettinger ___ Python tracker

[issue25848] Tkinter tests failed on Windows buildbots

Zachary Ware added the comment: Would pretty much eliminate the benefit; there are currently a few special cases for 3.4 (particularly for the ICC builders, and the XP bot), which could go away. For the record, the secret undocumented method for running a build on all custom builders is to

[issue25848] Tkinter tests failed on Windows buildbots

R. David Murray added the comment: How about just keeping the stable set configs, minus any from that set that have special cases? Although if it is just one form submission, maybe we just need to document that in the release manager's guide? --

[issue25848] Tkinter tests failed on Windows buildbots

Zachary Ware added the comment: I think only keeping some builders would be more complex than any other option. Here's a patch against pep101 to document the custom builder trick. -- keywords: +patch Added file: http://bugs.python.org/file41389/pep101_custom_buildbots.diff

[issue25927] add dir_fd for mkstemp, and also maybe to all tempfile.*

Changes by Марк Коренберг : -- components: +Library (Lib) ___ Python tracker ___ ___

[issue25927] add dir_fd for mkstemp, and also maybe to all tempfile.*

Serhiy Storchaka added the comment: Do you want to provide a patch Mark? -- nosy: +georg.brandl, ncoghlan, serhiy.storchaka stage: -> needs patch type: -> enhancement versions: -Python 3.3, Python 3.4, Python 3.5 ___ Python tracker

[issue25599] asyncio.iscoroutinefunction returns unexpected results when presented with unittest.mock.Mock

Guido van Rossum added the comment: Oh dang. We were waiting for the OP to submit a patch (not very complex) but they never did. Now we missed the 3.5.2 deadline. Maybe someone can try again for 3.5.3? On Tue, Dec 22, 2015 at 12:30 AM, Joseph Gordon wrote: > > Changes