[issue26067] test_shutil fails when gid name is missing

2016-01-11 Thread Ezio Melotti
Ezio Melotti added the comment: We looked at this at the PyLadies Sprint in Helsinki. When the group has an id but not a name (see "gid=203135016" in the "id" output -- the name is missing), its entry is missing from the list returned by grp.getgrall(). If this behaviour is expected and

[issue26083] ValueError: insecure string pickle in subprocess.Popen on Python 2

2016-01-11 Thread Gregory P. Smith
Gregory P. Smith added the comment: note: this was not a security issue nor was it a crash. an exception was being raised anyways from the forked child prior to the exec(), this bug just caused that to be swallowed and this ValueError raised instead. -- resolution: -> fixed stage:

[issue25517] regex howto example in "Lookahead Assertions"

2016-01-11 Thread Ezio Melotti
Ezio Melotti added the comment: Fixed, thanks for the patch! -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker

[issue25517] regex howto example in "Lookahead Assertions"

2016-01-11 Thread Roundup Robot
Roundup Robot added the comment: New changeset c6b5c03183e3 by Ezio Melotti in branch '2.7': #25517: fix regex in the regex howto. Patch by Elena Oat. https://hg.python.org/cpython/rev/c6b5c03183e3 New changeset 6bd4a4907f66 by Ezio Melotti in branch '3.5': #25517: fix regex in the regex

[issue25887] awaiting on coroutine more than once should be an error

2016-01-11 Thread Brett Cannon
Brett Cannon added the comment: I don't like "coroutine was already awaited". I feel like either "on" should be appended to that or another sentence like "coroutine had 'await' called on it" or something. -- ___ Python tracker

[issue25887] awaiting on coroutine more than once should be an error

2016-01-11 Thread Yury Selivanov
Yury Selivanov added the comment: Nick, > After all, waiting for the result with "await" is only one way to terminate a > coroutine - you can also get there with direct calls to next(), send(), > throw() and close(). Yes, but I expect that almost nobody will use 'send', 'throw' etc on

[issue25486] Resurrect inspect.getargspec() in 3.6

2016-01-11 Thread Martin Panter
Martin Panter added the comment: Now the documentation says it will be removed in 3.6. I guess the 3.5 documentation also needs updating. -- nosy: +martin.panter ___ Python tracker

[issue26068] re.compile() repr end quote truncated

2016-01-11 Thread Ezio Melotti
Ezio Melotti added the comment: FTR the repr was added in #13592. -- nosy: +serhiy.storchaka type: -> behavior versions: +Python 3.5, Python 3.6 -Python 3.4 ___ Python tracker

[issue25967] Devguide: add 2to3 to the "Changing CPython's Grammar" checklist

2016-01-11 Thread Roundup Robot
Roundup Robot added the comment: New changeset 367486fbab84 by Ezio Melotti in branch 'default': #25967: add note about updating lib2to3 when the grammar is updated. Patch by Chris Thomas. https://hg.python.org/devguide/rev/367486fbab84 -- nosy: +python-dev

[issue23942] Explain naming of the patch files in the bug tracker

2016-01-11 Thread Martin Panter
Martin Panter added the comment: I guess if people wonder about this, you could at least say the naming doesn’t matter very much for the review system. If I am generating my own patches, I try to name them with one or two concise words describing the particular solution, and then insert

[issue26082] functools.lru_cache user specified cachedict support

2016-01-11 Thread Josh Rosenberg
Josh Rosenberg added the comment: Given that lru_cache uses the cache dict in very specific ways, supporting arbitrary mapping types would be extremely hard. Among other things: 1. The C code uses the concrete dict APIs (including private APIs) that would not work on arbitrary mappings that

[issue26063] Update copyright in the devguide

2016-01-11 Thread Roundup Robot
Roundup Robot added the comment: New changeset a4c18139d9b0 by Ezio Melotti in branch 'default': #26063: future-proof copyright updating. https://hg.python.org/devguide/rev/a4c18139d9b0 -- ___ Python tracker

[issue25888] awaiting on coroutine that is being awaited should be an error

2016-01-11 Thread Yury Selivanov
Yury Selivanov added the comment: Will commit this patch tomorrow to 3.5 and 3.6. It only affects coroutines (async defs): if an await expression is used on a coroutine object while it's being already awaited by another coroutine, a `RuntimeError("coroutine is being awaited already")` will be

[issue25887] awaiting on coroutine more than once should be an error

2016-01-11 Thread Nick Coghlan
Nick Coghlan added the comment: The patch looks good to me, but I'd like to see the error message convey two points: - the coroutine has already terminated (regardless of how that happened) - the calling code attempted to resume it anyway That is, something like "Cannot resume terminated

[issue25888] awaiting on coroutine that is being awaited should be an error

2016-01-11 Thread Martin Panter
Martin Panter added the comment: Missing word in a comment on the review -- nosy: +martin.panter ___ Python tracker ___

[issue25887] awaiting on coroutine more than once should be an error

2016-01-11 Thread Martin Panter
Martin Panter added the comment: The patch looks like it adds checks for the special generator-like send() etc methods, but I was expecting __await__() to also (or instead) do this check. That way you wouldn’t have to break the iterator protocol by the iterator not raising StopIteration a

[issue19251] bitwise ops for bytes of equal length

2016-01-11 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker ___ ___

[issue25994] File descriptor leaks in os.scandir()

2016-01-11 Thread Guido van Rossum
Guido van Rossum added the comment: It was a bit more subtle. I think like this: def f(): with some_lock: yield 0 yield 1 def g(): with another_lock: it = f() for i in it: raise We determined that another_lock was freed *before* some_lock.

[issue26083] ValueError: insecure string pickle in subprocess.Popen on Python 2

2016-01-11 Thread Roundup Robot
Roundup Robot added the comment: New changeset 268d13c7e939 by Gregory P. Smith in branch '2.7': Fixes issue #26083: Workaround a subprocess bug that raised an incorrect https://hg.python.org/cpython/rev/268d13c7e939 -- nosy: +python-dev ___ Python

[issue26086] Bug in standardmodule os

2016-01-11 Thread Eryk Sun
Changes by Eryk Sun : -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware ___ Python tracker ___

[issue26086] Bug in standardmodule os

2016-01-11 Thread Eryk Sun
Eryk Sun added the comment: The "yield from" syntax was added in Python 3.3, so somehow you're using the 3.5 standard library with either an old 3.x or 2.x version. The older version shouldn't use 3.5's standard library, unless you have either PYTHONHOME or PYTHONPATH defined. Generally

[issue25887] awaiting on coroutine more than once should be an error

2016-01-11 Thread Yury Selivanov
Yury Selivanov added the comment: Attaching another patch. Please review (I plan to commit it tomorrow in 3.5 and 3.6 branches). The patch affects generators machinery in the following way: 1. Generators behaviour isn't touched, the patch is only for 'async def' coroutines. 2. Calling

[issue25994] File descriptor leaks in os.scandir()

2016-01-11 Thread Martin Panter
Martin Panter added the comment: Guido are you saying in the following code, the “finally” message is not guaranteed to be printed out? Or just that you cannot limit a ResourceWarning to garbage collection? def g(): try: yield "item" finally: # Run at exhaustion,

[issue26083] ValueError: insecure string pickle in subprocess.Popen on Python 2

2016-01-11 Thread Gregory P. Smith
Gregory P. Smith added the comment: I strongly recommend people use https://pypi.python.org/pypi/subprocess32/ instead of Python 2.7's subprocess module whenever possible. That said, the fix is pretty easy. -- assignee: -> gregory.p.smith ___

[issue26083] ValueError: insecure string pickle in subprocess.Popen on Python 2

2016-01-11 Thread Eryk Sun
Eryk Sun added the comment: > I strongly recommend people use https://pypi.python.org/pypi/subprocess32/ I think this warrants a note that draws more attention to itself than the "see also" text. -- nosy: +eryksun ___ Python tracker

[issue25967] Devguide: add 2to3 to the "Changing CPython's Grammar" checklist

2016-01-11 Thread Ezio Melotti
Ezio Melotti added the comment: Fixed, thanks for the patch! -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker

[issue25887] awaiting on coroutine more than once should be an error

2016-01-11 Thread Yury Selivanov
Yury Selivanov added the comment: > I don't like "coroutine was already awaited". I feel like either "on" should > be appended to that or another sentence like "coroutine had 'await' called on > it" or something. Fine with me to have "coroutine was already awaited on". --

[issue25994] File descriptor leaks in os.scandir()

2016-01-11 Thread Martin Panter
Martin Panter added the comment: Okay I understand. You have to explicitly call the close() method if you want a generator to be cleaned up properly, which parallels how Serhiy’s proposal would be used. -- ___ Python tracker

[issue25887] awaiting on coroutine more than once should be an error

2016-01-11 Thread Yury Selivanov
Yury Selivanov added the comment: Attaching an updated patch. The RuntimeError says 'coroutine was already awaited on' for now. -- Added file: http://bugs.python.org/file41588/Issue25887_4.patch ___ Python tracker

[issue25991] readline example eventually consumes all memory

2016-01-11 Thread Martin Panter
Martin Panter added the comment: Thanks Ezio for handling this. Ignore my previous comment; I missed the key word “example” :) -- ___ Python tracker ___

[issue25788] fileinput.hook_encoded has no way to pass arguments to codecs

2016-01-11 Thread Terry J. Reedy
Terry J. Reedy added the comment: fileinput is in Python, hence the source is in Lib. Online version is https://hg.python.org/cpython/file/tip/Lib/fileinput.py https://hg.python.org/cpython/file/tip/Lib/test/test_fileinput.py Patching openhook itself looks trivial. A test is the hard part.

[issue25348] Update pgo_build.bat to use --pgo flag for regrtest

2016-01-11 Thread Roundup Robot
Roundup Robot added the comment: New changeset 113c524aed93 by Zachary Ware in branch '2.7': Issue #25348: Add --pgo and --pgo-job flags to PCbuild\build.bat https://hg.python.org/cpython/rev/113c524aed93 New changeset 01ab138f4133 by Zachary Ware in branch '3.5': Issue #25348: Add --pgo and

[issue25348] Update pgo_build.bat to use --pgo flag for regrtest

2016-01-11 Thread Zachary Ware
Zachary Ware added the comment: Thanks for the review, Steve. -- assignee: brett.cannon -> zach.ware ___ Python tracker ___

[issue21955] ceval.c: implement fast path for integers with a single digit

2016-01-11 Thread Zach Byrne
Zach Byrne added the comment: Anybody still looking at this? I can take another stab at it if it's still in scope. -- ___ Python tracker ___

[issue25887] awaiting on coroutine more than once should be an error

2016-01-11 Thread Yury Selivanov
Yury Selivanov added the comment: "Cannot await previously awaited coroutine" might be confusing if raised on "coro.send(..)"-like code... So far "coroutine was already awaited on" (do you want to drop "was", btw?) is less of all evil IMHO. -- ___

[issue21955] ceval.c: implement fast path for integers with a single digit

2016-01-11 Thread Zach Byrne
Zach Byrne added the comment: > Can you figure why unpack_sequence and other benchmarks were slower? I didn't look really closely, A few of the slower ones were floating point heavy, which would incur the slow path penalty, but I can dig into unpack_sequence. --

[issue25887] awaiting on coroutine more than once should be an error

2016-01-11 Thread Yury Selivanov
Yury Selivanov added the comment: Oh, choosing a good error message is hard :( I've a few comments. Sorry, this thread is growing rather rapidly, but please help me to pick one of them: > From the point of view of the error message, the reason I changed my > suggestion was because I liked

[issue25486] Resurrect inspect.getargspec() in 3.6

2016-01-11 Thread Yury Selivanov
Yury Selivanov added the comment: > Now the documentation says it will be removed in 3.6. I guess the 3.5 > documentation also needs updating. Good catch! -- ___ Python tracker

[issue21955] ceval.c: implement fast path for integers with a single digit

2016-01-11 Thread Yury Selivanov
Yury Selivanov added the comment: > Anybody still looking at this? I can take another stab at it if it's still in > scope. There were some visible speedups from your patch -- I think we should merge this optimization. Can you figure why unpack_sequence and other benchmarks were slower?

[issue25887] awaiting on coroutine more than once should be an error

2016-01-11 Thread Nick Coghlan
Nick Coghlan added the comment: Sorry, dropping the "was" was a typo (I should have copied & pasted it instead of rewriting). >From the point of view of the error message, the reason I changed my >suggestion was because I liked your idea of optimising it for the "only using >await" case and

[issue25887] awaiting on coroutine more than once should be an error

2016-01-11 Thread Nick Coghlan
Nick Coghlan added the comment: I expect whatever message we use will become a Stack Overflow question in fairly short order, so "good enough" is almost certainly good enough here, and I'm massively overthinking the problem :) However, combining my last suggestion with a variant of Martin's

[issue25887] awaiting on coroutine more than once should be an error

2016-01-11 Thread Yury Selivanov
Yury Selivanov added the comment: > IMO “yield from coroutine_iterator” might be plausable for some strange > combination of 3.4 code and a 3.5 coroutine, but I think it would be rare. > And if you added a check in __await__() then the using “await” wouldn’t need > to rely on next() raising

[issue25887] awaiting on coroutine more than once should be an error

2016-01-11 Thread Martin Panter
Martin Panter added the comment: Isn’t the combined point of this issue and Issue 25888 to make it only legal to “await” a coroutine instance that has not yet been started? Perhaps “Cannot [re]start terminated coroutine” would be better. -- ___

[issue24712] Docs page's sidebar vibrates on mouse wheel scroll on Chrome.

2016-01-11 Thread Mike Taylor
Mike Taylor added the comment: I can reproduce on Chrome and Firefox Nightly -- Carol, if I'd like to write a patch where would I do that? I see https://github.com/python/pythondotorg, but am not sure that's the right repo. Thanks! -- nosy: +Mike Taylor

[issue25887] awaiting on coroutine more than once should be an error

2016-01-11 Thread Nick Coghlan
Nick Coghlan added the comment: Good point about having "await" in the error message to make it more obvious what it's referring to in the "awaiting twice" case. I'll tender "Cannot await previously awaited coroutine" as one final alternative, but if you don't like that, I can cope with

[issue26087] PEP 0373 should be updated

2016-01-11 Thread Chi Hsuan Yen
New submission from Chi Hsuan Yen: Current PEP 0373 lists Python 2.7.11 as a future release, and there's no information about Python 2.7.12. Please update it, thanks! -- assignee: docs@python components: Documentation messages: 258063 nosy: Chi Hsuan Yen, docs@python priority: normal

[issue25887] awaiting on coroutine more than once should be an error

2016-01-11 Thread Yury Selivanov
Yury Selivanov added the comment: >"Cannot reuse already awaited coroutine" Great, I like it! Thanks Martin and Nick. Please check out issue #25888 just in case. -- ___ Python tracker

[issue25486] Resurrect inspect.getargspec() in 3.6

2016-01-11 Thread Roundup Robot
Roundup Robot added the comment: New changeset 36a54e30bcbd by Yury Selivanov in branch '3.5': Issue #25486: Drop "removed in 3.6" wording from inspect.getargspec docs. https://hg.python.org/cpython/rev/36a54e30bcbd New changeset 4f1a0e5deca6 by Yury Selivanov in branch 'default': Merge 3.5

[issue25887] awaiting on coroutine more than once should be an error

2016-01-11 Thread Martin Panter
Martin Panter added the comment: If the coroutine-iterator is going to raise RuntimeError rather than StopIteration, do you think the __await__() documentation should be clarified? IMO “yield from coroutine_iterator”

[issue26085] Tkinter spoils the input text

2016-01-11 Thread fresh_nick
New submission from fresh_nick: Hello, I have Python 3.4.3 and Tk/Tcl 8.5 (built in Python; reported by tk.TclVersion and tk.TkVersion). When I assign printing 'This works' to a hotkey, the program prints 'This worsk'. After pressing the hotkey again, 'worsk' is replaced with 'works', but

[issue26083] ValueError: insecure string pickle in subprocess.Popen on Python 2

2016-01-11 Thread Ned Deily
Changes by Ned Deily : -- nosy: +gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list

[issue25991] readline example eventually consumes all memory

2016-01-11 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9a2c891a4333 by Ezio Melotti in branch '2.7': #25991: fix readline example to limit history size. Patch by Daniel Dye. https://hg.python.org/cpython/rev/9a2c891a4333 New changeset 416db1a2fb81 by Ezio Melotti in branch '3.5': #25991: fix readline

[issue25991] readline example eventually consumes all memory

2016-01-11 Thread Ezio Melotti
Ezio Melotti added the comment: Fixed, thanks for the patch! -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker

[issue25995] os.walk() consumes a lot of file descriptors

2016-01-11 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Both patches are basically equivalent. The first one collects all scandir() results in a list, the second one collects only directory names in a list. The purpose of using os.scandir() in os.walk() was a speed up (issue23605), and both patches preserve it.

[issue26086] Bug in standardmodule os

2016-01-11 Thread Hana Larsen
New submission from Hana Larsen: I get a error in the stardard module "os" (I use Python 3.5.1 64bit for Windows 10!) What is wrong and have someone a patch See the "os-bug.PNG"-file. -- files: os-bug.PNG messages: 258023 nosy: Johano priority: normal severity: normal status: open

[issue24918] Docs layout bug

2016-01-11 Thread Ezio Melotti
Ezio Melotti added the comment: Georg, do you have any opinion on this? AFAIK all the div.highlight contain a with the actual code and it's own background color, so using background: none; should be fine. -- nosy: +georg.brandl stage: needs patch -> patch review

[issue26041] Update deprecation messages of platform.dist() and platform.linux_distribution()

2016-01-11 Thread Ezio Melotti
Changes by Ezio Melotti : -- stage: needs patch -> patch review ___ Python tracker ___

[issue25995] os.walk() consumes a lot of file descriptors

2016-01-11 Thread Guido van Rossum
Guido van Rossum added the comment: I am all for preventing the leaks. But using FDs proportional to the tree depth seems reasonable to me. (If you are worried about some kind of DoS attack on the algorithm by someone who can build a tree with depth 1000, well, if they can do that they can also

[issue25486] Resurrect inspect.getargspec() in 3.6

2016-01-11 Thread Roundup Robot
Roundup Robot added the comment: New changeset 32c8bdcd66cc by Yury Selivanov in branch 'default': Issue #25486: Resurrect inspect.getargspec in 3.6. Backout a565aad5d6e1. https://hg.python.org/cpython/rev/32c8bdcd66cc -- nosy: +python-dev ___ Python

[issue26083] ValueError: insecure string pickle in subprocess.Popen on Python 2

2016-01-11 Thread Chi Hsuan Yen
New submission from Chi Hsuan Yen: Originally reported at [1] and [2]. On Mac OS X, read() on pipes may return only the first 512 bytes. The remaining bytes are not read into `data` in _execute_child(). There's a patch proposal at [3]. I didn't test it myself because I can't reproduce the

[issue26084] HTMLParser mishandles last attribute in self-closing tag

2016-01-11 Thread Tom Anderl
New submission from Tom Anderl: When the HTMLParser encounters a start tag element that includes: 1. an unquoted attribute as the final attribute 2. an optional '/' character marking the start tag as self-closing 3. no space between the final attribute and the '/' character the '/'

[issue23942] Explain naming of the patch files in the bug tracker

2016-01-11 Thread Maciej Szulik
Maciej Szulik added the comment: Ezio, I've meant we should provide some guidelines with information the system will pick whatever they choose based on submission date. More informational than as a requirement. -- ___ Python tracker

[issue25596] Use scandir() to speed up the glob module

2016-01-11 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Not this version of the path. It accumulates all scandir results in a list before yielding values. Otherwise globbing will consume a lot of open file descriptors and could leak them (see issue25994, issue25995). --

[issue25994] File descriptor leaks in os.scandir()

2016-01-11 Thread Guido van Rossum
Guido van Rossum added the comment: Note there's also a nasty corner case related to generators and GC. If a generator contains a with-block or finally-clause, and the generator is not run until its end because the caller hit an exception on one of the items returned, and the generator object

[issue25486] Resurrect inspect.getargspec() in 3.6

2016-01-11 Thread Yury Selivanov
Yury Selivanov added the comment: inspect.getargspec is back to Python 3.6 (it was never removed from <= 3.5, fwiw) -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker

[issue25486] Resurrect inspect.getargspec() in 3.6

2016-01-11 Thread Stefan Krah
Stefan Krah added the comment: On Mon, Jan 11, 2016 at 08:17:11PM +, Yury Selivanov wrote: > inspect.getargspec is back to Python 3.6 (it was never removed from <= 3.5, > fwiw) Yay! Thank you very much! -- ___ Python tracker

[issue24705] sysconfig._parse_makefile doesn't expand ${} vars appearing before $() vars

2016-01-11 Thread Roundup Robot
Roundup Robot added the comment: New changeset ef84d21f5292 by doko in branch '3.5': - Issue #24705: Fix sysconfig._parse_makefile not expanding ${} vars https://hg.python.org/cpython/rev/ef84d21f5292 -- nosy: +python-dev ___ Python tracker

[issue26084] HTMLParser mishandles last attribute in self-closing tag

2016-01-11 Thread Ezio Melotti
Changes by Ezio Melotti : -- assignee: -> ezio.melotti nosy: +ezio.melotti stage: -> test needed ___ Python tracker ___

[issue23942] Explain naming of the patch files in the bug tracker

2016-01-11 Thread R. David Murray
Changes by R. David Murray : -- nosy: -r.david.murray ___ Python tracker ___ ___

[issue25596] Use scandir() to speed up the glob module

2016-01-11 Thread Guido van Rossum
Guido van Rossum added the comment: Oh well. Too bad. Never mind then. -- ___ Python tracker ___ ___

[issue25995] os.walk() consumes a lot of file descriptors

2016-01-11 Thread Guido van Rossum
Guido van Rossum added the comment: I don't like the first solution (it just collects all scandir() results in a list, which defeats one of the purposes of using scandir()), but I don't understand the second solution. Ideally the number of FDs used should be limited by the depth of the tree

[issue25596] Use scandir() to speed up the glob module

2016-01-11 Thread Guido van Rossum
Guido van Rossum added the comment: Looks like switching to scandir will also resolve http://bugs.python.org/issue22167 without further action. -- ___ Python tracker

[issue22167] iglob() has misleading documentation (does indeed store names internally)

2016-01-11 Thread Guido van Rossum
Guido van Rossum added the comment: Once http://bugs.python.org/issue25596 (switching glob to use scandir) is solved this issue can be closed IMO. -- nosy: +gvanrossum ___ Python tracker

[issue11245] Implementation of IMAP IDLE in imaplib?

2016-01-11 Thread Maciej Szulik
Changes by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker ___ ___

[issue25596] Use scandir() to speed up the glob module

2016-01-11 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- title: Use scandir() to speed the glob module -> Use scandir() to speed up the glob module ___ Python tracker

[issue22642] trace module: unclear error message

2016-01-11 Thread Senthil Kumaran
Senthil Kumaran added the comment: I reviewed the patch. It looks like the problem is not just with list functions but with other options too. Like. $ ./python.exe -m trace -t $ ./python.exe -m trace -c $ ./python.exe -m trace -T Will throw the same error. So, any changes should address all

[issue26079] Build with Visual Studio 2015 using PlatformToolset=v120

2016-01-11 Thread Bjoern Thiel
New submission from Bjoern Thiel: Fixing the build output folder for tix-8.4.3.6. -- components: Build files: build.patch keywords: patch messages: 257956 nosy: bjoernthiel priority: normal severity: normal status: open title: Build with Visual Studio 2015 using PlatformToolset=v120

[issue25596] Use scandir() to speed up the glob module

2016-01-11 Thread Ben Hoyt
Ben Hoyt added the comment: Nice! Good to see scandir() getting used to speed up other functions, functions that folks are using a ton already, like glob(). -- ___ Python tracker

[issue26032] Use scandir() to speed up pathlib globbing

2016-01-11 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Proposed minimal patch implements globbing in pathlib using os.scandir(). Here are results of microbenchmarks: $ ./python -m timeit -s "from pathlib import Path; p = Path()" -- "list(p.glob('**/*'))" Unpatched: 598 msec per loop Patched: 372 msec per loop

[issue26079] Build with Visual Studio 2015 using PlatformToolset=v120

2016-01-11 Thread SilentGhost
Changes by SilentGhost : -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware type: crash -> compile error ___ Python tracker

[issue26071] bdist_wininst created binaries fail to start and find 32bit Pythons

2016-01-11 Thread Steve Dower
Steve Dower added the comment: The downside of the preprocessor - no errors when you spell an ifdef wrong ;) It looks good to me. -- ___ Python tracker

[issue7559] TestLoader.loadTestsFromName swallows import errors

2016-01-11 Thread Matej Cepl
Changes by Matej Cepl : -- nosy: +mcepl ___ Python tracker ___ ___ Python-bugs-list mailing

[issue25348] Update pgo_build.bat to use --pgo flag for regrtest

2016-01-11 Thread Steve Dower
Steve Dower added the comment: LGTM -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26080] "abandonned" -> "abandoned" in PEP 510's https://hg.python.org/peps/rev/b463c740990c

2016-01-11 Thread Roundup Robot
Roundup Robot added the comment: New changeset 63151533cebf by Victor Stinner in branch 'default': PEP 510: abandonned => abandoned https://hg.python.org/peps/rev/63151533cebf -- nosy: +python-dev ___ Python tracker

[issue26059] Integer Overflow in strop.replace()

2016-01-11 Thread Ramin Farajpour Cami
Ramin Farajpour Cami added the comment: The issue can be triggered by performing a large substitution that overflows the arithmetic used in mymemreplace() to calculate the size of the new string: -- ___ Python tracker

[issue26079] Build with Visual Studio 2015 using PlatformToolset=v120

2016-01-11 Thread Steve Dower
Steve Dower added the comment: It's better than using the Visual Studio version, which isn't necessarily tied to any VC version. To support another compiler will require more code like this anyway. An alternative may be to patch Tcl et al. to not put the VC version into the output path?

[issue26059] Integer Overflow in strop.replace()

2016-01-11 Thread Ramin Farajpour Cami
Ramin Farajpour Cami added the comment: please look image : Thanks, -- Added file: http://bugs.python.org/file41580/123.PNG ___ Python tracker ___

[issue26058] PEP 509: Add ma_version to PyDictObject

2016-01-11 Thread STINNER Victor
STINNER Victor added the comment: Patch version 3 updated for the second version of the PEP 509. Main changes: * ma_version now has the type PY_UINT64_T * remove dict.__version__ property: replace with _testcapi.dict_get_version() for tests -- versions: +Python 3.6 -Python 2.7 Added

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

2016-01-11 Thread Senthil Kumaran
Senthil Kumaran added the comment: The patch is correct and will fix the issue. It will require test coverage to be complete so that we don't land upon similar issues in future. -- nosy: +orsenthil stage: -> test needed versions: +Python 3.5, Python 3.6 -Python 3.4

[issue26081] Implement asyncio Future in C to improve performance

2016-01-11 Thread Yury Selivanov
New submission from Yury Selivanov: Some info on this: https://github.com/python/asyncio/issues/282#issuecomment-155957235 Long story short, Future implemented in C can speedup some asyncio code up to 25%. I'm attaching a patch with a WIP implementation. There are some failing assertions

[issue26050] Add new StreamReader.readuntil() method

2016-01-11 Thread Yury Selivanov
Changes by Yury Selivanov : -- Removed message: http://bugs.python.org/msg257983 ___ Python tracker ___

[issue26059] Integer Overflow in strop.replace()

2016-01-11 Thread Ramin Farajpour Cami
Ramin Farajpour Cami added the comment: Do you have any idea how to fix it? -- ___ Python tracker ___ ___

[issue26050] Add new StreamReader.readuntil() method

2016-01-11 Thread Roundup Robot
Roundup Robot added the comment: New changeset db11d0db1598 by Yury Selivanov in branch '3.4': Issue #26050: Add asyncio.StreamReader.readuntil() method. https://hg.python.org/cpython/rev/db11d0db1598 New changeset a6288fe5420f by Yury Selivanov in branch '3.5': Merge 3.4 (Issue #26050)

[issue26050] Add new StreamReader.readuntil() method

2016-01-11 Thread Yury Selivanov
Yury Selivanov added the comment: Leaving this issue open until we have the docs committed. -- ___ Python tracker ___

[issue26059] Integer Overflow in strop.replace()

2016-01-11 Thread STINNER Victor
Changes by STINNER Victor : -- title: Integer Overflow -> Integer Overflow in strop.replace() ___ Python tracker ___

[issue26079] Build with Visual Studio 2015 using PlatformToolset=v120

2016-01-11 Thread Zachary Ware
Zachary Ware added the comment: I'm on the fence about this one. MSVC 12.0 is not officially supported for any Python release. Also, using PlatformToolset makes things difficult for ICC builds (which set PlatformToolset to e.g. "Intel C++ Compiler 16.0"). On the other hand, this is a very

[issue26059] Integer Overflow in strop.replace()

2016-01-11 Thread Guido van Rossum
Guido van Rossum added the comment: I cannot reproduce this on Mac (the code form 1.py just gives a very long answer). I don't have a Windows machine to try it on. Do you have a patch or fix? -- ___ Python tracker

[issue26080] "abandonned" -> "abandoned" in PEP 510's https://hg.python.org/peps/rev/b463c740990c

2016-01-11 Thread STINNER Victor
STINNER Victor added the comment: Fixed, thanks for the report. -- nosy: +haypo resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue26059] Integer Overflow in strop.replace()

2016-01-11 Thread Ramin Farajpour Cami
Ramin Farajpour Cami added the comment: static char * mymemreplace(const char *str, Py_ssize_t len, const char *pat, Py_ssize_t pat_len,pattern string to find */ const char *sub, Py_ssize_t sub_len,substitution string */ Py_ssize_t

[issue26059] Integer Overflow in strop.replace()

2016-01-11 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The code in msg257977 doesn't match current sources. -- ___ Python tracker ___

  1   2   >