[issue26499] http.client.IncompleteRead from HTTPResponse read after part reading file

Martin Panter added the comment: Thanks for the report and the patch. It looks okay as far as it goes, but I think there are other related bugs: ## read1() doesn’t update length either ## >>> handle = urlopen("https://www.python.org/;) >>> len(handle.read1()) 7374 >>> handle.read() Traceback

[issue21042] ctypes.util.find_library() should return full pathname instead of filename in linux

Martin Panter added the comment: It looks like the ldconfig parsing isn’t working for some ABIs. See the following buildbot failures: * Cortex A15 armv7l: http://buildbot.python.org/all/builders/ARMv7%20Ubuntu%203.x/builds/3721/steps/test/logs/stdio * ppc64le POWER8:

[issue21910] File protocol should document if writelines must handle generators sensibly

Dan Haffey added the comment: +1, I just lost an hour-plus compute job to this. It sure violates POLA. I've been passing large generators to file.writelines since about as long as generators have existed, so I never would have guessed that a class named "StreamWriter" of all things wouldn't,

[issue26515] Update extending/embedding docs to new way to build modules in C

New submission from Brett Cannon: https://docs.python.org/3/extending/extending.html#a-simple-example uses PyModule_Create() instead of PyModuleDef_Init(). -- assignee: docs@python components: Documentation messages: 261398 nosy: brett.cannon, docs@python, eric.snow, ncoghlan priority:

[issue26508] Infinite crash leading to DoS

Brett Cannon added the comment: Victor's point is that this isn't a bug because you are manipulating the C API to make this occur. That means there is no safety guarantee and thus this is not a bug but simply a mis-use of the C API. -- nosy: +brett.cannon resolution: works for me ->

[issue26508] Infinite crash leading to DoS

Changes by pablo sacristan : -- status: closed -> open ___ Python tracker ___ ___

[issue26508] Infinite crash leading to DoS

pablo sacristan added the comment: New content for crash.py: import ctypes, struct, sys, os inner = () outer = (inner,) c_outer = (ctypes.c_char * sys.getsizeof(outer)).from_address(id(outer)) inner_index = c_outer[:].find(struct.pack('P', id(inner)))

[issue26508] Infinite crash leading to DoS

pablo sacristan added the comment: Then it is no bug that it crashes python? You don't have to put it in a loop, but by looping it I am adding the part that makes it take more time but will keep on crashing infinitely, take away the while loop but not what it has inside and then also delete

[issue18156] Add an 'attr' attribute to AttributeError

Xiang Zhang added the comment: The concerns mentioned by haypo seems to have existed in PEP473. -- ___ Python tracker ___

[issue21042] ctypes.util.find_library() should return full pathname instead of filename in linux

Roundup Robot added the comment: New changeset 3092cf163eb4 by Martin Panter in branch 'default': Issue #21042: Return full path in ctypes.util.find_library() on Linux https://hg.python.org/cpython/rev/3092cf163eb4 -- nosy: +python-dev ___ Python

[issue26439] ctypes.util.find_library fails when ldconfig/glibc not available (e.g., AIX)

Michael Felt added the comment: The patch works when installed on top of pre-compiled version (e.g., copy the two files to /opt/lib/python2.7/ctypes/ but there seems to be a nasty side-effect when trying to build. make completes, but make install fails during a compile step. Please assist

[issue26466] could not build python 2.7.11 on AIX

Michael Felt added the comment: Hope it is okay for me to close this. As it is working with the additional flag to configure. -- status: open -> closed ___ Python tracker

[issue26513] platform.win32_ver() broken in 2.7.11

Steve Dower added the comment: Nothing has changed here as far as I'm aware. The part of platform.py in use here has potentially different behavior if you have pywin32 installed. Is that the case? Maybe you updated that as well or haven't installed it for 2.7.11 yet? --

[issue26514] Object defines '__ne__' as 'not __eq__' if '__ne__' is not implemented

Changes by Eryk Sun : -- resolution: -> works for me stage: -> resolved status: open -> closed ___ Python tracker ___

[issue25458] ftplib: command response shift - mismatch

Peter Pan added the comment: The problem in my example is ftplib reports a "226" response to command "NOOP" which is nonsense. ftplib received "226" before "ftp.sendcmd('NOOP')" was called. Since "transfercmd()" returns a socket, ftplib was planned to allow for manual transfer socket

[issue25228] Regression in cookie parsing with brackets and quotes

Collin Anderson added the comment: It should be safe to hard split on semicolon. `name="some;value"` is not valid, even though it's quoted. I think raw double quotes, commas, semicolons and backslashes are _always_ invalid characters in cookie values. >From

[issue26514] Object defines '__ne__' as 'not __eq__' if '__ne__' is not implemented

Josh Rosenberg added the comment: It's not exactly what was asked for, but it's actually better (in that the __ne__ default implementation handles NotImplemented correctly). Per the docs at https://docs.python.org/3/reference/datamodel.html#object.__eq__ : "By default, __ne__() delegates to

[issue26514] Object defines '__ne__' as 'not __eq__' if '__ne__' is not implemented

Ethan Furman added the comment: The following behaviour is from 3.5: --> class Huh: ... def __eq__(self, other): ... return other == 'blah' ... --> h = Huh() --> h == 'ew' False --> h != 'ew' True --> h == 'blah' True --> h != 'blah' False Which seems to be exactly what you want. Do

[issue26514] Object defines '__ne__' as 'not __eq__' if '__ne__' is not implemented

New submission from Marc Guetg: I propose to change __ne__ of `object` in the following form: class NewObject(object): def __ne__(self, other): return not self.__eq__(other) Currently overwriting the `__eq__` method requires also overwriting

[issue26513] platform.win32_ver() broken in 2.7.11

New submission from Florian Roth: Using Python 2.7.9 and 2.7.10 (32bit) on a Windows Server 2008 R2 64bit System platform.win32_ver() shows the following, which is correct: ('2008ServerR2', '6.1.7601', 'SP1', u'Multiprocessor Free') Using Python version 2.7.11 (32bit) on the same Windows

[issue26512] Vocabulary: Using "integral" in library/stdtypes.html

Alexander Belopolsky added the comment: In the contexts that you mentioned, "integral" is a synonym of "integer." -- nosy: +belopolsky ___ Python tracker

[issue15068] fileinput requires two EOF when reading stdin

Roundup Robot added the comment: New changeset 88d6742aa99a by Serhiy Storchaka in branch '2.7': Issue #15068: Avoid creating a reference loop in fileinput. https://hg.python.org/cpython/rev/88d6742aa99a New changeset a0de41b46aa6 by Serhiy Storchaka in branch '3.5': Issue #15068: Avoid

[issue15068] fileinput requires two EOF when reading stdin

Serhiy Storchaka added the comment: Ah, thanks Martin. I forgot that assigning an attribute to a bound method creates a reference loop. This can be fixed without performance lost by using a clever trick. -- ___ Python tracker

[issue26465] Upgrade OpenSSL shipped with python installers

Changes by Steve Dower : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue26512] Vocabulary: Using "integral" in library/stdtypes.html

New submission from Julien: o/ TL;DR: I think the various usages of "Integral" in https://docs.python.org/3.5/library/stdtypes.html#numeric-types-int-float-complex are either wrong or too hard to understand and should be rewriten as "int". While translating the documentation I found the

[issue15068] fileinput requires two EOF when reading stdin

Martin Panter added the comment: It seems this change is causing some (intermittent?) buildbot failures in 2.7: http://buildbot.python.org/all/builders/s390x%20RHEL%202.7/builds/273/steps/test/logs/stdio == FAIL: test_saveall

[issue26465] Upgrade OpenSSL shipped with python installers

Steve Dower added the comment: I didn't have nasm on the path when preparing, so it made empty asm files. I've committed the correctly build ASM files, and I'll trigger the buildbots to clean and patch the prepare script to fail if nasm is not available. --

[issue26456] import _tkinter + TestForkInThread leaves zombie with stalled thread

Martin Panter added the comment: The change to the test seems to have the desired effect. The buildbots are no longer timing out (tests are failing for other reasons). -- resolution: -> fixed stage: commit review -> resolved status: open -> closed

[issue26465] Upgrade OpenSSL shipped with python installers

Zachary Ware added the comment: Steve: This broke 64-bit Windows, I haven't tried digging into what's going on yet. See: http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/7331/steps/compile/logs/stdio -- resolution: fixed -> stage: resolved -> status:

[issue25933] Unhandled exception (TypeError) with ftplib in function retrbinary/retrlines causes inoperable behavior without crashing

Giampaolo Rodola' added the comment: It looks to me that forcing self.voidresp() in case the callback raises an exception is a bad idea: it may easily end up hanging if the server is not supposed to send a response at that point (see: the transfer is not finished). As for the issue per se: I

[issue25458] ftplib: command response shift - mismatch

Giampaolo Rodola' added the comment: I'm not sure I understood the problem. Perhaps if you provide a patch that would make things more clear and you'd have more chances to see this issue fixed. -- ___ Python tracker

[issue25459] EAGAIN errors in Python logging module

Henrique Andrade added the comment: Vinay, apologies for the long time you took me to respond (the notification was stuck in my Spam folder, thanks Gmail!). Indeed, both of your comments are spot on. In my particular case, I ended up implementing what your first suggestion alludes to (a retry

[issue17446] doctest test finder doesnt find line numbers of properties

Michael Cuthbert added the comment: looks like we're stuck on a style change (backslash to parens; ironic: I chose backslash to match surrounding code; I never use them myself). tuxtimo - could you fix this? (or I'll do once the move to github is done). Thanks! --

[issue14102] argparse: add ability to create a man page

Changes by Ben Finney : -- versions: +Python 3.6 -Python 2.7 ___ Python tracker ___

[issue14102] argparse: add ability to create a man page

Ben Finney added the comment: Oz Tiram wrote: > I doubt if the correct place for formatting a man page should be in > argparse.py itself. My solution is an extension of Andial's brecht solution Thank you for that, Oz. I see an easy seam to refactor this work into separate concerns. The

[issue25911] Regression: os.walk now using os.scandir() breaks bytes filenames on windows

Roundup Robot added the comment: New changeset 757159fb4847 by Serhiy Storchaka in branch '3.5': Issue #25911: Tring to silence deprecation warnings in bytes path walk tests. https://hg.python.org/cpython/rev/757159fb4847 New changeset ecf4e51c222f by Serhiy Storchaka in branch 'default': Issue

[issue26263] Serialize array.array to JSON by default

Changes by shakur shams Mullick : -- nosy: +shakur shams Mullick ___ Python tracker ___

[issue26465] Upgrade OpenSSL shipped with python installers

Changes by Steve Dower : -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker ___

[issue26465] Upgrade OpenSSL shipped with python installers

Roundup Robot added the comment: New changeset 195ce1f4f54b by Steve Dower in branch '2.7': Issue #26465: Update Windows builds to use OpenSSL 1.0.2g. https://hg.python.org/cpython/rev/195ce1f4f54b -- ___ Python tracker

[issue26465] Upgrade OpenSSL shipped with python installers

Roundup Robot added the comment: New changeset 6d7f0421b71f by Steve Dower in branch '3.5': Issue #26465: Update Windows builds to use OpenSSL 1.0.2g. https://hg.python.org/cpython/rev/6d7f0421b71f New changeset e045f26ea74a by Steve Dower in branch 'default': Issue #26465: Update Windows

[issue26387] Crash calling sqlite3_close with invalid pointer

Serhiy Storchaka added the comment: This may be similar to issue26494. As for the patch, _pysqlite_seterror() shouldn't be called when GIL is released. And setting self->db not guarded with GIL looks dangerous. -- ___ Python tracker

[issue15068] fileinput requires two EOF when reading stdin

Serhiy Storchaka added the comment: Committed in changesets 5fbd16326353 (2.7), 9ead3a6c5f81 (3.5), and fefedbaac640 (default). Due to SMTP failure there is no Roundup report. Warnings are not emitted in maintained releases. -- resolution: -> fixed stage: patch review -> resolved

[issue22367] Add open_file_descriptor parameter to fcntl.lockf() (use the new F_OFD_SETLK flag)

Hristo Venev added the comment: Here is the OFD patch, I'll open another issue for the overflow bug. -- versions: +Python 3.6 Added file: http://bugs.python.org/file42093/0002-fcntl-Support-Linux-open-file-descriptor-locks.patch ___ Python tracker

[issue26511] Add link to id() built-in in comparison operator documentation for "is"

New submission from Mike Vertolli: Here's the doc: https://docs.python.org/2/reference/expressions.html#is It would be great if this line: "The operators is and is not test for object identity: x is y is true if and only if x and y are the same object. x is not y yields the inverse truth

[issue26387] Crash calling sqlite3_close with invalid pointer

Filipp Andjelo added the comment: Hi Serhiy, unfortunately not, we have one heavy application which is crashing with the given error non deterministically after about 25 hours of running on 40 CPUs with 280GiB memory (!) in use. We already made all kind of test to get it reproducible "in a

[issue26415] Fragmentation of the heap memory in the Python parser

A. Skrobov added the comment: @Serhiy: if your build is 32-bit, then every node is half the size, as it mostly consists of pointers. The amount of heap fragmentation can also depend on gcc/glibc version. -- ___ Python tracker

[issue25911] Regression: os.walk now using os.scandir() breaks bytes filenames on windows

Roundup Robot added the comment: New changeset 19a3e0e664af by Serhiy Storchaka in branch '3.4': Issues #23808, #25911: Trying to fix walk tests on Windows. https://hg.python.org/cpython/rev/19a3e0e664af New changeset f9e22717722d by Serhiy Storchaka in branch '3.5': Issues #23808, #25911:

[issue23808] Symlink to directory on Windows 8

Roundup Robot added the comment: New changeset 19a3e0e664af by Serhiy Storchaka in branch '3.4': Issues #23808, #25911: Trying to fix walk tests on Windows. https://hg.python.org/cpython/rev/19a3e0e664af New changeset f9e22717722d by Serhiy Storchaka in branch '3.5': Issues #23808, #25911:

[issue26510] [argparse] Add required argument to add_subparsers

Changes by Memeplex : -- nosy: +bethard ___ Python tracker ___ ___ Python-bugs-list

[issue26510] [argparse] Add required argument to add_subparsers

Changes by Memeplex : -- title: Add required argument to add_subparsers -> [argparse] Add required argument to add_subparsers ___ Python tracker

[issue26387] Crash calling sqlite3_close with invalid pointer

Serhiy Storchaka added the comment: Could you please provide a test Filipp? -- ___ Python tracker ___ ___

[issue26510] Add required argument to add_subparsers

New submission from Memeplex: It's useful in combination with dest. Currently you have to set required as an attribute. This is not only inconsistent but not even documented as a valid usage (in general, it's not clear from the docs whether attribute setting -vs argument passing- is a valid

[issue26502] traceback.extract_tb breaks compatibility by returning FrameSummary

Berker Peksag added the comment: This is basically a duplicate of issue 25573. We need to add the examples in traceback module documentation to test_traceback.py. > Should __len__ be added as well? IMO, the new FrameSummary API (and its friends) shouldn't change the return value of the

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Mathieu Dupuy added the comment: Much better indeed. Thanks. -- ___ Python tracker ___ ___ Python-bugs-list

[issue26502] traceback.extract_tb breaks compatibility by returning FrameSummary

Changes by STINNER Victor : -- nosy: +rbcollins ___ Python tracker ___ ___

[issue18156] Add an 'attr' attribute to AttributeError

STINNER Victor added the comment: > try: > cls.meth() > except AttributeError as exc: > if exc.attr != 'meth': > raise What if cls.__getattr__('meth') calls a completly unrelated function which also raises AttributeError(attr='meth') but on a different object? I would also expect an

[issue22367] Add open_file_descriptor parameter to fcntl.lockf() (use the new F_OFD_SETLK flag)

Changes by STINNER Victor : -- nosy: +pitrou ___ Python tracker ___ ___

[issue22367] Add open_file_descriptor parameter to fcntl.lockf() (use the new F_OFD_SETLK flag)

Changes by STINNER Victor : -- title: Add F_OFD_SETLK, etc support to fcntl.lockf -> Add open_file_descriptor parameter to fcntl.lockf() (use the new F_OFD_SETLK flag) ___ Python tracker

[issue22367] Add F_OFD_SETLK, etc support to fcntl.lockf

STINNER Victor added the comment: Strange, Rietveld (the tool linked with the [review] button) doesn't show the change on the Modules/fcntlmodule.c file. By the way, I suggest to not include the Modules/clinic/fcntlmodule.c.h change in the patch. -- title: Please add F_OFD_SETLK, etc

[issue22367] Please add F_OFD_SETLK, etc support to fcntl.lockf

STINNER Victor added the comment: > This implements the open_file_descriptor argument and fixes a bug with > converting to int when off_t is 64-bit but long is 32-bit. Please extract the fix into a different patch. -- ___ Python tracker

[issue26470] Make OpenSSL module compatible with OpenSSL 1.1.0

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___

[issue26493] Bad formatting in WinError 193 when using subprocess.check_call

STINNER Victor added the comment: See also issue #25585: "DLL load failed: %1 is not a valid Win32 application" message of ImportError exception. Hum, so maybe a function is better, since ImportError doesn't inherit from OSError. -- ___ Python

[issue25585] Bad path leads to: ImportError: DLL load failed: %1 is not a valid Win32 application.

STINNER Victor added the comment: See also issue #26493. -- ___ Python tracker ___ ___ Python-bugs-list

[issue26493] Bad formatting in WinError 193 when using subprocess.check_call

STINNER Victor added the comment: > A new issue should be raised to fix the FormatMessage calls in the standard > library that mistakenly leave out FORMAT_MESSAGE_IGNORE_INSERTS. Do you suggest to modify OSError constructor to modify the call to FormatMessageW(): don't pass the

[issue26415] Fragmentation of the heap memory in the Python parser

Serhiy Storchaka added the comment: On my computer peak memory usage in non-debug build is about 450 MB. Peak memory usage in debug build is about 730 MB. I'm not sure this is due to memory fragmentation. -- ___ Python tracker

[issue26494] Double deallocation on iterator exhausting

Serhiy Storchaka added the comment: Fixed test for OrderedDict. Tests for list and tuple are moved up to seq_tests.py. -- Added file: http://bugs.python.org/file42092/free_after_iterating_3.patch ___ Python tracker

[issue26493] Bad formatting in WinError 193 when using subprocess.check_call

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___

[issue26415] Fragmentation of the heap memory in the Python parser

STINNER Victor added the comment: libapr library of Apache is designed to group all memory allocations required to handle an HTTP request. It is possible to release *all* memory allocations of the request at once. It looks like the the "pool" object: *

[issue26415] Fragmentation of the heap memory in the Python parser

STINNER Victor added the comment: My misc notes about memory fragmentation: https://haypo-notes.readthedocs.org/heap_fragmentation.html -- ___ Python tracker

[issue26415] Fragmentation of the heap memory in the Python parser

Changes by STINNER Victor : -- title: Out of memory, trying to parse a 35MB dict -> Fragmentation of the heap memory in the Python parser ___ Python tracker

[issue26415] Out of memory, trying to parse a 35MB dict

STINNER Victor added the comment: > So, apparently, it's not the nodes themselves taking up a disproportionate > amount of memory -- it's the heap getting so badly fragmented that 89% of its > memory allocation is wasted. Yeah, the Python parser+compiler badly uses the memory allocator. See

[issue26492] Exhausted array iterator should left exhausted

Serhiy Storchaka added the comment: TODO: After resolving issue26494 add similar test for array. -- ___ Python tracker ___

[issue26494] Double deallocation on iterator exhausting

Serhiy Storchaka added the comment: TODO: After resolving issue26492 add the test for array. -- ___ Python tracker ___

[issue26492] Exhausted array iterator should left exhausted

Serhiy Storchaka added the comment: Thanks Victor. Answered you comments. -- ___ Python tracker ___ ___

[issue26508] Infinite crash leading to DoS

STINNER Victor added the comment: > "construct and print a self-referencing tuple" I don't understand the use case here. In pure Python, you cannot build a self-referecing tuple!? Yeah, using the C API or by modifying bytes directly in the memory, you can do that. But if you start to use the

[issue26509] spurious ConnectionAbortedError logged on Windows

STINNER Victor added the comment: Attached patch fixes the issue. -- keywords: +patch Added file: http://bugs.python.org/file42090/fatal_error_ignore.patch ___ Python tracker

[issue26492] Exhausted array iterator should left exhausted

STINNER Victor added the comment: I reviewed exhausted_array_iterator2.patch. -- nosy: +haypo ___ Python tracker ___

[issue26492] Exhausted array iterator should left exhausted

Serhiy Storchaka added the comment: Thanks for suggestion Benjamin. seq_tests.py provides common tests for list, tuple, UserList and deque. This test doesn't work for tuple, since it is not mutable. It doesn't work for deque, since it can't be iterated after changing size. Common test for

[issue26486] Backport some tests to 2.7

Serhiy Storchaka added the comment: Thanks Martin. This test just doesn't work in 2.7 on all platforms. -- status: open -> closed ___ Python tracker ___

[issue26486] Backport some tests to 2.7

Roundup Robot added the comment: New changeset ff2368d5c1d3 by Serhiy Storchaka in branch '2.7': Issue #26486: Removed pickle test that doesn't work in 2.7 on 64-bit platform. https://hg.python.org/cpython/rev/ff2368d5c1d3 -- ___ Python tracker

[issue26501] bytes splitlines() method returns strings without decoding

Paul Moore added the comment: Sigh. I had installed Python 2.7 at some point, and py.exe picked it up by default :-( Isn't it about time that py.exe defaulted to the latest version installed, not the latest version of Python 2? -- ___ Python

[issue26415] Out of memory, trying to parse a 35MB dict

A. Skrobov added the comment: OK, I've now looked into it with a fresh build of 3.6 trunk on Linux x64. Peak memory usage is about 3KB per node: $ /usr/bin/time -v ./python -c 'import ast; ast.parse("0,"*100, mode="eval")' Command being timed: "./python -c import ast;

[issue26498] _io.so flat namespace

Larry added the comment: Ned, thank you for your suggestions. Just so you know, my HD recently crashed so I rebuilt the system with a new SSD. I was previously running 2.7.9 so I installed 2.7.9 to minimize any potential conflicts with my code base. All was well. Now it was time to rev

[issue26039] More flexibility in zipfile interface

Serhiy Storchaka added the comment: Yes, using the lock in write() or writestr() is equally compatible. -- ___ Python tracker ___