[issue23551] IDLE to provide menu link to PIP gui.

Eric Khoo Jiun Hooi added the comment: One more thing, window should be able to install package with pip. So, why the need of http://www.lfd.uci.edu/~gohlke/pythonlibs/ ? -- Added file: http://bugs.python.org/file42284/Design reference from pycharm.png _

[issue23551] IDLE to provide menu link to PIP gui.

Eric Khoo Jiun Hooi added the comment: Terry, now I have done two more mockup for the installed package tab which is referenced from your suggestion and belopolsky's suggestion. Which you do you prefer? About the http://www.lfd.uci.edu/~gohlke/pythonlibs/ repo that you suggested to be added

[issue26076] redundant checks in tok_get in Parser\tokenizer.c

Roundup Robot added the comment: New changeset f0acce8022d1 by Benjamin Peterson in branch 'default': remove duplicated check for fractions and complex numbers (closes #26076) https://hg.python.org/cpython/rev/f0acce8022d1 -- nosy: +python-dev resolution: -> fixed stage: patch review ->

[issue26638] Avoid warnings about missing CLI options when building documentation

New submission from Martin Panter: Defeat many warnings and related fixes building documentation * Mask various CLI options with exclamation marks (!) * Correct link to CLI section in zipapp * Make CLI section label in timeit less ambiguous The following warnings from unittest remain. Ideally t

[issue8557] subprocess PATH semantics and portability

Eryk Sun added the comment: As is documented for CreateProcess [1], the search path always includes the following directories: * The directory from which the application loaded. * The current directory for the parent process. * The Windows system directory. Use the GetSystemDi

[issue6953] readline documentation needs work

Martin Panter added the comment: Here is a modified patch. Does the new wording for clear_history() clarify things for you Berker? In theory that function could be included or omitted for both the Gnu Readline and Editline cases. -- Added file: http://bugs.python.org/file42281/readline

[issue26565] [ctypes] Add value attribute to non basic pointers.

Eryk Sun added the comment: The `value` of a c_char_p or c_wchar_p pointer is a Python bytes or str object. Since `value` won't consistently be the address value, it may be better to introduce a read-only `as_void` attribute that can be implemented consistently for all pointer types (including

[issue26628] Undefined behavior calling C functions with ctypes.Union arguments

Eryk Sun added the comment: > I would strongly argue to generally prohibit this > with an exception I agree. A warning in the tutorial isn't sufficient. ctypes should raise an error when setting a union or bitfield struct type in argtypes or when passing one by value. Here's some background

[issue26632] __all__ decorator

Eryk Sun added the comment: > work off its __name__ and __module__ Why is __module__ required? It seems to me this should only operate on the current module. I added a prototype to Python/bltinmodule.c that gets or creates the __all__ list from the current globals (i.e. PyEval_GetGlobals). I

[issue23551] IDLE to provide menu link to PIP gui.

Terry J. Reedy added the comment: As I said on core-mentorship list, I decided that we should use Raymond's initial list for the feature list. If anyone has any elaborations or additions, now is the time to post them. -- ___ Python tracker

[issue23551] IDLE to provide menu link to PIP gui.

Terry J. Reedy added the comment: Upendra and Eric: get_list_data() should first parse the string into a list of lines with .splitlines. At some point, I think the scrolled list should become a scrolled ttk.Treeview, which can have multiple columns. Then get_line_data should parse each line

[issue26620] Fix ResourceWarning warnings in test_urllib2_localnet

Martin Panter added the comment: This handling of KeyboardInterrupt seems like a bug with unittest IMO. But personally I don’t spend too much thought or code handling KeyboardInterrupt in tests, for similar reasons to not doing special handling of test failures in Issue 26612. -- ___

[issue26076] redundant checks in tok_get in Parser\tokenizer.c

Martin Panter added the comment: The change looks pretty good to me. I guess some test cases could be added to Lib/test/test_grammar.py, unless there is somewhere else that already tests this sort of stuff. -- nosy: +martin.panter ___ Python tracker

[issue25654] test_multiprocessing_spawn ResourceWarning with -Werror

STINNER Victor added the comment: Oh, with fixes for issues #21925 and #26637, test_multiprocessing_spawn started to fail: http://buildbot.python.org/all/builders/AMD64%20Debian%20root%203.5/builds/727/steps/test/logs/stdio ==

[issue26632] __all__ decorator

Barry A. Warsaw added the comment: On Mar 25, 2016, at 12:14 AM, Ethan Furman wrote: >public = Public(globals()) > >@public >def baz(a, b): >#blah blah > >public('CONST1', 2) I'm not crazy about that, plus I rather don't like the implicit binding of the name. I suppose we should just drop

[issue26632] __all__ decorator

Ethan Furman added the comment: Not a fan. :/ How about getting your own copy of the public decorator initialized with the globals you pass in? class Public: def __init__(self, module): """ module should be the globals() dict from the calling module """ sel

[issue25951] SSLSocket.sendall() does not return None on success like socket.sendall()

Martin Panter added the comment: Agreed that the documentation and implementation should match. But this seems like a rather low-priority bug. What use case relies on the return value being None? If there is no immediate need for this change, it might be safer to just make it in 3.6, to minim

[issue26637] importlib: better error message when import fail during Python shutdown

Roundup Robot added the comment: New changeset 14c56f697a85 by Victor Stinner in branch 'default': Fix bug in __import__ during Python shutdown https://hg.python.org/cpython/rev/14c56f697a85 -- nosy: +python-dev ___ Python tracker

[issue26637] importlib: better error message when import fail during Python shutdown

Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue21925] ResourceWarning sometimes doesn't display

STINNER Victor added the comment: I fixed warnings.formatwarning(). I don't expect the code to be perfect (Python shutdown process is complex and fragile), but the fix is quite simple and it's enough to fix the bug described in the initial message. I even added an unit test for it. I didn't t

[issue21925] ResourceWarning sometimes doesn't display

Roundup Robot added the comment: New changeset 1de90a7065ba by Victor Stinner in branch '3.5': warnings.formatwarning(): catch exceptions https://hg.python.org/cpython/rev/1de90a7065ba New changeset 36be356f6253 by Victor Stinner in branch 'default': Merge 3.5 https://hg.python.org/cpython/rev/3

[issue21925] ResourceWarning sometimes doesn't display

STINNER Victor added the comment: It looks like logging a warning at Python exit always works on Python 2.7: --- import _warnings class Bla: def __del__(self, w=_warnings): w.warn_explicit('message', DeprecationWarning, 'x.py', 5) bla = Bla() --- It looks like it uses the Python im

[issue26632] __all__ decorator

Barry A. Warsaw added the comment: On Mar 24, 2016, at 10:31 PM, Martin Panter wrote: >FWIW I already invented this :) as written in Issue 22247. Although I think I >only used it once or twice in my own personal librarie(s). So it’s a nice >sign that we came up with the same @public name and usa

[issue8557] subprocess PATH semantics and portability

Anthony Sottile added the comment: Here's the workaround I'm opting for: if sys.platform =='win32': distutils.spawn.find_executable(cmd[0]) + cmd[1:] -- nosy: +Anthony Sottile ___ Python tracker ___

[issue26624] Windows hangs in call to CRT setlocale()

Jeremy Kloth added the comment: The lastest set of updates were installed on 1/28. Visual Studio does have Update 1. I'm doing another round of updates now, although nothing related to VC 2015 or Visual Studio, however. -- ___ Python tracker

[issue26632] __all__ decorator

Martin Panter added the comment: FWIW I already invented this :) as written in Issue 22247. Although I think I only used it once or twice in my own personal librarie(s). So it’s a nice sign that we came up with the same @public name and usage. I’m not a fan of hacks depending on the calling fr

[issue26637] importlib: better error message when import fail during Python shutdown

STINNER Victor added the comment: > It's technically a change in semantics as it shifts what exception is raised, > so I wouldn't backport it. Ok, I'm fine with only changing Python 3.6. -- ___ Python tracker ___

[issue26637] importlib: better error message when import fail during Python shutdown

Brett Cannon added the comment: It's technically a change in semantics as it shifts what exception is raised, so I wouldn't backport it. -- ___ Python tracker ___ __

[issue23551] IDLE to provide menu link to PIP gui.

Alexander Belopolsky added the comment: You may want to take a look a PyCharm's preferences dialog for inspiration. I am attaching a screenshot. I like the way they show installed and the latest available versions. -- nosy: +belopolsky Added file: http://bugs.python.org/file42280/PyC

[issue26637] importlib: better error message when import fail during Python shutdown

STINNER Victor added the comment: Oh. And is it ok to apply this change to Python 2.7 and 3.5? -- ___ Python tracker ___ ___ Python-bu

[issue26637] importlib: better error message when import fail during Python shutdown

STINNER Victor added the comment: I will reply to my own question: in fact, ImportError is more convenient. The "try/except ImportError" pattern is common, in some cases, it's acceptable to skip a whole module. For a direct example on import during Python shutdown, see the issue #21925: "Resou

[issue22401] argparse: 'resolve' conflict handler damages the actions of the parent parser

paul j3 added the comment: Neither 'parents' or 'resolve' are documented in any detail. Most of what I know comes from reading the code. 'parents' are, I think, most useful when importing a parser from some other module. It lets you add arguments to your own parser without digging into the

[issue23551] IDLE to provide menu link to PIP gui.

Terry J. Reedy added the comment: Answering Eric: 'change default repository' would set a value that pip_gui would pass to subsequent install requests with the --index-url option. On Windows, http://www.lfd.uci.edu/~gohlke/pythonlibs/ is essential and should be pre-listed as an option to sel

[issue22898] segfault during shutdown attempting to log ResourceWarning

Xavier de Gaye added the comment: When tested with runtimerror_singleton_3.py (see msg 231933 above), the latest Python 3.6.0a0 (default:3eec7bcc14a4, Mar 24 2016, 20:16:19) still crashes: $ python runtimerror_singleton_3.py Importing mymodule. Traceback (most recent call last): File "runtime

[issue25609] Add a ContextManager ABC and type

Brett Cannon added the comment: Here is an updated patch implementing Nick's suggestions and is ready for 3.6 sans a What's New entry. As for Python 3.5, I think I will copy __subclasshook__() from contextlib.AbstractContextManager and put it in typing.ContextManager so the isinstance() check

[issue25951] SSLSocket.sendall() does not return None on success like socket.sendall()

Aviv Palivoda added the comment: Changed SSLSocket.sendall() to return None. Also added a check of the return value of the SSLSocket.send(), SSLSocket.sendall() in the tests. -- keywords: +patch nosy: +palaviv Added file: http://bugs.python.org/file42278/25951.patch ___

[issue23551] IDLE to provide menu link to PIP gui.

Upendra Kumar added the comment: Here, I have one doubt regarding the get_data function that should the get_data function be a common function for different features for example : def _get_data(self, func_option): """ A separate function for extracting data from the runpip() fu

[issue26637] importlib: better error message when import fail during Python shutdown

Brett Cannon added the comment: Either ImportError or TypeError. ImportError makes sense since this is directly related to import semantics while TypeError makes sense as we are saying None specifically is not allowed. -- ___ Python tracker

[issue26637] importlib: better error message when import fail during Python shutdown

STINNER Victor added the comment: Updated patch with a dot in the comment :-) Is ImportError the best exception in this case? -- Added file: http://bugs.python.org/file42277/importlib_shutdown-2.patch ___ Python tracker

[issue22401] argparse: 'resolve' conflict handler damages the actions of the parent parser

Jared Deckard added the comment: That is correct. (Thank you for whipping up a repro script from my description). I appreciate the work around, but it is nearly as verbose as manually duplicating the parameters on the child and I would have to type up a large comment block to educate future de

[issue22401] argparse: 'resolve' conflict handler damages the actions of the parent parser

Jared Deckard added the comment: Adding back components and version data I unintentionally removed in http://bugs.python.org/msg262314 -- components: +Documentation, Tests versions: +Python 3.5 ___ Python tracker

[issue26624] Windows hangs in call to CRT setlocale()

Steve Dower added the comment: It's been fixed, just figuring out when the update will be available, or how to get it if it already is. Jeremy - how up to date is your build machine? It's likely this fix will come through Windows Update for most users, but since you're running debug builds I

[issue23551] IDLE to provide menu link to PIP gui.

Eric Khoo Jiun Hooi added the comment: The implementation of features that already provided by command line interface should not be a problem. However, I do not understand how the search for package and change default repository function. Is it going to search the package from other website? T

[issue26624] Windows hangs in call to CRT setlocale()

Steve Dower added the comment: If the comment is in the sources, presumably it's also handled correctly. But it does seem like there's potential here for simultaneous thread creation and first-time calls into OS locale functions to cause a deadlock. I'll email the CRT team and see what they kn

[issue10305] Cleanup up ResourceWarnings in multiprocessing

STINNER Victor added the comment: Oh, I found the issue #25654 which contains more information and even patches. -- superseder: -> test_multiprocessing_spawn ResourceWarning with -Werror ___ Python tracker ___

[issue19829] _pyio.BufferedReader and _pyio.TextIOWrapper destructor don't emit ResourceWarning if the file is not closed

STINNER Victor added the comment: > I don't like _dealloc_warn() at all. It looks as a dirty hack and doesn't > work with custom file-like objects. I tried to support emitting a ResourceWarning when the close() method is overriden in a subclass, but then I saw that io doesn't support this use

[issue26624] Windows hangs in call to CRT setlocale()

STINNER Victor added the comment: > I'll email the CRT team and see what they know about this. Thanks. It helps to have a Microsoft employee working on CPython :-) -- ___ Python tracker ___

[issue26636] SystemError while running tests: extra exception raised

STINNER Victor added the comment: > Probably same issue as in Django, but in other Python module. Do you understand that bug very likely comes from your code? Please review the code of the Crypto module (especially number._fastmath.getStrongPrime) to ensure that it doesn't return a result with

[issue21925] ResourceWarning sometimes doesn't display

STINNER Victor added the comment: See also the issue #26637: "importlib: better error message when import fail during Python shutdown". -- ___ Python tracker ___ ___

[issue25654] test_multiprocessing_spawn ResourceWarning with -Werror

STINNER Victor added the comment: I marked the issue #10305 as a duplicate of this issue. -- ___ Python tracker ___ ___ Python-bugs-li

[issue10305] Cleanup up ResourceWarnings in multiprocessing

STINNER Victor added the comment: Sorry but without any information about the module or function which emits such ResourceWarning, I prefer to close the issue. Anyway, with Python 3.6, it became trivial to identify the root cause of ResourceWarning warinings: https://docs.python.org/dev/whatsn

[issue22898] segfault during shutdown attempting to log ResourceWarning

STINNER Victor added the comment: I tried the following script on Python 3.5 and Python 3.6 and I failed to reproduce the bug: --- import sys, traceback class MyException(Exception): def __init__(self, *args): 1/0 def gen(): f = open(__file__, mode='rb', buffering=0) yield

[issue25654] test_multiprocessing_spawn ResourceWarning with -Werror

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue21925] ResourceWarning sometimes doesn't display

STINNER Victor added the comment: It looks like the warnings is logged when the C implemention is used. When the Python implementation is used, "import linecache" or "linecache.getline()" fail, and so the warnings is skipped. Attached patch makes the Python implementation safer when Python is

[issue6721] Locks in the standard library should be sanitized on fork

Changes by A. Jesse Jiryu Davis : -- nosy: +emptysquare ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue26637] importlib: better error message when import fail during Python shutdown

New submission from STINNER Victor: Example of script.py: - class Bla: def __del__(self): try: import except Exception as exc: print("import error: [%s] %r" % (type(exc), exc)) bla = Bla() - Running

[issue19829] _pyio.BufferedReader and _pyio.TextIOWrapper destructor don't emit ResourceWarning if the file is not closed

Serhiy Storchaka added the comment: I don't like _dealloc_warn() at all. It looks as a dirty hack and doesn't work with custom file-like objects. I think we should use one of Martin's option. If there are any issues with garbage collecting, we should fix the garbage collector. -- vers

[issue19829] _pyio.BufferedReader and _pyio.TextIOWrapper destructor don't emit ResourceWarning if the file is not closed

STINNER Victor added the comment: Try attached res_warn.py script to test manually all ResourceWarning warnings. Ouput of python3.6 -Wd res_warn.py: -- text <_pyio.TextIOWrapper name='/etc/issue' mode='r' encoding='UTF-8'> res_warn.py:9: ResourceWarning: unclosed file <_p

[issue19829] _pyio.BufferedReader and _pyio.TextIOWrapper destructor don't emit ResourceWarning if the file is not closed

STINNER Victor added the comment: del-detach.patch: I don't understand the change in _pyio.py. I think that the change on socket.py is no more need since the change 46329eec5515 (issue #26590). del-flush.patch: * change on IOBase.__del__() change the behaviour compared to the io module, I don

[issue26636] SystemError while running tests: extra exception raised

Changes by Serhiy Storchaka : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue19829] _pyio.BufferedReader and _pyio.TextIOWrapper destructor don't emit ResourceWarning if the file is not closed

STINNER Victor added the comment: Oh, the io module is more complex than what I expected :-) test_io fails with pyio_res_warn-2.patch. test_io now pass with pyio_res_warn-3.patch. I fixed FileIO.close() to always call super().close(), and set self._fd to -1 even if logging the ResourceWarning

[issue26636] SystemError while running tests: extra exception raised

New submission from Denis: Looks like related to Issue23571 Probably same issue as in Django, but in other Python module. While compiling python-module-crypto: = ERROR: test_getStrongPrime_randfunc_bogus (Crypto.SelfTest.Util

[issue26632] __all__ decorator

Barry A. Warsaw added the comment: On Mar 24, 2016, at 02:48 AM, Ethan Furman wrote: >On the down side, you know somebody is going to @public a class' method -- >how do we check for that? Do we need to? Consenting adults and __all__. OT1H, you do get an AttributeError if you from-import-* and

[issue19829] _pyio.BufferedReader and _pyio.TextIOWrapper destructor don't emit ResourceWarning if the file is not closed

STINNER Victor added the comment: (oops, there was a typo in my first patch) -- Added file: http://bugs.python.org/file42272/pyio_res_warn-2.patch ___ Python tracker ___

[issue19829] _pyio.BufferedReader and _pyio.TextIOWrapper destructor don't emit ResourceWarning if the file is not closed

Changes by STINNER Victor : Removed file: http://bugs.python.org/file42271/pyio_res_warn.patch ___ Python tracker ___ ___ Python-bugs-list mai

[issue19829] _pyio.BufferedReader and _pyio.TextIOWrapper destructor don't emit ResourceWarning if the file is not closed

STINNER Victor added the comment: Attached patch modifies _pyio to mimick better the reference io module: * Add IOBase._finalizing * IOBase.__del__() sets _finalizing to True * Add FileIO._dealloc_warn() * Remove FileIO.__del__() * FileIO.close(), _BufferedIOMixin.close() and TextIOWrapper.close

[issue23551] IDLE to provide menu link to PIP gui.

Terry J. Reedy added the comment: After running the code, I want to stick with details in the same window. The tab should be a Frame with a PanedWindow on top with list frame on left and detail frame on right. The buttons would be under the paned window. Run Lib/turtledemo/__main__.py eithe

[issue26628] Undefined behavior calling C functions with ctypes.Union arguments

Thomas added the comment: So after some more pondering about the issue I read the documentation again: > Warning ctypes does not support passing unions or structures with bit-fields > to functions by value. Previously I always read this as 'does not support passing unions with bit-fields'...

[issue23551] IDLE to provide menu link to PIP gui.

Changes by Steve Dower : -- nosy: -steve.dower ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue26620] Fix ResourceWarning warnings in test_urllib2_localnet

STINNER Victor added the comment: Martin wrote: > This patch looks okay to me. I left one review suggestion. Thanks for the review, I changed this code. While testing one more time my patch with CTRL+c, I noticed that sometimes the servers are not stopped properly and os.environ is not restore

[issue26620] Fix ResourceWarning warnings in test_urllib2_localnet

Roundup Robot added the comment: New changeset 54d7e9919876 by Victor Stinner in branch 'default': Closes #26620: Fix ResourceWarning in test_urllib2_localnet https://hg.python.org/cpython/rev/54d7e9919876 -- nosy: +python-dev resolution: -> fixed stage: -> resolved status: open -> clo

[issue26635] Python default date does not match Unix time

STINNER Victor added the comment: The year 1900 is a delibrate choice, it's even documented: https://docs.python.org/dev/library/datetime.html#strftime-and-strptime-behavior "For time objects, the format codes for year, month, and day should not be used, as time objects have no such values. If

[issue26614] False/0 and True/1 collision when used as dict keys?

STINNER Victor added the comment: Many values have the same hash value, it's not an issue. The hash is only a best effort function to reduce hash collision, but hash collision is well handled in the dict type (as explained in other messages). >>> hash(1) == hash(1.0) == hash(1.0+0j) == 1 True

[issue26635] Python default date does not match Unix time

New submission from Itay Grudev: When parsing a time only string like: ``` datetime.datetime.strptime('13:48:25', '%H:%M:%S') ``` This produces: ``` datetime.datetime(1900, 1, 1, 13, 48, 25) ``` Not that the year is `1900` which just doesn't make sense. This will produce `-1` when you attemp

[issue26614] False/0 and True/1 collision when used as dict keys?

Mark Dickinson added the comment: "Apparently True and 1 hash to the same item and False and 0 hash to the same item" Just to clear up a possible misconception here, the key point here is not that they hash to the same integer, but that they're *equal*: >>> True == 1 True >>> False == 0 True

[issue23551] IDLE to provide menu link to PIP gui.

Eric Khoo Jiun Hooi added the comment: I also change some of the design like instead of showing the installed package information beside the list, I think that it will be better to show the package information on a new pop up window. You can try to double click the list of search tab and insta

[issue23551] IDLE to provide menu link to PIP gui.

Changes by Eric Khoo Jiun Hooi : Added file: http://bugs.python.org/file42270/GSoC2016Proposal(1).pdf ___ Python tracker ___ ___ Python-bugs-l

[issue23551] IDLE to provide menu link to PIP gui.

Eric Khoo Jiun Hooi added the comment: Thank @Terry for your suggestion. I have been working on this few hour to fix and improve the code. I have also add some new feature into the application. Hope you can help me to review it again. Thank. About the proposal, please help me to review it if y

[issue25911] Regression: os.walk now using os.scandir() breaks bytes filenames on windows

STINNER Victor added the comment: I faile to reproduce the bug by running test_os alone on Windows 8. I wrote a script to try to isolate a sequential list of tests which reproduce the bug on Windows, but I failed to find such list after 2 hours: https://bitbucket.org/haypo/misc/src/3e2e6138798c

[issue25911] Regression: os.walk now using os.scandir() breaks bytes filenames on windows

Roundup Robot added the comment: New changeset eb91d0387d59 by Victor Stinner in branch 'default': Enhance os._DummyDirEntry https://hg.python.org/cpython/rev/eb91d0387d59 -- ___ Python tracker

[issue26076] redundant checks in tok_get in Parser\tokenizer.c

SilentGhost added the comment: Could any one of the core developers have a look? Seems like a rather straightforward change. -- ___ Python tracker ___ __

[issue26633] multiprocessing behavior combining daemon with non-daemon children inconsistent with threading

Changes by SilentGhost : -- nosy: +jnoller, sbt ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue25911] Regression: os.walk now using os.scandir() breaks bytes filenames on windows

Roundup Robot added the comment: New changeset d54ee39b061f by Victor Stinner in branch 'default': Fix DeprecationWarning on Windows https://hg.python.org/cpython/rev/d54ee39b061f -- ___ Python tracker