[issue20116] urlparse.parse_qs should take argument for query separator

2016-04-19 Thread Senthil Kumaran
Senthil Kumaran added the comment: Luiz, The original question was about introducing a parameter to override query string separate ';'. If we do with enable or disable, then we should provide another option for query string separator. The OP provided one example of query string which had &

[issue26806] IDLE not displaying RecursionError tracebacks

2016-04-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Experimentally found that minimal recursion level for 2.7 is 29, for 3.2-3.3 is 24, and for 3.4-3.6 is 25. 3.2 produces following output and restart the shell: Unhandled server exception! Thread: SockThread Client

[issue26804] Prioritize lowercase proxy variables in urllib.request

2016-04-19 Thread Senthil Kumaran
Senthil Kumaran added the comment: Hi Hans-Peter, I agree with Martin's comments and suggestion. If I understand the suggestion correctly, the only change will be a documentation change. Isn't it? Because getproxies_environment() in it's current form already fetches the lower_case proxy

[issue26806] IDLE not displaying RecursionError tracebacks

2016-04-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: In 3.6 just setting the recursion level to 20 produces following output on terminal: Unhandled server exception! Thread: SockThread Client Address: ('127.0.0.1', 41515) Unhandled exception in thread started by and

[issue22625] When cross-compiling, don’t try to execute binaries

2016-04-19 Thread Martin Panter
Martin Panter added the comment: In Issue 22359, Xavier has posted a patch that looks like a reasonable solution to both cross compiling and allowing parallel make. -- resolution: -> duplicate status: open -> closed superseder: -> Remove incorrect uses of recursive make

[issue22359] Remove incorrect uses of recursive make

2016-04-19 Thread Martin Panter
Changes by Martin Panter : -- dependencies: -When cross-compiling, don’t try to execute binaries status: languishing -> open ___ Python tracker

[issue26804] Prioritize lowercase proxy variables in urllib.request

2016-04-19 Thread Martin Panter
Martin Panter added the comment: I think this should be applied as a bug fix to 2.7 and 3.5 as well. What do you think? Lowercase is the normal way to use these variables. I left some comments on the code review. A similar bug seems to exist for the “no_proxy” variable. Also, it would be

[issue22558] Missing doc links to source code

2016-04-19 Thread Yoni Lavi
Yoni Lavi added the comment: I went over all the library rst files and added a link to the source for each of the modules. Also, I standardized the structure of the headers in all of the files to be in the following order: """ .. module .. moduleauthor .. sectionauthor .. versionadded

[issue24291] Many servers (wsgiref, http.server, etc) can truncate large output blobs

2016-04-19 Thread Martin Panter
Martin Panter added the comment: Widening the scope of the title to attract reviewers :) -- title: wsgiref.handlers.SimpleHandler truncates large output blobs -> Many servers (wsgiref, http.server, etc) can truncate large output blobs ___ Python

[issue26769] Python 2.7: make private file descriptors non inheritable

2016-04-19 Thread Martin Panter
Martin Panter added the comment: The patch looks reasonable as far as I understand it. I don’t know what the consequences of adding new PyAPI_FUNC() symbols to 2.7 is, or changing the Windows build files, so can’t really comment on those aspects though. I left some questions about porting

[issue26058] PEP 509: Add ma_version to PyDictObject

2016-04-19 Thread STINNER Victor
STINNER Victor added the comment: Results of the CPython benchmark suite on dict_version-8.patch. IMHO regex_v8 can be ignored, this benchmark is unstable (issue #26275). Original python: ../pep509/python 3.6.0a0 (default:3a9b47b062b9, Apr 19 2016, 16:23:15) [GCC 5.3.1 20151207 (Red Hat

[issue26793] uuid causing thread issues when forking using os.fork py3.4+

2016-04-19 Thread Chase Sterling
Chase Sterling added the comment: @STINNER Victor Your example is starting a thread before calling fork, the other examples just init a threading.Thread class before the fork (I imagine the OS thread is not created at that point.) Are you saying that just instantiating a threading.Thread

[issue26806] IDLE not displaying RecursionError tracebacks

2016-04-19 Thread Terry J. Reedy
New submission from Terry J. Reedy: Test program: import sys sys.setrecursionlimit(20) def f(): return f() f() F:\Python\mypy>python tem.py Traceback (most recent call last): File "tem.py", line 4, in f() File "tem.py", line 3, in f def f(): return f() ... RecursionError: maximum

[issue26802] Avoid copy in call_function_var when no extra stack args are passed

2016-04-19 Thread STINNER Victor
STINNER Victor added the comment: > New changeset 6535481d610e by Victor Stinner in branch 'default': > Optimize func(*tuple) function call > https://hg.python.org/cpython/rev/6535481d610e Oops. Mercurial is too hard for me /o\ I didn't want to push this change, since Serhiy already pushed the

[issue26801] Fix shutil.get_terminal_size() to catch AttributeError

2016-04-19 Thread Martin Panter
Martin Panter added the comment: I doubt it is worth spending much effort supporting sys.__stdout__ being overwritten with StringIO or deleted. That seems an abuse of the “sys” module. Idle doesn’t even seem to alter this attribute. But if you call stdout.close() or detach(), I think that is

[issue26802] Avoid copy in call_function_var when no extra stack args are passed

2016-04-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 6535481d610e by Victor Stinner in branch 'default': Optimize func(*tuple) function call https://hg.python.org/cpython/rev/6535481d610e -- ___ Python tracker

[issue26470] Make OpenSSL module compatible with OpenSSL 1.1.0

2016-04-19 Thread Christian Heimes
Christian Heimes added the comment: PS: The patch depends on https://github.com/openssl/openssl/pull/979 -- ___ Python tracker ___

[issue26470] Make OpenSSL module compatible with OpenSSL 1.1.0

2016-04-19 Thread Christian Heimes
Changes by Christian Heimes : Removed file: http://bugs.python.org/file42184/0001-Port-Python-s-SSL-module-to-OpenSSL-1.1.0-WIP.patch ___ Python tracker

[issue26470] Make OpenSSL module compatible with OpenSSL 1.1.0

2016-04-19 Thread Christian Heimes
Christian Heimes added the comment: The patch makes Python compatible with OpenSSL 1.1.0-pre6-dev from git. The ssl and hashlib module are also compatible with OpenSSL 0.9.8zh, 1.0.1s, 1.0.2g as well as LibreSSL 2.3.3. -- Added file:

[issue26805] Refer to types.SimpleNamespace in namedtuple documentation

2016-04-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3115b6ce1006 by Paul Moore in branch '3.5': Mention types.SimpleNamespace in collections.namedtuple doc https://hg.python.org/cpython/rev/3115b6ce1006 -- ___ Python tracker

[issue26802] Avoid copy in call_function_var when no extra stack args are passed

2016-04-19 Thread Joe Jevnik
Joe Jevnik added the comment: CALL_FUNCTION doesn't use extended arg; I don't see what we get by adding some opcode to convert the sequence into a tuple. We also don't want to box up the stack arguments into a tuple because when we do a CALL_FUNCTION to a python function we just copy the

[issue26802] Avoid copy in call_function_var when no extra stack args are passed

2016-04-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > Do you have a reference to the more efficient implementation of CALL_FUNCTION? Actually it was about MAKE_FUNCTION. But I think the same is applicable to CALL_FUNCTION. http://comments.gmane.org/gmane.comp.python.devel/157321 --

[issue23926] skipitem() in getargs.c still supports 'w' and 'w#', and shouldn't

2016-04-19 Thread STINNER Victor
STINNER Victor added the comment: I reviewed skipitems.patch. -- nosy: +haypo ___ Python tracker ___ ___

[issue26802] Avoid copy in call_function_var when no extra stack args are passed

2016-04-19 Thread STINNER Victor
STINNER Victor added the comment: > FYI, there is a proposition about constructing arguments tuple and dict in > bytecode instead of ceval.c. This will significantly simplify CALL_FUNCTION > (which will get just one optional tuple and one optional dict). Likely this > idea will be implemented

[issue26802] Avoid copy in call_function_var when no extra stack args are passed

2016-04-19 Thread STINNER Victor
STINNER Victor added the comment: > New changeset 15b20201cfa5 by Serhiy Storchaka in branch 'default': Oh. I was cooking a commit, you was faster than me :-) IMHO it's worth to make the optimization in Misc/NEWS, or maybe even in Whats new in Python 3.6. I prepared the text: Issue #26802:

[issue26801] Fix shutil.get_terminal_size() to catch AttributeError

2016-04-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is a patch that adds ValueError in the exceptions list and adds tests. -- resolution: fixed -> status: closed -> open Added file: http://bugs.python.org/file42525/get_terminal_size_valueerror.patch ___ Python

[issue26802] Avoid copy in call_function_var when no extra stack args are passed

2016-04-19 Thread STINNER Victor
STINNER Victor added the comment: Good news. On a microbenchmark, the patch makes func(*tuple) between 14% and 18% faster. See attached bench.py. I ran the benchmark on Linux with isolated CPUs to get reliable results. https://haypo-notes.readthedocs.org/microbenchmark.html $ ./python-orig

[issue26802] Avoid copy in call_function_var when no extra stack args are passed

2016-04-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: FYI, there is a proposition about constructing arguments tuple and dict in bytecode instead of ceval.c. This will significantly simplify CALL_FUNCTION (which will get just one optional tuple and one optional dict). Likely this idea will be implemented after

[issue26802] Avoid copy in call_function_var when no extra stack args are passed

2016-04-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 15b20201cfa5 by Serhiy Storchaka in branch 'default': Issue #26802: Optimized calling a function with *args only positional arguments. https://hg.python.org/cpython/rev/15b20201cfa5 -- nosy: +python-dev

[issue26805] Refer to types.SimpleNamespace in namedtuple documentation

2016-04-19 Thread Berker Peksag
Berker Peksag added the comment: Or if you don't want to use any hg extension: hg update 3.5 hg import --no-c http://bugs.python.org/file42520/collections.patch hg commit hg update default hg merge 3.5 hg revert -ar default hg resolve -am hg commit (Null merge (hg merge 3.5 and later) is step

[issue26801] Fix shutil.get_terminal_size() to catch AttributeError

2016-04-19 Thread STINNER Victor
Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue26801] Fix shutil.get_terminal_size() to catch AttributeError

2016-04-19 Thread STINNER Victor
STINNER Victor added the comment: Well, since Serhiy, Emmanuel and me agree that unit tests are overkill, I pushed the obivous and trivial fix. Thank you Emmanual for your contribution! I added your name to Misc/ACKS ;-) -- ___ Python tracker

[issue26801] Fix shutil.get_terminal_size() to catch AttributeError

2016-04-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset e3763b5964b6 by Victor Stinner in branch '3.5': Fix shutil.get_terminal_size() error handling https://hg.python.org/cpython/rev/e3763b5964b6 New changeset 75f40345d784 by Victor Stinner in branch 'default': Merge 3.5: issue #26801

[issue26801] Fix shutil.get_terminal_size() to catch AttributeError

2016-04-19 Thread Emanuel Barry
Emanuel Barry added the comment: To be fair, I don't think we actually need a unit test to check if `os.get_terminal_size` exists, as we catch any `AttributeError` at all. I'd want to keep the except clause there to properly handle `sys.__stdout__` being `None` (or simply absent). I also

[issue26801] Fix shutil.get_terminal_size() to catch AttributeError

2016-04-19 Thread STINNER Victor
STINNER Victor added the comment: > Honest, I don't think that we need such complex test for the case that isn't > occurred in wild. Right. I'm also fine if you test manually this corner case. The Lib/shutil.py change LGTM in get_term_size_with_test2.patch (I ignored the unit test).

[issue26802] Avoid copy in call_function_var when no extra stack args are passed

2016-04-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: call-function-var-3.patch LGTM. Thank you for your contribution Joe. -- assignee: -> serhiy.storchaka stage: patch review -> commit review ___ Python tracker

[issue26805] Refer to types.SimpleNamespace in namedtuple documentation

2016-04-19 Thread STINNER Victor
STINNER Victor added the comment: I don't know what "inactive" means in Mercurial. Python 3.5 is actively developed (maintained): https://docs.python.org/devguide/#status-of-python-branches > How should I do the commit into 3.5? Update to 3.5 (hg up 3.5), transplant your change (hg transplant

[issue26801] Fix shutil.get_terminal_size() to catch AttributeError

2016-04-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Honest, I don't think that we need such complex test for the case that isn't occurred in wild. If delete os.get_terminal_size, all TermsizeTests tests fail, so we will know if encounter a platform without os.get_terminal_size. Instead I suggest to add

[issue26805] Refer to types.SimpleNamespace in namedtuple documentation

2016-04-19 Thread Paul Moore
Paul Moore added the comment: Ah, thanks. I probably did the commit the wrong way round in that case, as I committed to tip. How should I do the commit into 3.5? (I'm also somewhat confused by the fact that hg describes the 3.5 branch as "inactive"...) --

[issue26801] Fix shutil.get_terminal_size() to catch AttributeError

2016-04-19 Thread STINNER Victor
STINNER Victor added the comment: > Hmm, if `sys.__stdout__` was deleted (or set to `None`), this would also > raise an `AttributeError` when calling `shutil.get_terminal_size`, so I think > that even if `os.get_terminal_size` is guaranteed to be always present (which > it's not, IIUC),

[issue14102] argparse: add ability to create a man page

2016-04-19 Thread Zbyszek Jędrzejewski-Szmek
Changes by Zbyszek Jędrzejewski-Szmek : -- nosy: +zbysz ___ Python tracker ___ ___

[issue26805] Refer to types.SimpleNamespace in namedtuple documentation

2016-04-19 Thread STINNER Victor
STINNER Victor added the comment: types.SimpleNamespace is also available on Python 3.5, you may also modify Python 3.5 doc. -- ___ Python tracker ___

[issue26799] gdb support fails with "Invalid cast."

2016-04-19 Thread STINNER Victor
STINNER Victor added the comment: > Turns out the type->length of the the globally initialized ptr types is > wrong: It is 4 instead of 8, causing the cast to fail. I suspect the > initialization is done before the executable is loaded and gdb is using some > default. Hum. I see two options:

[issue26805] Refer to types.SimpleNamespace in namedtuple documentation

2016-04-19 Thread Paul Moore
Changes by Paul Moore : -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker ___

[issue26801] Fix shutil.get_terminal_size() to catch AttributeError

2016-04-19 Thread Emanuel Barry
Changes by Emanuel Barry : Added file: http://bugs.python.org/file42523/get_term_size_with_test2.patch ___ Python tracker ___

[issue26805] Refer to types.SimpleNamespace in namedtuple documentation

2016-04-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset c3232d1d8ca0 by Paul Moore in branch 'default': Mention types.SimpleNamespace in collections.namedtuple doc https://hg.python.org/cpython/rev/c3232d1d8ca0 -- nosy: +python-dev ___ Python tracker

[issue26801] Fix shutil.get_terminal_size() to catch AttributeError

2016-04-19 Thread Emanuel Barry
Emanuel Barry added the comment: Hmm, if `sys.__stdout__` was deleted (or set to `None`), this would also raise an `AttributeError` when calling `shutil.get_terminal_size`, so I think that even if `os.get_terminal_size` is guaranteed to be always present (which it's not, IIUC), catching

[issue26801] Fix shutil.get_terminal_size() to catch AttributeError

2016-04-19 Thread Emanuel Barry
Emanuel Barry added the comment: On posix-based OSes, `os.get_terminal_size` might not exist ( https://hg.python.org/cpython/file/default/Modules/posixmodule.c#l12462 ), so this is needed. New patch file with tests included. -- Added file:

[issue26802] Avoid copy in call_function_var when no extra stack args are passed

2016-04-19 Thread Josh Rosenberg
Josh Rosenberg added the comment: BTW, for a realistic use case that would be sped up by this patch (possibly a lot), consider a recursive function that is continually doing a "virtual" pop of the first argument, and receiving the rest as varargs, which are then unpacked for the recursive

[issue1612012] builtin compile() doc needs PyCF_DONT_IMPLY_DEDENT

2016-04-19 Thread Berker Peksag
Berker Peksag added the comment: A similar request (issue 12207 - "Document ast.PyCF_ONLY_AST") was rejected in 2012. -- nosy: +berker.peksag resolution: -> rejected stage: -> resolved status: open -> closed ___ Python tracker

[issue4260] ctypes.xFUNCTYPE are decorators.

2016-04-19 Thread Berker Peksag
Changes by Berker Peksag : -- keywords: +easy nosy: +berker.peksag stage: -> needs patch versions: +Python 3.5, Python 3.6 -Python 3.0 ___ Python tracker

[issue26799] gdb support fails with "Invalid cast."

2016-04-19 Thread Thomas
Thomas added the comment: I have done a bit more digging, turns out it is actually no problem at all to debug python in gdb with gdb with python support (at least using a fixed python-gdb-py). Turns out the type->length of the the globally initialized ptr types is wrong: It is 4 instead of

[issue26802] Avoid copy in call_function_var when no extra stack args are passed

2016-04-19 Thread Joe Jevnik
Joe Jevnik added the comment: > It's possible that stararg is already an empty tuple. Is it worth to use it? PyTuple_New(0) should return the unit tuple in most cases: #if PyTuple_MAXSAVESIZE > 0 if (size == 0 && free_list[0]) { op = free_list[0]; Py_INCREF(op); #ifdef

[issue22558] Missing doc links to source code

2016-04-19 Thread Yoni Lavi
Changes by Yoni Lavi : -- nosy: +Yoni Lavi ___ Python tracker ___ ___ Python-bugs-list mailing

[issue26802] Avoid copy in call_function_var when no extra stack args are passed

2016-04-19 Thread STINNER Victor
STINNER Victor added the comment: FYI I ran the full test suite with the second attached patch and all tests pass. By the way, please add a suffix like -2, -3, etc. to your patches next time. It's easier to identify them if they have a different name ;-) --

[issue26799] gdb support fails with "Invalid cast."

2016-04-19 Thread STINNER Victor
STINNER Victor added the comment: I tried Python 3.6 with "./configure --with-pydebug --without-pymalloc --with-valgrind". The py-bt commands works as expect in gdb. Can you try to modify python-gdb.py to get a traceback of your Invalid cast error? > I am able to fix it with the following

[issue26801] Fix shutil.get_terminal_size() to catch AttributeError

2016-04-19 Thread STINNER Victor
STINNER Victor added the comment: > On all supported platforms (including such exotic as old AIX, QNX or Minix) > it should be defined. test_shutil always call shutil.get_terminal_size() and I didn't see any failure on the unit suite on our buildbots, even less common platforms like OpenBSD,

[issue26801] Fix shutil.get_terminal_size() to catch AttributeError

2016-04-19 Thread STINNER Victor
STINNER Victor added the comment: get_terminal_size.diff LGTM. Would you like to try to write an unit test? Maybe using unittest.mock.patch? -- nosy: +haypo ___ Python tracker

[issue26516] Add PYTHONMALLOC env var and add support for malloc debug hooks in release mode

2016-04-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset c4c14e34e528 by Victor Stinner in branch 'default': Don't define _PyMem_PymallocEnabled() if pymalloc is disabled https://hg.python.org/cpython/rev/c4c14e34e528 -- ___ Python tracker

[issue26803] syslog logging handler fails with address in unix abstract namespace

2016-04-19 Thread STINNER Victor
STINNER Victor added the comment: The following change looks good to me: -if isinstance(address, str): +if isinstance(address, (str, bytes)): self.unixsocket = True self._connect_unixsocket(address) But I don't understand the testcase. Is an address

[issue11233] clarifying Availability: Unix

2016-04-19 Thread STINNER Victor
STINNER Victor added the comment: I like the idea of a single place where the Availability is described, and adding a link to this place. availability-directive.patch LGTM. -- nosy: +haypo ___ Python tracker

[issue25942] subprocess.call SIGKILLs too liberally

2016-04-19 Thread Mike Pomraning
Mike Pomraning added the comment: Re: #2, I'd rather have a zombie than a hard kill on a child whose code I perhaps don't control. Zombies are a fact of life (er, a fact of undeath?) in UNIX process management, and are the historical and IMHO expected behavior. --

[issue26802] Avoid copy in call_function_var when no extra stack args are passed

2016-04-19 Thread STINNER Victor
STINNER Victor added the comment: call-function-var.patch LGTM. -- ___ Python tracker ___ ___

[issue26802] Avoid copy in call_function_var when no extra stack args are passed

2016-04-19 Thread STINNER Victor
STINNER Victor added the comment: +if (!nstar) { +/* There are no positional arguments on the stack or in in a + sequence that was unpacked. */ +return PyTuple_New(0); +} It's possible that stararg is already an empty tuple. Is it worth to

[issue21668] The select and time modules uses libm functions without linking against it

2016-04-19 Thread STINNER Victor
STINNER Victor added the comment: I pushed ext_modules_libm.patch with the helper function proposed by Chi Hsuan Yen in https://github.com/yan12125/python3-android/blob/038271d/mk/python/modules-link-libm.patch. Tell me if it's not enough. I hope that it will make CPython a little bit more

[issue26805] Refer to types.SimpleNamespace in namedtuple documentation

2016-04-19 Thread Paul Moore
Paul Moore added the comment: Thanks Victor. I'll sort this out this evening when I get to my PC with access to the CPython repo. -- ___ Python tracker

[issue21668] The select and time modules uses libm functions without linking against it

2016-04-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset f92fea23161d by Victor Stinner in branch '3.5': setup.py: add missing libm dependency https://hg.python.org/cpython/rev/f92fea23161d New changeset 3a9b47b062b9 by Victor Stinner in branch 'default': Merge 3.5: Issue #21668

[issue13876] Sporadic failure in test_socket: testRecvmsgEOF

2016-04-19 Thread Berker Peksag
Changes by Berker Peksag : -- status: open -> closed ___ Python tracker ___ ___

[issue26805] Refer to types.SimpleNamespace in namedtuple documentation

2016-04-19 Thread STINNER Victor
STINNER Victor added the comment: LGTM. I was going to push your sugestion when I saw that you are allowed to push yourself. See my attached patch: * I fixed :ref:`types.SimpleNamespace` => you have to use :class:`...` * I replaced "may be" with "can be" (I'm not confortable with "may", but

[issue22297] 2.7 json encoding broken for enums

2016-04-19 Thread Berker Peksag
Berker Peksag added the comment: -1 from me, too. -- nosy: +berker.peksag stage: -> resolved status: open -> closed ___ Python tracker ___

[issue11233] clarifying Availability: Unix

2016-04-19 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag stage: needs patch -> patch review type: -> enhancement versions: +Python 3.5, Python 3.6 ___ Python tracker

[issue9014] Incorrect documentation of the PyObject_HEAD macro

2016-04-19 Thread Berker Peksag
Changes by Berker Peksag : -- stage: commit review -> resolved ___ Python tracker ___

[issue18378] locale.getdefaultlocale() fails on Mac OS X with default language set to English

2016-04-19 Thread Tommy Sparber
Changes by Tommy Sparber : -- nosy: +tsparber ___ Python tracker ___ ___

[issue23710] C API doc for PyObject_HEAD is outdated

2016-04-19 Thread Berker Peksag
Berker Peksag added the comment: Docs of PyObject_HEAD and friends have already been fixed in 760c5cfacbaa. https://docs.python.org/3/extending/newtypes.html still needs to be updated to mention ob_base: This is what a Noddy object will contain—in this case, nothing more than what every

[issue26805] Refer to types.SimpleNamespace in namedtuple documentation

2016-04-19 Thread Berker Peksag
Changes by Berker Peksag : -- keywords: +easy stage: -> needs patch versions: +Python 3.5 ___ Python tracker ___

[issue26769] Python 2.7: make private file descriptors non inheritable

2016-04-19 Thread STINNER Victor
STINNER Victor added the comment: > It looks like some of these do make the file descriptor accessible to the > Python user. (...) Oh right, I reverted changes on these modules. What do you think of the patch version 2? Changes since patch version 1: * Revert changes in linuxaudio, oss,

[issue26805] Refer to types.SimpleNamespace in namedtuple documentation

2016-04-19 Thread Chris Angelico
Changes by Chris Angelico : -- nosy: +Rosuav ___ Python tracker ___ ___ Python-bugs-list

[issue26805] Refer to types.SimpleNamespace in namedtuple documentation

2016-04-19 Thread Paul Moore
New submission from Paul Moore: People often look towards collections.namedtuple when all they actually want is "named attribute" access to a collection of values, without needing a tuple subclass, or positional access. In these cases, types.SimpleNamespace may be a better fit. I suggest

[issue26058] PEP 509: Add ma_version to PyDictObject

2016-04-19 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 19.04.2016 13:11, STINNER Victor wrote: > > STINNER Victor added the comment: > >> Could you perhaps check what's causing these slowdowns ? > > It's obvious, no? My patch causes the slowdown. Well, yes, of course :-) I meant whether there's anything

[issue26058] PEP 509: Add ma_version to PyDictObject

2016-04-19 Thread STINNER Victor
STINNER Victor added the comment: > Could you perhaps check what's causing these slowdowns ? It's obvious, no? My patch causes the slowdown. On a timeit microbenchmark, I don't see such slowdown. That's also why I suspect that pybench is unstable. python3.6 -m timeit '{}' says 105 ns with and

[issue26058] PEP 509: Add ma_version to PyDictObject

2016-04-19 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 19.04.2016 12:52, STINNER Victor wrote: > > As usual, I'm very skeptical on the pybench results which almost look like > noise. I don't understand how my change can make any operation *faster*, > whereas some benchmarks are faster with the patch...

[issue24838] tarfile.py: fix GNU and USTAR formats to properly handle paths with special characters that are encoded with more than one byte each

2016-04-19 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed ___ Python tracker ___ ___

[issue26058] PEP 509: Add ma_version to PyDictObject

2016-04-19 Thread STINNER Victor
STINNER Victor added the comment: pybench results on dict_version-8.patch with CPU isolation: http://haypo-notes.readthedocs.org/microbenchmark.html As usual, I'm very skeptical on the pybench results which almost look like noise. I don't understand how my change can make any operation

[issue26058] PEP 509: Add ma_version to PyDictObject

2016-04-19 Thread STINNER Victor
STINNER Victor added the comment: I ran again timeit microbenchmarks with CPU isolation on dict_version-8.patch, minimum of 10 runs. -m timeit 'd={1: 0}; d[2]=0; d[3]=0; d[4]=0; del d[1]; del d[2]; d.clear()' * Original: 287 ns * Version: 289 ns (+2 ns, +0.7%) -m timeit 'd={i:i for i in

[issue26058] PEP 509: Add ma_version to PyDictObject

2016-04-19 Thread STINNER Victor
STINNER Victor added the comment: timeit microbenchmarks on dict_version-8.patch, minimum of 10 runs. $ ./python.orig -m timeit 'd={1: 0}; d[2]=0; d[3]=0; d[4]=0; del d[1]; del d[2]; d.clear()' 100 loops, best of 3: 0.292 usec per loop $ ./python.version -m timeit 'd={1: 0}; d[2]=0;

[issue26058] PEP 509: Add ma_version to PyDictObject

2016-04-19 Thread STINNER Victor
STINNER Victor added the comment: Patch version 8: * Update to the latest PEP: remove micro-optimization in dictobject.c if the new value is identical to the current value, dict.__setitem__() now always changes the version * Refactor test_pep509 to address Brett's comments * Add new unit

[issue1322] Deprecate platform.dist() and platform.linux_distribution() functions

2016-04-19 Thread Andy Maier
Andy Maier added the comment: @leycec: By the way, the "ld" package *does* use shlex.shlex() to parse the os-release file. -- ___ Python tracker ___

[issue1322] Deprecate platform.dist() and platform.linux_distribution() functions

2016-04-19 Thread Andy Maier
Andy Maier added the comment: Nir currently proposes to change the package name from "ld" to "dist". See https://github.com/nir0s/ld/issues/103 Comments on this name change proposal are welcome (over there). On "Given the unremarkable simplicity of implementing this function correctly ...":

[issue24838] tarfile.py: fix GNU and USTAR formats to properly handle paths with special characters that are encoded with more than one byte each

2016-04-19 Thread Lars Gustäbel
Lars Gustäbel added the comment: Sorry for the glitch, I suppose everything works fine now. -- status: open -> closed ___ Python tracker ___

[issue24838] tarfile.py: fix GNU and USTAR formats to properly handle paths with special characters that are encoded with more than one byte each

2016-04-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 78ede2baa146 by Lars Gustäbel in branch '3.5': Issue #24838: Fix test_tarfile.py for non-utf8 filesystem encodings. https://hg.python.org/cpython/rev/78ede2baa146 New changeset 08835d1e7a50 by Lars Gustäbel in branch 'default': Issue #24838: Merge

[issue24838] tarfile.py: fix GNU and USTAR formats to properly handle paths with special characters that are encoded with more than one byte each

2016-04-19 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___

[issue26804] Prioritize lowercase proxy variables in urllib.request

2016-04-19 Thread SilentGhost
Changes by SilentGhost : -- components: +Library (Lib) -Extension Modules nosy: +orsenthil stage: -> patch review ___ Python tracker

[issue26804] Prioritize lowercase proxy variables in urllib.request

2016-04-19 Thread Hans-Peter Jansen
Changes by Hans-Peter Jansen : -- versions: +Python 3.6 -Python 3.5 ___ Python tracker ___

[issue26804] Prioritize lowercase proxy variables in urllib.request

2016-04-19 Thread Hans-Peter Jansen
New submission from Hans-Peter Jansen: During programming a function, that replaces a wget call, I noticed, that something is wrong with urllibs proxy handling. I usually use the scheme "http_proxy= wget -N -nd URL" when I need to bypass the proxy. Hence I was pretty confused, that this

[issue24838] tarfile.py: fix GNU and USTAR formats to properly handle paths with special characters that are encoded with more than one byte each

2016-04-19 Thread STINNER Victor
STINNER Victor added the comment: Tests fail on FreeBSD: http://buildbot.python.org/all/builders/AMD64%20FreeBSD%209.x%203.5/builds/713/steps/test/logs/stdio Example: == FAIL: test_unicode_link1

[issue26802] Avoid copy in call_function_var when no extra stack args are passed

2016-04-19 Thread Joe Jevnik
Changes by Joe Jevnik : -- type: -> performance ___ Python tracker ___ ___

[issue21668] The select and time modules uses libm functions without linking against it

2016-04-19 Thread Chi Hsuan Yen
Chi Hsuan Yen added the comment: The approach with a helper function is better. See https://github.com/yan12125/python3-android/blob/038271d/mk/python/modules-link-libm.patch. By the way, I have verified there are no libraries referencing libm functions with

[issue26802] Avoid copy in call_function_var when no extra stack args are passed

2016-04-19 Thread Joe Jevnik
Joe Jevnik added the comment: in _PyEval_EvalCodeWithName we will have already pulled the underlying array out of the tuple subclass and the then we will reconstruct the vararg value in the locals from this array. This means that with this patch we can get: >>> class C(tuple): pass ... >>>

[issue21668] The select and time modules uses libm functions without linking against it

2016-04-19 Thread Xavier de Gaye
Xavier de Gaye added the comment: The _datetime module also calls functions in libm: delta_new() uses round() and accum() uses modf(). The attached patch updates setup.py for all the modules that use libm. -- nosy: +xdegaye Added file:

[issue26803] syslog logging handler fails with address in unix abstract namespace

2016-04-19 Thread Xavier de Gaye
New submission from Xavier de Gaye: The traceback: Traceback (most recent call last): File "Lib/logging/handlers.py", line 917, in emit self.socket.sendto(msg, self.address) TypeError: getsockaddrarg: AF_INET address must be tuple, not bytes The attached patch reproduces

  1   2   >