[issue25931] os.fork() command distributed in windows Python27 (in SocketServer module)

2016-06-02 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- resolution: -> fixed stage: needs patch -> commit review status: open -> closed ___ Python tracker ___

[issue25747] test_idle failure in leaks searching mode

2016-06-02 Thread Terry J. Reedy
Terry J. Reedy added the comment: idlever.py is now gone in 3.6. -- ___ Python tracker ___ ___

[issue25931] os.fork() command distributed in windows Python27 (in SocketServer module)

2016-06-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset a4c0208b10df by Gregory P. Smith in branch '2.7': issue25931: document that socketserver.Forking* are unavailable on platforms https://hg.python.org/cpython/rev/a4c0208b10df -- ___ Python tracker

[issue25931] os.fork() command distributed in windows Python27 (in SocketServer module)

2016-06-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset 015b86646d8e by Gregory P. Smith in branch 'default': issue25931: document that socketserver.Forking* are unavailable on platforms https://hg.python.org/cpython/rev/015b86646d8e -- ___ Python tracker

[issue27184] Support path objects in the ntpath module

2016-06-02 Thread Eryk Sun
Eryk Sun added the comment: Sorry, I must have missed or misunderstood something. PEP 519 discusses modifying os.path. For the os module it only discusses adding fspath and updating fsencode and fsdecode. It also discusses a new PyOS_FSPath C API, but without any discussion regarding its use

[issue27193] Tkinter Unresponsive With Special Keys

2016-06-02 Thread Ned Deily
Ned Deily added the comment: Tkinter is essentially just a think wrapper around the Tk graphical toolkit. Keyboard modifier mappings are handled by Tk (or OS X), and not Tkinter. Unfortunately, for various reasons, how Tk handles keyboard modifiers varies somewhat among OS platforms

[issue25931] os.fork() command distributed in windows Python27 (in SocketServer module)

2016-06-02 Thread Gregory P. Smith
Gregory P. Smith added the comment: It may be worth rolling back the above two commits. I'm not sure. I'd like to see if anything else falls out of this during the beta phases. There is a chance that some library has code similar to that found in test_socketserver.py that defines classes

[issue27192] Keyboard Shortcuts Consistently Cause Crashes

2016-06-02 Thread Ned Deily
Ned Deily added the comment: You are almost certainly seeing a crash due to a critical bug in the Apple-supplied version of Tk 8.5 on OS X systems up through at least OS X 10.11. See here for more information: https://www.python.org/download/mac/tcltk/#apple-8-5-9. The solution is to use a

[issue27185] Clarify Test Coverage for the String Module (test_pep292 is not easily discoverable)

2016-06-02 Thread Benjamin Peterson
Benjamin Peterson added the comment: On Thu, Jun 2, 2016, at 18:28, Martin Panter wrote: > > Martin Panter added the comment: > > FWIW I doubt Git is any better at this than Mercurial: > > > Git can automatically

[issue25931] os.fork() command distributed in windows Python27 (in SocketServer module)

2016-06-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3145242bc81f by Gregory P. Smith in branch 'default': Issue25931: fix tests broken by the conditional define of socketserver.Forking* https://hg.python.org/cpython/rev/3145242bc81f -- ___ Python tracker

[issue20408] memoryview() constructor documentation error

2016-06-02 Thread Berker Peksag
Berker Peksag added the comment: I think the safest solution is to change 'obj' to 'object' in memoryview documentation. -- assignee: -> docs@python components: +Documentation -Interpreter Core keywords: +easy nosy: +berker.peksag, docs@python stage: patch review -> needs patch

[issue19611] inspect.getcallargs doesn't properly interpret set comprehension code objects.

2016-06-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I have no idea what relations Argument Clinic have with this issue. -- ___ Python tracker ___

[issue27194] Tarfile superfluous truncate calls slows extraction.

2016-06-02 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +lars.gustaebel ___ Python tracker ___

[issue27195] Crash when RawIOBase.write(b) evaluates b.format

2016-06-02 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +benjamin.peterson, pitrou, serhiy.storchaka, skrah, stutzbach ___ Python tracker ___

[issue27184] Support path objects in the ntpath module

2016-06-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Please don't change os.path until all other module will be changed. It may be that os.path would not need any change at all. -- ___ Python tracker

[issue27195] Crash when RawIOBase.write(b) evaluates b.format

2016-06-02 Thread Martin Panter
New submission from Martin Panter: $ gdb --args ./python -c ' import io class R(io.RawIOBase): def writable(self): return True def write(self, b): print("About to evaluate {!r}.format".format(b)) b.format print("Never reached") b =

[issue27194] Tarfile superfluous truncate calls slows extraction.

2016-06-02 Thread Jason Fried
Jason Fried added the comment: I ran this on Linux ext4. I didn't see much improvement on OSX with SSD. -- Added file: http://bugs.python.org/file43139/test.py ___ Python tracker

[issue27185] Clarify Test Coverage for the String Module (test_pep292 is not easily discoverable)

2016-06-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This is even more complex, since you can't merge a revision with its parent. A. Start at revision A. B. Rename test_string to test_string_merged, giving revision B. A. Update back to revision A. C. Rename test_pep292 to test_string_merged, giving revision C.

[issue27194] Tarfile superfluous truncate calls slows extraction.

2016-06-02 Thread Jason Fried
New submission from Jason Fried: With large tar file extracts I noticed that tarfile was slower than it should be. Seems in linux that for large files (10MB) truncate is not always a free operation even when it should be a no-op. ex: File is already 10mb seek to end and truncate. I created

[issue11501] distutils.archive_util should handle absence of zlib module

2016-06-02 Thread Berker Peksag
Berker Peksag added the comment: Tests are already skipped if zlib is not available in 2.7. To backport test_make_zipfile_no_zlib we also need the 'patch' helper so I'm not sure it's worth it at this point. -- nosy: +berker.peksag status: open -> pending

[issue26876] Extend MSVCCompiler class to respect environment variables

2016-06-02 Thread Steve Dower
Steve Dower added the comment: I still want the behavior I described, since there's no value in overriding just the executable name but not the rest of the path. For 2.7 I think this'll help with long term maintainability enough to be the Right Thing. For 3.5 I'm not as sure, but it's

[issue15243] Misleading documentation for __prepare__

2016-06-02 Thread Berker Peksag
Changes by Berker Peksag : -- keywords: +easy versions: +Python 3.6 -Python 3.4 ___ Python tracker ___

[issue17352] Be clear that __prepare__ must be declared as a class method

2016-06-02 Thread Berker Peksag
Berker Peksag added the comment: This is a duplicate of issue 15243. -- nosy: +berker.peksag resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Misleading documentation for __prepare__ ___ Python tracker

[issue19489] move quick search box above TOC

2016-06-02 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker ___ ___

[issue17500] move PC/icons/source.xar to http://www.python.org/community/logos/

2016-06-02 Thread Matthias Klose
Changes by Matthias Klose : -- nosy: +ned.deily, steve.dower ___ Python tracker ___ ___

[issue17500] move PC/icons/source.xar to http://www.python.org/community/logos/

2016-06-02 Thread Matthias Klose
Matthias Klose added the comment: even for the window builds, I don't see any use of these icons for any build. I filed https://github.com/python/pythondotorg/issues/945 to make these files available as downloadable resources. However even if these are not accepted there, I think we should

[issue23670] Modifications to support iOS as a cross-compilation target

2016-06-02 Thread Luke Taylor
Luke Taylor added the comment: Are you aware of Pythonista? I have no affiliation, but I'm a fan of the app and the community surrounding it. See http://omz-software.com/pythonista/ for details. I'm sure communication with the developer of the app could yield some useful insights. --

[issue25931] os.fork() command distributed in windows Python27 (in SocketServer module)

2016-06-02 Thread Martin Panter
Martin Panter added the comment: This broke test_socketserver: http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/7709/steps/test/logs/stdio 0:08:57 [193/400/1] test_socketserver failed test test_socketserver crashed -- Traceback (most recent call last): File

[issue27193] Tkinter Unresponsive With Special Keys

2016-06-02 Thread Emanuel Barry
Changes by Emanuel Barry : -- components: +Extension Modules stage: -> needs patch type: -> behavior ___ Python tracker ___

[issue27192] Keyboard Shortcuts Consistently Cause Crashes

2016-06-02 Thread Emanuel Barry
Changes by Emanuel Barry : -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Tkinter Unresponsive With Special Keys ___ Python tracker

[issue15476] Index "code object" and link to code object definition

2016-06-02 Thread Tommy Beadle
Tommy Beadle added the comment: This restores the original code -> object items. -- Added file: http://bugs.python.org/file43137/0001-Issue-15476-Make-code-object-its-own-entry-in-the-do.patch ___ Python tracker

[issue27193] Tkinter Unresponsive With Special Keys

2016-06-02 Thread Harrison Chudleigh
New submission from Harrison Chudleigh: When working on my program (the same one where I found Issue 27192), I tried adding keyboard shortcuts. I discovered that Tkinter doe not register the keys Alt, Command, Control, Fn, Shift and Caps Lock on a Mac. -- components: Macintosh

[issue27192] Keyboard Shortcuts Consistently Cause Crashes

2016-06-02 Thread Harrison Chudleigh
New submission from Harrison Chudleigh: When trying to add keys to my program, I noticed that using the shortcuts Alt-e, Alt-i, Alt-n and Alt-u caused IDLE to consistently crash. No odd behavior was observed with the corresponding capital letters. -- components: Macintosh messages:

[issue27179] subprocess uses wrong encoding on Windows

2016-06-02 Thread Dāvis
Dāvis added the comment: if there's no console then os.device_encoding won't fail, it will just return None which means that ANSI codepage will be used like it currently is and so here it doesn't change anything, current behavior stays. Also like I showed TextIOWrapper already calls

[issue27179] subprocess uses wrong encoding on Windows

2016-06-02 Thread Steve Dower
Steve Dower added the comment: > There is right encoding, it's encoding that's actually used. This is true, but it puts the decision entirely in the hands of the developer(s) of the two processes involved. All IPC on Windows uses bytes, and encodings _always_ need to be negotiated by the

[issue27130] zlib: OverflowError while trying to compress 2^32 bytes or more

2016-06-02 Thread Xiang Zhang
Xiang Zhang added the comment: I'd like to help but it'll need some time. And I'd like to start after issue27164 is solved. zdict now also checks for 4GB limit. -- ___ Python tracker

[issue27190] Check sqlite3_version before allowing check_same_thread = False

2016-06-02 Thread Berker Peksag
Changes by Berker Peksag : -- components: +Extension Modules ___ Python tracker ___

[issue27190] Check sqlite3_version before allowing check_same_thread = False

2016-06-02 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch. I'm not sure we can apply the patch to bugfix branches. You can use SQLITE_VERSION_NUMBER to check sqlite3 version. -- nosy: +berker.peksag stage: -> patch review versions: +Python 3.6 ___

[issue27191] Add formatting around methods in PEP 8

2016-06-02 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue27191] Add formatting around methods in PEP 8

2016-06-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset bf7f369fb49a by Berker Peksag in branch 'default': Issue #27191: Improve markup of PEP 8, patch by Ian Lee https://hg.python.org/peps/rev/bf7f369fb49a -- nosy: +python-dev ___ Python tracker

[issue27184] Support path objects in the ntpath module

2016-06-02 Thread Eryk Sun
New submission from Eryk Sun: nt is the module name for posixmodule.c on Windows, so I'm changing the title to reference ntpath instead. Regarding nt, two of its built-in functions are exposed directly in ntpath. _isdir is imported as isdir, so it needs a wrapper to support __fspath__. Only

[issue27185] Clarify Test Coverage for the String Module (test_pep292 is not easily discoverable)

2016-06-02 Thread Martin Panter
Martin Panter added the comment: FWIW I doubt Git is any better at this than Mercurial: Git can automatically pick up file renames and copies when analysing the history, but has no special metadata for this. I

[issue22890] StringIO.StringIO pickled in 2.7 is not unpickleable on 3.x

2016-06-02 Thread Mark Lawrence
Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-02 Thread John Mark Vandenberg
Changes by John Mark Vandenberg : -- nosy: +jayvdb ___ Python tracker ___ ___

[issue22890] StringIO.StringIO pickled in 2.7 is not unpickleable on 3.x

2016-06-02 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: Unless I'm missing something, StringIO doesn't exist as a module in Python 3, as mentioned in https://docs.python.org/3.0/whatsnew/3.0.html#text-vs-data-instead-of-unicode-vs-8-bit. If you're trying to unpickle in 3.x an object pickled by 2.7.x, I'm not sure

[issue25812] locale.nl_langinfo() can't decode value

2016-06-02 Thread Nina Zakharenko
Nina Zakharenko added the comment: Adding the test below to test__locale.py will reproduce the issue under the following conditions: - The locale `uk_UA` is installed on your system. - 'uk_UA': (',', '\xa0') is added to the `known_numerics` dictionary in this test file

[issue15476] Index "code object" and link to code object definition

2016-06-02 Thread Mark Lawrence
Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue18751] A manager's server never joins its threads

2016-06-02 Thread Mark Lawrence
Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue27191] Add formatting around methods in PEP 8

2016-06-02 Thread Ian Lee
New submission from Ian Lee: Noticed a couple methods in the text that aren't backtick quoted. -- assignee: docs@python components: Documentation files: rst-formatting.txt messages: 267015 nosy: IanLee1521, barry, docs@python priority: normal severity: normal status: open title: Add

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-02 Thread Ian Lee
Ian Lee added the comment: I added a comment on a pull request related to this that shows some of the cases that we probably don't want to allow: https://github.com/PyCQA/pycodestyle/pull/523#issuecomment-223464775 -- ___ Python tracker

[issue27190] Check sqlite3_version before allowing check_same_thread = False

2016-06-02 Thread Dave Sawyer
New submission from Dave Sawyer: Starting in sqlite version 3.3.1 (Jan 2006) multiple threads can share the same connection. Python allows you do use this with the check_same_thread parameter of sqlite3.connect() method. It's almost certain users have a late enough version of sqlite that they

[issue23061] Update pep8 to specify explicitly 'module level' imports at top of file

2016-06-02 Thread Ian Lee
Ian Lee added the comment: Are there any other concerns with the patch that I would be able to clean up? -- nosy: +barry ___ Python tracker ___

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-02 Thread Ian Lee
Changes by Ian Lee : Added file: http://bugs.python.org/file43134/issue-27187-patch2.txt ___ Python tracker ___

[issue15476] Index "code object" and link to code object definition

2016-06-02 Thread R. David Murray
R. David Murray added the comment: Since the main object of the issue is to have a canonical reference to use for linking 'code object' from elsewhere in the text, I think that can be satisfied by existing _bltin-code-objects 'ref' link as Terry suggests, even though it is a bit awkward to

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

2016-06-02 Thread Dave Sawyer
Dave Sawyer added the comment: Hi Thomas and Senthil, for the serialized setting I mentioned earlier "The serialized mode is default on both Mac and Windows so we can probably skip validating that. I did like mentioning the user needs to serialize the writes. They could use one thread for

[issue27167] subprocess reports signal as negative exit status, not documented

2016-06-02 Thread Gregory P. Smith
Gregory P. Smith added the comment: docs updated (7b12180481da and 19d77132f38d). working on the error message update. -- ___ Python tracker ___

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-02 Thread Ian Lee
Ian Lee added the comment: I might also suggest that the entire "Version bookkeeping" section could be removed in this case, as it would be covered by my newly added dunder section. -- ___ Python tracker

[issue25702] Link Time Optimizations support for GCC and CLANG

2016-06-02 Thread Gregory P. Smith
Gregory P. Smith added the comment: the main part of this issue is done but it can't be closed until the dependencies listed are also dealt with. un-assigning myself. -- assignee: gregory.p.smith -> resolution: -> fixed ___ Python tracker

[issue27186] add os.fspath()

2016-06-02 Thread Dusty Phillips
Changes by Dusty Phillips : Removed file: http://bugs.python.org/file43123/issue27186.buchuki.patch ___ Python tracker ___

[issue25931] os.fork() command distributed in windows Python27 (in SocketServer module)

2016-06-02 Thread R. David Murray
R. David Murray added the comment: Well, defined for 3.6, and "functional" for 2.7 and 3.5 docs. -- ___ Python tracker ___

[issue25931] os.fork() command distributed in windows Python27 (in SocketServer module)

2016-06-02 Thread R. David Murray
R. David Murray added the comment: Your news entry says "don't defining". The doc note can say that the classes are only defined if the platform supports fork. -- ___ Python tracker

[issue27186] add os.fspath()

2016-06-02 Thread Dusty Phillips
Dusty Phillips added the comment: This patch adds fspath protocol and constructor initialization to pathlib.Path. -- Added file: http://bugs.python.org/file43133/issue27186-pathlib.buchuki.patch ___ Python tracker

[issue27137] Python implementation of `functools.partial` is not a class

2016-06-02 Thread Nick Coghlan
Nick Coghlan added the comment: As Raymond notes, the main downside here is in terms of code complexity. However, the concrete gain is that APIs that rely on callable pickling, such as concurrent.futures with a ProcessPoolExecutor, would be consistently compatible with functools.partial: >>>

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-02 Thread Ian Lee
Ian Lee added the comment: I think that it should be updated to specify that all dunders ('__all__', '__version__', '__author__', etc) should be placed after the module docstring and before any imports. See issue-27187-patch1.txt for a possible update. -- Added file:

[issue25931] os.fork() command distributed in windows Python27 (in SocketServer module)

2016-06-02 Thread Gregory P. Smith
Gregory P. Smith added the comment: I made the change to not export the Forking names on Windows or other non-os.fork() supporting platforms in 3.6 only as it is arguably an API change, even though the names it removes would effectively be unusable on those platforms anyways. the docs still

[issue22797] urllib.request.urlopen documentation falsely guarantees that a URLError will be raised on errors

2016-06-02 Thread Alexander Liu
Alexander Liu added the comment: Fixed the docs to specifically note that only protocol related errors raise the UrlError exception. -- nosy: +alex_thebear versions: +Python 3.6 -Python 3.4 Added file: http://bugs.python.org/file43131/urlopen_doc.patch

[issue25931] os.fork() command distributed in windows Python27 (in SocketServer module)

2016-06-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset d772400a1211 by Gregory P. Smith in branch 'default': Issue #25931: Don't defining socketserver.Forking* names on platforms such https://hg.python.org/cpython/rev/d772400a1211 -- nosy: +python-dev ___

[issue27038] Make os.DirEntry exist

2016-06-02 Thread Jelle Zijlstra
Changes by Jelle Zijlstra : -- keywords: +patch Added file: http://bugs.python.org/file43130/issue27038.patch ___ Python tracker

[issue26829] update docs: when creating classes a new dict is created for the final class object

2016-06-02 Thread R. David Murray
R. David Murray added the comment: Thanks, Emily. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue26829] update docs: when creating classes a new dict is created for the final class object

2016-06-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset 754118f8b3ce by R David Murray in branch '3.5': #26829: Clarify that namespace is copied to a new __dict__ in instance creation. https://hg.python.org/cpython/rev/754118f8b3ce New changeset 5a4ace14b350 by R David Murray in branch 'default': Merge:

[issue25738] http.server doesn't handle RESET CONTENT status correctly

2016-06-02 Thread Susumu Koshiba
Susumu Koshiba added the comment: Patched the behaviors when NO_CONTENT and RESET_CONTENT are sent via send_error(). According to RFCs, they aren't actually errors so sending them through send_response() seems to make the most sense, however. send_error()'s behavior changes in this patch are:

[issue27186] add os.fspath()

2016-06-02 Thread Jelle Zijlstra
Changes by Jelle Zijlstra : Added file: http://bugs.python.org/file43128/issue27186-DirEntry-fspath.patch ___ Python tracker ___

[issue26589] Add HTTP Response code 451

2016-06-02 Thread Martin Panter
Martin Panter added the comment: Don’t forget to fix the RFC number (see review) :) -- ___ Python tracker ___

[issue27185] Clarify Test Coverage for the String Module (test_pep292 is not easily discoverable)

2016-06-02 Thread Erin Braswell
Erin Braswell added the comment: Hooray thank you everyone! -- ___ Python tracker ___ ___ Python-bugs-list

[issue25702] Link Time Optimizations support for GCC and CLANG

2016-06-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset f710dac07312 by Gregory P. Smith in branch '2.7': Issue #25702: A --with-lto configure option has been added that will https://hg.python.org/cpython/rev/f710dac07312 -- ___ Python tracker

[issue26829] update docs: when creating classes a new dict is created for the final class object

2016-06-02 Thread Emily Morehouse
Emily Morehouse added the comment: Trimmed down by keeping the more explicit explanation and taking into account suggestions. -- Added file: http://bugs.python.org/file43127/26829-v3.patch ___ Python tracker

[issue27185] Clarify Test Coverage for the String Module (test_pep292 is not easily discoverable)

2016-06-02 Thread R. David Murray
R. David Murray added the comment: Thanks, Erin. -- resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 3.5, Python 3.6 ___ Python tracker

[issue27185] Clarify Test Coverage for the String Module (test_pep292 is not easily discoverable)

2016-06-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset 89abefdebf4d by R David Murray in branch '3.5': #27185: move test_pep292 into test_string. https://hg.python.org/cpython/rev/89abefdebf4d New changeset c2d3d8c3e0bf by R David Murray in branch 'default': Merge: #27185: move test_pep292 into

[issue15476] Index "code object" and link to code object definition

2016-06-02 Thread Tommy Beadle
Tommy Beadle added the comment: The attached patch makes it so that 'code object' is its own 'top-level' entry in the index instead of being 'code' with an 'object' sub-item. It also makes the links from the index go to the location in the documents just before the header instead of having

[issue19611] inspect.getcallargs doesn't properly interpret set comprehension code objects.

2016-06-02 Thread Nick Coghlan
Nick Coghlan added the comment: Oh, I see what you mean, now - we can special case the compiler-generated ".N" names when extracting the signature. I like it - make the claimed parameter something like "implicit0" instead of ".0", mention that in the note on the docs, and folks may have some

[issue26829] update docs: when creating classes a new dict is created for the final class object

2016-06-02 Thread R. David Murray
R. David Murray added the comment: I can't get the rietveld review tool to work from this network, so I'll do this in a comment. This looks pretty good to me, but in the following: +It is important to note that during the creation of the class, a copy of the +namespace object is used in

[issue24291] Many servers (wsgiref, http.server, etc) can truncate large output blobs

2016-06-02 Thread Martin Panter
Martin Panter added the comment: I prefer your first solution because it seems to fit in better with how things were intended. I can add in handling of partial writes with a deprecation warning when I get a chance. I guess the documentation would be something like “Since 3.5.2, partial

[issue26266] add classattribute to enum to handle non-Enum attributes

2016-06-02 Thread Ethan Furman
Ethan Furman added the comment: One possible downside to the `classattribute` route is that we have a descriptor whose only purpose is to shield the item from becoming a member; the up-side is that it's simple to implement. Another possibility is `skip`: class skip: """ Protects item

[issue27186] add os.fspath()

2016-06-02 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: This patch adds the C implementation (copied from the PEP). Some notes: - I added a new .h file in Include/ because there didn't seem to be an obvious existing place to put it. - There was some uncertainty about whether we should Py_INCREF the string or bytes

[issue27130] zlib: OverflowError while trying to compress 2^32 bytes or more

2016-06-02 Thread Martin Panter
Martin Panter added the comment: Klamann, thanks for crash report. I think your decompress crash is explained by the bug expanding past UINT_MAX I identified above. The key is that length = 0 in zlib_Decompress_decompress_impl(), as if wrapped around, and the return value will have been

[issue27186] add os.fspath()

2016-06-02 Thread Dusty Phillips
Dusty Phillips added the comment: Test __fspath__ returning bytes as well. -- Added file: http://bugs.python.org/file43124/issue27186.buchuki.patch ___ Python tracker

[issue24254] Make class definition namespace ordered by default

2016-06-02 Thread Eric Snow
Eric Snow added the comment: Thanks. Yeah, I wanted to keep the patches separate for the sake of code review. I'll fold the changes into a single commit once everything's ready. -- ___ Python tracker

[issue19611] inspect.getcallargs doesn't properly interpret set comprehension code objects.

2016-06-02 Thread Yury Selivanov
Yury Selivanov added the comment: > We definitely can't use a valid identifier in the code generator, since any > valid identifier we used might shadow a nonlocal, global or builtin name (and > the latter two cases aren't visible to the compiler at compile time). I wasn't proposing to fix

[issue27186] add os.fspath()

2016-06-02 Thread Dusty Phillips
Dusty Phillips added the comment: Make os.fsencode and os.fsdecode able to accept a PathLike by calling into fspath. Additionally adds test for PathLike objects. -- keywords: +patch nosy: +buchuki Added file: http://bugs.python.org/file43123/issue27186.buchuki.patch

[issue19611] inspect.getcallargs doesn't properly interpret set comprehension code objects.

2016-06-02 Thread Nick Coghlan
Nick Coghlan added the comment: We definitely can't use a valid identifier in the code generator, since any valid identifier we used might shadow a nonlocal, global or builtin name (and the latter two cases aren't visible to the compiler at compile time). They're also genuinely not positional

[issue27179] subprocess uses wrong encoding on Windows

2016-06-02 Thread Martin Panter
Martin Panter added the comment: Patch B changes _Py_device_encoding() to accept a file descriptor of 3, which seems wrong to me. Patch A is like the earlier patch, but calls os.device_encoding(1) instead of relying on sys.stdout, etc. I think this will still fail when the Python parent’s

[issue27189] configure --with-lto with clang should find the appropriate llvm-profdata tool

2016-06-02 Thread Gregory P. Smith
New submission from Gregory P. Smith: The --with-lto support added in issue25702 can work with clang, but on a Linux distribution such as ubuntu 16.04 with clang installed you get: $ CC=clang ./configure --with-lto ... $ make profile-opt Error: Cannot perform PGO build because llvm-profdata

[issue16192] ctypes - documentation example

2016-06-02 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue16192] ctypes - documentation example

2016-06-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset dfde53cf07e6 by Berker Peksag in branch '3.5': Issue #16192: Fix copy and paste mistake noticed by Eryk Sun https://hg.python.org/cpython/rev/dfde53cf07e6 New changeset 7f3ebd86464b by Berker Peksag in branch 'default': Issue #16192: Merge from 3.5

[issue16113] Add SHA-3 and SHAKE (Keccak) support

2016-06-02 Thread Gregory P. Smith
Gregory P. Smith added the comment: comments added to the code review. -- ___ Python tracker ___ ___

[issue26829] update docs: when creating classes a new dict is created for the final class object

2016-06-02 Thread Emily Morehouse
Emily Morehouse added the comment: Second version of patch for this -- more clearly states the process and outcome for class creation. Also adds to https://docs.python.org/3.6/library/functions.html#type to clarify that the dictionary object is copied to a standard dict. -- Added

[issue27186] add os.fspath()

2016-06-02 Thread Roundup Robot
New submission from Roundup Robot: New changeset 59a52a9dd0dc by Ethan Furman in branch 'default': issue27186 -- initial docs, tests, and python version of os.fspath https://hg.python.org/cpython/rev/59a52a9dd0dc -- nosy: +python-dev ___ Python

[issue27172] Add skip_bound_arg argument to inspect.Signature.from_callable()

2016-06-02 Thread Yury Selivanov
Yury Selivanov added the comment: Nick, what do you think about this one? I'm +1 to add this, but I'm not sure about the name for the argument. Do you have better ideas, or "skip_bound_arg" is good enough? -- nosy: +ncoghlan ___ Python tracker

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

2016-06-02 Thread Kaushik N
Kaushik N added the comment: Applied patch from sean.rodman. Created a test. -- nosy: +Kaushik N Added file: http://bugs.python.org/file43121/Issue16484_python3.6.patch ___ Python tracker

[issue27181] Add geometric mean to `statistics` module

2016-06-02 Thread Steven D'Aprano
Steven D'Aprano added the comment: On Thu, Jun 02, 2016 at 09:04:54PM +, Raymond Hettinger wrote: > Steven, this seems like a reasonable suggestion (though I would expect > someone else will immediately suggest a harmonic mean as well). Is > this within the scope of what you were trying

  1   2   3   >