[issue27212] Doc for itertools, 'islice()' implementation have unwanted behavior for recipe 'consume()'

2016-06-03 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: docs@python -> rhettinger nosy: +rhettinger ___ Python tracker ___

[issue27212] Doc for itertools, 'islice()' implementation have unwanted behavior for recipe 'consume()'

2016-06-03 Thread alex0307
New submission from alex0307: In the doc for itertools, the python implementation of islice() doesn't actually perform the iteration when given an empty slice (e.g. islice(it,3,3)). This is not the expected behavior for 'consume()' in the recipe given below, i.e. consume(it,3) couldn't

[issue22797] urllib.request.urlopen documentation falsely guarantees that a URLError will be raised on errors

2016-06-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 2d69d0419879 by Martin Panter in branch 'default': Issue #22797: Synchronize urlopen() doc string with RST documentation https://hg.python.org/cpython/rev/2d69d0419879 -- ___ Python tracker

[issue27211] Heap corruption via Python 2.7.11 IOBase readline()

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This bug was fixed for 3.x in issue18408. Maybe we should backport other Victor's fixes from this issue. Yet one possible bug -- using memcpy instead of memmove. The memory block can be resized without changing the address. -- nosy: +haypo,

[issue27211] Heap corruption via Python 2.7.11 IOBase readline()

2016-06-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset afbd4473947a by Benjamin Peterson in branch '2.7': check the result of PyByteArray_Resize in readline() (closes #27211) https://hg.python.org/cpython/rev/afbd4473947a -- nosy: +python-dev resolution: -> fixed stage: -> resolved status:

[issue24225] Idlelib: changing file names

2016-06-03 Thread Ned Deily
Ned Deily added the comment: I just tried to run IDLE from the command line as a (UNIX) user would. And then I grepped. :) -- ___ Python tracker ___

[issue27211] Heap corruption via Python 2.7.11 IOBase readline()

2016-06-03 Thread Benjamin Peterson
New submission from Benjamin Peterson: Guido Vranken on PSRT report: Python-2.7.11/Modules/_io/iobase.c iobase_readline(): 531 old_size = PyByteArray_GET_SIZE(buffer); 532 PyByteArray_Resize(buffer, old_size + PyBytes_GET_SIZE(b)); 533

[issue20567] test_idle causes test_ttk_guionly 'can't invoke "event" command: application has been destroyed' messages from Tk

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: -To avoid interfering with other GUI tests, all GUI objects must be +To avoid interfering with other gui tests, all gui objects must be destroyed and Why "gui" is in lower case? -- ___ Python tracker

[issue24225] Idlelib: changing file names

2016-06-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: Thanks. Did you grep the whole repository for 'idlelib' or did you think to look for the latter two? -- ___ Python tracker

[issue27196] Eliminate 'ThemeChanged' warning when running IDLE tests

2016-06-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: I closed #20567 after finishing what I intended to do 3 years ago. I decided make this a separate issue for trying Serhiy's suggestion of updata_idletasks. Pursuing 'no default root' is #24137. 3 other files also gave the warning, once, when run alone. 2

[issue20567] test_idle causes test_ttk_guionly 'can't invoke "event" command: application has been destroyed' messages from Tk

2016-06-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: Using update_idletasks msg229182 is #27196; it succeeded in stopping ThemeChanged warnings. Using 'no-default-root' msg229201 is #24137. -- ___ Python tracker

[issue27196] Eliminate 'ThemeChanged' warning when running IDLE tests

2016-06-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0207c6203f84 by Terry Jan Reedy in branch '3.5': Issue #27196: Stop 'application destroyed' warnings when running IDLE tests. https://hg.python.org/cpython/rev/0207c6203f84 New changeset 2d864ac472f0 by Terry Jan Reedy in branch 'default': Merge

[issue25548] Show the address in the repr for class objects

2016-06-03 Thread Raymond Hettinger
Raymond Hettinger added the comment: Thanks Kushal. It looks like we had a race condition ;-) I'll assign it back after Nofar's work is in and reconciled. -- ___ Python tracker

[issue27198] Adding an assertClose() method to unittest.TestCase

2016-06-03 Thread Raymond Hettinger
Raymond Hettinger added the comment: FWIW, I find assertClose easy to misinterpret. At first, it looks like an assertion that a file is closed. And once you mentally pronounce it like "close something that is open", it is harder to make the jump to "close as in nearby". Also, I feed there

[issue20567] test_idle causes test_ttk_guionly 'can't invoke "event" command: application has been destroyed' messages from Tk

2016-06-03 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed versions: +Python 3.6 ___ Python tracker

[issue20567] test_idle causes test_ttk_guionly 'can't invoke "event" command: application has been destroyed' messages from Tk

2016-06-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 813bb6a4c693 by Terry Jan Reedy in branch '3.5': Issue 20567: Revise idle_test/README.txt and some tests to match new advice. https://hg.python.org/cpython/rev/813bb6a4c693 New changeset d8e5e3da4d57 by Terry Jan Reedy in branch 'default': Issue

[issue27179] subprocess uses wrong encoding on Windows

2016-06-03 Thread Dāvis
Dāvis added the comment: > qprocess.exe (also to console) > quser.exe (also to console) these are broken (http://i.imgur.com/0zIhHrv.png) >chcp 1257 >quser USERNAME SESSIONNAME dƒvis console > chcp 775 > quser USERNAME

[issue27179] subprocess uses wrong encoding on Windows

2016-06-03 Thread Steve Dower
Steve Dower added the comment: > so ANSI is the natural default for a detached process To clarify - ANSI is the natural default *for programs that don't support Unicode*. Unfortunately, since "Unicode" on Windows is an incompatible data type (wchar_t rather than char), targeting Unicode

[issue27202] make doctest fails on 2.7 release notes

2016-06-03 Thread Martin Panter
Martin Panter added the comment: Since I stuck my neck out, I will say that this seems reasonable to me. We could probably still run doctest in the actual 2.7 branch to detect any errors there. -- stage: -> patch review versions: +Python 3.5 ___

[issue27203] Failing doctests in Doc/faq/programming.rst

2016-06-03 Thread Martin Panter
Martin Panter added the comment: make -C Doc/ suspicious fails: WARNING: [faq/programming:1177] ".. testsetup:" found in ".. testsetup::" Suspicious check complete; look for any errors in the above output or in build/suspicious/suspicious.csv. If all issues are false positives, append that

[issue25738] http.server doesn't handle RESET CONTENT status correctly

2016-06-03 Thread Martin Panter
Martin Panter added the comment: Ah, forget that bit about RESET_CONTENT. If we include Content-Length, it will probably be non-zero, which will be wrong. So your patch is better in that regard. -- ___ Python tracker

[issue27202] make doctest fails on 2.7 release notes

2016-06-03 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: Yes, I've been attempting to get that make to fully succeed. -- ___ Python tracker ___

[issue25738] http.server doesn't handle RESET CONTENT status correctly

2016-06-03 Thread Martin Panter
Martin Panter added the comment: I suggest to drop the RESET_CONTENT exception. Content-Length: 0 is explicitly allowed by option a), and is not very different to the general case IMO. Content-Length was added here to help with buggy

[issue27198] Adding an assertClose() method to unittest.TestCase

2016-06-03 Thread Chris Barker
Chris Barker added the comment: """w.r.t. error messages, a regular function that raises AssertionError with a nice message will be precisely as usable.""" sure -- I totally agree -- but that's not the current unittest API :-( where would you put it? How would people find it and know to use

[issue27202] make doctest fails on 2.7 release notes

2016-06-03 Thread Martin Panter
Martin Panter added the comment: Ignore my message; I was thinking of something different :) I presume you are running something like the following, which seems to smoke-test the examples in the documentation: make -C Doc doctest -- ___ Python

[issue27202] make doctest fails on 2.7 release notes

2016-06-03 Thread Martin Panter
Changes by Martin Panter : -- Removed message: http://bugs.python.org/msg267213 ___ Python tracker ___

[issue27202] make doctest fails on 2.7 release notes

2016-06-03 Thread Martin Panter
Martin Panter added the comment: What failures are seeing, and what version of Sphinx are you using? Perhaps this is related to Issue 26638? -- nosy: +martin.panter ___ Python tracker

[issue26372] Popen.communicate not ignoring BrokenPipeError

2016-06-03 Thread Łukasz Langa
Łukasz Langa added the comment: Thanks, I looked at this issue just today :) -- ___ Python tracker ___ ___

[issue24225] Idlelib: changing file names

2016-06-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5dcc52d6829f by Ned Deily in branch 'default': Issue #24225: Fix additional renamed module references. https://hg.python.org/cpython/rev/5dcc52d6829f -- ___ Python tracker

[issue25738] http.server doesn't handle RESET CONTENT status correctly

2016-06-03 Thread Susumu Koshiba
Susumu Koshiba added the comment: Thanks, I've added some comments to the doc and updated the patch. -- Added file: http://bugs.python.org/file43182/issue25738_http_reset_content_02.patch ___ Python tracker

[issue24617] os.makedirs()'s [mode] not correct

2016-06-03 Thread Tommy Beadle
Tommy Beadle added the comment: I've fixed the apostrophe issue by avoiding it's use. I've moved the text about the mode to mkdir and added a link to it from makedirs. -- Added file: http://bugs.python.org/file43180/0001-Issue-24617-Add-comment-for-os.makedirs-about-certai.patch

[issue27200] make doctest in CPython has failures

2016-06-03 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: Added a number of more specific issues with patches. I'll add more patches after the current ones are resolved. -- dependencies: +Failing doctests due to environmental dependencies in Lib/*lib.rst, Failing doctests in Doc/faq/programming.rst, Failing

[issue27209] Failing doctests in Library/email.*.rst

2016-06-03 Thread Jelle Zijlstra
Changes by Jelle Zijlstra : -- assignee: docs@python components: Documentation files: doctests-email.patch keywords: patch nosy: Jelle Zijlstra, docs@python priority: normal severity: normal status: open title: Failing doctests in Library/email.*.rst versions:

[issue27210] Failing doctests due to environmental dependencies in Lib/*lib.rst

2016-06-03 Thread Jelle Zijlstra
New submission from Jelle Zijlstra: The difflib test fails because "False" is close enough to "apple". The ftplib and nntplib tests rely on things downloaded from the web that are inherently variable. -- assignee: docs@python components: Documentation files: doctests-libs.patch

[issue27208] Failing doctests in Library/traceback.rst

2016-06-03 Thread Jelle Zijlstra
New submission from Jelle Zijlstra: Updated to the output of current 3.6. -- assignee: docs@python components: Documentation files: doctests-traceback.patch keywords: patch messages: 267205 nosy: Jelle Zijlstra, docs@python priority: normal severity: normal status: open title: Failing

[issue26372] Popen.communicate not ignoring BrokenPipeError

2016-06-03 Thread Gregory P. Smith
Gregory P. Smith added the comment: the bot hasn't piped up with the changesets. these are the 3.5 and default fixes: remote: notified python-check...@python.org of incoming changeset 883cfb3e28f9 remote: notified python-check...@python.org of incoming changeset 78e81de6d447 --

[issue26372] Popen.communicate not ignoring BrokenPipeError

2016-06-03 Thread Gregory P. Smith
Gregory P. Smith added the comment: Lukas - cc'ing you just in case this bug is related to the asyncio subprocess race condition-ish problems you were talking about at pycon. -- nosy: +lukasz.langa ___ Python tracker

[issue27207] Failing doctests in Doc/whatsnew/3.2.rst

2016-06-03 Thread Jelle Zijlstra
New submission from Jelle Zijlstra: Mostly missing imports, some bad syntax, and a few typos. This patch fixes most but not all errors. -- assignee: docs@python components: Documentation files: doctests-whatsnew-32.patch keywords: patch messages: 267203 nosy: Jelle Zijlstra,

[issue26372] Popen.communicate not ignoring BrokenPipeError

2016-06-03 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- resolution: -> fixed stage: patch review -> commit review ___ Python tracker ___

[issue27206] Failing doctests in Doc/tutorial/

2016-06-03 Thread Jelle Zijlstra
New submission from Jelle Zijlstra: Patch adds an import. -- assignee: docs@python components: Documentation files: doctests-tutorial.patch keywords: patch messages: 267202 nosy: Jelle Zijlstra, docs@python priority: normal severity: normal status: open title: Failing doctests in

[issue26373] asyncio: add support for async context manager on streams?

2016-06-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 883cfb3e28f9 by Gregory P. Smith in branch '3.5': Fixes Issue #26373: subprocess.Popen.communicate now correctly ignores https://hg.python.org/cpython/rev/883cfb3e28f9 New changeset 78e81de6d447 by Gregory P. Smith in branch 'default': merge from

[issue25738] http.server doesn't handle RESET CONTENT status correctly

2016-06-03 Thread R. David Murray
R. David Murray added the comment: Well, the reason it makes sense to use send_error, or at least the reason I suspect a lot of people do it, is because then you don't have to call end_headers() yourself. So, acknowleding this, it might be worth mentioning in the docs that the body isn't

[issue27205] Failing doctests in Library/collections.rst

2016-06-03 Thread Jelle Zijlstra
New submission from Jelle Zijlstra: Mostly due to unspecified sorting order. The patch sorts a few tests and skips others that can't easily be sorted (e.g. most_common and str() output). -- assignee: docs@python components: Documentation files: doctests-collections.patch keywords:

[issue27204] Failing doctests in Doc/howto/

2016-06-03 Thread Jelle Zijlstra
New submission from Jelle Zijlstra: Patch adds some imports, fixes doctests syntax, and skips Py2-only code. -- files: doctests-howto.patch keywords: patch messages: 267198 nosy: Jelle Zijlstra priority: normal severity: normal status: open title: Failing doctests in Doc/howto/ Added

[issue27203] Failing doctests in Doc/faq/programming.rst

2016-06-03 Thread Jelle Zijlstra
New submission from Jelle Zijlstra: Patch attached. Added testsetup for the shared A variable and skipped doctests that rely on the return value of id(). -- files: faqdoctests.patch keywords: patch messages: 267197 nosy: Jelle Zijlstra priority: normal severity: normal status: open

[issue22797] urllib.request.urlopen documentation falsely guarantees that a URLError will be raised on errors

2016-06-03 Thread R. David Murray
R. David Murray added the comment: Thanks, Alexander. -- resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 3.5 ___ Python tracker

[issue22797] urllib.request.urlopen documentation falsely guarantees that a URLError will be raised on errors

2016-06-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset b4df20312b78 by R David Murray in branch 'default': Clean up urlopen doc string. https://hg.python.org/cpython/rev/b4df20312b78 -- ___ Python tracker

[issue24617] os.makedirs()'s [mode] not correct

2016-06-03 Thread Martin Panter
Martin Panter added the comment: Thanks for the patch Tommy. One minor quirk that bugs me: *mode*'s gets marked up with an opening quote rather than an apostrophe. Perhaps we can change it to a Unicode apostrophe (*mode*’s). Another alternative would be: the octal representation of *mode*.

[issue19611] inspect.getcallargs doesn't properly interpret set comprehension code objects.

2016-06-03 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: Patch adding @cpython_only decorators to the tests. -- Added file: http://bugs.python.org/file43172/issue19611-decorators.patch ___ Python tracker

[issue25812] locale.nl_langinfo() can't decode value

2016-06-03 Thread R. David Murray
R. David Murray added the comment: Thanks, Nina. We do have support in test.support for running a test with a specific locale (run_with_locale), so this could be turned into a unit test patch if you or someone else is willing to do that. -- nosy: +r.david.murray

[issue22257] PEP 432: Redesign the interpreter startup sequence

2016-06-03 Thread Nick Coghlan
Nick Coghlan added the comment: I merged the current 3.6 dev branch into the BitBucket PEP 432 branch in my CPython sandbox. The attached patch is the diff between that branch and CPython default. All of the proposed changes here should only affect private APIs now, allowing this to be

[issue27202] make doctest fails on 2.7 release notes

2016-06-03 Thread Jelle Zijlstra
New submission from Jelle Zijlstra: Running `make doctest` in the Doc/ repository of master fails on the 2.7 release notes. This patch excludes these files from `make doctest`, because it doesn't seem worth it to try to get these running in Python 3. -- assignee: docs@python

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

2016-06-03 Thread R. David Murray
R. David Murray added the comment: Thanks Sean and Kaushik. The final patch didn't apply to 2.7. If someone wants to port the patch I'll apply it, but I'm going to close the issue. -- resolution: -> fixed stage: test needed -> resolved status: open -> closed type: behavior ->

[issue15476] Index "code object" and link to code object definition

2016-06-03 Thread Martin Panter
Martin Panter added the comment: Not sure why it doesn’t come up in the code review, but in diff --git a/Doc/reference/datamodel.rst b/Doc/reference/datamodel.rst index c0b4930..f34ba9f 100644 --- a/Doc/reference/datamodel.rst +++ b/Doc/reference/datamodel.rst @@ -847,8 +847,10 @@ Internal

[issue27198] Adding an assertClose() method to unittest.TestCase

2016-06-03 Thread Robert Collins
Robert Collins added the comment: Future direction: hamcrest style matchers. You can read more about them in the context of unittest https://rbtcollins.wordpress.com/2010/05/10/maintainable-pyunit-test-suites/ and http://testtools.readthedocs.io/en/latest/for-test-authors.html#matchers -

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

2016-06-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 64e7c8531131 by R David Murray in branch '3.5': #16484: Fix pydoc doc links to modules whose names are mixed case. https://hg.python.org/cpython/rev/64e7c8531131 New changeset 912b9aad0b45 by R David Murray in branch 'default': Merge: #16484: Fix

[issue27152] Additional assert methods for unittest

2016-06-03 Thread Robert Collins
Robert Collins added the comment: I'm fine with these as a mixin - they are all very generic and unambiguously named. I'd marginally prefer the opt-in mixin over adding them to the base class. Ideally they'd be matchers, but since I haven't ported that upstream yet, thats asking for more

[issue24254] Make class definition namespace ordered by default

2016-06-03 Thread Eric Snow
Changes by Eric Snow : Added file: http://bugs.python.org/file43169/deforder.diff ___ Python tracker ___

[issue24254] Make class definition namespace ordered by default

2016-06-03 Thread Eric Snow
Changes by Eric Snow : Removed file: http://bugs.python.org/file43168/deforder.diff ___ Python tracker ___

[issue22558] Missing doc links to source code for Python-coded modules.

2016-06-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: Great report. It appears that the remaining questions are subjective decisions for a core developer: what is the best link, if any, for a package; should the link also be last thing in the section. -- ___ Python

[issue24254] Make class definition namespace ordered by default

2016-06-03 Thread Eric Snow
Eric Snow added the comment: Here's the full patch, including the addition of __definition_order__, tests, and docs. -- Added file: http://bugs.python.org/file43168/deforder.diff ___ Python tracker

[issue15476] Index "code object" and link to code object definition

2016-06-03 Thread Martin Panter
Martin Panter added the comment: I haven’t tested, but maybe this will do what you want: .. index:: object; code, code object or .. index:: single: object; code single: code object -- ___ Python tracker

[issue27201] expose the ABI name as a config variable

2016-06-03 Thread Matthias Klose
New submission from Matthias Klose: Some python extensions provide/rely on support libraries which are shipped in addition to the extension module, and which depend on the Python ABI (version and ABI flags). talloc is such an example, and it currently uses the SOABI as the symbol version for

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

2016-06-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: I saw the review comment about adding lines. I do not have 8.4 either, but I get the point: the startup version check does not not guard the unittests. After test.text_idle imports unittest and tkinter (as tk) (line 6), I will add if tk.TkVersion < 8.5:

[issue27162] Add idlelib.interface module

2016-06-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: Import should fail if tk.TkVersion < 8.5. -- ___ Python tracker ___ ___

[issue27198] Adding an assertClose() method to unittest.TestCase

2016-06-03 Thread Chris Barker
Chris Barker added the comment: Would that make folks more amenable to adding more "specialized" asserts? If so, then sure. I don't know that it takes a PEP (I hope not) but it would be good to have some guidance as to the direction we want unittest to take written down somewhere. --

[issue27140] Opcode for creating dict with constant keys

2016-06-03 Thread Demur Rumed
Demur Rumed added the comment: When is this intended to be merged? I've been waiting on this before updating the patch @ #27095 with fixes to other code review comments -- ___ Python tracker

[issue27198] Adding an assertClose() method to unittest.TestCase

2016-06-03 Thread R. David Murray
R. David Murray added the comment: I raised the same point on that issue, and the answer as I understand it is that we want to change the API by making the assert methods independent of the rest of unit test, so I think Serhiy was seeing the mixin as a move in that general direction.

[issue27152] Additional assert methods for unittest

2016-06-03 Thread Chris Barker
Chris Barker added the comment: Why a mixin rather than adding to TestCase? If they are useful they should be easy to find. Also, see Issue27198 for another possible new assert. -- nosy: +ChrisBarker ___ Python tracker

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

2016-06-03 Thread R. David Murray
R. David Murray added the comment: This patch looks good to me. Note that the reason for the basedir change is that the test would fail if run from a build directory which hadn't been installed. An implication of this is that 'doc_loc' is None most of the time when the other tests are run,

[issue27198] Adding an assertClose() method to unittest.TestCase

2016-06-03 Thread Chris Barker
Chris Barker added the comment: thanks, that's Issue27152 if anyone's curious. Though I have no idea why you'd want it in a mixin, rather than just there. But sure, this could be "bundled" in with that. Perhaps it's time for a broader discussion / consensus about the future of the unittest

[issue22558] Missing doc links to source code for Python-coded modules.

2016-06-03 Thread Nathan Harold
Nathan Harold added the comment: I went through all the diffs in Rietveld, checking it against msg228576 as I went. There were (naturally) more source links added than there are in that list from 2014, and there were also many more files with slight header reorganizations for consistency.

[issue17888] docs: more information on documentation team

2016-06-03 Thread Berker Peksag
Berker Peksag added the comment: Thanks, Laura. I will commit issue17888_2.patch later today. -- ___ Python tracker ___

[issue24459] Mention PYTHONFAULTHANDLER in the man page

2016-06-03 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Joshua. I did a quick review and it looks good to me. I will review and test it more carefully later today. -- ___ Python tracker

[issue27198] Adding an assertClose() method to unittest.TestCase

2016-06-03 Thread R. David Murray
R. David Murray added the comment: On the name, I assumed it had something to do with files when I saw the issue title. I'm not sure that's enough of an argument against it, though. There's an issue where Serhiy is proposing a mixin with additional assert methods. If that has any traction

[issue27198] Adding an assertClose() method to unittest.TestCase

2016-06-03 Thread Chris Barker
Chris Barker added the comment: I'm not sure it's confusing --what would "close" mean for an assertion for a file? "assertClosed" would be confusing -- and an even more trivial assert :-). But we can bikeshed the name if we decide to put this in. """ I certainly don't want to add narrow usage

[issue24459] Mention PYTHONFAULTHANDLER in the man page

2016-06-03 Thread Joshua Jay Herman
Joshua Jay Herman added the comment: Undid alphabetization and added additional missing environment variables including debug mode variables. -- Added file: http://bugs.python.org/file43166/addMissingEnvironmentVariables.patch ___ Python tracker

[issue27200] make doctest in CPython has failures

2016-06-03 Thread Jelle Zijlstra
New submission from Jelle Zijlstra: I'm going to gather together a patch to fix some of these issues. -- messages: 267166 nosy: Jelle Zijlstra, brett.cannon priority: normal severity: normal status: open title: make doctest in CPython has failures

[issue27073] redundant checks in long_add and long_sub

2016-06-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset c21bf38a9d07 by Serhiy Storchaka in branch 'default': Issue #27073: Removed redundant checks in long_add and long_sub. https://hg.python.org/cpython/rev/c21bf38a9d07 -- nosy: +python-dev ___ Python

[issue27073] redundant checks in long_add and long_sub

2016-06-03 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- type: behavior -> performance ___ Python tracker ___

[issue27073] redundant checks in long_add and long_sub

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM (except a trailing space in a comment). Thank you for your contribution Oren. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue27184] Support path objects in the ntpath module

2016-06-03 Thread Brett Cannon
Brett Cannon added the comment: os.path will be updated to work with __fspath__() as specified by Guido as part of the conversation for PEP 519 (IOW listing os.path as being updated in PEP 519 is not an accident). -- ___ Python tracker

[issue27197] mock.patch interactions with "from" imports

2016-06-03 Thread Robert Collins
Robert Collins added the comment: So its a feature of mock that it can mock a module that doesn't exist. And the semantics of the import system are designed to be very cheap when a module is already imported - so when 'patchbug.a' is in sys.modules, import will correctly return it rather than

[issue5124] IDLE - pasting text doesn't delete selection

2016-06-03 Thread R. David Murray
R. David Murray added the comment: Note that I would find it *very* confusing if the paste took place at some other location than the cursor location. From Serhiy's description I don't think that's an issue in the proposed change. -- ___ Python

[issue27198] Adding an assertClose() method to unittest.TestCase

2016-06-03 Thread Robert Collins
Robert Collins added the comment: Thanks for proposing this. I really don't want to add new assertions to unittest, and I certainly don't want to add narrow usage ones like this, nor ones that are confusingly named (this has nothing to do with files, but 'close' is a verb for files, just like

[issue24459] Mention PYTHONFAULTHANDLER in the man page

2016-06-03 Thread Berker Peksag
Berker Peksag added the comment: > Hi, I have alphabetized and [...] Can you please de-alphabetize the list to make patch review a little bit easier? Thanks! -- nosy: +berker.peksag stage: needs patch -> patch review ___ Python tracker

[issue25931] os.fork() command distributed in windows Python27 (in SocketServer module)

2016-06-03 Thread Berker Peksag
Changes by Berker Peksag : -- stage: commit review -> resolved ___ Python tracker ___

[issue20041] TypeError when f_trace is None and tracing.

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This may be worthwhile optimization, but this is different issue. Let first fix a TypeError, and then open new issue for the optimization. -- ___ Python tracker

[issue20041] TypeError when f_trace is None and tracing.

2016-06-03 Thread Xavier de Gaye
Xavier de Gaye added the comment: On a 'call' trace event, the bdb dispatch_call() function returns None when there is nothing to trace in this function (no breakpoints). With the changes made by the patch in ceval.c, the costly maybe_call_line_trace() function is not called on each line in

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I meant Tk 8.4, not Python 3.4. Tests should be either passed or skipped, no errors raised. -- ___ Python tracker

[issue5124] IDLE - pasting text doesn't delete selection

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: In modern text editors selecting text with a mouse moves text cursor, and moving the cursor by arrow keys cancels the selection (if Shift is not pressed). But in terminal emulators selecting text with a mouse doesn't move text cursor, and moving the cursor

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

2016-06-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: No, 3.4 is security fixes only and this is a 3.6 only issue. -- ___ Python tracker ___

[issue27198] Adding an assertClose() method to unittest.TestCase

2016-06-03 Thread Chris Barker
Chris Barker added the comment: updated patch with the equation in the docs. -- Added file: http://bugs.python.org/file43165/assertClose.patch ___ Python tracker

[issue27073] redundant checks in long_add and long_sub

2016-06-03 Thread Oren Milman
Changes by Oren Milman : Added file: http://bugs.python.org/file43164/patchedCPythonTestOutput.txt ___ Python tracker ___

[issue23306] Within zipfile, use of zlib.crc32 raises OverflowError at argument-parsing time on large strings

2016-06-03 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- dependencies: +zlib: OverflowError while trying to compress 2^32 bytes or more stage: -> needs patch ___ Python tracker

[issue27073] redundant checks in long_add and long_sub

2016-06-03 Thread Oren Milman
Oren Milman added the comment: I considered doing that, but I had already opened another issue (http://bugs.python.org/issue27145) in which I had proposed to replace that in-place negate in long_sub with a call to _PyLong_Negate. But I guess I shouldn't worry about my patches colliding.

[issue27198] Adding an assertClose() method to unittest.TestCase

2016-06-03 Thread R. David Murray
Changes by R. David Murray : -- nosy: +mark.dickinson ___ Python tracker ___ ___

[issue22797] urllib.request.urlopen documentation falsely guarantees that a URLError will be raised on errors

2016-06-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 8b6b6add8e47 by R David Murray in branch 'default': psuedo merge: #22797: clarify when URLErrors are raised by urlopen. https://hg.python.org/cpython/rev/8b6b6add8e47 -- ___ Python tracker

[issue27198] Adding an assertClose() method to unittest.TestCase

2016-06-03 Thread Chris Barker
Chris Barker added the comment: Thanks, I'll add the equation to the docstring and docs. As for adding a rel_tol to assertAlmostEqual -- I think that's a bad idea -- it's a pretty different concept -- overloading the same method would be more confusing than anything else. in isclose(),

[issue22558] Missing doc links to source code for Python-coded modules.

2016-06-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: For me, the issue is willingness, not permission ;-). Reviewing a patch includes somehow indicating changes needed to apply it 'today', and a revised patch is the best way. Please say whether the header changes are in 3.6 only (in which case a separate 3.5

  1   2   3   >